Re: [PATCH] ARM: EXYNOS: add the definition for IRQ_DWMCI

2012-04-18 Thread Kukjin Kim
Jaehoon Chung wroteh: On 04/19/2012 09:12 AM, Kukjin Kim wrote: Jaehoon Chung wrote: In dev-dwmci.c, IRQ_DWMCI is referenced. But there is no defined anywhere. This patch is added the missing definition for IRQ_DWMCI. Signed-off-by: Jaehoon Chung Signed-off-by: Kyungmin Park --- arch/arm/m

[PATCH 7/7] ARM: SAMSUNG: move options for common s5p into plat-samsung/Kconfig

2012-04-18 Thread Kukjin Kim
Signed-off-by: Kukjin Kim --- arch/arm/plat-s5p/Kconfig | 65 - arch/arm/plat-samsung/Kconfig | 65 + 2 files changed, 65 insertions(+), 65 deletions(-) diff --git a/arch/arm/plat-s5p/Kconfig b/arch/arm/plat-

[PATCH 6/7] ARM: SAMSUNG: move setup code for s5p mfc and mipiphy into plat-samsung

2012-04-18 Thread Kukjin Kim
Signed-off-by: Kukjin Kim --- arch/arm/plat-s5p/Kconfig | 10 -- arch/arm/plat-s5p/Makefile |5 - arch/arm/plat-samsung/Kconfig | 10 ++ arch/arm/plat-samsung/Makefile |3 +++

[PATCH 5/7] ARM: SAMSUNG: move platform device for s5p uart into plat-samsung

2012-04-18 Thread Kukjin Kim
Signed-off-by: Kukjin Kim --- arch/arm/plat-s5p/Kconfig |4 - arch/arm/plat-s5p/Makefile |1 - arch/arm/plat-samsung/Kconfig |6 ++ arch/arm/plat-samsung/Makefile |1 + .../dev-uart.c => plat

[PATCH 4/7] ARM: SAMSUNG: move hr timer for common s5p into plat-samsung

2012-04-18 Thread Kukjin Kim
Signed-off-by: Kukjin Kim --- arch/arm/plat-s5p/Kconfig |6 -- arch/arm/plat-s5p/Makefile |4 arch/arm/plat-samsung/Kconfig |8 arch/arm/plat-samsung/Makefile |2 ++ arch/arm/{plat-s5p => p

[PATCH 3/7] ARM: SAMSUNG: move pm part for common s5p into plat-samsung

2012-04-18 Thread Kukjin Kim
Signed-off-by: Kukjin Kim --- arch/arm/plat-s5p/Kconfig | 12 arch/arm/plat-s5p/Makefile |2 -- arch/arm/plat-samsung/Kconfig | 12 arch/arm/plat-samsung/Makefile |3 +++

[PATCH 2/7] ARM: SAMSUNG: move interrupt part for common s5p into plat-samsung

2012-04-18 Thread Kukjin Kim
Signed-off-by: Kukjin Kim --- arch/arm/plat-s5p/Kconfig | 11 --- arch/arm/plat-s5p/Makefile |3 --- arch/arm/plat-samsung/Kconfig | 16 arch/arm/plat-samsung/Makefile |3

[PATCH 1/7] ARM: SAMSUNG: move clock part for common s5p into plat-samsung

2012-04-18 Thread Kukjin Kim
Signed-off-by: Kukjin Kim --- arch/arm/plat-s5p/Makefile |1 - arch/arm/plat-samsung/Kconfig |5 + arch/arm/plat-samsung/Makefile |1 + .../{plat-s5p/clock.c => plat-samsung/s5p-clock.c} |3 +-- 4 files changed,

[PATCH 0/7] ARM: S5P: moving plat-s5p stuff into plat-samsung

2012-04-18 Thread Kukjin Kim
This patches move plat-s5p stuff into plat-samsung for keep just one plat directory, plat-samsung for Samsung stuff. Actually, it includes small things for common s5p and there is no problem this moving. Of course, I'm working on removing plat-s3c24xx and will be submitted before v3.4 release. NOT

Re: [PATCH] ARM: EXYNOS: add the definition for IRQ_DWMCI

2012-04-18 Thread Jaehoon Chung
On 04/19/2012 09:12 AM, Kukjin Kim wrote: > Jaehoon Chung wrote: >> In dev-dwmci.c, IRQ_DWMCI is referenced. >> But there is no defined anywhere. >> This patch is added the missing definition for IRQ_DWMCI. >> >> Signed-off-by: Jaehoon Chung >> Signed-off-by: Kyungmin Park >> --- >> arch/arm/mac

Re: [PATCH 05/12] ARM: Exynos5: Add MDMA0 clock instance

2012-04-18 Thread Kukjin Kim
Thomas Abraham wrote: > Add clock instance for MDMA0 controller. > > Signed-off-by: Thomas Abraham > --- > arch/arm/mach-exynos/clock-exynos5.c | 11 +-- > 1 files changed, 9 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/mach-exynos/clock-exynos5.c > b/arch/arm/mach-exynos

Re: [PATCH 10/12] ARM: Exynos: Redefine IRQ_MCT_L0,1 definition

2012-04-18 Thread Kukjin Kim
Thomas Abraham wrote: > From: Changhwan Youn > > Redefine IRQ_MCT_L0,1 irq definition as it is changed in rev1 of Exynos5. > > Signed-off-by: Changhwan Youn Basically, looks ok after initial reviewing but you need to add your sign here. As you know, it is a legal issue and _very_ important. Ple

Re: [PATCH 02/12] ARM: Exynos5: Fix incorrect initialization of GIC

2012-04-18 Thread Kukjin Kim
Thomas Abraham wrote: > Use the of_irq_init() call to setup the gic which also properly registers > the gic device node pointer with gic irq domain, without which all interrupt > specifier translations for gic fail. > > Signed-off-by: Thomas Abraham > --- > arch/arm/mach-exynos/common.c |4 +

Re: [PATCH 08/12] gpio/samsung: add GPC4 bank instance

2012-04-18 Thread Kukjin Kim
Thomas Abraham wrote: > From: Sangsu Park > > Add GPC4 bank instance which is included in rev1 of Exynos5. > > Cc: Grant Likely > Signed-off-by: Sangsu Park Where is your sign??? Your sign MUST be included here. > --- > arch/arm/mach-exynos/include/mach/gpio.h |9 ++--- > drivers/gpi

Re: [PATCH 04/12] ARM: Exynos5: Remove duplicated instantiation of pdma clock

2012-04-18 Thread Kukjin Kim
Thomas Abraham wrote: > The clock of both the peripheral dma controllers is controlled by a single > clock gate. Hence remove the duplicate instantiation of the pdma clock. > > Signed-off-by: Thomas Abraham > --- > arch/arm/mach-exynos/clock-exynos5.c | 17 - > 1 files changed

Re: [PATCH 03/12] ARM: Exynos5: Add watchdog timer clock instance

2012-04-18 Thread Kukjin Kim
Thomas Abraham wrote: > Add watchdog timer clock instance for Exynos5 watchdog controller. > > Signed-off-by: Thomas Abraham > --- > arch/arm/mach-exynos/clock-exynos5.c |5 + > 1 files changed, 5 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/mach-exynos/clock-exynos5.c > b/

Re: [PATCH 12/12] ARM: Exynos5: Update device tree enabled machine file

2012-04-18 Thread Kukjin Kim
Thomas Abraham wrote: > Add AUXDATA for i2c and MDMA controllers of Exynos5. > > Signed-off-by: Thomas Abraham > --- > arch/arm/mach-exynos/mach-exynos5-dt.c |7 ++- > 1 files changed, 6 insertions(+), 1 deletions(-) > > diff --git a/arch/arm/mach-exynos/mach-exynos5-dt.c > b/arch/arm

Re: [PATCH 01/12] ARM: Exynos: Remove a new bus_type instance for Exynos5

2012-04-18 Thread Kukjin Kim
Thomas Abraham wrote: > A seperate bus_type instance is not required for Exynos5. The existing > bus_type > instance used with Exynos4 is sufficient for both Exynos4 and Exynos5. This > also solves issue of uninitialized usage of exynos4_subsys in Exynos4 power Yes, could be. BTW could you please

Re: [PATCH] ARM: SAMSUNG: Should check for IS_ERR(clk) instead of NULL

2012-04-18 Thread Kukjin Kim
jhbird.c...@gmail.com wrote: > From: Jonghwan Choi > > On the error condition clk_get() returns ERR_PTR(). > > Signed-off-by: Jonghwan Choi > --- > .../arm/plat-samsung/include/plat/watchdog-reset.h |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/arch/arm/plat-s

Re: [PATCH] ARM: EXYNOS: add the definition for IRQ_DWMCI

2012-04-18 Thread Kukjin Kim
Jaehoon Chung wrote: In dev-dwmci.c, IRQ_DWMCI is referenced. But there is no defined anywhere. This patch is added the missing definition for IRQ_DWMCI. Signed-off-by: Jaehoon Chung Signed-off-by: Kyungmin Park --- arch/arm/mach-exynos/include/mach/irqs.h |1 + 1 files changed, 1 inserti

Re: [PATCH v5 1/2] mfd: add irq domain support for max8997 interrupts

2012-04-18 Thread Mark Brown
On Wed, Apr 18, 2012 at 03:01:02PM +0530, Thomas Abraham wrote: > struct max8997_platform_data { > /* IRQ */ > - int irq_base; > int ono; > int wakeup; This will *still* break the build. signature.asc Description: Digital signature

Re: [PATCH 3/3] i2c-s3c2410: Add HDMIPHY quirk for S3C2440

2012-04-18 Thread Karol Lewandowski
On 18.04.2012 15:46, Wolfram Sang wrote: > Optional properties: + - gpios: The order of the gpios should be the following: . +The gpio specifier depends on the gpio controller. Required in all cases +except when "samsung,i2c-no-gpio" is also specified. +

Re: [PATCH 3/3] i2c-s3c2410: Add HDMIPHY quirk for S3C2440

2012-04-18 Thread Wolfram Sang
> > > Optional properties: > > > + - gpios: The order of the gpios should be the following: . > > > +The gpio specifier depends on the gpio controller. Required in all > > > cases > > > +except when "samsung,i2c-no-gpio" is also specified. > > > + - samsung,i2c-no-gpio: input/output li

Re: [PATCH 2/3] i2c-s3c2410: Rework device type handling

2012-04-18 Thread Wolfram Sang
Hi, > >> Reorganize driver a bit to better handle device tree-based systems: > >> > >> - move machine type to driver's private structure instead of > >>quering platform device variants in runtime > >> > >> - replace s3c24xx_i2c_type enum with unsigned int that holds > >>bitmask with revi

RE: [PATCH 3/3] i2c-s3c2410: Add HDMIPHY quirk for S3C2440

2012-04-18 Thread Marek Szyprowski
Hi Wolfram, On Tuesday, April 17, 2012 7:40 PM Wolfram Sang wrote: > On Wed, Mar 21, 2012 at 08:11:53PM +0100, Karol Lewandowski wrote: > > This patch adds support for s3c2440 I2C bus controller dedicated HDMIPHY > > device on > > Exynos4 platform. Some quirks are introduced due to differences b

Re: [PATCH 2/3] i2c-s3c2410: Rework device type handling

2012-04-18 Thread Karol Lewandowski
On 17.04.2012 19:31, Wolfram Sang wrote: > Hi, Hi Wolfram! > > On Wed, Mar 21, 2012 at 08:11:52PM +0100, Karol Lewandowski wrote: >> Reorganize driver a bit to better handle device tree-based systems: >> >> - move machine type to driver's private structure instead of >>quering platform de

Re: [PATCH 1/3] i2c-s3c2410: Drop unused define

2012-04-18 Thread Wolfram Sang
On Wed, Mar 21, 2012 at 08:11:51PM +0100, Karol Lewandowski wrote: > Use standard of_match_ptr() to avoid defining variable unused > in non device tree builds. > > Signed-off-by: Karol Lewandowski > Signed-off-by: Kyungmin Park > Acked-by: Grant Likely I applied this one already. -- Pengutro

[PATCH v5 2/2] regulator: add device tree support for max8997

2012-04-18 Thread Thomas Abraham
Add device tree based discovery support for max8997. Cc: Karol Lewandowski Cc: Rajendra Nayak Cc: Rob Herring Cc: Grant Likely Signed-off-by: Thomas Abraham Acked-by: MyungJoo Ham --- .../devicetree/bindings/regulator/max8997-pmic.txt | 147 +++ drivers/mfd/max8997.c

[PATCH v5 1/2] mfd: add irq domain support for max8997 interrupts

2012-04-18 Thread Thomas Abraham
Add irq domain support for max8997 interrupts. The reverse mapping method used is linear mapping since the sub-drivers of max8997 such as regulator and charger drivers can use the max8997 irq_domain to get the linux irq number for max8997 interrupts. All uses of irq_base in platform data and max899

[PATCH v5 0/2] regulator: add irq domain and device tree support for MAX8997

2012-04-18 Thread Thomas Abraham
Changes since v4: - Removed redundant irq_to_max8997_irq function. - Fixed the bug in lookup of regulator names - Inculded documentation of additional regulators supported. - Rebased to Mark's latest 'for-next' branch Changes since v3: - Fixed all comments from Grant Likely. - In patch 1/2, sinc

Re: [PATCH v4 2/2] regulator: add device tree support for max8997

2012-04-18 Thread Thomas Abraham
Hi Mark, On 18 April 2012 00:08, Mark Brown wrote: > On Wed, Apr 18, 2012 at 12:05:59AM +0530, Thomas Abraham wrote: >> On 28 March 2012 22:33, Karol Lewandowski wrote: > >> >> +    For BUCK's: > > No 's here, BTW. Ok. > >> >  - EN32KHz_AP >> >  - EN32KHz_CP >> >  - ENVICHG >> >  - ESAFEOUT1 >