Re: [PATCH 1/2] ARM: dts: exynos4210-origen: Add fixed voltage regulator to simple bus

2013-09-27 Thread Sachin Kamat
Hi Tomasz, On 26 September 2013 13:50, Tomasz Figa tomasz.f...@gmail.com wrote: Hi Sachin, I must have missed this patch so better later than never ;). Since you are quite prompt at reviewing I thought you did not have any comments :) Please see my comments inline. On Thursday 26 of

[PATCH V2 2/4] ARM: dts: add watchdog device tree node for exynos5420

2013-09-27 Thread Leela Krishna Amudala
Add watchdog device tree node for exynos5420 Signed-off-by: Leela Krishna Amudala l.kris...@samsung.com --- arch/arm/boot/dts/exynos5420.dtsi |6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi index d537cd7..9fadc23

[PATCH V2 3/4] watchdog: s3c2410_wdt: parse watchdog dt node to read PMU registers adresses

2013-09-27 Thread Leela Krishna Amudala
This patch parses the watchdog node to read pmu wdt sys registers addresses and do mask/unmask enable/disable of WDT in probe and s2r scenarios. Signed-off-by: Leela Krishna Amudala l.kris...@samsung.com --- .../devicetree/bindings/watchdog/samsung-wdt.txt | 24 -

[PATCH V2 1/4] ARM: dts: Fix the watchdog DT node name for Exynos5

2013-09-27 Thread Leela Krishna Amudala
Fixes the watchdog DT node name for Exynos5 as per the DT node naming convention also update status property for Exynos5250 SoC. Signed-off-by: Leela Krishna Amudala l.kris...@samsung.com --- arch/arm/boot/dts/exynos5.dtsi|2 +- arch/arm/boot/dts/exynos5250.dtsi |3 ++- 2 files

[PATCH V2 0/4] Add watchdog DT nodes and parse it to read PMU registers addresses

2013-09-27 Thread Leela Krishna Amudala
This patchset does the following things - Fixes the watchdog DT node name to follow convention - Adds watchdog DT node to Exynos5420 SoC - parse the watchdog device node to read pmu wdt sys registers addresses and do mask/unmask enable/disable of WDT in probe

[PATCH V2 4/4] ARM: dts: exynos: add PMU registers addresses and mask bit to watchdog node

2013-09-27 Thread Leela Krishna Amudala
This patch adds support for specifying the pmu registers and masking bit for watchdog to enable/disable and mask/unmask the watchdog reset request. Signed-off-by: Leela Krishna Amudala l.kris...@samsung.com --- arch/arm/boot/dts/exynos5.dtsi|4 ++-- arch/arm/boot/dts/exynos5250.dtsi |

Re: [PATCH 3/4] watchdog: s3c2410_wdt: parse watchdog dt node to read PMU registers adresses

2013-09-27 Thread Tomasz Figa
On Monday 23 of September 2013 19:11:11 Tomasz Figa wrote: On Monday 23 of September 2013 19:03:10 Bartlomiej Zolnierkiewicz wrote: Hi, On Wednesday, September 18, 2013 12:20:31 PM Leela Krishna Amudala wrote: Tomasz, On Wed, Sep 18, 2013 at 10:04 AM, Doug Anderson

[PATCH v2 1/3] ARM: dts: exynos4210-origen: Add fixed voltage regulator to simple bus

2013-09-27 Thread Sachin Kamat
This has been done for Arndale board vide commit aa3edb65 (ARM: dts: Put Arndale fixed voltage regulators on a simple-bus). Replicate here for consistency and correctness. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- Based on Kukjin's for-next branch. Changes since v1: * Added reg

[PATCH v2 2/3] ARM: dts: exynos4412-origen: Add fixed voltage regulator to simple bus

2013-09-27 Thread Sachin Kamat
This has been done for Arndale board vide commit aa3edb65 (ARM: dts: Put Arndale fixed voltage regulators on a simple-bus). Replicate here for consistency and correctness. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- Based on Kukjin's for-next branch. Changes since v1: * Added reg

[PATCH 3/3] ARM: dts: Add reg property to regulator nodes in exynos5250-arndale

2013-09-27 Thread Sachin Kamat
For consistency and correctness, since this is a bus, even if not physical, it is worth to add 'reg' property and unit-address to subnodes. The 'reg' property would merely be an index. Also for consistency, use regulator as node name as used most commonly across other dts files. Signed-off-by:

[PATCH] spi/s3c64x: Ensure runtime PM is enabled prior to registration

2013-09-27 Thread Mark Brown
From: Mark Brown broo...@linaro.org Otherwise we may try to start transfers immediately and then fail to runtime resume the device causing us not to have clocks enabled. Signed-off-by: Mark Brown broo...@linaro.org --- drivers/spi/spi-s3c64xx.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH v9 02/13] [media] exynos5-fimc-is: Add Exynos5 FIMC-IS device tree bindings documentation

2013-09-27 Thread Arun Kumar K
The patch adds the DT binding documentation for Samsung Exynos5 SoC series imaging subsystem (FIMC-IS). Signed-off-by: Arun Kumar K arun...@samsung.com Reviewed-by: Sylwester Nawrocki s.nawro...@samsung.com --- .../devicetree/bindings/media/exynos5-fimc-is.txt | 84 1

[PATCH v9 03/13] [media] exynos5-fimc-is: Add driver core files

2013-09-27 Thread Arun Kumar K
This driver is for the FIMC-IS IP available in Samsung Exynos5 SoC onwards. This patch adds the core files for the new driver. Signed-off-by: Arun Kumar K arun...@samsung.com Signed-off-by: Kilyeon Im kilyeon...@samsung.com Reviewed-by: Sylwester Nawrocki s.nawro...@samsung.com ---

[PATCH v9 08/13] [media] exynos5-fimc-is: Add sensor interface

2013-09-27 Thread Arun Kumar K
Some sensors to be used with fimc-is are exclusively controlled by the fimc-is firmware. This minimal sensor driver provides the required info for the firmware to configure the sensors sitting on I2C bus. Signed-off-by: Arun Kumar K arun...@samsung.com Reviewed-by: Sylwester Nawrocki

[PATCH v9 12/13] V4L: s5k6a3: Change sensor min/max resolutions

2013-09-27 Thread Arun Kumar K
s5k6a3 sensor has actual pixel resolution of 1408x1402 against the active resolution 1392x1392. The real resolution is needed when raw sensor SRGB data is dumped to memory by fimc-lite. Signed-off-by: Arun Kumar K arun...@samsung.com Reviewed-by: Sylwester Nawrocki s.nawro...@samsung.com ---

[PATCH v9 10/13] [media] exynos5-fimc-is: Add the hardware interface module

2013-09-27 Thread Arun Kumar K
The hardware interface module finally sends the commands to the FIMC-IS firmware and runs the interrupt handler for getting the responses. Signed-off-by: Arun Kumar K arun...@samsung.com Signed-off-by: Kilyeon Im kilyeon...@samsung.com Reviewed-by: Sylwester Nawrocki s.nawro...@samsung.com ---

[PATCH v9 09/13] [media] exynos5-fimc-is: Add the hardware pipeline control

2013-09-27 Thread Arun Kumar K
This patch adds the crucial hardware pipeline control for the fimc-is driver. All the subdev nodes will call this pipeline interfaces to reach the hardware. Responsibilities of this module involves configuring and maintaining the hardware pipeline involving multiple sub-ips like ISP, DRC, Scalers,

[PATCH v9 13/13] V4L: Add driver for s5k4e5 image sensor

2013-09-27 Thread Arun Kumar K
This patch adds subdev driver for Samsung S5K4E5 raw image sensor. Like s5k6a3, it is also another fimc-is firmware controlled sensor. This minimal sensor driver doesn't do any I2C communications as its done by ISP firmware. It can be updated if needed to a regular sensor driver by adding the I2C

[PATCH v9 07/13] [media] exynos5-fimc-is: Add scaler subdev

2013-09-27 Thread Arun Kumar K
FIMC-IS has two hardware scalers named as scaler-codec and scaler-preview. This patch adds the common code handling the video nodes and subdevs of both the scalers. Signed-off-by: Arun Kumar K arun...@samsung.com Signed-off-by: Kilyeon Im kilyeon...@samsung.com Reviewed-by: Sylwester Nawrocki

[PATCH v9 00/13] Exynos5 IS driver

2013-09-27 Thread Arun Kumar K
The patch series add support for Exynos5 camera subsystem. It re-uses mipi-csis and fimc-lite from exynos4-is and adds a new media device and fimc-is device drivers for exynos5. Changes from v8 --- - Moved i2c-isp device nodes into the fimc-is node as suggested by Sylwester -

[PATCH v9 05/13] [media] exynos5-fimc-is: Add register definition and context header

2013-09-27 Thread Arun Kumar K
This patch adds the register definition file for the fimc-is driver and also the header file containing the main context for the driver. Signed-off-by: Arun Kumar K arun...@samsung.com Signed-off-by: Kilyeon Im kilyeon...@samsung.com Reviewed-by: Sylwester Nawrocki s.nawro...@samsung.com ---

[PATCH v9 06/13] [media] exynos5-fimc-is: Add isp subdev

2013-09-27 Thread Arun Kumar K
fimc-is driver takes video data input from the ISP video node which is added in this patch. This node accepts Bayer input buffers which is given from the IS sensors. Signed-off-by: Arun Kumar K arun...@samsung.com Signed-off-by: Kilyeon Im kilyeon...@samsung.com Reviewed-by: Sylwester Nawrocki

[PATCH v9 01/13] [media] exynos5-is: Adding media device driver for exynos5

2013-09-27 Thread Arun Kumar K
From: Shaik Ameer Basha shaik.am...@samsung.com This patch adds support for media device for EXYNOS5 SoCs. The current media device supports the following ips to connect through the media controller framework. * MIPI-CSIS Support interconnection(subdev interface) between devices * FIMC-LITE

Re: [PATCH] spi/s3c64x: Ensure runtime PM is enabled prior to registration

2013-09-27 Thread Sylwester Nawrocki
On 27/09/13 12:53, Mark Brown wrote: From: Mark Brown broo...@linaro.org Otherwise we may try to start transfers immediately and then fail to runtime resume the device causing us not to have clocks enabled. Signed-off-by: Mark Brown broo...@linaro.org Reviewed-by: Sylwester Nawrocki

Re: [PATCH 3/4] watchdog: s3c2410_wdt: parse watchdog dt node to read PMU registers adresses

2013-09-27 Thread Leela Krishna Amudala
Tomasz, On Fri, Sep 27, 2013 at 3:42 PM, Tomasz Figa t.f...@samsung.com wrote: On Monday 23 of September 2013 19:11:11 Tomasz Figa wrote: On Monday 23 of September 2013 19:03:10 Bartlomiej Zolnierkiewicz wrote: Hi, On Wednesday, September 18, 2013 12:20:31 PM Leela Krishna Amudala

Re: [PATCH 3/4] watchdog: s3c2410_wdt: parse watchdog dt node to read PMU registers adresses

2013-09-27 Thread Tomasz Figa
On Friday 27 of September 2013 16:48:34 Leela Krishna Amudala wrote: Tomasz, On Fri, Sep 27, 2013 at 3:42 PM, Tomasz Figa t.f...@samsung.com wrote: On Monday 23 of September 2013 19:11:11 Tomasz Figa wrote: On Monday 23 of September 2013 19:03:10 Bartlomiej Zolnierkiewicz wrote: Hi,

Re: [PATCH 2/3] clk: samsung: Add clock driver for s5pc100

2013-09-27 Thread Yadwinder Singh Brar
Hi Tomasz, On Thu, Sep 26, 2013 at 7:30 PM, Tomasz Figa t.f...@samsung.com wrote: Hi Yadwinder, I haven't reviewed this series yet, but let me clarify some things from your comments. On Thursday 26 of September 2013 17:38:58 Yadwinder Singh Brar wrote: + +/* Helper macros to define

Re: [PATCH] clockevent: exynos_mct: fix lockdep warning

2013-09-27 Thread Ming Lei
On Thu, Sep 26, 2013 at 6:32 PM, Tomasz Figa t.f...@samsung.com wrote: This is a fix that we may want to have, but it must be modified to take my regression fix[1] into account. [1] clocksource: exynos_mct: Set IRQ affinity when the CPU goes online

Re: [PATCH] clockevent: exynos_mct: fix lockdep warning

2013-09-27 Thread Daniel Lezcano
On 09/27/2013 03:09 PM, Ming Lei wrote: On Thu, Sep 26, 2013 at 6:32 PM, Tomasz Figa t.f...@samsung.com wrote: This is a fix that we may want to have, but it must be modified to take my regression fix[1] into account. [1] clocksource: exynos_mct: Set IRQ affinity when the CPU goes online

Re: [PATCH] pinctrl: Correct number of pins for s5pv210

2013-09-27 Thread Linus Walleij
On Tue, Sep 24, 2013 at 5:04 PM, Mateusz Krawczuk m.krawc...@partner.samsung.com wrote: Values of pins in table s5pv210 bank are incorrect. This patch correct values. Signed-off-by: Mateusz Krawczuk m.krawc...@partner.samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com Patch

Re: [PATCH] ARM: S3C24XX: Fix configuration of gpio port sizes on S3C24XX.

2013-09-27 Thread Linus Walleij
On Wed, Sep 11, 2013 at 10:46 AM, José Miguel Gonçalves jose.goncal...@inov.pt wrote: Some GPIO line limits are incorrectly set which, for instance, does not allow nRTS1 (GPH11) configuration on a S3C2416 chip. Signed-off-by: José Miguel Gonçalves jose.goncal...@inov.pt ---

Re: [PATCH V2 4/4] ARM: dts: exynos: add PMU registers addresses and mask bit to watchdog node

2013-09-27 Thread Sachin Kamat
Hi Leela, On 27 September 2013 15:46, Leela Krishna Amudala l.kris...@samsung.com wrote: watchdog@101D { - compatible = samsung,s3c2410-wdt; - reg = 0x101D 0x100; + compatible = samsung,s3c5250-wdt; + reg = 0x101D

Re: [PATCH V2 3/4] watchdog: s3c2410_wdt: parse watchdog dt node to read PMU registers adresses

2013-09-27 Thread Sachin Kamat
On 27 September 2013 15:46, Leela Krishna Amudala l.kris...@samsung.com wrote: This patch parses the watchdog node to read pmu wdt sys registers addresses and do mask/unmask enable/disable of WDT in probe and s2r scenarios. Signed-off-by: Leela Krishna Amudala l.kris...@samsung.com ---

Re: [PATCH 3/4] watchdog: s3c2410_wdt: parse watchdog dt node to read PMU registers adresses

2013-09-27 Thread Tomasz Figa
On Friday 27 of September 2013 08:20:25 Doug Anderson wrote: Tomasz On Fri, Sep 27, 2013 at 4:25 AM, Tomasz Figa t.f...@samsung.com wrote: Since we already have PMU driver in mach-exynos, which already has suspend/resume syscore ops, what about placing such configuration there

Re: [PATCH 3/4] watchdog: s3c2410_wdt: parse watchdog dt node to read PMU registers adresses

2013-09-27 Thread Doug Anderson
Tomasz, On Fri, Sep 27, 2013 at 11:14 AM, Tomasz Figa tomasz.f...@gmail.com wrote: So isn't the register in the PMU there to save power in the case that the watchdog timer isn't being used? How is the PMU driver to know whether the watchdog is being used? Better IMHO that the watchdog

Re: [PATCH v6 07/12] ARM: EXYNOS: remove system mmu initialization from exynos tree

2013-09-27 Thread Sean Paul
On Tue, Dec 25, 2012 at 8:54 PM, Cho KyongHo pullip@samsung.com wrote: This removes System MMU initialization from arch/arm/mach-exynos/ to move them to DT and the exynos-iommu driver except gating clock definitions. exynos with iommu support no longer compiles with this patch: CC

Re: [PATCH] MAINTAINERS: add maintainer entry for Samsung Exynos PCIe driver

2013-09-27 Thread Bjorn Helgaas
On Thu, Sep 12, 2013 at 5:29 AM, Jingoo Han jg1@samsung.com wrote: Add myself as maintainer for Samsung Exynos PCIe driver. Signed-off-by: Jingoo Han jg1@samsung.com Applied to my pci/host-exynos branch for v3.13. Thanks! --- MAINTAINERS |6 ++ 1 file changed, 6

Re: [PATCH V3] PCI: exynos: add support for MSI

2013-09-27 Thread Bjorn Helgaas
On Fri, Sep 6, 2013 at 12:54 AM, Jingoo Han jg1@samsung.com wrote: This patch adds support for Message Signaled Interrupt in the Exynos PCIe diver using Synopsys designware PCIe core IP. Signed-off-by: Siva Reddy Kallam siva.kal...@samsung.com Signed-off-by: Srikanth T Shivanand

Re: [PATCH] PCI: exynos: turn off power of phy block when link failed

2013-09-27 Thread Bjorn Helgaas
On Fri, Sep 6, 2013 at 2:21 AM, Jingoo Han jg1@samsung.com wrote: When link failed, there is no need to turn on phy block. Also, turning on phy block is added, in order to turn on phy block regardless of the default value of phy registers. Signed-off-by: Jingoo Han jg1@samsung.com

[PATCH 1/6] spi/s3c64xx: Flush FIFOs prior to cleaning up transfer

2013-09-27 Thread Mark Brown
From: Mark Brown broo...@linaro.org Ensure that the FIFOs are fully drained before we deassert /CS or do any delays that have been requested in order to ensure that the behaviour visible on the bus matches that which was requested by the caller. Signed-off-by: Mark Brown broo...@linaro.org ---

[PATCH 5/6] spi/s3c64xx: Factor transfer start out of enable/disable_cs()

2013-09-27 Thread Mark Brown
From: Mark Brown broo...@linaro.org The hardware level /CS handling is tied to the start of the data path so is rolled into the same function as we use to manipulate GPIO /CS. In order to support factoring out the /CS handling into the core separate the two and explicitly start transfers

[PATCH 3/6] spi/s3c64xx: Remove unused gpios field from driver data

2013-09-27 Thread Mark Brown
From: Mark Brown broo...@linaro.org Signed-off-by: Mark Brown broo...@linaro.org --- drivers/spi/spi-s3c64xx.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index dd5ed13..7f960db 100644 --- a/drivers/spi/spi-s3c64xx.c +++

[PATCH 6/6] spi/s3c64xx: Enable GPIO /CS prior to starting hardware

2013-09-27 Thread Mark Brown
From: Mark Brown broo...@linaro.org To help with bisection of future refactoring to share more of the code for handling a spi_message pull the enabling of GPIO based /CS prior to all the hardware setup for starting a transfer. Signed-off-by: Mark Brown broo...@linaro.org ---

[PATCH 4/6] spi/s3c64xx: Use core cs_gpio field

2013-09-27 Thread Mark Brown
From: Mark Brown broo...@linaro.org Rather than using the driver custom platform data to store the chip select GPIO use the cs_gpio field provided by the SPI core, supporting future refectoring. Signed-off-by: Mark Brown broo...@linaro.org --- drivers/spi/spi-s3c64xx.c | 24

[PATCH 2/6] spi/s3c64xx: Check that clock enables succeed on runtime resume

2013-09-27 Thread Mark Brown
From: Mark Brown broo...@linaro.org Signed-off-by: Mark Brown broo...@linaro.org --- drivers/spi/spi-s3c64xx.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index 2e267ce..dd5ed13 100644 ---

Re: [PATCH v9 01/13] [media] exynos5-is: Adding media device driver for exynos5

2013-09-27 Thread Sylwester Nawrocki
Hi Arun, Shaik, This patch looks good to me, I have added it to my tree for 3.13, with slightly edited patch's description. I will be sending a pull request to the media tree not earlier than in two weeks, thus there is still some time, should anyone have any further comments/change requests.

Re: [PATCH V2 1/4] ARM: dts: Fix the watchdog DT node name for Exynos5

2013-09-27 Thread Doug Anderson
Leela Krishna, On Fri, Sep 27, 2013 at 3:16 AM, Leela Krishna Amudala l.kris...@samsung.com wrote: Fixes the watchdog DT node name for Exynos5 as per the DT node naming convention also update status property for Exynos5250 SoC. Signed-off-by: Leela Krishna Amudala l.kris...@samsung.com ---

Re: [PATCH V2 2/4] ARM: dts: add watchdog device tree node for exynos5420

2013-09-27 Thread Doug Anderson
Leela Krishna, On Fri, Sep 27, 2013 at 3:16 AM, Leela Krishna Amudala l.kris...@samsung.com wrote: Add watchdog device tree node for exynos5420 Signed-off-by: Leela Krishna Amudala l.kris...@samsung.com --- arch/arm/boot/dts/exynos5420.dtsi |6 ++ 1 file changed, 6 insertions(+)

ARM: EXYNOS: implement pm_power_off for EXYNOS5440

2013-09-27 Thread Jungseok Lee
This patch implements pm_power_off function since a power-down control register should be set in order to turn off EXYNOS5440. Otherwise, power domains remain alive despite poweroff action. Signed-off-by: Jungseok Lee jays@samsung.com --- arch/arm/mach-exynos/common.c | 17