Re: [PATCH v2 10/10] mfd: cros_ec: move EC interrupt to cros_ec_keyb

2014-06-19 Thread Simon Glass
On 18 June 2014 12:14, Doug Anderson wrote: > From: Andrew Bresticker > > If we receive EC interrupts after the cros_ec driver has probed, but > before the cros_ec_keyb driver has probed, the cros_ec IRQ handler > will not run the cros_ec_keyb notifier and the EC will leave the IRQ > line asserte

Re: [PATCH v2 08/10] mfd: cros_ec: Check result code from EC messages

2014-06-19 Thread Simon Glass
On 18 June 2014 12:14, Doug Anderson wrote: > From: Bill Richardson > > Just because the host was able to talk to the EC doesn't mean that the EC > was happy with what it was told. Errors in communincation are not the same > as error messages from the EC itself. > > This change lets the EC report

Re: [PATCH v2 05/10] mfd: cros_ec: Use struct cros_ec_command to communicate with the EC

2014-06-19 Thread Simon Glass
On 18 June 2014 12:14, Doug Anderson wrote: > From: Bill Richardson > > This is some internal structure reorganization / renaming to prepare > for future patches that will add a userspace API to cros_ec. There > should be no visible changes. > > Signed-off-by: Bill Richardson > Signed-off-by: D

Re: MMC error on Exynos4210 board

2014-06-19 Thread Sachin Kamat
On Thu, Jun 19, 2014 at 6:11 PM, Jaehoon Chung wrote: > On 06/19/2014 07:40 PM, Sachin Kamat wrote: >> On Thu, Jun 19, 2014 at 2:40 PM, Tim Kryger wrote: >>> On Thu, Jun 19, 2014 at 1:49 AM, Sachin Kamat wrote: +cc Some relevant guys from Samsung On Thu, Jun 19, 2014 at 2:12 PM, T

Re: [PATCHv4 2/4] iio: adc: exynos_adc: Control special clock of ADC to support Exynos3250 ADC

2014-06-19 Thread Naveen Krishna Ch
Hello Tomasz, On 20 June 2014 06:00, Tomasz Figa wrote: > On 20.06.2014 02:28, Chanwoo Choi wrote: >> On 06/20/2014 09:24 AM, Tomasz Figa wrote: >>> On 20.06.2014 02:22, Chanwoo Choi wrote: Hi Tomasz, On 06/18/2014 04:58 PM, Tomasz Figa wrote: > Hi Chanwoo, > > On 18.06

Re: [PATCHv4 2/4] iio: adc: exynos_adc: Control special clock of ADC to support Exynos3250 ADC

2014-06-19 Thread Tomasz Figa
On 20.06.2014 02:28, Chanwoo Choi wrote: > On 06/20/2014 09:24 AM, Tomasz Figa wrote: >> On 20.06.2014 02:22, Chanwoo Choi wrote: >>> Hi Tomasz, >>> >>> On 06/18/2014 04:58 PM, Tomasz Figa wrote: Hi Chanwoo, On 18.06.2014 04:20, Chanwoo Choi wrote: > This patch control special cl

Re: [PATCHv4 2/4] iio: adc: exynos_adc: Control special clock of ADC to support Exynos3250 ADC

2014-06-19 Thread Chanwoo Choi
On 06/20/2014 09:24 AM, Tomasz Figa wrote: > On 20.06.2014 02:22, Chanwoo Choi wrote: >> Hi Tomasz, >> >> On 06/18/2014 04:58 PM, Tomasz Figa wrote: >>> Hi Chanwoo, >>> >>> On 18.06.2014 04:20, Chanwoo Choi wrote: This patch control special clock for ADC in Exynos series's FSYS block. If

Re: [PATCHv4 1/4] iio: adc: exynos_adc: Add exynos_adc_ops structure to improve readability

2014-06-19 Thread Tomasz Figa
On 20.06.2014 02:20, Chanwoo Choi wrote: > Hi Tomasz, > > On 06/18/2014 04:55 PM, Tomasz Figa wrote: >> Hi Chanwoo, >> >> On 18.06.2014 04:20, Chanwoo Choi wrote: >>> This patchset add 'exynos_adc_ops' structure which includes some functions >>> to control ADC operation according to ADC version (v

Re: [PATCHv4 2/4] iio: adc: exynos_adc: Control special clock of ADC to support Exynos3250 ADC

2014-06-19 Thread Tomasz Figa
On 20.06.2014 02:22, Chanwoo Choi wrote: > Hi Tomasz, > > On 06/18/2014 04:58 PM, Tomasz Figa wrote: >> Hi Chanwoo, >> >> On 18.06.2014 04:20, Chanwoo Choi wrote: >>> This patch control special clock for ADC in Exynos series's FSYS block. >>> If special clock of ADC is registerd on clock list of c

Re: [PATCHv4 2/4] iio: adc: exynos_adc: Control special clock of ADC to support Exynos3250 ADC

2014-06-19 Thread Chanwoo Choi
Hi Tomasz, On 06/18/2014 04:58 PM, Tomasz Figa wrote: > Hi Chanwoo, > > On 18.06.2014 04:20, Chanwoo Choi wrote: >> This patch control special clock for ADC in Exynos series's FSYS block. >> If special clock of ADC is registerd on clock list of common clk framework, >> Exynos ADC drvier have to c

Re: [PATCHv4 1/4] iio: adc: exynos_adc: Add exynos_adc_ops structure to improve readability

2014-06-19 Thread Chanwoo Choi
Hi Tomasz, On 06/18/2014 04:55 PM, Tomasz Figa wrote: > Hi Chanwoo, > > On 18.06.2014 04:20, Chanwoo Choi wrote: >> This patchset add 'exynos_adc_ops' structure which includes some functions >> to control ADC operation according to ADC version (v1 or v2). >> >> Signed-off-by: Chanwoo Choi >> Ack

Re: [PATCH 1/2] drm/exynos/fbdev: don't set fix.smem/mmio_{start,len}

2014-06-19 Thread Siarhei Siamashka
On Fri, 4 Apr 2014 17:22:01 +0800 Daniel Kurtz wrote: > Kernel access to the eyxnos fbdev framebuffer is via its gem object's > kernel mapping (kvaddr, stored in info->screen_base). > > User space access is provided by mmap(), read() and write() of /dev/fb/fb0. > These functions also only use s

Re: [PATCH] i2c: exynos5: Properly use the "noirq" variants of suspend/resume

2014-06-19 Thread Doug Anderson
Kevin, On Thu, Jun 19, 2014 at 11:43 AM, Kevin Hilman wrote: > Doug Anderson writes: > >> The original code for the exynos i2c controller registered for the >> "noirq" variants. However during review feedback it was moved to >> SIMPLE_DEV_PM_OPS without anyone noticing that it meant we were no

Re: [PATCH v2] arm: exynos: Support cluster power off on exynos5420/5800

2014-06-19 Thread Kevin Hilman
the MCPM > back-end. > > The patch is based on Linux-next 20140619. It has been tested on an > exynos5420-based chromebook using the "/dev/bL_switcher" interface as > well as the script provided by Nicolas Pitre and Dave Martin [1]. > > Patch depends on: > [v2] ARM: EXYN

Re: [PATCH] i2c: exynos5: Properly use the "noirq" variants of suspend/resume

2014-06-19 Thread Kevin Hilman
Doug Anderson writes: > The original code for the exynos i2c controller registered for the > "noirq" variants. However during review feedback it was moved to > SIMPLE_DEV_PM_OPS without anyone noticing that it meant we were no > longer actually "noirq" (despite functions named > exynos5_i2c_susp

[PATCH v3 01/14] mfd: max77686: Convert to use regmap_irq

2014-06-19 Thread Javier Martinez Canillas
By using the generic IRQ support in the Register map API, it is possible to get rid max77686-irq.c and simplify the code. Suggested-by: Krzysztof Kozlowski Signed-off-by: Javier Martinez Canillas Acked-by: Lee Jones Reviewed-by: Doug Anderson Tested-by: Doug Anderson --- Changes since v2: -

[PATCH v3 03/14] clk: max77686: Add DT include for MAX77686 PMIC clock

2014-06-19 Thread Javier Martinez Canillas
This patch adds a dt-binding include for Maxim 77686 PMIC clock IDs that can be to be shared between the clk-max77686 clock driver and DeviceTree source files. Signed-off-by: Javier Martinez Canillas --- drivers/clk/clk-max77686.c | 7 +-- include/dt-bindings/clock/maxim,max

[PATCH v3 02/14] mfd: max77686: Allow the max77686 rtc to wakeup the system

2014-06-19 Thread Javier Martinez Canillas
From: Doug Anderson The max77686 includes an RTC that keeps power during suspend. It's convenient to be able to use it as a wakeup source. Signed-off-by: Doug Anderson --- drivers/rtc/rtc-max77686.c | 28 1 file changed, 28 insertions(+) diff --git a/drivers/rtc/

[PATCH v3 04/14] clk: max77686: Improve Maxim 77686 PMIC clocks binding

2014-06-19 Thread Javier Martinez Canillas
Like most clock drivers, the Maxim 77686 PMIC clock binding follows the convention that the "#clock-cells" property is used to specify the number of cells in a clock provider. But the binding document is not clear enough that it shall be set to 1 since the PMIC support multiple clocks outputs. Al

[PATCH v3 05/14] clk: Add generic driver for Maxim PMIC clocks

2014-06-19 Thread Javier Martinez Canillas
Maxim Integrated Power Management ICs are very similar with regard to their clock outputs. Most of the clock drivers for these chips are duplicating code and are simpler enough that can be converted to use a generic driver to consolidate code and avoid duplication. Signed-off-by: Javier Martinez C

[PATCH v3 08/14] mfd: max77802: Add DT binding documentation

2014-06-19 Thread Javier Martinez Canillas
Add Device Tree binding documentation for Maxim 77802 PMIC. Signed-off-by: Javier Martinez Canillas --- Changes since v2: - Explain better the Dynamic Voltage Scaling (DVS) support in some Buck regulators and the max77802,pmic-buck-{dvs,selb}-gpios properties. Suggested by Mark Brown. D

[PATCH v3 06/14] clk: max77686: Convert to the generic max clock driver

2014-06-19 Thread Javier Martinez Canillas
Clocks drivers for Maxim PMIC are very similar so they can be converted to use the generic Maxim clock driver. Also, while being there use module_platform_driver() helper macro to eliminate more boilerplate code. Signed-off-by: Javier Martinez Canillas --- drivers/clk/Kconfig| 1 + dr

[PATCH v3 07/14] mfd: Add driver for Maxim 77802 Power Management IC

2014-06-19 Thread Javier Martinez Canillas
Maxim MAX77802 is a power management chip that contains 10 high efficiency Buck regulators, 32 Low-dropout (LDO) regulators used to power up application processors and peripherals, a 2-channel 32kHz clock outputs, a Real-Time-Clock (RTC) and a I2C interface to program the individual regulators, clo

[PATCH v3 09/14] regmap: Add regmap_reg_copy function

2014-06-19 Thread Javier Martinez Canillas
Some device drivers using the register map API need to copy the value from one register to another. Even though it can be done with a combination of regmap_read() and regmap_write(), it is better to have a function to avoid code duplication, sanity check passed values and do it atomically by holdin

[PATCH v3 10/14] regulator: Add driver for Maxim 77802 PMIC regulators

2014-06-19 Thread Javier Martinez Canillas
The MAX77802 PMIC has 10 high-efficiency Buck and 32 Low-dropout (LDO) regulators. This patch adds support for all these regulators found on the MAX77802 PMIC and is based on a driver added by Simon Glass to the Chrome OS kernel 3.8 tree. Signed-off-by: Javier Martinez Canillas --- Changes since

[PATCH v3 11/14] clk: Add driver for Maxim 77802 PMIC clocks

2014-06-19 Thread Javier Martinez Canillas
The MAX77802 PMIC has two 32.768kHz Buffered Clock Outputs with Low Jitter Mode. This patch adds support for these two clocks. Signed-off-by: Javier Martinez Canillas --- Changes since v2: None Changes since v1: - Use module_platform_driver() instead of having init/exit functions. Suggested

[PATCH v3 12/14] clk: max77802: Add DT binding documentation

2014-06-19 Thread Javier Martinez Canillas
Add Device Tree binding documentation for the clocks outputs in the Maxim 77802 Power Management IC. Signed-off-by: Javier Martinez Canillas --- Changes since v2: - Split the DT binding documentation in a separate patch. .../devicetree/bindings/clock/maxim,max77802.txt | 42

[PATCH v3 13/14] rtc: Add driver for Maxim 77802 PMIC Real-Time-Clock

2014-06-19 Thread Javier Martinez Canillas
The MAX7802 PMIC has a Real-Time-Clock (RTC) with two alarms. This patch adds support for the RTC and is based on a driver added by Simon Glass to the Chrome OS kernel 3.8 tree. Signed-off-by: Javier Martinez Canillas --- drivers/rtc/Kconfig| 10 + drivers/rtc/Makefile | 1 + dr

[PATCH v3 14/14] ARM: dts: Add max77802 device node for exynos5420-peach-pit

2014-06-19 Thread Javier Martinez Canillas
Peach pit board uses a Maxim 77802 power management IC to drive regulators and its Real Time Clock. This patch adds support for this chip. These are the device nodes and pinctrl configuration that is present on the Peach pit DeviceTree source file in the the Chrome OS kernel 3.8 tree. Signed-off-

[PATCH v3 00/14] Add Maxim 77802 PMIC support

2014-06-19 Thread Javier Martinez Canillas
MAX77802 is a PMIC that contains 10 high efficiency Buck regulators, 32 Low-dropout (LDO) regulators, two 32kHz buffered clock outputs, a Real-Time-Clock (RTC) and a I2C interface to program the individual regulators, clocks and the RTC. This third version of the patch-set addresses several issues

[PATCH v2] clocksource: exynos_mct: Fix ftrace

2014-06-19 Thread Doug Anderson
In (93bfb76 clocksource: exynos_mct: register sched_clock callback) we supported using the MCT as a scheduler clock. We properly marked exynos4_read_sched_clock() as notrace. However, we then went and called another function that _wasn't_ notrace. That means if you do: cd /sys/kernel/debug/tr

Re: [PATCH 1/3] clocksource: exynos_mct: Fix ftrace

2014-06-19 Thread Doug Anderson
Daniel, On Tue, Jun 17, 2014 at 5:13 AM, Daniel Lezcano wrote: > On 06/04/2014 07:30 PM, Doug Anderson wrote: >> >> In (93bfb76 clocksource: exynos_mct: register sched_clock callback) we >> supported using the MCT as a scheduler clock. We properly marked >> exynos4_read_sched_clock() as notrace.

Re: [PATCH v2] clocksource: exynos-mct: Register the timer for stable udelay

2014-06-19 Thread Tomasz Figa
On 19.06.2014 18:31, Doug Anderson wrote: > Tomasz, > > On Thu, Jun 19, 2014 at 9:17 AM, Tomasz Figa wrote: >> On 19.06.2014 18:01, Doug Anderson wrote: >>> Hi, >>> >>> On Thu, Jun 19, 2014 at 3:21 AM, Tomasz Figa wrote: > +static struct delay_timer exynos4_delay_timer; > + > +static

Re: [PATCH v2] clocksource: exynos-mct: Register the timer for stable udelay

2014-06-19 Thread Doug Anderson
Tomasz, On Thu, Jun 19, 2014 at 9:17 AM, Tomasz Figa wrote: > On 19.06.2014 18:01, Doug Anderson wrote: >> Hi, >> >> On Thu, Jun 19, 2014 at 3:21 AM, Tomasz Figa wrote: +static struct delay_timer exynos4_delay_timer; + +static unsigned long exynos4_read_current_timer(void) >> >> N

Re: [PATCH v2] clocksource: exynos-mct: Register the timer for stable udelay

2014-06-19 Thread Tomasz Figa
On 19.06.2014 18:01, Doug Anderson wrote: > Hi, > > On Thu, Jun 19, 2014 at 3:21 AM, Tomasz Figa wrote: >>> +static struct delay_timer exynos4_delay_timer; >>> + >>> +static unsigned long exynos4_read_current_timer(void) > > Note: I think this should return a cycles_t, not an unsigned long. > Th

Re: [PATCH] clocksource: exynos-mct: Register the timer for stable udelay

2014-06-19 Thread Doug Anderson
Daniel, On Thu, Jun 19, 2014 at 9:02 AM, Daniel Lezcano wrote: >> My understanding of the current status is: >> * I posed the 64-bit version that's almost as fast as the 32-bit version. >> * I asked if people want the 32-bit version: no answer >> * I asked if anyone is opposed to the 64-bit versi

Re: [PATCH] clocksource: exynos-mct: Register the timer for stable udelay

2014-06-19 Thread Daniel Lezcano
On 06/19/2014 05:49 PM, Doug Anderson wrote: Daniel, On Thu, Jun 19, 2014 at 2:07 AM, Daniel Lezcano wrote: On 06/19/2014 01:17 AM, Doug Anderson wrote: Amit, Thanks for posting! On Wed, Jun 18, 2014 at 4:31 AM, Amit Daniel Kachhap wrote: This patch register the exynos mct clocksource a

Re: [PATCH v2] clocksource: exynos-mct: Register the timer for stable udelay

2014-06-19 Thread Doug Anderson
Hi, On Thu, Jun 19, 2014 at 3:21 AM, Tomasz Figa wrote: >> +static struct delay_timer exynos4_delay_timer; >> + >> +static unsigned long exynos4_read_current_timer(void) Note: I think this should return a cycles_t, not an unsigned long. They're the same (right now), but probably shouldn't be (se

Re: [PATCH] clocksource: exynos-mct: Register the timer for stable udelay

2014-06-19 Thread Doug Anderson
Daniel, On Thu, Jun 19, 2014 at 2:07 AM, Daniel Lezcano wrote: > On 06/19/2014 01:17 AM, Doug Anderson wrote: >> >> Amit, >> >> Thanks for posting! >> >> On Wed, Jun 18, 2014 at 4:31 AM, Amit Daniel Kachhap >> wrote: >>> >>> This patch register the exynos mct clocksource as the current timer >>>

[RFC] drm/exynos: abort commit when framebuffer is removed from plane

2014-06-19 Thread Rahul Sharma
This situation arises when userspace remove the frambuffer object and call setmode ioctl. drm_mode_rmfb --> drm_plane_force_disable --> plane->crtc = NULL; and drm_mode_setcrtc --> exynos_plane_commit --> passes plane->crtc to exynos_drm_crtc_plane_commit which is NULL. This crashes the system.

Re: [PATCH v2 07/10] regulator: Add driver for Maxim 77802 PMIC regulators

2014-06-19 Thread Alessandro Zummo
On Wed, 18 Jun 2014 15:10:48 +0100 Lee Jones wrote: > > So I guess you should either a) take the whole patch-set through your mfd > > tree > > or b) merge the mfd patches and create an immutable branch that can be > > pulled by > > Mark, Mike and Alessandro. > > > > I don't know what's the pre

Re: [PATCH 1/4] ARM: dts: exynos4: add port sub-nodes to exynos usb host modules

2014-06-19 Thread Tomasz Figa
On 19.06.2014 13:44, Daniel Drake wrote: > On Tue, Jun 17, 2014 at 10:25 AM, Marek Szyprowski > wrote: >> This patch adds port sub-nodes to exynos4 ehci and ohci modules, which >> are required by recently merged new exynos4 usb2 phy support. >> >> Signed-off-by: Marek Szyprowski > > I checked th

Re: [PATCH 2/4] ARM: dts: exynos4412-odroidx: enable common hardware blocks

2014-06-19 Thread Tomasz Figa
On 19.06.2014 14:21, Daniel Drake wrote: > On Tue, Jun 17, 2014 at 10:25 AM, Marek Szyprowski > wrote: >> This patch adds support for common hardware modules available on all >> Exynos4412-based Odroid boards, which already have complete support in >> mainline kernel. This includes secure firmware

Re: [PATCH 4/4] ARM: dts: refactor Odroid DTS file and add support for Odroid X2 and U2/U3

2014-06-19 Thread Daniel Drake
On Tue, Jun 17, 2014 at 10:25 AM, Marek Szyprowski wrote: > This patch moves some parts of exynos4412-odroidx.dts to common > exynos4412-odroid-common.dtsi file and adds support for Odroid X2 and > U2/U3 boards. X2 is same as X, but it has faster SoC module (1.7GHz > instead of 1.4GHz), while U2/U

Re: MMC error on Exynos4210 board

2014-06-19 Thread Jaehoon Chung
On 06/19/2014 07:40 PM, Sachin Kamat wrote: > On Thu, Jun 19, 2014 at 2:40 PM, Tim Kryger wrote: >> On Thu, Jun 19, 2014 at 1:49 AM, Sachin Kamat wrote: >>> +cc Some relevant guys from Samsung >>> >>> On Thu, Jun 19, 2014 at 2:12 PM, Tim Kryger wrote: On Wed, Jun 18, 2014 at 8:54 PM, Sachin

[PATCH v2] arm: exynos: Support cluster power off on exynos5420/5800

2014-06-19 Thread Abhilash Kesavan
polling the cluster power status register. Signed-off-by: Abhilash Kesavan Acked-by: Nicolas Pitre --- Change in v2: Added a macro for the COMMON_OPTION register and used it in the MCPM back-end. The patch is based on Linux-next 20140619. It has been tested on an exynos5420-based chromebook using the

Re: [PATCH 3/4] ARM: dts: exynos4412-odroidx: add support for USB (phy, host, device)

2014-06-19 Thread Daniel Drake
On Tue, Jun 17, 2014 at 10:25 AM, Marek Szyprowski wrote: > From: Kamil Debski > > This patch adds basic support for USB modules (host and device) on > OdroidX board. > > Signed-off-by: Kamil Debski > Signed-off-by: Marek Szyprowski Checked that this conforms to the documented DT bindings. Re

Re: [PATCH] arm: exynos: Support cluster power off on exynos5420/5800

2014-06-19 Thread Abhilash Kesavan
Hi Nicolas, On Wed, Jun 18, 2014 at 9:10 PM, Nicolas Pitre wrote: > On Wed, 18 Jun 2014, Abhilash Kesavan wrote: > >> Turning off a cluster when all 4 cores of the cluster are powered off >> saves power significantly. Powering off the A15 L2 alone gives around >> 100mW in savings. Add support for

Re: [PATCH 2/4] ARM: dts: exynos4412-odroidx: enable common hardware blocks

2014-06-19 Thread Daniel Drake
On Tue, Jun 17, 2014 at 10:25 AM, Marek Szyprowski wrote: > This patch adds support for common hardware modules available on all > Exynos4412-based Odroid boards, which already have complete support in > mainline kernel. This includes secure firmware calls, watchdog, g2d and > fimc (mem2mem) multi

Re: [PATCH 1/4] ARM: dts: exynos4: add port sub-nodes to exynos usb host modules

2014-06-19 Thread Daniel Drake
On Tue, Jun 17, 2014 at 10:25 AM, Marek Szyprowski wrote: > This patch adds port sub-nodes to exynos4 ehci and ohci modules, which > are required by recently merged new exynos4 usb2 phy support. > > Signed-off-by: Marek Szyprowski I checked this against the DT binding documentation for the samsu

Re: [PATCH v2] clocksource: exynos-mct: Register the timer for stable udelay

2014-06-19 Thread amit daniel kachhap
On Thu, Jun 19, 2014 at 4:00 PM, Daniel Lezcano wrote: > On 06/19/2014 12:21 PM, amit daniel kachhap wrote: >> >> On Thu, Jun 19, 2014 at 2:41 PM, Daniel Lezcano >> wrote: >>> >>> On 06/19/2014 10:39 AM, Amit Daniel Kachhap wrote: This patch register the exynos mct clocksource as t

Re: MMC error on Exynos4210 board

2014-06-19 Thread Sachin Kamat
On Thu, Jun 19, 2014 at 2:40 PM, Tim Kryger wrote: > On Thu, Jun 19, 2014 at 1:49 AM, Sachin Kamat wrote: >> +cc Some relevant guys from Samsung >> >> On Thu, Jun 19, 2014 at 2:12 PM, Tim Kryger wrote: >>> On Wed, Jun 18, 2014 at 8:54 PM, Sachin Kamat wrote: >>> > On Wed, Jun 18, 2014 at 4:

Re: [PATCH v2] clocksource: exynos-mct: Register the timer for stable udelay

2014-06-19 Thread Daniel Lezcano
On 06/19/2014 12:21 PM, amit daniel kachhap wrote: On Thu, Jun 19, 2014 at 2:41 PM, Daniel Lezcano wrote: On 06/19/2014 10:39 AM, Amit Daniel Kachhap wrote: This patch register the exynos mct clocksource as the current timer as it has constant clock rate. This will generate correct udelay for

Re: [PATCH v2] clocksource: exynos-mct: Register the timer for stable udelay

2014-06-19 Thread Arnd Bergmann
On Thursday 19 June 2014 15:51:58 amit daniel kachhap wrote: > I also didn't want to use macros but used as a last option. you want > me to put more comments here? > Or something like below is also possible for checking the size of > (unsigned long) in runtime. > > unsigned long x; > unsigned int

Re: [PATCH v2] clocksource: exynos-mct: Register the timer for stable udelay

2014-06-19 Thread Tomasz Figa
Hi Amit, Please see my comments inline. On 19.06.2014 10:39, Amit Daniel Kachhap wrote: > This patch register the exynos mct clocksource as the current timer > as it has constant clock rate. This will generate correct udelay for the > exynos platform and avoid using unnecessary calibrated jiffies

Re: [PATCH v2] clocksource: exynos-mct: Register the timer for stable udelay

2014-06-19 Thread amit daniel kachhap
On Thu, Jun 19, 2014 at 2:41 PM, Daniel Lezcano wrote: > On 06/19/2014 10:39 AM, Amit Daniel Kachhap wrote: >> >> This patch register the exynos mct clocksource as the current timer >> as it has constant clock rate. This will generate correct udelay for the >> exynos platform and avoid using unnec

Re: [PATCH v2] clocksource: exynos-mct: Register the timer for stable udelay

2014-06-19 Thread Daniel Lezcano
On 06/19/2014 10:39 AM, Amit Daniel Kachhap wrote: This patch register the exynos mct clocksource as the current timer as it has constant clock rate. This will generate correct udelay for the exynos platform and avoid using unnecessary calibrated jiffies. This change has been tested on exynos5420

Re: MMC error on Exynos4210 board

2014-06-19 Thread Tim Kryger
On Thu, Jun 19, 2014 at 1:49 AM, Sachin Kamat wrote: > +cc Some relevant guys from Samsung > > On Thu, Jun 19, 2014 at 2:12 PM, Tim Kryger wrote: >> On Wed, Jun 18, 2014 at 8:54 PM, Sachin Kamat wrote: >> On Wed, Jun 18, 2014 at 4:33 AM, Sachin Kamat wrote: >> > I see the below error o

Re: [PATCH] clocksource: exynos-mct: Register the timer for stable udelay

2014-06-19 Thread Daniel Lezcano
On 06/19/2014 01:17 AM, Doug Anderson wrote: Amit, Thanks for posting! On Wed, Jun 18, 2014 at 4:31 AM, Amit Daniel Kachhap wrote: This patch register the exynos mct clocksource as the current timer as it has constant clock rate. This will generate correct udelay for the exynos platform and a

Re: MMC error on Exynos4210 board

2014-06-19 Thread Sachin Kamat
+cc Some relevant guys from Samsung On Thu, Jun 19, 2014 at 2:12 PM, Tim Kryger wrote: > On Wed, Jun 18, 2014 at 8:54 PM, Sachin Kamat wrote: > >>> On Wed, Jun 18, 2014 at 4:33 AM, Sachin Kamat wrote: > I see the below error on Exynos4210 based Origen board with linux-next (20140618).

Re: MMC error on Exynos4210 board

2014-06-19 Thread Tim Kryger
On Wed, Jun 18, 2014 at 8:54 PM, Sachin Kamat wrote: >> On Wed, Jun 18, 2014 at 4:33 AM, Sachin Kamat wrote: >>> I see the below error on Exynos4210 based Origen board with linux-next >>> (20140618). >>> Reverting the below commit works fine. >>> >>> Commit: 8d02e775a6 "mmc: sdhci: Use mmc core

[PATCH v2] clocksource: exynos-mct: Register the timer for stable udelay

2014-06-19 Thread Amit Daniel Kachhap
This patch register the exynos mct clocksource as the current timer as it has constant clock rate. This will generate correct udelay for the exynos platform and avoid using unnecessary calibrated jiffies. This change has been tested on exynos5420 based board and udelay is very close to expected. S

Re: [PATCH] clocksource: exynos-mct: Register the timer for stable udelay

2014-06-19 Thread amit daniel kachhap
On Thu, Jun 19, 2014 at 4:47 AM, Doug Anderson wrote: > Amit, > > Thanks for posting! > > On Wed, Jun 18, 2014 at 4:31 AM, Amit Daniel Kachhap > wrote: >> This patch register the exynos mct clocksource as the current timer >> as it has constant clock rate. This will generate correct udelay for th