Re: [BUG] blocked task after exynos_drm_init

2014-11-18 Thread Grant Likely
On Tue, Nov 18, 2014 at 12:29 PM, Javier Martinez Canillas wrote: > [adding Kevin to cc list] > > Hello Inki, > > On Tue, Nov 18, 2014 at 11:52 AM, Inki Dae wrote: >> On 2014년 11월 18일 19:42, Andrzej Hajda wrote: >>> On 11/06/2014 10:06 AM, Krzysztof Kozlowski wrote: Hi, On last nex

Re: 3.17-rc6 on ODROID: ERROR: Bad of_node_put() on /ehci@12580000/port@1

2014-10-01 Thread Grant Likely
On Wed, Oct 1, 2014 at 4:12 PM, Daniel Drake wrote: > On Wed, Oct 1, 2014 at 12:36 AM, Vivek Gautam > wrote: >> One reason i doubt why it could be coming is because we are >> specifically putting the >> child after doing everything with it. >> >> When we are getting the child node using for_each

Re: Unable to boot mainline on snow chromebook since 3.15

2014-09-29 Thread Grant Likely
On Mon, Sep 29, 2014 at 1:57 PM, Thierry Reding wrote: > On Wed, Sep 10, 2014 at 03:56:16PM +0100, Grant Likely wrote: >> On Wed, Sep 10, 2014 at 3:31 PM, Mark Brown wrote: >> > On Wed, Sep 10, 2014 at 06:06:46AM -0700, Olof Johansson wrote: >> >> On Mon, Sep 8,

Re: Unable to boot mainline on snow chromebook since 3.15

2014-09-11 Thread Grant Likely
On Wed, 10 Sep 2014 17:57:23 +0100, Mark Brown wrote: > On Wed, Sep 10, 2014 at 05:29:32PM +0100, Grant Likely wrote: > > > What we can do is have an inhibit flag for > > simplefb/simpleuart/simplewhatever that holds off PM. When a real > > driver, or a stub that understa

Re: Unable to boot mainline on snow chromebook since 3.15

2014-09-11 Thread Grant Likely
On Wed, 10 Sep 2014 15:31:44 +0100, Mark Brown wrote: > On Wed, Sep 10, 2014 at 06:06:46AM -0700, Olof Johansson wrote: > > On Mon, Sep 8, 2014 at 12:40 PM, Grant Likely > > wrote: > > > > Well, lets see... We've got a real user complaining about a platform >

Re: Unable to boot mainline on snow chromebook since 3.15

2014-09-10 Thread Grant Likely
On Wed, Sep 10, 2014 at 4:39 PM, Mark Brown wrote: > On Wed, Sep 10, 2014 at 03:56:16PM +0100, Grant Likely wrote: >> On Wed, Sep 10, 2014 at 3:31 PM, Mark Brown wrote: > >> > As far as I can tell the problem here is coming from the decision to >> > have simplefb

Re: Unable to boot mainline on snow chromebook since 3.15

2014-09-10 Thread Grant Likely
On Wed, Sep 10, 2014 at 3:31 PM, Mark Brown wrote: > On Wed, Sep 10, 2014 at 06:06:46AM -0700, Olof Johansson wrote: >> On Mon, Sep 8, 2014 at 12:40 PM, Grant Likely >> wrote: > >> > Well, lets see... We've got a real user complaining about a platform >> &

Re: Unable to boot mainline on snow chromebook since 3.15

2014-09-08 Thread Grant Likely
On Mon, Sep 8, 2014 at 4:58 PM, Doug Anderson wrote: > Grant, > > On Mon, Sep 8, 2014 at 5:20 AM, Grant Likely > wrote: >> On Mon, Sep 8, 2014 at 12:21 PM, Will Deacon wrote: >>> On Sun, Sep 07, 2014 at 05:19:03PM +0100, Tomasz Figa wrote: >>>> At least f

Re: Unable to boot mainline on snow chromebook since 3.15

2014-09-08 Thread Grant Likely
On Mon, Sep 8, 2014 at 12:21 PM, Will Deacon wrote: > On Sun, Sep 07, 2014 at 05:19:03PM +0100, Tomasz Figa wrote: >> At least for next 3.17-rc I'd suggest fixing this up in respective clock >> driver and dropping the hack only after Exynos DRM patches are merged >> and confirmed working. > > Whil

Re: [RESEND][PATCHv2 0/3] Fix for buggy u-boot memory banks

2014-07-29 Thread Grant Likely
On Mon, 28 Jul 2014 11:56:42 -0700, Laura Abbott wrote: > On 7/26/2014 2:20 PM, Rob Herring wrote: > > On Tue, Jul 15, 2014 at 12:03 PM, Laura Abbott > > wrote: > >> Hi, > >> > >> This is a resend of the series to fix the uboot bug exposed by the removal > >> of meminfo. I haven't gotten any ack

Re: [PATCH 2/2] arm: Add back maximum bank limit

2014-07-01 Thread Grant Likely
On Mon, Jun 30, 2014 at 7:03 PM, Laura Abbott wrote: > On 6/30/2014 3:43 AM, Grant Likely wrote: >> >> Instead of splitting early_init_dt_scan(), the call to >> early_init_dt_scan() could probably be moved after the >> of_flat_dt_match_machine() call. It's at leas

Re: [PATCH 2/2] arm: Add back maximum bank limit

2014-06-30 Thread Grant Likely
On Sun, 29 Jun 2014 12:06:24 -0700, Laura Abbott wrote: > Commit 1c2f87c22566cd057bc8cde10c37ae9da1a1bb76 > (ARM: 8025/1: Get rid of meminfo) dropped the upper bound on > the number of memory banks that can be added as there was no > technical need in the kernel. It turns out though, some bootload

Re: [PATCH 51/97] ARM: l2c: remove platforms/SoCs setting early BRESP

2014-05-01 Thread Grant Likely
On Tue, 29 Apr 2014 01:21:41 +0100, Russell King - ARM Linux wrote: > On Tue, Apr 29, 2014 at 09:02:27AM +0900, Simon Horman wrote: > > On Mon, Apr 28, 2014 at 08:30:32PM +0100, Russell King wrote: > > > Since we now automatically enable early BRESP in core L2C-310 code when > > > we detect a Cor

Re: [PATCH 1/2] ARM: DT: fix gic interrupt controller documentation

2014-03-14 Thread Grant Likely
On Thu, Mar 13, 2014 at 6:25 PM, Jason Gunthorpe wrote: > On Thu, Mar 13, 2014 at 11:44:33AM -0600, Stephen Warren wrote: >> On 03/13/2014 11:40 AM, Tim Harvey wrote: >> > When using interrupt-maps, the size of a map entry is #address-cells + >> > #interrupt-cells for the parent interrupt control

Re: [PATCH v4 0/4] Bugfix for of_match_node ordering

2014-02-20 Thread Grant Likely
On Thu, 20 Feb 2014 18:12:40 +0800, Kevin Hao wrote: > On Thu, Feb 20, 2014 at 02:09:08PM +0530, Sachin Kamat wrote: > > Hi Grant, > > > > I observe the following boot failure with today's (next-20140220) linux-next > > tree on Exynos based boards with the default exynos_defconfig. > > Does this

Re: [PATCH v4 0/4] Bugfix for of_match_node ordering

2014-02-20 Thread Grant Likely
] [] (of_find_compatible_node) from > [] (exynos_firmware_init+0x18/0x7c) > [ 0.000000] [] (exynos_firmware_init) from [] > (setup_arch+0x860/0x898) > [0.00] [] (setup_arch) from [] > (start_kernel+0x80/0x3dc) > [0.00] [] (start_kernel) f

Re: [PATCH 22/51] DMA-API: amba: get rid of separate dma_mask

2013-09-22 Thread Grant Likely
On Thu, 19 Sep 2013 22:47:01 +0100, Russell King wrote: > AMBA Primecell devices always treat streaming and coherent DMA exactly > the same, so there's no point in having the masks separated. > > Signed-off-by: Russell King for the drivers/of/platform.c portion: Acked-by:

Re: [PATCH V3] i2c: move of helpers into the core

2013-08-28 Thread Grant Likely
gister child nodes in the core instead of doing this manually > in each driver. So, fix the drivers and documentation, too. > > Acked-by: Rob Herring > Reviewed-by: Felipe Balbi > Acked-by: Rafael J. Wysocki > Tested-by: Sylwester Nawrocki > Signed-off-by: Wolf

Re: [PATCH] of: provide of_platform_unpopulate()

2013-07-24 Thread Grant Likely
On Mon, 22 Jul 2013 16:16:07 -0500, Rob Herring wrote: > On 07/21/2013 06:44 PM, Grant Likely wrote: > > On Sun, Jul 21, 2013 at 9:48 PM, Rob Herring wrote: > >> On 07/21/2013 09:42 AM, Rob Herring wrote: > >>> On 07/19/2013 01:14 PM, Sebastian Andrzej Sie

Re: [PATCH] of: provide of_platform_unpopulate()

2013-07-21 Thread Grant Likely
On Sun, Jul 21, 2013 at 9:48 PM, Rob Herring wrote: > On 07/21/2013 09:42 AM, Rob Herring wrote: >> On 07/19/2013 01:14 PM, Sebastian Andrzej Siewior wrote: >>> So I called of_platform_populate() on a device to get each child device >>> probed and on rmmod and I need to reverse its doing. After a

Re: [PATCH 9/9] ARM/dts: update device tree binding documentation for hdmi susbsystem

2013-06-11 Thread Grant Likely
region. > - interrupts: interrupt number to the cpu. > +- clocks: list of clock IDs from SoC clock driver. > + a) mixer: It is required for gate operation on aclk_200_disp1 clock > + which clocks the display1 block. > + b) sclk_hdmi: Parent for mux mout_mixer. &g

Re: [PATCH v7 3/3] of/pci: mips: convert to common of_pci_range_parser

2013-04-18 Thread Grant Likely
you very much for doing the legwork to merge the common code. Reviewed-by: Grant Likely -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v7 2/3] of/pci: Provide support for parsing PCI DT ranges property

2013-04-18 Thread Grant Likely
: Liviu Dudau > Signed-off-by: Thomas Petazzoni > Reviewed-by: Rob Herring > Tested-by: Thomas Petazzoni > Tested-by: Linus Walleij Acked-by: Grant Likely But comments below... > --- > drivers/of/address.c | 67 ++ > drivers/of/of

Re: [REPOST PATCH] spi: s3c64xx: let device core setup the default pin configuration

2013-04-16 Thread Grant Likely
On Mon, 15 Apr 2013 20:42:57 -0700, Doug Anderson wrote: > From: Thomas Abraham > > With device core now able to setup the default pin configuration, > the pin configuration code based on the deprecated Samsung specific > gpio bindings is removed. > > Signed-off-by: Thomas Abraham > Signed-off

Re: [PATCH] ARM: dts: moving dt binding documents for video devices to common place

2013-03-03 Thread Grant Likely
On Wed, 06 Feb 2013 09:51:39 -0500, Rahul Sharma wrote: > Binding Documents for drm-devices are placed in > Documentation/devicetree/bindings/drm/*. But these devices are common > for v4l framework, hence moved to a common place at > Documentation/devicetree/bindings/video/. 'exynos_' prefix is a

Re: [PATCH v2 3/4] spi: s3c64xx: add dma maxburst size initialization

2013-03-03 Thread Grant Likely
On Fri, 22 Feb 2013 17:09:18 +0900, Boojin Kim wrote: > This patch adds dma maxburst size initialization. > The maxburst should be set by MODE_CFGn.DMA_TYPE, > because the pl330 dma driver supports burst mode. > > Signed-off-by: Hyeonkook Kim Applied, thanks. g. -- To unsubscribe from this li

Re: [PATCH v2 3/4] spi: s3c64xx: add dma maxburst size initialization

2013-03-03 Thread Grant Likely
irection = sdd->tx_dma.direction; > config.fifo = sdd->sfr_start + S3C64XX_SPI_TX_DATA; > config.width = sdd->cur_bpw / 8; > -- > 1.7.5.4 > > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in &g

Re: [PATCH v3 1/2] ARM: Exynos5250: Enabling ehci-s5p driver

2013-02-08 Thread Grant Likely
"samsung-i2s.2", NULL), > >>>> + OF_DEV_AUXDATA("samsung,exynos4210-ehci", EXYNOS5_PA_EHCI, > >>>> + "s5p-ehci", NULL), > >>> > >>> I'm assuming the above change is temporary. What is l

Re: [PATCH v4] i2c: exynos5: add High Speed I2C controller driver

2013-02-08 Thread Grant Likely
On Fri, 01 Feb 2013 21:24:44 +0530, Naveen Krishna Chatradhi wrote: > Adds support for High Speed I2C driver found in Exynos5 and later > SoCs from Samsung. This driver currently supports Auto mode. > > Driver only supports Device Tree method. > Note: Added debugfs support for registers view, no

Re: [PATCH V2] spi: remove check for bits_per_word on transfer from low level driver

2012-12-22 Thread Grant Likely
On Thu, 20 Dec 2012 11:33:47 +0530, Laxman Dewangan wrote: > On Wednesday 19 December 2012 09:54 PM, Grant Likely wrote: > > On Tue, 18 Dec 2012 14:25:43 +0530, Laxman Dewangan > > wrote: > >> The spi core make sure that each transfer structure have the proper > &

Re: [PATCH 1/2] i2c-core: Add gpio based bus arbitration implementation

2012-12-19 Thread Grant Likely
On Thu, Dec 20, 2012 at 12:17 AM, Simon Glass wrote: > On Wed, Dec 19, 2012 at 9:14 AM, Mark Brown > wrote: >> On Wed, Dec 19, 2012 at 12:32:01PM +, Grant Likely wrote: >> >>> I'm not convinced on the design of this protocol. It won't scale beyond >>

Re: [PATCH 1/2] i2c-core: Add gpio based bus arbitration implementation

2012-12-19 Thread Grant Likely
On Wed, Dec 19, 2012 at 5:14 PM, Mark Brown wrote: > On Wed, Dec 19, 2012 at 12:32:01PM +0000, Grant Likely wrote: > >> I'm not convinced on the design of this protocol. It won't scale beyond >> 2 bus masters and it seems very specific to the design of a specific &

Re: [PATCH] gpio: samsung: remove exynos_gpio_cfg

2012-12-19 Thread Grant Likely
On Fri, 14 Dec 2012 19:44:01 +0900, Joonyoung Shim wrote: > The exynos_gpio_cfg can be substituted to samsung_gpio_cfgs[8]. > > Signed-off-by: Joonyoung Shim Hi Joonyoung, I need some help here. I don't understand what this patch is for or how it works. The commit text above doesn't give me e

Re: [PATCH V2] spi: remove check for bits_per_word on transfer from low level driver

2012-12-19 Thread Grant Likely
On Tue, 18 Dec 2012 14:25:43 +0530, Laxman Dewangan wrote: > The spi core make sure that each transfer structure have the proper > setting for bits_per_word before calling low level transfer APIs. > > Hence it is no more require to check again in low level driver for > this field whether this is

Re: [PATCH V5 2/2] ASoC: SAMSUNG: Add DT support for i2s

2012-12-19 Thread Grant Likely
On Thu, 13 Dec 2012 16:12:53 +0530, Padmavathi Venna wrote: > Add support for device based discovery. > > Signed-off-by: Padmavathi Venna > --- > .../devicetree/bindings/sound/samsung-i2s.txt | 75 +++ > sound/soc/samsung/dma.c|1 + > sound/soc/samsun

Re: [PATCH 1/2] i2c-core: Add gpio based bus arbitration implementation

2012-12-19 Thread Grant Likely
On Fri, 14 Dec 2012 11:20:53 +0530, Naveen Krishna Chatradhi wrote: > The arbitrator is a general purpose function which uses two GPIOs to > communicate with another device to claim/release a bus. > > i2c_transfer() > if adapter->gpio_arbit > i2c_bus_claim(); >

Re: [PATCH v3 1/2] ARM: Exynos5250: Enabling ehci-s5p driver

2012-12-16 Thread Grant Likely
x 462e5ac..b3b9af1 100644 > --- a/arch/arm/mach-exynos/mach-exynos5-dt.c > +++ b/arch/arm/mach-exynos/mach-exynos5-dt.c > @@ -110,6 +110,8 @@ static const struct of_dev_auxdata > exynos5250_auxdata_lookup[] __initconst = { > "samsung-i2s.1", NULL), >

Re: [PATCH 0/2] usb: exynos: Fix compatible strings used for device

2012-12-16 Thread Grant Likely
ix compatible strings for the device for both patches: Acked-by: Grant Likely > > drivers/usb/dwc3/dwc3-exynos.c |2 +- > drivers/usb/host/ehci-s5p.c|2 +- > drivers/usb/host/ohci-exynos.c |2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > -- &

Re: [PATCH RFC 01/12] s5p-csis: Add device tree support

2012-12-11 Thread Grant Likely
On Tue, 11 Dec 2012 12:24:23 +0100, Sylwester Nawrocki wrote: > Hello Grant, > > On 12/11/2012 09:36 AM, Grant Likely wrote: > > On Mon, 10 Dec 2012 20:45:55 +0100, Sylwester Nawrocki > > wrote: > >> s5p-csis is platform device driver for MIPI-CSI frontend

Re: [PATCH RFC 01/12] s5p-csis: Add device tree support

2012-12-11 Thread Grant Likely
On Mon, 10 Dec 2012 20:45:55 +0100, Sylwester Nawrocki wrote: > s5p-csis is platform device driver for MIPI-CSI frontend to the FIMC > (camera host interface DMA engine and image processor). This patch > adds support for instantiating the MIPI-CSIS devices from DT and > parsing all SoC and board

Re: [PATCH V4 0/2] Add DT support for i2s

2012-12-07 Thread Grant Likely
On Thu, 6 Dec 2012 13:11:42 +0900, Mark Brown wrote: > On Thu, Dec 06, 2012 at 09:31:40AM +0530, Padma Venkat wrote: > > On Wed, Nov 28, 2012 at 4:17 PM, Padmavathi Venna > > wrote: > > > > Padmavathi Venna (2): > > > ASoC: Samsung: Get I2S src_clk from clock alias id. > > > ASoC: SAMSUNG:

Re: [PATCH v2 1/2] ARM: Exynos5250: Enabling ehci-s5p driver

2012-12-06 Thread Grant Likely
On Thu, 08 Nov 2012 12:24:24 +0530, Vivek Gautam wrote: > Adding EHCI device tree node for Exynos5250 along with > the device base adress and gpio line for vbus. > > Signed-off-by: Vivek Gautam > Acked-by: Jingoo Han > --- > .../devicetree/bindings/usb/exynos-usb.txt | 25 > +++

Re: [PATCH v2] ARM: Exynos5250: Enabling dwc3-exynos driver

2012-12-06 Thread Grant Likely
m/mach-exynos/mach-exynos5-dt.c > index c03f3dd..303 100644 > --- a/arch/arm/mach-exynos/mach-exynos5-dt.c > +++ b/arch/arm/mach-exynos/mach-exynos5-dt.c > @@ -90,6 +90,8 @@ static const struct of_dev_auxdata > exynos5250_auxdata_lookup[] __initconst = { > "s5p-ehci", NULL), > OF_DEV_

Re: [PATCH 3/3] gpio: exynos4: skip gpiolib registration if pinctrl driver is used

2012-05-26 Thread Grant Likely
On Thu, 24 May 2012 05:17:37 +0530, Thomas Abraham wrote: > Pinctrl driver, when enabled, registers all the gpio pins and hence the > registration of gpio pins by this driver can be skipped. > > Signed-off-by: Thomas Abraham Acked-by: Grant Likely > --- > drivers/gpio/gpi

Re: [PATCH] spi: Keep chipselect assertion during one message

2012-05-26 Thread Grant Likely
else > - disable_cs(sdd, spi); > } > > msg->actual_length += xfer->len; > -- > 1.7.1 > > -- Grant Likely, B.Sc, P.Eng. Secret Lab Technologies, Ltd. -- To unsubscribe from this list: send the line "unsub

Re: [PATCH] spi: Change FIFO flush operation and spi channel off

2012-05-26 Thread Grant Likely
64XX_SPI_CH_RXCH_ON | S3C64XX_SPI_CH_TXCH_ON); > - writel(val, regs + S3C64XX_SPI_CH_CFG); > } > > static void s3c64xx_spi_dmacb(void *data) > -- > 1.7.1 > > -- Grant Likely, B.Sc, P.Eng. Secret Lab Technologies, Ltd. -- To unsubscribe from this list: send the line

Re: [PATCH v2 6/6] spi: s3c64xx: add device tree support

2012-05-19 Thread Grant Likely
On Fri, 18 May 2012 15:03:33 +0530, Thomas Abraham wrote: > Add support for device based discovery. > > Signed-off-by: Thomas Abraham > Acked-by: Jaswinder Singh Acked-by: Grant Likely ... but one nitpick below... > +#ifdef CONFIG_OF > +static const s

Re: [PATCH v2 5/6] spi: s3c64xx: Remove the 'set_level' callback from controller data

2012-05-19 Thread Grant Likely
as the slave select line, this callback can be removed from the > controller data and replaced with call to gpio_set_value in the driver. > > Signed-off-by: Thomas Abraham > Acked-by: Jaswinder Singh Acked-by: Grant Likely > --- > arch/arm/plat-samsung/include/plat/s3c64xx-

Re: [PATCH v2 2/6] spi: s3c64xx: move controller information into driver data

2012-05-19 Thread Grant Likely
t; it can be moved into the driver data and removed from platform data. > > Signed-off-by: Thomas Abraham > Acked-by: Jaswinder Singh Acked-by: Grant Likely > --- > arch/arm/mach-exynos/clock-exynos4.c | 18 +- > arch/arm/mach-exynos/setup-spi.c

Re: [PATCH v2 1/6] spi: s3c64xx: remove unused S3C64XX_SPI_ST_TRLCNTZ macro

2012-05-19 Thread Grant Likely
On Fri, 18 May 2012 15:03:28 +0530, Thomas Abraham wrote: > The macro S3C64XX_SPI_ST_TRLCNTZ is not used and hence it is removed. > > Signed-off-by: Thomas Abraham > Acked-by: Jaswinder Singh Acked-by: Grant Likely > --- > drivers/spi/spi-s3c64xx.c |4 >

Re: [PATCH v2 0/6] spi: s3c64xx: add support for device tree

2012-05-19 Thread Grant Likely
t/s3c64xx-spi.h | 31 +- > drivers/spi/spi-s3c64xx.c | 467 > +++++--- > 20 files changed, 611 insertions(+), 300 deletions(-) > create mode 100644 Documentation/devicetree/bindings/spi/spi-samsung.txt > -- Grant Likely, B.Sc, P.Eng. Secre

Re: [PATCH 07/10] spi: s3c64xx: Remove the 'set_level' callback from controller data

2012-05-19 Thread Grant Likely
as the slave select line, this callback can be removed from the > controller data and replaced with call to gpio_set_value in the driver. > > Cc: Jaswinder Singh > Signed-off-by: Thomas Abraham Acked-by: Grant Likely > --- > arch/arm/plat-samsung/include/plat/s3c64xx-spi.

Re: [PATCH 05/10] ARM: Samsung: Update the device names for spi clock lookup

2012-05-19 Thread Grant Likely
> > I'd not say the diff is *that* big (and most of what's there is simple > and repetitive), and bisection is a very useful tool. I know I > frequently find it enormously painful trying to figure out breakage when > large chunks of the history don't work usefully. I

Re: [PATCH 02/10] spi: s3c64xx: move controller information into driver data

2012-05-19 Thread Grant Likely
t; it can be moved into the driver data and removed from platform data. > > Cc: Jaswinder Singh > Signed-off-by: Thomas Abraham Acked-by: Grant Likely > --- > drivers/spi/spi-s3c64xx.c | 180 > ++--- > 1 files changed, 153 inserti

Re: [PATCH 01/10] spi: s3c64xx: remove unused S3C64XX_SPI_ST_TRLCNTZ macro

2012-05-19 Thread Grant Likely
On Wed, 09 May 2012 03:34:45 +0530, Thomas Abraham wrote: > The macro S3C64XX_SPI_ST_TRLCNTZ is not used and hence it is removed. > > Cc: Jaswinder Singh > Signed-off-by: Thomas Abraham Acked-by: Grant Likely Since this series has dependencies, I'm fine with it going via

Re: [PATCH 19/20] ARM: Exynos5: Add combiner, wakeup interrupt controller and ethernet nodes

2012-05-18 Thread Grant Likely
On Wed, 2 May 2012 10:57:11 -0700, Olof Johansson wrote: > Hi, > > [adding devicetree-discuss] > > On Mon, Apr 30, 2012 at 12:14 PM, Thomas Abraham > wrote: > > And interrupt combiner, external interrupt wakeup interrupt controller > > and smsc9215 lan controller nodes. > > > > Signed-off-by: T

Re: [PATCH 10/20] of/irq: fix interrupt parent lookup procedure

2012-05-15 Thread Grant Likely
On Tue, May 15, 2012 at 12:41 PM, Grant Likely wrote: > On Tue, 15 May 2012 17:29:14 +0900, Kukjin Kim wrote: >> Thomas Abraham wrote: >> > >> > The interrupt parent lookup fails for a node that is a interrupt-controller >> > but does not have an explict i

RE: [PATCH 10/20] of/irq: fix interrupt parent lookup procedure

2012-05-15 Thread Grant Likely
} > > of_node_put(child); > > child = p; > > - } while (p && of_get_property(p, "#interrupt-cells", NULL) == NULL); > > + } while (p); This does break one use-case. Sometimes the interrupt-parent is the same node whe

Re: [PATCH 17/20] ARM: Exynos: Add device tree support for gpio wakeup interrupt controller

2012-05-15 Thread Grant Likely
On Mon, 30 Apr 2012 12:14:27 -0700, Thomas Abraham wrote: > Add device tree support for gpio wakeup source interrupt controller > for Exynos platforms. > > Cc: Rob Herring > Cc: Grant Likely > Signed-off-by: Thomas Abraham > --- > arch/arm/mac

Re: [PATCH 15/20] ARM: Exynos: Add irq_domain support for gpio wakeup interrupts

2012-05-15 Thread Grant Likely
uired to use irq domain based interrupt mapping is also included. > > Cc: Grant Likely > Signed-off-by: Thomas Abraham > Acked-by: Rob Herring Acked-by: Grant Likely > --- > arch/arm/mach-exynos/common.c | 67 > + > arch/arm/

Re: [PATCH 06/20] ARM: EXYNOS: add GPC4 bank instance

2012-05-15 Thread Grant Likely
On Mon, 30 Apr 2012 12:14:16 -0700, Thomas Abraham wrote: > From: Sangsu Park > > Add GPC4 bank instance which is included in rev1 of EXYNOS5. > > Cc: Grant Likely > Signed-off-by: Sangsu Park > Signed-off-by: Thomas Abraham > [kgene@samsung.com: re-worked on t

Re: [PATCH v2] of/irq: add empty irq_of_parse_and_map() for non-dt builds

2012-04-07 Thread Grant Likely
claration is made available only if CONFIG_OF_IRQ is defined, > which is the same config option that makes the irq_of_parse_and_map() > function definition available. While at it, fix a typo as well. > > Suggested-by: Grant Likely > Signed-off-by: Thomas Abraham > Acked-by: Rob Her

Re: [PATCH v4 1/2] mfd: add irq domain support for max8997 interrupts

2012-03-30 Thread Grant Likely
; number for max8997 interrupts. All uses of irq_base in platform data and > max8997 driver private data are removed. > > Cc: MyungJoo Ham > Signed-off-by: Thomas Abraham > Acked-by: Grant Likely > --- > arch/arm/mach-exynos/mach-nuri.c|4 -- > arch/a

Re: [PATCH v4 2/2] regulator: add device tree support for max8997

2012-03-30 Thread Grant Likely
On Sat, 24 Mar 2012 15:19:50 +0530, Thomas Abraham wrote: > Add device tree based discovery support for max8997. > > Cc: MyungJoo Ham > Cc: Rajendra Nayak > Cc: Rob Herring > Cc: Grant Likely > Signed-off-by: Thomas Abraham > --- > .../devicetree/bindings/regula

Re: Device node for a controller with two interrupt parents

2012-03-24 Thread Grant Likely
On Fri, 23 Mar 2012 16:18:09 +0530, Thomas Abraham wrote: > Hi Grant, > > On 21 March 2012 20:43, Grant Likely wrote: > > Okay, so you're saying there are three important aspects to this > > device: > > 1) it terminates interrupts from other devices (the

Re: Device node for a controller with two interrupt parents

2012-03-22 Thread Grant Likely
t;0xe>, <0xf>, ><0x10>; >#address-cells = <0>; >#size-cells = <0>; > interrupt-map = <0x0 &gic 0 16 0>, ><0x1 &gic 0 17 0>, ><0x2 &gic 0 18

Re: [PATCH 1/3] i2c-s3c2410: Drop unused define

2012-03-18 Thread Grant Likely
On Tue, 13 Mar 2012 17:54:37 +0100, Karol Lewandowski wrote: > Use standard of_match_ptr() to avoid defining variable unused > in non device tree builds. > > Signed-off-by: Karol Lewandowski > Signed-off-by: Kyungmin Park Acked-by: Grant Likely > --- > drivers/i2c

Re: [PATCH] spi: s3c64xx: Fix build

2012-03-15 Thread Grant Likely
A_DEV_TO_MEM) { > + if (dma->direction == DMA_DEV_TO_MEM) > sdd = container_of((void *)dma, > struct s3c64xx_spi_driver_data, rx_dma); > else > -- > 1.7.9.1 > -- Grant Likely, B.Sc, P.Eng. Secret Lab Technologies,Ltd. -- To unsu

Re: [PATCH v3 2/2] regulator: add device tree support for max8997

2012-03-13 Thread Grant Likely
On Tue, 13 Mar 2012 12:14:42 +0530, Thomas Abraham wrote: > On 13 March 2012 09:13, Grant Likely wrote: > > On Thu, 23 Feb 2012 18:08:08 +0530, Thomas Abraham > > wrote: > > Otherwise, the patch looks pretty good.  (although seeing the decode > > function >

Re: [PATCH v4 2/2] ARM: Exynos: Add device tree support for interrupt combiner

2012-03-12 Thread Grant Likely
On Tue, 21 Feb 2012 10:03:26 +0530, Thomas Abraham wrote: > Add device tree based instantiation of the interrupt combiner controller. > > Cc: Grant Likely > Cc: Rob Herring > Signed-off-by: Thomas Abraham > --- > @@ -406,13 +432,33 @@ void __init combiner_init(void _

Re: [PATCH v3 2/2] regulator: add device tree support for max8997

2012-03-12 Thread Grant Likely
On Thu, 23 Feb 2012 18:08:08 +0530, Thomas Abraham wrote: > Add device tree based discovery support for max8997. > > Cc: MyungJoo Ham > Cc: Rajendra Nayak > Cc: Rob Herring > Cc: Grant Likely > Signed-off-by: Thomas Abraham > --- > .../devicetree/bindings/regula

Re: [PATCH v3 1/2] mfd: add irq domain support for max8997 interrupts

2012-03-12 Thread Grant Likely
; number for max8997 interrupts. All uses of irq_base in platform data and > max8997 driver private data are removed. > > Cc: Grant Likely > Cc: MyungJoo Ham > Signed-off-by: Thomas Abraham > --- > arch/arm/mach-exynos/mach-nuri.c|4 -- > arch/arm/mach-exynos/ma

Re: [PATCH v2 3/3] gpio/samsung: use ioremap() for EXYNOS4 GPIOlib

2012-03-12 Thread Grant Likely
time. > > Signed-off-by: Sangsu Park > Cc: Grant Likely > Signed-off-by: Kukjin Kim Acked-by: Grant Likely Kukjin, I think you wanted to take this via your tree? I'm fine with that. Let me know if you'd rather it go via the gpio tree. g. > --- > arch/arm/mach

Re: [PATCH] spi: Compatibility with direction which is used in samsung DMA operation

2012-03-09 Thread Grant Likely
ch = dmatx_res->start; > - sdd->tx_dma.direction = DMA_TO_DEVICE; > + sdd->tx_dma.direction = DMA_MEM_TO_DEV; > sdd->rx_dma.dmach = dmarx_res->start; > - sdd->rx_dma.direction = DMA_FROM_DEVICE; > + sdd->rx_dma.direction = DMA_DEV_TO_MEM; > >

Re: [PATCH] spi: Compatibility with direction which is used in samsung DMA operation

2012-03-09 Thread Grant Likely
t;start; > - sdd->tx_dma.direction = DMA_TO_DEVICE; > + sdd->tx_dma.direction = DMA_MEM_TO_DEV; > sdd->rx_dma.dmach = dmarx_res->start; > - sdd->rx_dma.direction = DMA_FROM_DEVICE; > + sdd->rx_dma.direction = DMA_DEV_TO_MEM; > > sdd-&

Re: [PATCH] spi/s3c64xx: Convert to using core message queue

2012-03-09 Thread Grant Likely
> > writel(0, sdd->regs + S3C64XX_SPI_INT_EN); > > free_irq(platform_get_irq(pdev, 0), sdd); > > - destroy_workqueue(sdd->workqueue); > - > clk_disable(sdd->src_clk); > clk_put(sdd->src_clk); > > @@ -1243,14 +1171,8 @@

Re: Subject: [PATCH] MAINTAINERS: add maintainer entry for SAMSUNG EXYNOS DeviceTree

2012-03-09 Thread Grant Likely
On Wed, 22 Feb 2012 07:49:18 +0530, Thomas Abraham wrote: > On 22 February 2012 05:46, Kukjin Kim wrote: > > Add Samsung EXYNOS DT maintainer > > > > Cc: Thomas Abraham > > Cc: Grant Likely > > Signed-off-by: Kukjin Kim > > --- > >  MAINTAINERS

Re: [PATCH v2 03/11] ARM: EXYNOS: add clock part for EXYNOS5250 SoC

2012-02-13 Thread Grant Likely
On Mon, Feb 13, 2012 at 11:04:53AM +, Russell King - ARM Linux wrote: > On Mon, Feb 13, 2012 at 05:47:48AM +, Arnd Bergmann wrote: > > On Saturday 11 February 2012, Mark Brown wrote: > > > On Sat, Feb 11, 2012 at 08:07:08PM +, Arnd Bergmann wrote: > > > > what the risk is in changing ex

Re: [PATCH 1/2] ARM: EXYNOS: add support GPIO for EXYNOS5250

2012-02-02 Thread Grant Likely
On Tue, Jan 31, 2012 at 10:40:43PM +, Russell King - ARM Linux wrote: > On Wed, Feb 01, 2012 at 12:50:39AM +0900, Kukjin Kim wrote: > > From: Sangsu Park > > > > This patch adds follwing. > > - IO-map for EXYNOS5250 GPIO support > > - EXYNOS5250 GPIO bank size/number definitions > > - memory

Re: [PATCH 1/2] ARM: EXYNOS: add support GPIO for EXYNOS5250

2012-02-02 Thread Grant Likely
On Tue, Jan 31, 2012 at 05:34:02PM +0100, Sylwester Nawrocki wrote: > Hi Kukjin, > > I have few comments below... > > On 01/31/2012 04:50 PM, Kukjin Kim wrote: > > From: Sangsu Park > > > > This patch adds follwing. > > s/follwing/following. > > nit: AFAIK it's a good habit not to start a com

Re: [PATCH] gpio: samsung: adapt to changes in gpio specifier translator function declaration

2012-02-01 Thread Grant Likely
On Wed, Feb 01, 2012 at 06:32:32PM +0530, Thomas Abraham wrote: > Commit 15c9a0acc3f7 (of: create of_phandle_args to simplify return of phandle > parsing data) modifies the parameter list of of_xlate function pointer > declaration > in gpio_chip. Adapt the gpio specifier translate function for thi

Re: [PATCH v3 6/6] mmc: sdhci-s3c: Add device tree support

2012-01-31 Thread Grant Likely
ivers/mmc/host/sdhci-s3c.c | 148 > +++- > 2 files changed, 212 insertions(+), 6 deletions(-) > create mode 100644 Documentation/devicetree/bindings/mmc/samsung-sdhci.txt Looks okay to me on brief review. Acked-by: Grant Likely > > diff

Re: [PATCH 6/6] mmc: sdhci-s3c: Add device tree support

2012-01-30 Thread Grant Likely
On Mon, Jan 30, 2012 at 10:51:11AM +0100, Heiko Stübner wrote: > Am Mittwoch, 2. November 2011, 21:36:03 schrieb Thomas Abraham: > > Hi Thomas, > > in patch 1/6: > > +static struct platform_device_id sdhci_s3c_driver_ids[] = { > > + { > > + .name = "s3c-sdhci", > > +

Re: [PATCH 0/3] spi/s3c64xx diagnostic and PM updates

2012-01-30 Thread Grant Likely
On Sat, Jan 21, 2012 at 03:13:41PM +, Mark Brown wrote: > On Sat, Jan 21, 2012 at 07:27:23AM -0700, Grant Likely wrote: > > > Pushed out to git://git.secretlab.ca/git/linux-2.6.git spi/merge. > > I'll ask Linus to pull in a couple of days after it has hit >

Re: [PATCH] spi: Add spi-s3c64xx driver dependency on ARCH_EXYNOS4

2012-01-25 Thread Grant Likely
On Wed, Jan 25, 2012 at 05:20:59PM +0100, Sylwester Nawrocki wrote: > The spi-s3c64xx driver is also used on Exynos4 so update the dependency > to enable build on those platforms. > > Cc: Jaswinder Singh > Signed-off-by: Sylwester Nawrocki > Signed-off-by: Kyungmin Park Applied, thanks. > ---

Re: [PATCH 0/3] spi/s3c64xx diagnostic and PM updates

2012-01-21 Thread Grant Likely
gt; > Mark Brown (3): >      spi/s3c64xx: Log error interrupts >      spi/s3c64xx: Convert to dev_pm_ops >      spi/s3c64xx: Implement runtime PM support > >  drivers/spi/spi-s3c64xx.c |  115 >  1 files changed, 104 insertions(+),

Re: [PATCH 2/2] ARM: Exynos: Hook up power domains to generic power domain infrastructure

2012-01-03 Thread Grant Likely
On Tue, Jan 03, 2012 at 01:53:28PM +0530, Thomas Abraham wrote: > Hi Sylwester, > > On 3 January 2012 03:49, Sylwester Nawrocki wrote: > > Hi Thomas, > > > > thank you for clarifying. > > > > On 01/02/2012 03:14 AM, Thomas Abraham wrote: > >> > >> The following is a snippet from the dts file used

Re: [RFC][PATCH 0/4] lcd: platform-lcd: Add lcd panel and device tree support

2012-01-01 Thread Grant Likely
On Mon, Jan 02, 2012 at 11:24:31AM +0530, Thomas Abraham wrote: > The platform-lcd driver depends on platform-specific callbacks to setup the > lcd panel. These callbacks are supplied using driver's platform data. But > for adding device tree support for platform-lcd driver, providing such > callba

Re: [RFC][PATCH 4/4] lcd: platform-lcd: Add device tree support

2012-01-01 Thread Grant Likely
On Mon, Jan 02, 2012 at 11:24:35AM +0530, Thomas Abraham wrote: > Add device tree based initialization for Hydis hv070wsa lcd panel. > > Cc: Ben Dooks > Signed-off-by: Thomas Abraham > --- > drivers/video/backlight/platform_lcd.c | 33 > > 1 files changed, 33

Re: [PATCH 1/2] PM / Domains: Add OF support

2012-01-01 Thread Grant Likely
On Mon, Dec 26, 2011 at 08:13:19PM +0100, Rafael J. Wysocki wrote: > Hi, > > On Monday, December 12, 2011, Thomas Abraham wrote: > > A device node pointer is added to generic pm domain structure to associate > > the domain with a node in the device tree. > > That sounds fine except for one thing:

Re: [PATCH 6/6] mmc: sdhci-s3c: Add device tree support

2011-11-07 Thread Grant Likely
On Thu, Nov 03, 2011 at 02:06:03AM +0530, Thomas Abraham wrote: > Add device tree based discovery support for Samsung's sdhci controller > > Cc: Ben Dooks > Signed-off-by: Thomas Abraham > --- > +Example: > + sdhci@1253 { > + compatible = "samsung,exynos4210-sdhci"; > +

Re: [PATCH 5/6] mmc: Add OF bindings support for mmc host controller capabilities

2011-11-07 Thread Grant Likely
On Mon, Nov 07, 2011 at 07:51:26PM +0530, Thomas Abraham wrote: > On 5 November 2011 01:27, Olof Johansson wrote: > > On Thu, Nov 03, 2011 at 02:06:02AM +0530, Thomas Abraham wrote: > >> Device nodes representing sd/mmc controllers in a device tree would include > >> mmc host controller capabiliti

Re: [PATCH v2 9/9] serial: samsung: add device tree support

2011-10-24 Thread Grant Likely
On Mon, Oct 10, 2011 at 03:38:05PM +0530, Thomas Abraham wrote: > Add device tree based discovery support for Samsung's uart controller. > > Cc: Ben Dooks > Cc: Grant Likely > Signed-off-by: Thomas Abraham Acked-by: Grant Likely > --- > .../devicetree/bindin

Re: [PATCH v2 4/9] serial: samsung: remove struct 's3c24xx_uart_clksrc' and all uses of it

2011-10-24 Thread Grant Likely
On Mon, Oct 10, 2011 at 03:38:00PM +0530, Thomas Abraham wrote: > With clkdev based clock lookup added to samsung serial driver, the use > of 'struct s3c24xx_uart_clksrc' to supply clock names in platform > data is removed from all the Samsung platform code. > > Cc: Ben Dooks > Cc: Ramax Lo > Cc

Re: [PATCH 1/3] ARM: Samsung: Move timer irq numbers to end of linux irq space

2011-10-22 Thread Grant Likely
t should be fixed before applying. In addition I need to keep > the ordering to apply them to avoid conflicts. But as you know, v3.1 is now > close at hand and we don't have enough time for it now :( > > I will leave tomorrow morning (KST) for KS. I will talk to Grant Likely >

Re: [PATCH] rtc: rtc-s3c: Add device tree support

2011-10-13 Thread Grant Likely
c'ed Alessandro Zummo who is RTC Subsystem maintainer) > > I'm ok with this, so if this can be got the ack from Grant and Alessandro, > will take this. Acked-by: Grant Likely > > > > > > > diff --git a/Documentation/devicetree/bindings/rtc/s3c-rtc.txt

Re: [PATCH 2/2] ARM: dts: Add intial dts file for Exynos4210 SoC, SMDKV310 and Origen board

2011-10-13 Thread Grant Likely
Exynos4210 dts file > and extends it to describe the board specific properties. > > Signed-off-by: Thomas Abraham Acked-by: Grant Likely > --- > arch/arm/boot/dts/exynos4210-origen.dts | 137 ++ > arch/arm/boot/dts/exynos4210-smdkv310.dts | 182 +

Re: [PATCH 1/2] ARM: Samsung: Add Exynos4 device tree enabled board file

2011-10-13 Thread Grant Likely
describes the > board's > properties should be supplied at boot time to the kernel. > > Signed-off-by: Thomas Abraham Acked-by: Grant Likely > --- > .../devicetree/bindings/arm/insignal-boards.txt|8 ++ > .../devicetree/bindings/arm/samsung-boards.txt |

Re: [PATCH 2/3] ARM: Exynos4: Add ioremap interceptor for statically remapped regions

2011-10-12 Thread Grant Likely
On Wed, Oct 12, 2011 at 9:28 PM, Thomas Abraham wrote: > On 12 October 2011 22:00, Thomas Abraham wrote: >> On 12 October 2011 21:43, Rob Herring wrote: >>> On 10/10/2011 03:11 AM, Thomas Abraham wrote: ioremap() request for statically remapped regions are intercepted and the staticall

Re: [PATCH 3/3] ARM: Exynos4: Add support for dt irq specifier to linux virq conversion

2011-10-12 Thread Grant Likely
On Mon, Oct 10, 2011 at 01:41:29PM +0530, Thomas Abraham wrote: > Add support for conversion of device tree interrupt specifier to linux > virq domain for GIC and Interrupt combiner controllers. > > Signed-off-by: Thomas Abraham > --- > .../devicetree/bindings/irq/samsung-combiner.txt | 24 +

  1   2   >