Re: [PATCH] dmaengine: pl330: Set residue in tx_status callback

2015-03-12 Thread Jassi Brar
Hi Vinod, Hi Russell, On 11 December 2014 at 11:42, Jassi Brar wrote: > On 11 December 2014 at 10:17, Vinod Koul wrote: >> On Tue, Dec 09, 2014 at 08:48:04PM +0530, Jassi Brar wrote: >>> As Russell pointed out, that ain't the case either. >>> So we are yet

Re: [PATCH] dmaengine: pl330: Set residue in tx_status callback

2014-12-10 Thread Jassi Brar
On 11 December 2014 at 10:17, Vinod Koul wrote: > On Tue, Dec 09, 2014 at 08:48:04PM +0530, Jassi Brar wrote: >> As Russell pointed out, that ain't the case either. >> So we are yet to figure out benefits of having explicit >> issue_pending() after tx_submit(). > cal

Re: [PATCH] dmaengine: pl330: Set residue in tx_status callback

2014-12-09 Thread Jassi Brar
On 8 December 2014 at 18:37, Vinod Koul wrote: > On Sat, Dec 06, 2014 at 12:31:01PM +0530, Jassi Brar wrote: >> It does, though, create an "awkward situation" when a channel is >> active while new requests are submitted - why would the channel want >> to stop a

Re: [PATCH] dmaengine: pl330: Set residue in tx_status callback

2014-12-05 Thread Jassi Brar
On 5 December 2014 at 20:48, Russell King - ARM Linux wrote: > On Wed, Dec 03, 2014 at 01:21:37PM +0530, Jassi Brar wrote: >> because the reasoning above seems incorrect considering the following >> documentation... >> >> Documentation/c

Re: [PATCH] dmaengine: pl330: Set residue in tx_status callback

2014-12-02 Thread Jassi Brar
On 3 December 2014 at 10:17, Padma Venkat wrote: > Hi Lars, > > [snip] + + ret = dma_cookie_status(chan, cookie, txstate); + if (ret == DMA_COMPLETE || !txstate) + return ret; + + used = txstate->used; + + spin_lock_irqsave(&pch->lock, flag

Re: [PATCH 3/3] cpufreq: exynos: Add exynos5420 cpufreq driver

2013-12-16 Thread Jassi Brar
On Tue, Dec 10, 2013 at 10:02 PM, Lukasz Majewski wrote: >> >> Actually these values are not for PLL, but for the dividers. >> If you see below, the PLL rate setting is done through clk_set_rate() >> going via CCF. But I found an issue if the divider values are set via >> clk_set_rate API. >> What

Re: [PATCH 0/2] Support device_prep_dma_sg for pl330

2013-04-07 Thread Jassi Brar
-- > 1 file changed, 157 insertions(+), 52 deletions(-) > Acked-by : Jassi Brar -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 4/4] DMA: PL330: add device tree property for DMA_MEMCPY capability

2012-12-11 Thread Jassi Brar
y ("peri-map") for storing indices > of peripherals connected to DMAC and fix DT nodes of client > drivers to use 'dma peripheral id' instead of 'dma request id'. > Also instead of setting DMA_MEMCPY capability unconditionally in > pl330_probe() do it only wh

Re: [PATCH 4/4] DMA: PL330: add device tree property for DMA_MEMCPY capability

2012-11-08 Thread Jassi Brar
On 30 October 2012 14:51, Bartlomiej Zolnierkiewicz wrote: > > Hi, > > On Monday 29 October 2012 22:45:48 Jassi Brar wrote: >> On Mon, Oct 29, 2012 at 10:59 AM, Bartlomiej Zolnierkiewicz >> wrote: >> > * Add device tree (DT) property ("pl330,dma-memcpy&

Re: [PATCH 1/4] DMA: PL330: fix locking in pl330_free_chan_resources()

2012-10-29 Thread Jassi Brar
xa0) from [] > (cpuidle_enter_state+0x18/0x68) > [ 368.47] [] (cpuidle_enter_state+0x18/0x68) from [] > (cpuidle_idle_call+0xac/0xe0) > [ 368.48] [] (cpuidle_idle_call+0xac/0xe0) from [] > (cpu_idle+0xac/0xf0) > [ 368.49] [] (cpu_idle+0xac/0xf0) from [] > (st

Re: [PATCH 4/4] DMA: PL330: add device tree property for DMA_MEMCPY capability

2012-10-29 Thread Jassi Brar
On Mon, Oct 29, 2012 at 10:59 AM, Bartlomiej Zolnierkiewicz wrote: > * Add device tree (DT) property ("pl330,dma-memcpy") for DMA_MEMCPY > capability and instead of setting this capability unconditionally > in pl330_probe() do it only when property is present. > Perhaps we should pass the arra

Re: [PATCH v2 0/4] DMA: PL330: Fix mem leaks and balance probe/remove

2012-10-13 Thread Jassi Brar
/dma/pl330.c | 53 > ++++--- > 1 file changed, 38 insertions(+), 15 deletions(-) > All seem fine. Acked-by: Jassi Brar Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 3/3] DMA: PL330: Balance module remove function with probe

2012-09-28 Thread Jassi Brar
On Fri, Sep 28, 2012 at 10:03 AM, Inderpal Singh wrote: > > Now, if we have to check if any client is using the channel and then > decide. We will have to traverse the channel list twice once to check > the usage and second time to delete the nodes from the list if we go > ahead with remove. > The

Re: [PATCH 3/3] DMA: PL330: Balance module remove function with probe

2012-09-27 Thread Jassi Brar
On Thu, Sep 27, 2012 at 9:11 PM, Inderpal Singh wrote: > On 27 September 2012 15:18, Vinod Koul wrote: >> On Wed, 2012-09-26 at 12:11 +0530, Inderpal Singh wrote: >>> If we fail pl330_remove while some client is queued, the force unload >>> will fail and the >>> force unload will lose its purpose

Re: [PATCH 3/3] DMA: PL330: Balance module remove function with probe

2012-09-26 Thread Jassi Brar
On Thu, Sep 27, 2012 at 11:00 AM, Inderpal Singh wrote: > On 27 September 2012 10:35, Jassi Brar wrote: >> On Thu, Sep 27, 2012 at 9:43 AM, Inderpal Singh >> wrote: >>> >>> Don't you think free_chan_resource should be done __only if__ >>> alloc_ch

Re: [PATCH 3/3] DMA: PL330: Balance module remove function with probe

2012-09-26 Thread Jassi Brar
On Thu, Sep 27, 2012 at 9:43 AM, Inderpal Singh wrote: > > Don't you think free_chan_resource should be done __only if__ > alloc_chan_resource was successful ? > No, I don't think so. Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message t

Re: [PATCH 3/3] DMA: PL330: Balance module remove function with probe

2012-09-26 Thread Jassi Brar
On Wed, Sep 26, 2012 at 4:25 PM, Inderpal Singh wrote: > On 26 September 2012 15:02, Jassi Brar wrote: >> On Wed, Sep 26, 2012 at 12:11 PM, Inderpal Singh >> wrote: >> >>> How about conditionally DMA_TERMINATE_ALL and free resources like below ? >>>

Re: [PATCH 3/3] DMA: PL330: Balance module remove function with probe

2012-09-26 Thread Jassi Brar
On Wed, Sep 26, 2012 at 12:11 PM, Inderpal Singh wrote: > How about conditionally DMA_TERMINATE_ALL and free resources like below ? > > @@ -3017,9 +3017,11 @@ static int __devexit pl330_remove(struct > amba_device *adev) > /* Remove the channel */ > list_del(&pch->

Re: [PATCH 3/3] DMA: PL330: Balance module remove function with probe

2012-09-25 Thread Jassi Brar
On Tue, Sep 25, 2012 at 2:27 PM, Inderpal Singh wrote: > Since peripheral channel resources are not being allocated at probe, > no need to flush the channels and free the resources in remove function. > > Signed-off-by: Inderpal Singh > --- > drivers/dma/pl330.c |8 +--- > 1 file changed

Re: [PATCH 2/3] DMA: PL330: Change allocation method to properly free DMA descriptors

2012-09-25 Thread Jassi Brar
On Tue, Sep 25, 2012 at 2:27 PM, Inderpal Singh wrote: > In probe, memory for multiple DMA descriptors were being allocated at once > and then it was being split and added into DMA pool one by one. The address > of this memory allocation is not being saved anywhere. To free this memory, > the addr

Re: [PATCH 1/3] DMA: PL330: Free memory allocated for peripheral channels

2012-09-25 Thread Jassi Brar
On Tue, Sep 25, 2012 at 2:27 PM, Inderpal Singh wrote: > The allocated memory for peripheral channels is not being freed upon > failure in probe and in module's remove funtion. It will lead to memory > leakage. Hence free the allocated memory. > > Signed-off-by: Inderpal Singh > --- > drivers/dm

Re: [PATCH] DMA: PL330: return ENOMEM instead of 0 from pl330_alloc_chan_resources

2012-09-16 Thread Jassi Brar
On Mon, Sep 17, 2012 at 9:57 AM, Inderpal Singh wrote: > Since 0 is not considered as error at dmaengine level, return ENOMEM > from pl330_alloc_chan_resources in case of failure. > > Signed-off-by: Inderpal Singh Acked-by: Jassi Brar > --- > drivers/dma/pl330.c |2 +-

Re: [PATCH 07/10] spi: s3c64xx: Remove the 'set_level' callback from controller data

2012-05-09 Thread Jassi Brar
On 9 May 2012 14:50, Heiko Stübner wrote: > Am Mittwoch, 9. Mai 2012, 00:04:51 schrieb Thomas Abraham: >> The set_level callback in the controller data, which is used to configure >> the slave select line, cannot be supported when migrating the driver to >> device tree based discovery. Since all t

Re: [PATCH 00/10] spi: s3c64xx: add support for device tree

2012-05-09 Thread Jassi Brar
x27;set_level' callback from controller data >  ARM: Exynos4: Fix the incorrect hierarchy of spi controller bus clock >  ARM: Exynos5: Add spi clock support >  spi: s3c64xx: add device tree support > Look ok to me. FWIW, Acked-by: Jassi Brar -- To unsubscribe from this list: send the

Re: [PATCH 07/10] spi: s3c64xx: Remove the 'set_level' callback from controller data

2012-05-09 Thread Jassi Brar
On Wed, May 9, 2012 at 3:34 AM, Thomas Abraham wrote: > > The set_level callback in the controller data, which is used to configure > the slave select line, cannot be supported when migrating the driver to > device tree based discovery. Since all the platforms currently use gpio > as the slave sel

Re: spi-s3c64xx: problems with SPI_MODE_3 transfers

2012-04-08 Thread Jassi Brar
On Mon, Apr 9, 2012 at 12:09 AM, Heiko Stübner wrote: > [@jassi: I know that you do not work at this stuff any longer, but I included > you in the list of recipients in the hope that you might be able to give me a > pointer on where to look for the culprit of the problem :-) ] > > > Hi, > > while

Re: [PATCH v3] DMA: PL330: Merge PL330 driver into drivers/dma/

2012-02-22 Thread Jassi Brar
On Thu, Feb 23, 2012 at 1:05 AM, Russell King - ARM Linux wrote: Just in case you didn't read the ugly thread fully, let me clarify a few points. > That, to me, means that Samsung hold the copyrights, and Jaswinder Singh > was the author of it. Jaswinder has no copyright on the code. Exactly wh

Re: [PATCH 1/2] ARM: S3C24XX: Move s3c2443-clock.c to mach-s3c24xx

2012-02-22 Thread Jassi Brar
On 22 February 2012 22:58, Heiko Stübner wrote: > >> No objections on the patch, but please use 'git format-patch -M' when >> moving files so that we can see which parts have changed in the process. > the results of -M look really nice, thanks for the hint and I will try to > remember it :-) > The

Re: [PATCH v3] DMA: PL330: Merge PL330 driver into drivers/dma/

2012-02-22 Thread Jassi Brar
On Wed, Feb 22, 2012 at 10:59 PM, Kukjin Kim wrote: >>> >>> * Copyright (c) 2012 Samsung Electronics Co., Ltd. >>> *               http://www.samsung.com >>> * >>> * Copyright (C) 2010 Samsung Electronics Co. Ltd. >>> *       Jaswinder Singh >>> * >> >> The following is more appropriate >> >> -  *

Re: [PATCH v3] DMA: PL330: Merge PL330 driver into drivers/dma/

2012-02-22 Thread Jassi Brar
On Wed, Feb 22, 2012 at 10:21 PM, Kukjin Kim wrote: > > * Copyright (c) 2012 Samsung Electronics Co., Ltd. > *               http://www.samsung.com > * > * Copyright (C) 2010 Samsung Electronics Co. Ltd. > *       Jaswinder Singh > * The following is more appropriate - * Copyright (C) 2010 Sams

Re: [PATCH v3] DMA: PL330: Merge PL330 driver into drivers/dma/

2012-02-22 Thread Jassi Brar
On Wed, Feb 22, 2012 at 3:57 PM, Vinod Koul wrote: > > Sadly, what a mess!!! > > Jassi, you don't own the copyright, your company did, as they employed > you to do the job. So both your and Kukjin are not correct in claiming > the copyright!! > Read the thread again. Nobody is claiming the copyrig

Re: [PATCH v3] DMA: PL330: Merge PL330 driver into drivers/dma/

2012-02-21 Thread Jassi Brar
On Wed, Feb 22, 2012 at 7:41 AM, Kukjin Kim wrote: > >> Can't you read this ? . >> > As I know, the Copyright can belong to a person or company. See my patches in > mainline. I meant that. Of course, it depends on writer. > >> - >> /* linux/drivers/dma/pl330.c >>  * >>

Re: [PATCH v3] DMA: PL330: Merge PL330 driver into drivers/dma/

2012-02-21 Thread Jassi Brar
On Wed, Feb 22, 2012 at 5:52 AM, Kukjin Kim wrote: > > And since she has been doing these updates on behalf of Samsung, she has > added attribution to Samsung also (which you never did while at Samsung). > What the bloody fuck ?!! Can't you read this ? . - /* linux/dr

Re: [PATCH v3] DMA: PL330: Merge PL330 driver into drivers/dma/

2012-02-21 Thread Jassi Brar
gt; Basically this patch merges arch/arm/common/pl330.c into > drivers/dma/pl330.c driver and removes useless exported > symbol, externed function and so on. > > The newer pl330 driver tested on SMDKV310 and SMDK4212 boards > > Cc: Jassi Brar > Cc: Russell King > Acked-by:

Re: [PATCH] ARM: PL330: Fix driver freeze

2011-12-15 Thread Jassi Brar
t the driver from sending more requests if it > didn't guess correctly. > > Signed-off-by: Javi Merino > Cc: Jassi Brar > --- >  arch/arm/common/pl330.c |  116 > --- >  1 files changed, 49 insertions(+), 67 deletions(-) &

Re: [PATCH v2] ARM: pl330: Fix a race condition

2011-12-11 Thread Jassi Brar
On 11 December 2011 20:39, Javi Merino wrote: >>> >>> What about properly tracking what we have sent to the DMA?  Something >>> like the following (warning *ugly* and untested code ahead, may eat your >>> kitten): >>> >> Yeah, this is like I said 'marker' method. Though we can clean it up a bit. >

Re: [PATCH v2] ARM: pl330: Fix a race condition

2011-12-11 Thread Jassi Brar
On Sat, Dec 10, 2011 at 1:20 AM, Javi Merino wrote: > > What about properly tracking what we have sent to the DMA?  Something > like the following (warning *ugly* and untested code ahead, may eat your > kitten): > > diff --git a/arch/arm/common/pl330.c b/arch/arm/common/pl330.c > index f407a6b..36

Re: [PATCH 2/2] DMA: PL330: Removes useless function

2011-12-11 Thread Jassi Brar
On Thu, Dec 8, 2011 at 1:53 PM, Kukjin Kim wrote: > From: Boojin Kim > > Cc: Jassi Brar > Cc: Linus Walleij > Cc: Vinod Koul > Signed-off-by: Boojin Kim > Signed-off-by: Kukjin Kim > --- >  drivers/dma/pl330.c |   47 --

Re: [PATCH v2] ARM: pl330: Fix a race condition

2011-12-09 Thread Jassi Brar
On Fri, Dec 9, 2011 at 8:22 PM, Javi Merino wrote: > > I think the best solution would be to revert > ee3f615819404a9438b2dd01b7a39f276d2737f2 and go back to my original > patch (in the beginning of this thread): > > http://article.gmane.org/gmane.linux.ports.arm.kernel/133110 > > What do you thin

Re: [PATCH v2] ARM: pl330: Fix a race condition

2011-12-09 Thread Jassi Brar
On Fri, Dec 9, 2011 at 7:11 PM, Javi Merino wrote: > On 09/12/11 13:04, Jassi Brar wrote: >> Hi Javi, >> >> On 9 December 2011 17:28, Javi Merino wrote: >>> >>>>>>> Javi, could you please check if you too get the memcpy failure with >>>

Re: [PATCH v2] ARM: pl330: Fix a race condition

2011-12-09 Thread Jassi Brar
Hi Javi, On 9 December 2011 17:28, Javi Merino wrote: > > Javi, could you please check if you too get the memcpy failure with > dmatest ? >> Ok, I think I've just reproduced it in my end with the kernel's dmatest >> module.  After the first transaction it looks like the dma test wasn

Re: [PATCH 1/2] DMA: PL330: Remove pm_runtime_xxx calls from pl330 probe/remove

2011-12-08 Thread Jassi Brar
On 9 December 2011 08:49, Tushar Behera wrote: > On 12/08/2011 07:02 PM, Jassi Brar wrote: >> >> Guys, any reason to keep me, the author of the driver, out of loop ? >> I almost lost this patch, had it not for chance. > > > Apologies. I didn't realize

Re: [PATCH 1/2] DMA: PL330: Remove pm_runtime_xxx calls from pl330 probe/remove

2011-12-08 Thread Jassi Brar
On 8 December 2011 13:46, Vinod Koul wrote: > On Thu, 2011-12-08 at 16:43 +0900, Kukjin Kim wrote: >> Vinod Koul wrote: >> > >> > On Tue, 2011-12-06 at 16:15 +0530, Tushar Behera wrote: >> > > amba_probe() now calls pm_runtime_get_noresume() and pm_runtime_enable() >> > > for the devices before th

Re: [PATCH v2] ARM: pl330: Fix a race condition

2011-11-29 Thread Jassi Brar
On 29 November 2011 15:23, Javi Merino wrote: >> On Samsung's Exynos4 platform, while testing audio playback with >>> i2s >> interface, the above change causes the playback to freeze. The >> _thrd_active(thrd) call always returns '1' and hence _start(thrd) >>> is >> not getting cal

Re: [PATCH v8 00/16] To use DMA generic APIs for Samsung DMA

2011-09-19 Thread Jassi Brar
On Mon, Sep 19, 2011 at 8:29 AM, Vinod Koul wrote: >> >> The changelog for [PATCH v8 04/16] is misleading - we don't need any >> >> modification for the reason mentioned in changelog. But the modification >> >> has positive side-effect of preventing callbacks during terminate_all >> >> which >> >

Re: [PATCH v8 00/16] To use DMA generic APIs for Samsung DMA

2011-09-14 Thread Jassi Brar
On 14 September 2011 16:47, Vinod Koul wrote: >> The changelog for [PATCH v8 04/16] is misleading - we don't need any >> modification for the reason mentioned in changelog. But the modification >> has positive side-effect of preventing callbacks during terminate_all which >> is no way understood

Re: [PATCH v8 00/16] To use DMA generic APIs for Samsung DMA

2011-09-13 Thread Jassi Brar
samsung-dma branch, Fixed the typos in the > changelog of patch 4. > > Please check and let me know if all are fine, I will push them to my > next tomorrow > > If anyone has concerns on this series please let me know by tomorrow > I have no concern about patches modifying samsung

Re: [PATCH v3 4/6] DMA: PL330: Add device tree support

2011-09-12 Thread Jassi Brar
converts the phandle to the device node pointer and matches that > with channel's private data. If a match is found, the request id > from the client node and the 'chan_id' of the channel is matched. > A channel is found if both the values match. > > Cc: Jassi Brar

Re: [PATCH v3 1/6] DMA: PL330: move filter function into driver

2011-09-12 Thread Jassi Brar
l330 channel instance (and avoid any incorrect > access of chan->private in a system with multiple types of DMA > drivers). > > Suggested-by: Russell King > Signed-off-by: Thomas Abraham Acked-by: Jassi Brar -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH v8 04/16] DMA: PL330: Remove the start operation for handling DMA_TERMINATE_ALL command

2011-09-07 Thread Jassi Brar
On 7 September 2011 12:53, Kukjin Kim wrote: > Jassi Brar wrote: >> >> On 6 September 2011 17:57, Russell King - ARM Linux >> wrote: >> > On Tue, Sep 06, 2011 at 05:52:19PM +0530, Jassi Brar wrote: >> >> On Fri, Sep 2, 2011 at 6:14 AM, Boojin Kim wr

Re: [PATCH v8 04/16] DMA: PL330: Remove the start operation for handling DMA_TERMINATE_ALL command

2011-09-06 Thread Jassi Brar
On 6 September 2011 17:57, Russell King - ARM Linux wrote: > On Tue, Sep 06, 2011 at 05:52:19PM +0530, Jassi Brar wrote: >> On Fri, Sep 2, 2011 at 6:14 AM, Boojin Kim wrote: >> > Origianl code carries out the start operation after flush operation. >> > But start op

Re: [PATCH v8 04/16] DMA: PL330: Remove the start operation for handling DMA_TERMINATE_ALL command

2011-09-06 Thread Jassi Brar
On Fri, Sep 2, 2011 at 6:14 AM, Boojin Kim wrote: > Origianl code carries out the start operation after flush operation. > But start operation is not required for DMA_TERMINATE_ALL command. > So, This patch removes the unnecessary start operation and only carries out > the flush oeration for handl

Re: [PATCH v7 04/15] DMA: PL330: Add DMA_CYCLIC capability

2011-08-26 Thread Jassi Brar
h); >  } This is a useless churn since v6. Please fix this and add Acked-by: Jassi Brar -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v7 03/15] DMA: PL330: Modify device_control()

2011-08-26 Thread Jassi Brar
On Thu, Aug 25, 2011 at 7:43 AM, Boojin Kim wrote: > This patch modifies device_control() to support both DMA_TERMINATE_ALL > and DMA_SLAVE_CONFIG command. > First, modify the flush control for DMA_TERMINATE_ALL command. > Second, add the slave configuration control for DMA_SLAVE_CONFIG command.

Re: [PATCH v7 02/15] DMA: PL330: Update PL330 DMA API driver

2011-08-26 Thread Jassi Brar
> Signed-off-by: Boojin Kim > Acked-by: Linus Walleij > Acked-by: Vinod Koul > Cc: Dan Williams > Signed-off-by: Kukjin Kim Acked-by: Jassi Brar -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kern

Re: [PATCH 1/3] DMA: PL330: Infer transfer direction from transfer request instead of platform data

2011-08-23 Thread Jassi Brar
x27; > is no longer required. > > With the 'struct dma_pl330_peri' removed, the dma controller transfer > capabilities cannot be inferred any longer. Hence, the dma controller > capabilities is specified using platforme data. > > Cc: Jassi Brar > Cc: Boojin Kim > Si

Re: [PATCH v6 04/15] DMA: PL330: Add DMA_CYCLIC capability

2011-08-23 Thread Jassi Brar
On Tue, Aug 23, 2011 at 12:38 PM, Boojin Kim wrote: > Jassi Brar [mailto:jassisinghb...@gmail.com] >> Sent: Tuesday, August 23, 2011 2:42 PM >> To: Boojin Kim >> Cc: linux-arm-ker...@lists.infradead.org; linux-samsung- >> s...@vger.kernel.org; Vinod Koul; Kukjin Ki

Re: [PATCH v6 04/15] DMA: PL330: Add DMA_CYCLIC capability

2011-08-22 Thread Jassi Brar
On Mon, Aug 22, 2011 at 5:33 PM, Boojin Kim wrote: >> >> > +static struct dma_async_tx_descriptor *pl330_prep_dma_cyclic( >> > +               struct dma_chan *chan, dma_addr_t dma_addr, size_t len, >> > +               size_t period_len, enum dma_data_direction direction) >> > +{ >> > +       str

Re: [PATCH] DMA: PL330: Merge PL330 drivers

2011-08-22 Thread Jassi Brar
> deleted file mode 100644 > index 575fa81..000 > --- a/arch/arm/include/asm/hardware/pl330.h > +++ /dev/null > @@ -1,217 +0,0 @@ > -/* linux/include/asm/hardware/pl330.h > - * > - * Copyright (C) 2010 Samsung Electronics Co. Ltd. > - *     Jaswinder Singh While at

Re: [PATCH v6 14/15] ASoC: Samsung: Update DMA interface

2011-08-22 Thread Jassi Brar
> Signed-off-by: Boojin Kim > Acked-by: Linus Walleij > Acked-by: Vinod Koul > Cc: Jassi Brar > Cc: Liam Girdwood > Acked-by: Mark Brown > [kgene@samsung.com: removed useless variable] > Signed-off-by: Kukjin Kim > --- >  arch/arm/mach-s3c2410/include/mach/d

Re: [PATCH v6 03/15] DMA: PL330: Support DMA_SLAVE_CONFIG command

2011-08-22 Thread Jassi Brar
On Fri, Aug 19, 2011 at 2:24 PM, Boojin Kim wrote: > Signed-off-by: Boojin Kim > Acked-by: Linus Walleij > Acked-by: Vinod Koul > Cc: Dan Williams > Signed-off-by: Kukjin Kim > --- >  drivers/dma/pl330.c |   56 ++ >  1 files changed, 42 insertio

Re: [PATCH v6 02/15] DMA: PL330: Update PL330 DMA API driver

2011-08-22 Thread Jassi Brar
> Signed-off-by: Boojin Kim > Acked-by: Linus Walleij > Acked-by: Vinod Koul > Cc: Dan Williams > Signed-off-by: Kukjin Kim Acked-by: Jassi Brar -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kern

Re: [PATCH v6 04/15] DMA: PL330: Add DMA_CYCLIC capability

2011-08-22 Thread Jassi Brar
On Fri, Aug 19, 2011 at 2:24 PM, Boojin Kim wrote: > @@ -324,6 +362,9 @@ static void pl330_free_chan_resources(struct dma_chan > *chan) >        pl330_release_channel(pch->pl330_chid); >        pch->pl330_chid = NULL; > > +       if (pch->cyclic) > +               list_splice_tail_init(&pch->wor

Re: [RFC][PATCH 2/2] spi: s3c64xx: Use clkdev for bus clock lookup

2011-08-10 Thread Jassi Brar
On Wed, Aug 10, 2011 at 5:33 PM, padma venkat wrote: > Hi Jassi, > > On Tue, Aug 9, 2011 at 6:13 PM, Jassi Brar wrote: >> On Tue, Aug 9, 2011 at 7:28 PM, Padmavathi Venna wrote: >>> SPI driver is modified to lookup the bus clock using the >>> alias name instea

Re: [RFC][PATCH 2/2] spi: s3c64xx: Use clkdev for bus clock lookup

2011-08-09 Thread Jassi Brar
On Tue, Aug 9, 2011 at 7:28 PM, Padmavathi Venna wrote: > SPI driver is modified to lookup the bus clock using the > alias name instead of getting clock name and clock > number from platform data. Cool. > Driver is modified to get the best source clock among the > available source clocks for the

Re: [PATCH 14/15] ASoC: Samsung: Update DMA interface

2011-08-08 Thread Jassi Brar
On Wed, Jul 27, 2011 at 11:01 AM, Boojin Kim wrote: >  static void dma_enqueue(struct snd_pcm_substream *substream) >  { >        struct runtime_data *prtd = substream->runtime->private_data; >        dma_addr_t pos = prtd->dma_pos; >        unsigned int limit; > -       int ret; > +       struct

Re: [PATCH 13/15] spi/s3c64xx: Merge dma control code

2011-08-08 Thread Jassi Brar
On Wed, Jul 27, 2011 at 11:01 AM, Boojin Kim wrote: > This patch modifies to merge the dma control code. > Original s3c64xx spi driver has each dma control code for rx and tx channel. > This patch merges these dma control codes into one. > With this patch, a dma setup function and callback functio

Re: [PATCH 12/15] spi/s3c64xx: Add support DMA engine API

2011-08-08 Thread Jassi Brar
On Mon, Aug 8, 2011 at 11:25 PM, Heiko Stübner wrote: > Am Montag 08 August 2011, 19:47:58 schrieb Jassi Brar: >> Btw, this spi driver is for S3C64xx(with pl080) and S5P(with pl330) >> series, both of which >> have DMAENGINE drivers. May be it could be directly switched to u

Re: [PATCH 12/15] spi/s3c64xx: Add support DMA engine API

2011-08-08 Thread Jassi Brar
On Wed, Jul 27, 2011 at 11:01 AM, Boojin Kim wrote: > This patch adds to support DMA generic API to transfer raw > SPI data. Basiclly the spi driver uses DMA generic API if > architecture supports it. Otherwise, uses Samsung specific > S3C-PL330 APIs. > > Signed-off-by: Boojin Kim > Acked-by: Gra

Re: [PATCH V4 06/14] ARM: SAMSUNG: Add common DMA operations

2011-07-27 Thread Jassi Brar
On Wed, Jul 27, 2011 at 10:47 AM, Boojin Kim wrote: > Jassi Brar wrote: >> Sent: Wednesday, July 27, 2011 10:34 AM >> To: Boojin Kim >> Cc: linux-arm-ker...@lists.infradead.org; linux-samsung- >> s...@vger.kernel.org; Vinod Koul; Dan Williams; Kukjin Kim; Grant >&

Re: [PATCH 01/15] DMA: PL330: Add support runtime PM for PL330 DMAC

2011-07-27 Thread Jassi Brar
On Wed, Jul 27, 2011 at 11:01 AM, Boojin Kim wrote: > Signed-off-by: Boojin Kim > Cc: Vinod Koul > Cc: Dan Williams > Signed-off-by: Kukjin Kim Acked-by: Jassi Brar -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body

Re: [RFC PATCH] DMA: PL330: Update PL330 DMAC to support runtime PM

2011-07-27 Thread Jassi Brar
On Wed, Jul 27, 2011 at 11:44 AM, Chanwoo Choi wrote: > This patch update runtime PM for PL330 DMAC to reduce power consumption. > > Signed-off-by: Chanwoo Choi > Signed-off-by: Kyungmin Park > --- > The following patch support runtime PM for PL330 DMAC, but the clock > of PL330 is always on. If

Re: [PATCH V4 06/14] ARM: SAMSUNG: Add common DMA operations

2011-07-26 Thread Jassi Brar
On Tue, Jul 26, 2011 at 3:05 PM, Boojin Kim wrote: > Jassi Brar Wrote: >> Sent: Monday, July 25, 2011 8:52 PM >> To: Boojin Kim >> Cc: linux-arm-ker...@lists.infradead.org; linux-samsung- >> s...@vger.kernel.org; Vinod Koul; Dan Williams; Kukjin Kim; Grant >>

Re: [PATCH V4 06/14] ARM: SAMSUNG: Add common DMA operations

2011-07-26 Thread Jassi Brar
On Tue, Jul 26, 2011 at 11:44 PM, Russell King - ARM Linux wrote: > > 1. Arrange for individual DMA engine drivers to provide a filter >   function - eg, pl08x_filter_id() for pl08x channels. > > 2. Have the filter function check chan->device->dev->driver == its >   own struct driver as the very

Re: [PATCH] Improve slave/cyclic DMA engine documentation (was: [PATCH V4 04/14] DMA: PL330: Add DMA_CYCLIC capability)

2011-07-26 Thread Jassi Brar
On Tue, Jul 26, 2011 at 10:50 PM, Russell King - ARM Linux wrote: > On Tue, Jul 26, 2011 at 08:07:44PM +0530, Jassi Brar wrote: >> Dear Vinod, >> >>  Since it came from the RMK, most probably it'll be the best. >> >> But applying patches upon personal time

Re: [PATCH V4 06/14] ARM: SAMSUNG: Add common DMA operations

2011-07-26 Thread Jassi Brar
On Tue, Jul 26, 2011 at 1:32 PM, Russell King - ARM Linux wrote: > On Mon, Jul 25, 2011 at 05:21:44PM +0530, Jassi Brar wrote: >> On Mon, Jul 25, 2011 at 6:58 AM, Boojin Kim wrote: >> >> > + >> > +static bool pl330_filter(struct dma_chan *chan, void *p

Re: [PATCH] Improve slave/cyclic DMA engine documentation (was: [PATCH V4 04/14] DMA: PL330: Add DMA_CYCLIC capability)

2011-07-26 Thread Jassi Brar
On Tue, Jul 26, 2011 at 3:05 PM, Vinod Koul wrote: > On Tue, 2011-07-26 at 08:57 +0100, Russell King - ARM Linux wrote: >> Here's an updated patch. >> >> 8<-- >> From: Russell King >> DMAEngine: Improve slave/cyclic documentation >> >> Improve the documentation for the slave and cyclic DM

Re: [PATCH V4 14/14] ARM: SAMSUNG: Remove Samsung specific enum type for dma direction

2011-07-25 Thread Jassi Brar
On Mon, Jul 25, 2011 at 6:58 AM, Boojin Kim wrote: > This patch removes the samsung specific enum type 's3c2410_dmasrc' > and uses 'dma_data_direction' instead. > > Signed-off-by: Boojin Kim > Signed-off-by: Kukjin Kim Acked-by: Jassi Brar If this patch was

Re: [PATCH V4 07/14] ARM: EXYNOS4: Use generic DMA PL330 driver

2011-07-25 Thread Jassi Brar
On Mon, Jul 25, 2011 at 6:58 AM, Boojin Kim wrote: > diff --git a/arch/arm/mach-exynos4/dma.c b/arch/arm/mach-exynos4/dma.c > index 564bb53..e1c00cf 100644 > --- a/arch/arm/mach-exynos4/dma.c > +++ b/arch/arm/mach-exynos4/dma.c > @@ -21,151 +21,250 @@ >  * Foundation, Inc., 675 Mass Ave, Cambridg

Re: [PATCH V4 06/14] ARM: SAMSUNG: Add common DMA operations

2011-07-25 Thread Jassi Brar
On Mon, Jul 25, 2011 at 6:58 AM, Boojin Kim wrote: > + > +static bool pl330_filter(struct dma_chan *chan, void *param) > +{ > +       struct dma_pl330_peri *peri = (struct dma_pl330_peri *)chan->private; > +       unsigned dma_ch = (unsigned)param; > + > +       if (peri->peri_id != dma_ch) > +  

Re: [PATCH V4 05/14] ARM: SAMSUNG: Update to use PL330-DMA driver

2011-07-25 Thread Jassi Brar
On Mon, Jul 25, 2011 at 6:58 AM, Boojin Kim wrote: > diff --git a/arch/arm/plat-samsung/Kconfig b/arch/arm/plat-samsung/Kconfig > index 4d79519..cb170a6 100644 > --- a/arch/arm/plat-samsung/Kconfig > +++ b/arch/arm/plat-samsung/Kconfig > @@ -300,6 +300,14 @@ config S3C_PL330_DMA >        help >  

Re: [PATCH V4 04/14] DMA: PL330: Add DMA_CYCLIC capability

2011-07-25 Thread Jassi Brar
On Mon, Jul 25, 2011 at 6:58 AM, Boojin Kim wrote: > This patch adds DMA_CYCLIC capability that is used for audio driver. > DMA driver with DMA_CYCLIC capability reuses the dma requests that > were submitted through tx_submit(). > > Signed-off-by: Boojin Kim > --- >  drivers/dma/pl330.c |  111 >

Re: [PATCH V4 02/14] DMA: PL330: Update PL330 DMA API driver

2011-07-25 Thread Jassi Brar
On Mon, Jul 25, 2011 at 6:58 AM, Boojin Kim wrote: > diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c > index b7ecf47..586ab39 100644 > --- a/drivers/dma/pl330.c > +++ b/drivers/dma/pl330.c > @@ -455,7 +455,7 @@ static struct dma_pl330_desc *pl330_get_desc(struct > dma_pl330_chan *pch) >  

Re: [PATCH V4 03-1/13] DMA: PL330: Support DMA_SLAVE_CONFIG command

2011-07-21 Thread Jassi Brar
On Wed, Jul 20, 2011 at 4:16 PM, Boojin Kim wrote: > Signed-off-by: Boojin Kim > Signed-off-by: Kukjin Kim > --- >  drivers/dma/pl330.c |   53 +- >  1 files changed, 39 insertions(+), 14 deletions(-) > > diff --git a/drivers/dma/pl330.c b/drivers/d

Re: [PATCH V4 03-1/13] DMA: PL330: Support DMA_SLAVE_CONFIG command

2011-07-21 Thread Jassi Brar
On Thu, Jul 21, 2011 at 8:53 PM, Russell King - ARM Linux wrote: > On Thu, Jul 21, 2011 at 08:42:40PM +0530, Jassi Brar wrote: >> On Thu, Jul 21, 2011 at 4:59 PM, Russell King - ARM Linux >> wrote: >> > Does your hardware have a hardware block from the device itself

Re: [PATCH V4 03-1/13] DMA: PL330: Support DMA_SLAVE_CONFIG command

2011-07-21 Thread Jassi Brar
On Thu, Jul 21, 2011 at 4:59 PM, Russell King - ARM Linux wrote: >> >> PL330 has fixed channels to peripherals. >> >> So FIFO addresses(burst_sz too?) should already be set via platform data. >> >> Client drivers shouldn't bother. >> > >> > That's utter crap, and isn't what the DMA engine API is a

Re: [PATCH V4 03-1/13] DMA: PL330: Support DMA_SLAVE_CONFIG command

2011-07-21 Thread Jassi Brar
On Thu, Jul 21, 2011 at 3:53 PM, Linus Walleij wrote: > On Thu, Jul 21, 2011 at 11:14 AM, Jassi Brar wrote: >> On Thu, Jul 21, 2011 at 1:41 PM, Russell King - ARM Linux >> wrote: >>> On Thu, Jul 21, 2011 at 12:47:49AM +0530, Jassi Brar wrote: >>>> PL3

Re: [PATCH V4 03-1/13] DMA: PL330: Support DMA_SLAVE_CONFIG command

2011-07-21 Thread Jassi Brar
On Thu, Jul 21, 2011 at 1:41 PM, Russell King - ARM Linux wrote: > On Thu, Jul 21, 2011 at 12:47:49AM +0530, Jassi Brar wrote: >> On Wed, Jul 20, 2011 at 4:16 PM, Boojin Kim wrote: >> > +               if (slave_config->direction == DMA_TO_DEVICE) { >> > +        

Re: [PATCH V4 03-1/13] DMA: PL330: Support DMA_SLAVE_CONFIG command

2011-07-21 Thread Jassi Brar
On Thu, Jul 21, 2011 at 12:04 PM, Boojin Kim wrote: > Jassi Brar wrote: >> Sent: Thursday, July 21, 2011 2:00 PM >> To: Boojin Kim >> Cc: linux-arm-ker...@lists.infradead.org; linux-samsung-soc@vger.kernel.org; >> Vinod Koul; Dan Williams; Kukjin Kim >> Subject:

Re: [PATCH V4 03-1/13] DMA: PL330: Support DMA_SLAVE_CONFIG command

2011-07-20 Thread Jassi Brar
On Thu, Jul 21, 2011 at 9:43 AM, Boojin Kim wrote: >> > -       pl330_tasklet((unsigned long) pch); >> > +               list_splice_tail_init(&list, &pdmac->desc_pool); >> > +               spin_unlock_irqrestore(&pch->lock, flags); >> > +               break; >> > +       case DMA_SLAVE_CONFIG:

Re: [PATCH V4 03-1/13] DMA: PL330: Support DMA_SLAVE_CONFIG command

2011-07-20 Thread Jassi Brar
On Wed, Jul 20, 2011 at 4:16 PM, Boojin Kim wrote: > Signed-off-by: Boojin Kim > Signed-off-by: Kukjin Kim > --- >  drivers/dma/pl330.c |   53 +- >  1 files changed, 39 insertions(+), 14 deletions(-) > > diff --git a/drivers/dma/pl330.c b/drivers/d

Re: [PATCH V4 01/13] DMA: PL330: Add support runtime PM for PL330 DMAC

2011-07-20 Thread Jassi Brar
On Wed, Jul 20, 2011 at 4:16 PM, Boojin Kim wrote: > Signed-off-by: Boojin Kim > Cc: Vinod Koul > Cc: Dan Williams > Signed-off-by: Kukjin Kim Acked-by: Jassi Brar > --- >  drivers/dma/pl330.c |   75 +- >  1 files c

Re: [PATCH V3 00/13] To use DMA generic APIs for Samsung DMA

2011-07-18 Thread Jassi Brar
On Sat, Jul 16, 2011 at 12:14 PM, Kukjin Kim wrote: > Following is diagram of this changes > > +-+ > | Each drivers which uses DMA                                         | > +--

Re: [PATCH 3/7] DMA: PL330: Add DMA capabilities

2011-07-13 Thread Jassi Brar
On Thu, Jul 14, 2011 at 6:27 AM, boojin wrote: > Jassi Brar wrote: > >> On Tue, Jul 5, 2011 at 12:03 PM, Chanho Park wrote: >> > Kukjin Kim samsung.com> writes: >> > >> > (snip) >> > >> >> +             if (slave_config->directio

Re: [PATCH] ASoC: SAMSUNG: 24-bit audio playback on Exynos4210

2011-07-13 Thread Jassi Brar
On Wed, Jul 13, 2011 at 4:52 PM, Giridhar Maruthy wrote: > Using 256fs or 512fs will result in distortion of 24-bit > audio samples. This is because the lrclk generated is not > proper. Using 384 fs generates proper output. > > Signed-off-by: Giridhar Maruthy > --- >  sound/soc/samsung/smdk_wm899

Re: [PATCH 3/7] DMA: PL330: Add DMA capabilities

2011-07-12 Thread Jassi Brar
On Tue, Jul 5, 2011 at 12:03 PM, Chanho Park wrote: > Kukjin Kim samsung.com> writes: > > (snip) > >> +             if (slave_config->direction == DMA_TO_DEVICE) { >> +                     if (slave_config->dst_addr) >> +                             peri->fifo_addr = slave_config->dst_addr; >> +

Re: [PATCH] ARM:SAMSUNG: DMA Cleanup as per sparse

2011-07-05 Thread Jassi Brar
On Wed, Jul 6, 2011 at 11:38 AM, Kukjin Kim wrote: > Kukjin Kim wrote: >> >> Sangwook Lee wrote: >> > >> > Function declaration differs between file:s3c-pl330.c and file:dma.h >> > and SPARSE (Documentation/sparse.txt) gives error messages >> > >> > Signed-off-by: Sangwook Lee >> > --- >> >  arch

Re: [PATCH 6/7] spi/s3c64xx: Add support DMA engine API

2011-07-05 Thread Jassi Brar
On Tue, Jul 5, 2011 at 4:57 PM, Russell King - ARM Linux wrote: > On Tue, Jul 05, 2011 at 04:46:47PM +0530, Jassi Brar wrote: >> Ideally, like PL330 for S5P, drivers/dma/pl080 should be enabled >> for s3c64xx And new generic dma api drivers written for S3C24xx in >> dri

Re: [PATCH 6/7] spi/s3c64xx: Add support DMA engine API

2011-07-05 Thread Jassi Brar
On Tue, Jul 5, 2011 at 12:35 PM, Kukjin Kim wrote: > Grant Likely wrote: >> >> On Mon, Jul 04, 2011 at 09:51:43PM +0200, Heiko Stübner wrote: >> > Am Montag 04 Juli 2011, 19:02:17 schrieb Grant Likely: >> > > On Mon, Jul 04, 2011 at 06:59:11PM +0200, Heiko Stübner wrote: >> > > > Am Montag 04 Juli

Re: [PATCH 2/2] SPI: SAMSUNG: Bug fix for SPI with different FIFO level

2011-06-30 Thread Jassi Brar
On Fri, Jul 1, 2011 at 11:29 AM, padma venkat wrote: > Hi Jassi, > > On Fri, Jul 1, 2011 at 11:22 AM, Jassi Brar wrote: >> On Fri, Jul 1, 2011 at 11:16 AM, padma venkat wrote: >>> Hi Tony, >>> >>> On Thu, Jun 30, 2011 at 4:30 PM, Tony Nadackal wrote

  1   2   3   >