Re: [PATCH] dmaengine: pl330: Set residue in tx_status callback

2015-03-12 Thread Jassi Brar
Hi Vinod, Hi Russell, On 11 December 2014 at 11:42, Jassi Brar jaswinder.si...@linaro.org wrote: On 11 December 2014 at 10:17, Vinod Koul vinod.k...@intel.com wrote: On Tue, Dec 09, 2014 at 08:48:04PM +0530, Jassi Brar wrote: As Russell pointed out, that ain't the case either. So we are yet

Re: [PATCH] dmaengine: pl330: Set residue in tx_status callback

2014-12-10 Thread Jassi Brar
On 11 December 2014 at 10:17, Vinod Koul vinod.k...@intel.com wrote: On Tue, Dec 09, 2014 at 08:48:04PM +0530, Jassi Brar wrote: As Russell pointed out, that ain't the case either. So we are yet to figure out benefits of having explicit issue_pending() after tx_submit(). callback

Re: [PATCH] dmaengine: pl330: Set residue in tx_status callback

2014-12-09 Thread Jassi Brar
On 8 December 2014 at 18:37, Vinod Koul vinod.k...@intel.com wrote: On Sat, Dec 06, 2014 at 12:31:01PM +0530, Jassi Brar wrote: It does, though, create an awkward situation when a channel is active while new requests are submitted - why would the channel want to stop after current transfer

Re: [PATCH] dmaengine: pl330: Set residue in tx_status callback

2014-12-05 Thread Jassi Brar
On 5 December 2014 at 20:48, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Wed, Dec 03, 2014 at 01:21:37PM +0530, Jassi Brar wrote: because the reasoning above seems incorrect considering the following documentation... Documentation/crypto/async-tx-api.txt says

Re: [PATCH] dmaengine: pl330: Set residue in tx_status callback

2014-12-02 Thread Jassi Brar
On 3 December 2014 at 10:17, Padma Venkat padma@gmail.com wrote: Hi Lars, [snip] + + ret = dma_cookie_status(chan, cookie, txstate); + if (ret == DMA_COMPLETE || !txstate) + return ret; + + used = txstate-used; + + spin_lock_irqsave(pch-lock, flags); + sar =

Re: [PATCH 3/3] cpufreq: exynos: Add exynos5420 cpufreq driver

2013-12-16 Thread Jassi Brar
On Tue, Dec 10, 2013 at 10:02 PM, Lukasz Majewski l.majew...@samsung.com wrote: Actually these values are not for PLL, but for the dividers. If you see below, the PLL rate setting is done through clk_set_rate() going via CCF. But I found an issue if the divider values are set via clk_set_rate

Re: [PATCH 0/2] Support device_prep_dma_sg for pl330

2013-04-07 Thread Jassi Brar
changed, 157 insertions(+), 52 deletions(-) Acked-by : Jassi Brar jassisinghb...@gmail.com -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 4/4] DMA: PL330: add device tree property for DMA_MEMCPY capability

2012-12-11 Thread Jassi Brar
is present (idea from Jassi Brar). It fixes the issue on ARM EXYNOS platforms using DT where pdma controller erroneously was used for DMA_MEMCPY operations instead of mdma one (it seems to work correctly but at the cost of worse performance). Sorry, we need to change it as per new generic dma

Re: [PATCH 4/4] DMA: PL330: add device tree property for DMA_MEMCPY capability

2012-11-08 Thread Jassi Brar
On 30 October 2012 14:51, Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com wrote: Hi, On Monday 29 October 2012 22:45:48 Jassi Brar wrote: On Mon, Oct 29, 2012 at 10:59 AM, Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com wrote: * Add device tree (DT) property (pl330,dma-memcpy

Re: [PATCH 4/4] DMA: PL330: add device tree property for DMA_MEMCPY capability

2012-10-29 Thread Jassi Brar
On Mon, Oct 29, 2012 at 10:59 AM, Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com wrote: * Add device tree (DT) property (pl330,dma-memcpy) for DMA_MEMCPY capability and instead of setting this capability unconditionally in pl330_probe() do it only when property is present. Perhaps we

Re: [PATCH 1/4] DMA: PL330: fix locking in pl330_free_chan_resources()

2012-10-29 Thread Jassi Brar
+0xac/0xe0) from [c00102f8] (cpu_idle+0xac/0xf0) [ 368.49] [c00102f8] (cpu_idle+0xac/0xf0) from [c04796a0] (start_kernel+0x28c/0x294) Cc: Jassi Brar jassisinghb...@gmail.com Cc: Vinod Koul vinod.k...@linux.intel.com Cc: Tomasz Figa t.f...@samsung.com Signed-off-by: Bartlomiej

Re: [PATCH v2 0/4] DMA: PL330: Fix mem leaks and balance probe/remove

2012-10-13 Thread Jassi Brar
-by: Jassi Brar jassisinghb...@gmail.com Thanks. -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 3/3] DMA: PL330: Balance module remove function with probe

2012-09-28 Thread Jassi Brar
On Fri, Sep 28, 2012 at 10:03 AM, Inderpal Singh inderpal.si...@linaro.org wrote: Now, if we have to check if any client is using the channel and then decide. We will have to traverse the channel list twice once to check the usage and second time to delete the nodes from the list if we go

Re: [PATCH 3/3] DMA: PL330: Balance module remove function with probe

2012-09-26 Thread Jassi Brar
On Wed, Sep 26, 2012 at 12:11 PM, Inderpal Singh inderpal.si...@linaro.org wrote: How about conditionally DMA_TERMINATE_ALL and free resources like below ? @@ -3017,9 +3017,11 @@ static int __devexit pl330_remove(struct amba_device *adev) /* Remove the channel */

Re: [PATCH 2/3] DMA: PL330: Change allocation method to properly free DMA descriptors

2012-09-25 Thread Jassi Brar
On Tue, Sep 25, 2012 at 2:27 PM, Inderpal Singh inderpal.si...@linaro.org wrote: In probe, memory for multiple DMA descriptors were being allocated at once and then it was being split and added into DMA pool one by one. The address of this memory allocation is not being saved anywhere. To free

Re: [PATCH 3/3] DMA: PL330: Balance module remove function with probe

2012-09-25 Thread Jassi Brar
On Tue, Sep 25, 2012 at 2:27 PM, Inderpal Singh inderpal.si...@linaro.org wrote: Since peripheral channel resources are not being allocated at probe, no need to flush the channels and free the resources in remove function. Signed-off-by: Inderpal Singh inderpal.si...@linaro.org ---

Re: [PATCH] DMA: PL330: return ENOMEM instead of 0 from pl330_alloc_chan_resources

2012-09-16 Thread Jassi Brar
On Mon, Sep 17, 2012 at 9:57 AM, Inderpal Singh inderpal.si...@linaro.org wrote: Since 0 is not considered as error at dmaengine level, return ENOMEM from pl330_alloc_chan_resources in case of failure. Signed-off-by: Inderpal Singh inderpal.si...@linaro.org Acked-by: Jassi Brar jassisinghb

Re: [PATCH 07/10] spi: s3c64xx: Remove the 'set_level' callback from controller data

2012-05-09 Thread Jassi Brar
On Wed, May 9, 2012 at 3:34 AM, Thomas Abraham thomas.abra...@linaro.org wrote: The set_level callback in the controller data, which is used to configure the slave select line, cannot be supported when migrating the driver to device tree based discovery. Since all the platforms currently use

Re: [PATCH 00/10] spi: s3c64xx: add support for device tree

2012-05-09 Thread Jassi Brar
hierarchy of spi controller bus clock  ARM: Exynos5: Add spi clock support  spi: s3c64xx: add device tree support Look ok to me. FWIW, Acked-by: Jassi Brar jassisinghb...@gmail.com -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord

Re: [PATCH 07/10] spi: s3c64xx: Remove the 'set_level' callback from controller data

2012-05-09 Thread Jassi Brar
On 9 May 2012 14:50, Heiko Stübner he...@sntech.de wrote: Am Mittwoch, 9. Mai 2012, 00:04:51 schrieb Thomas Abraham: The set_level callback in the controller data, which is used to configure the slave select line, cannot be supported when migrating the driver to device tree based discovery.

Re: spi-s3c64xx: problems with SPI_MODE_3 transfers

2012-04-09 Thread Jassi Brar
On Mon, Apr 9, 2012 at 12:09 AM, Heiko Stübner he...@sntech.de wrote: [@jassi: I know that you do not work at this stuff any longer, but I included you in the list of recipients in the hope that you might be able to give me a pointer on where to look for the culprit of the problem :-) ] Hi,

Re: [PATCH v3] DMA: PL330: Merge PL330 driver into drivers/dma/

2012-02-22 Thread Jassi Brar
On Wed, Feb 22, 2012 at 3:57 PM, Vinod Koul vinod.k...@intel.com wrote: Sadly, what a mess!!! Jassi, you don't own the copyright, your company did, as they employed you to do the job. So both your and Kukjin are not correct in claiming the copyright!! Read the thread again. Nobody is

Re: [PATCH v3] DMA: PL330: Merge PL330 driver into drivers/dma/

2012-02-22 Thread Jassi Brar
On Wed, Feb 22, 2012 at 10:21 PM, Kukjin Kim kgene@samsung.com wrote: * Copyright (c) 2012 Samsung Electronics Co., Ltd. *               http://www.samsung.com * * Copyright (C) 2010 Samsung Electronics Co. Ltd. *       Jaswinder Singh jassi.b...@samsung.com * The following is more

Re: [PATCH v3] DMA: PL330: Merge PL330 driver into drivers/dma/

2012-02-22 Thread Jassi Brar
On Wed, Feb 22, 2012 at 10:59 PM, Kukjin Kim kgene@samsung.com wrote: * Copyright (c) 2012 Samsung Electronics Co., Ltd. *               http://www.samsung.com * * Copyright (C) 2010 Samsung Electronics Co. Ltd. *       Jaswinder Singhjassi.b...@samsung.com * The following is more

Re: [PATCH 1/2] ARM: S3C24XX: Move s3c2443-clock.c to mach-s3c24xx

2012-02-22 Thread Jassi Brar
On 22 February 2012 22:58, Heiko Stübner he...@sntech.de wrote: No objections on the patch, but please use 'git format-patch -M' when moving files so that we can see which parts have changed in the process. the results of -M look really nice, thanks for the hint and I will try to remember it

Re: [PATCH v3] DMA: PL330: Merge PL330 driver into drivers/dma/

2012-02-21 Thread Jassi Brar
them now. Basically this patch merges arch/arm/common/pl330.c into drivers/dma/pl330.c driver and removes useless exported symbol, externed function and so on. The newer pl330 driver tested on SMDKV310 and SMDK4212 boards Cc: Jassi Brar jassisinghb...@gmail.com Cc: Russell King rmk+ker

Re: [PATCH v3] DMA: PL330: Merge PL330 driver into drivers/dma/

2012-02-21 Thread Jassi Brar
On Wed, Feb 22, 2012 at 5:52 AM, Kukjin Kim kgene@samsung.com wrote: And since she has been doing these updates on behalf of Samsung, she has added attribution to Samsung also (which you never did while at Samsung). What the bloody fuck ?!! Can't you read this ? .

Re: [PATCH v3] DMA: PL330: Merge PL330 driver into drivers/dma/

2012-02-21 Thread Jassi Brar
On Wed, Feb 22, 2012 at 7:41 AM, Kukjin Kim kgene@samsung.com wrote: Can't you read this ? . As I know, the Copyright can belong to a person or company. See my patches in mainline. I meant that. Of course, it depends on writer. - /*

Re: [PATCH] ARM: PL330: Fix driver freeze

2011-12-15 Thread Jassi Brar
prevent the driver from sending more requests if it didn't guess correctly. Signed-off-by: Javi Merino javi.mer...@arm.com Cc: Jassi Brar jaswinder.si...@linaro.org ---  arch/arm/common/pl330.c |  116 ---  1 files changed, 49 insertions(+), 67

Re: [PATCH 2/2] DMA: PL330: Removes useless function

2011-12-11 Thread Jassi Brar
On Thu, Dec 8, 2011 at 1:53 PM, Kukjin Kim kgene@samsung.com wrote: From: Boojin Kim boojin@samsung.com Cc: Jassi Brar jassisinghb...@gmail.com Cc: Linus Walleij linus.wall...@linaro.org Cc: Vinod Koul vinod.k...@intel.com Signed-off-by: Boojin Kim boojin@samsung.com Signed-off

Re: [PATCH v2] ARM: pl330: Fix a race condition

2011-12-11 Thread Jassi Brar
On Sat, Dec 10, 2011 at 1:20 AM, Javi Merino javi.mer...@arm.com wrote: What about properly tracking what we have sent to the DMA?  Something like the following (warning *ugly* and untested code ahead, may eat your kitten): diff --git a/arch/arm/common/pl330.c b/arch/arm/common/pl330.c

Re: [PATCH v2] ARM: pl330: Fix a race condition

2011-12-11 Thread Jassi Brar
On 11 December 2011 20:39, Javi Merino javi.mer...@arm.com wrote: What about properly tracking what we have sent to the DMA?  Something like the following (warning *ugly* and untested code ahead, may eat your kitten): Yeah, this is like I said 'marker' method. Though we can clean it up a

Re: [PATCH v2] ARM: pl330: Fix a race condition

2011-12-09 Thread Jassi Brar
Hi Javi, On 9 December 2011 17:28, Javi Merino javi.mer...@arm.com wrote: Javi, could you please check if you too get the memcpy failure with dmatest ? Ok, I think I've just reproduced it in my end with the kernel's dmatest module.  After the first transaction it looks like the dma test

Re: [PATCH v2] ARM: pl330: Fix a race condition

2011-12-09 Thread Jassi Brar
On Fri, Dec 9, 2011 at 8:22 PM, Javi Merino javi.mer...@arm.com wrote: I think the best solution would be to revert ee3f615819404a9438b2dd01b7a39f276d2737f2 and go back to my original patch (in the beginning of this thread): http://article.gmane.org/gmane.linux.ports.arm.kernel/133110 What

Re: [PATCH v2] ARM: pl330: Fix a race condition

2011-11-29 Thread Jassi Brar
On 29 November 2011 15:23, Javi Merino javi.mer...@arm.com wrote: On Samsung's Exynos4 platform, while testing audio playback with i2s interface, the above change causes the playback to freeze. The _thrd_active(thrd) call always returns '1' and hence _start(thrd) is not getting called. If

Re: [PATCH v8 00/16] To use DMA generic APIs for Samsung DMA

2011-09-14 Thread Jassi Brar
On 14 September 2011 16:47, Vinod Koul vinod.k...@intel.com wrote: The changelog for [PATCH v8 04/16] is misleading - we don't need any modification for the reason mentioned in changelog. But the modification has positive side-effect of preventing callbacks during terminate_all which is no

Re: [PATCH v3 1/6] DMA: PL330: move filter function into driver

2011-09-12 Thread Jassi Brar
invoked is pl330 channel instance (and avoid any incorrect access of chan-private in a system with multiple types of DMA drivers). Suggested-by: Russell King rmk+ker...@arm.linux.org.uk Signed-off-by: Thomas Abraham thomas.abra...@linaro.org Acked-by: Jassi Brar jassisinghb...@gmail.com

Re: [PATCH v3 4/6] DMA: PL330: Add device tree support

2011-09-12 Thread Jassi Brar
to the device node pointer and matches that with channel's private data. If a match is found, the request id from the client node and the 'chan_id' of the channel is matched. A channel is found if both the values match. Cc: Jassi Brar jassisinghb...@gmail.com Cc: Boojin Kim boojin@samsung.com

Re: [PATCH v8 04/16] DMA: PL330: Remove the start operation for handling DMA_TERMINATE_ALL command

2011-09-07 Thread Jassi Brar
On 7 September 2011 12:53, Kukjin Kim kgene@samsung.com wrote: Jassi Brar wrote: On 6 September 2011 17:57, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Tue, Sep 06, 2011 at 05:52:19PM +0530, Jassi Brar wrote: On Fri, Sep 2, 2011 at 6:14 AM, Boojin Kim boojin

Re: [PATCH v8 04/16] DMA: PL330: Remove the start operation for handling DMA_TERMINATE_ALL command

2011-09-06 Thread Jassi Brar
On Fri, Sep 2, 2011 at 6:14 AM, Boojin Kim boojin@samsung.com wrote: Origianl code carries out the start operation after flush operation. But start operation is not required for DMA_TERMINATE_ALL command. So, This patch removes the unnecessary start operation and only carries out the flush

Re: [PATCH v8 04/16] DMA: PL330: Remove the start operation for handling DMA_TERMINATE_ALL command

2011-09-06 Thread Jassi Brar
On 6 September 2011 17:57, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Tue, Sep 06, 2011 at 05:52:19PM +0530, Jassi Brar wrote: On Fri, Sep 2, 2011 at 6:14 AM, Boojin Kim boojin@samsung.com wrote: Origianl code carries out the start operation after flush operation

Re: [PATCH v7 02/15] DMA: PL330: Update PL330 DMA API driver

2011-08-26 Thread Jassi Brar
-by: Boojin Kim boojin@samsung.com Acked-by: Linus Walleij linus.wall...@linaro.org Acked-by: Vinod Koul vinod.k...@intel.com Cc: Dan Williams dan.j.willi...@intel.com Signed-off-by: Kukjin Kim kgene@samsung.com Acked-by: Jassi Brar jassisinghb...@gmail.com -- To unsubscribe from this list

Re: [PATCH v7 03/15] DMA: PL330: Modify device_control()

2011-08-26 Thread Jassi Brar
On Thu, Aug 25, 2011 at 7:43 AM, Boojin Kim boojin@samsung.com wrote: This patch modifies device_control() to support both DMA_TERMINATE_ALL and DMA_SLAVE_CONFIG command. First, modify the flush control for DMA_TERMINATE_ALL command. Second, add the slave configuration control for

Re: [PATCH v7 04/15] DMA: PL330: Add DMA_CYCLIC capability

2011-08-26 Thread Jassi Brar
);  } This is a useless churn since v6. Please fix this and add Acked-by: Jassi Brar jassisinghb...@gmail.com -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH v6 04/15] DMA: PL330: Add DMA_CYCLIC capability

2011-08-23 Thread Jassi Brar
On Tue, Aug 23, 2011 at 12:38 PM, Boojin Kim boojin@samsung.com wrote: Jassi Brar [mailto:jassisinghb...@gmail.com] Sent: Tuesday, August 23, 2011 2:42 PM To: Boojin Kim Cc: linux-arm-ker...@lists.infradead.org; linux-samsung- s...@vger.kernel.org; Vinod Koul; Kukjin Kim; Dan Williams

Re: [PATCH 1/3] DMA: PL330: Infer transfer direction from transfer request instead of platform data

2011-08-23 Thread Jassi Brar
' is no longer required. With the 'struct dma_pl330_peri' removed, the dma controller transfer capabilities cannot be inferred any longer. Hence, the dma controller capabilities is specified using platforme data. Cc: Jassi Brar jassisinghb...@gmail.com Cc: Boojin Kim boojin@samsung.com

Re: [PATCH v6 04/15] DMA: PL330: Add DMA_CYCLIC capability

2011-08-22 Thread Jassi Brar
On Fri, Aug 19, 2011 at 2:24 PM, Boojin Kim boojin@samsung.com wrote: @@ -324,6 +362,9 @@ static void pl330_free_chan_resources(struct dma_chan *chan)        pl330_release_channel(pch-pl330_chid);        pch-pl330_chid = NULL; +       if (pch-cyclic) +              

Re: [PATCH v6 02/15] DMA: PL330: Update PL330 DMA API driver

2011-08-22 Thread Jassi Brar
-by: Boojin Kim boojin@samsung.com Acked-by: Linus Walleij linus.wall...@linaro.org Acked-by: Vinod Koul vinod.k...@intel.com Cc: Dan Williams dan.j.willi...@intel.com Signed-off-by: Kukjin Kim kgene@samsung.com Acked-by: Jassi Brar jassisinghb...@gmail.com -- To unsubscribe from this list

Re: [PATCH v6 03/15] DMA: PL330: Support DMA_SLAVE_CONFIG command

2011-08-22 Thread Jassi Brar
On Fri, Aug 19, 2011 at 2:24 PM, Boojin Kim boojin@samsung.com wrote: Signed-off-by: Boojin Kim boojin@samsung.com Acked-by: Linus Walleij linus.wall...@linaro.org Acked-by: Vinod Koul vinod.k...@intel.com Cc: Dan Williams dan.j.willi...@intel.com Signed-off-by: Kukjin Kim

Re: [PATCH v6 14/15] ASoC: Samsung: Update DMA interface

2011-08-22 Thread Jassi Brar
. Signed-off-by: Boojin Kim boojin@samsung.com Acked-by: Linus Walleij linus.wall...@linaro.org Acked-by: Vinod Koul vinod.k...@intel.com Cc: Jassi Brar jassisinghb...@gmail.com Cc: Liam Girdwood l...@ti.com Acked-by: Mark Brown broo...@opensource.wolfsonmicro.com [kgene@samsung.com

Re: [PATCH] DMA: PL330: Merge PL330 drivers

2011-08-22 Thread Jassi Brar
/asm/hardware/pl330.h +++ /dev/null @@ -1,217 +0,0 @@ -/* linux/include/asm/hardware/pl330.h - * - * Copyright (C) 2010 Samsung Electronics Co. Ltd. - *     Jaswinder Singh jassi.b...@samsung.com While at it, please also modify the instances of author id to 'Jassi Brar jassisinghb

Re: [PATCH v6 04/15] DMA: PL330: Add DMA_CYCLIC capability

2011-08-22 Thread Jassi Brar
On Mon, Aug 22, 2011 at 5:33 PM, Boojin Kim boojin@samsung.com wrote: +static struct dma_async_tx_descriptor *pl330_prep_dma_cyclic( +               struct dma_chan *chan, dma_addr_t dma_addr, size_t len, +               size_t period_len, enum dma_data_direction direction) +{ +    

Re: [RFC][PATCH 2/2] spi: s3c64xx: Use clkdev for bus clock lookup

2011-08-10 Thread Jassi Brar
On Wed, Aug 10, 2011 at 5:33 PM, padma venkat padma@gmail.com wrote: Hi Jassi, On Tue, Aug 9, 2011 at 6:13 PM, Jassi Brar jassisinghb...@gmail.com wrote: On Tue, Aug 9, 2011 at 7:28 PM, Padmavathi Venna padm...@samsung.com wrote: SPI driver is modified to lookup the bus clock using

Re: [RFC][PATCH 2/2] spi: s3c64xx: Use clkdev for bus clock lookup

2011-08-09 Thread Jassi Brar
On Tue, Aug 9, 2011 at 7:28 PM, Padmavathi Venna padm...@samsung.com wrote: SPI driver is modified to lookup the bus clock using the alias name instead of getting clock name and clock number from platform data. Cool. Driver is modified to get the best source clock among the available source

Re: [PATCH 12/15] spi/s3c64xx: Add support DMA engine API

2011-08-08 Thread Jassi Brar
On Wed, Jul 27, 2011 at 11:01 AM, Boojin Kim boojin@samsung.com wrote: This patch adds to support DMA generic API to transfer raw SPI data. Basiclly the spi driver uses DMA generic API if architecture supports it. Otherwise, uses Samsung specific S3C-PL330 APIs. Signed-off-by: Boojin Kim

Re: [PATCH 12/15] spi/s3c64xx: Add support DMA engine API

2011-08-08 Thread Jassi Brar
On Mon, Aug 8, 2011 at 11:25 PM, Heiko Stübner he...@sntech.de wrote: Am Montag 08 August 2011, 19:47:58 schrieb Jassi Brar: Btw, this spi driver is for S3C64xx(with pl080) and S5P(with pl330) series, both of which have DMAENGINE drivers. May be it could be directly switched to using those

Re: [PATCH 13/15] spi/s3c64xx: Merge dma control code

2011-08-08 Thread Jassi Brar
On Wed, Jul 27, 2011 at 11:01 AM, Boojin Kim boojin@samsung.com wrote: This patch modifies to merge the dma control code. Original s3c64xx spi driver has each dma control code for rx and tx channel. This patch merges these dma control codes into one. With this patch, a dma setup function

Re: [PATCH 14/15] ASoC: Samsung: Update DMA interface

2011-08-08 Thread Jassi Brar
On Wed, Jul 27, 2011 at 11:01 AM, Boojin Kim boojin@samsung.com wrote:  static void dma_enqueue(struct snd_pcm_substream *substream)  {        struct runtime_data *prtd = substream-runtime-private_data;        dma_addr_t pos = prtd-dma_pos;        unsigned int limit; -       int ret; +

Re: [RFC PATCH] DMA: PL330: Update PL330 DMAC to support runtime PM

2011-07-27 Thread Jassi Brar
On Wed, Jul 27, 2011 at 11:44 AM, Chanwoo Choi cw00.c...@samsung.com wrote: This patch update runtime PM for PL330 DMAC to reduce power consumption. Signed-off-by: Chanwoo Choi cw00.c...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- The following patch support

Re: [PATCH 01/15] DMA: PL330: Add support runtime PM for PL330 DMAC

2011-07-27 Thread Jassi Brar
On Wed, Jul 27, 2011 at 11:01 AM, Boojin Kim boojin@samsung.com wrote: Signed-off-by: Boojin Kim boojin@samsung.com Cc: Vinod Koul vinod.k...@intel.com Cc: Dan Williams dan.j.willi...@intel.com Signed-off-by: Kukjin Kim kgene@samsung.com Acked-by: Jassi Brar jassisinghb

Re: [PATCH V4 06/14] ARM: SAMSUNG: Add common DMA operations

2011-07-27 Thread Jassi Brar
On Wed, Jul 27, 2011 at 10:47 AM, Boojin Kim boojin@samsung.com wrote: Jassi Brar wrote: Sent: Wednesday, July 27, 2011 10:34 AM To: Boojin Kim Cc: linux-arm-ker...@lists.infradead.org; linux-samsung- s...@vger.kernel.org; Vinod Koul; Dan Williams; Kukjin Kim; Grant Likely; Mark Brown

Re: [PATCH] Improve slave/cyclic DMA engine documentation (was: [PATCH V4 04/14] DMA: PL330: Add DMA_CYCLIC capability)

2011-07-26 Thread Jassi Brar
On Tue, Jul 26, 2011 at 3:05 PM, Vinod Koul vk...@infradead.org wrote: On Tue, 2011-07-26 at 08:57 +0100, Russell King - ARM Linux wrote: Here's an updated patch. 8-- From: Russell King rmk+ker...@arm.linux.org.uk DMAEngine: Improve slave/cyclic documentation Improve the

Re: [PATCH V4 06/14] ARM: SAMSUNG: Add common DMA operations

2011-07-26 Thread Jassi Brar
On Tue, Jul 26, 2011 at 11:44 PM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: 1. Arrange for individual DMA engine drivers to provide a filter   function - eg, pl08x_filter_id() for pl08x channels. 2. Have the filter function check chan-device-dev-driver == its   own struct

Re: [PATCH V4 06/14] ARM: SAMSUNG: Add common DMA operations

2011-07-26 Thread Jassi Brar
On Tue, Jul 26, 2011 at 3:05 PM, Boojin Kim boojin@samsung.com wrote: Jassi Brar Wrote: Sent: Monday, July 25, 2011 8:52 PM To: Boojin Kim Cc: linux-arm-ker...@lists.infradead.org; linux-samsung- s...@vger.kernel.org; Vinod Koul; Dan Williams; Kukjin Kim; Grant Likely; Mark Brown

Re: [PATCH V4 04/14] DMA: PL330: Add DMA_CYCLIC capability

2011-07-25 Thread Jassi Brar
On Mon, Jul 25, 2011 at 6:58 AM, Boojin Kim boojin@samsung.com wrote: This patch adds DMA_CYCLIC capability that is used for audio driver. DMA driver with DMA_CYCLIC capability reuses the dma requests that were submitted through tx_submit(). Signed-off-by: Boojin Kim

Re: [PATCH V4 05/14] ARM: SAMSUNG: Update to use PL330-DMA driver

2011-07-25 Thread Jassi Brar
On Mon, Jul 25, 2011 at 6:58 AM, Boojin Kim boojin@samsung.com wrote: diff --git a/arch/arm/plat-samsung/Kconfig b/arch/arm/plat-samsung/Kconfig index 4d79519..cb170a6 100644 --- a/arch/arm/plat-samsung/Kconfig +++ b/arch/arm/plat-samsung/Kconfig @@ -300,6 +300,14 @@ config S3C_PL330_DMA

Re: [PATCH V4 06/14] ARM: SAMSUNG: Add common DMA operations

2011-07-25 Thread Jassi Brar
On Mon, Jul 25, 2011 at 6:58 AM, Boojin Kim boojin@samsung.com wrote: + +static bool pl330_filter(struct dma_chan *chan, void *param) +{ +       struct dma_pl330_peri *peri = (struct dma_pl330_peri *)chan-private; +       unsigned dma_ch = (unsigned)param; + +       if (peri-peri_id !=

Re: [PATCH V4 07/14] ARM: EXYNOS4: Use generic DMA PL330 driver

2011-07-25 Thread Jassi Brar
On Mon, Jul 25, 2011 at 6:58 AM, Boojin Kim boojin@samsung.com wrote: diff --git a/arch/arm/mach-exynos4/dma.c b/arch/arm/mach-exynos4/dma.c index 564bb53..e1c00cf 100644 --- a/arch/arm/mach-exynos4/dma.c +++ b/arch/arm/mach-exynos4/dma.c @@ -21,151 +21,250 @@  * Foundation, Inc., 675

Re: [PATCH V4 14/14] ARM: SAMSUNG: Remove Samsung specific enum type for dma direction

2011-07-25 Thread Jassi Brar
On Mon, Jul 25, 2011 at 6:58 AM, Boojin Kim boojin@samsung.com wrote: This patch removes the samsung specific enum type 's3c2410_dmasrc' and uses 'dma_data_direction' instead. Signed-off-by: Boojin Kim boojin@samsung.com Signed-off-by: Kukjin Kim kgene@samsung.com Acked-by: Jassi

Re: [PATCH V4 03-1/13] DMA: PL330: Support DMA_SLAVE_CONFIG command

2011-07-21 Thread Jassi Brar
On Thu, Jul 21, 2011 at 12:04 PM, Boojin Kim boojin@samsung.com wrote: Jassi Brar wrote: Sent: Thursday, July 21, 2011 2:00 PM To: Boojin Kim Cc: linux-arm-ker...@lists.infradead.org; linux-samsung-soc@vger.kernel.org; Vinod Koul; Dan Williams; Kukjin Kim Subject: Re: [PATCH V4 03-1/13

Re: [PATCH V4 03-1/13] DMA: PL330: Support DMA_SLAVE_CONFIG command

2011-07-21 Thread Jassi Brar
On Thu, Jul 21, 2011 at 3:53 PM, Linus Walleij linus.wall...@linaro.org wrote: On Thu, Jul 21, 2011 at 11:14 AM, Jassi Brar jassisinghb...@gmail.com wrote: On Thu, Jul 21, 2011 at 1:41 PM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Thu, Jul 21, 2011 at 12:47:49AM +0530, Jassi

Re: [PATCH V4 03-1/13] DMA: PL330: Support DMA_SLAVE_CONFIG command

2011-07-21 Thread Jassi Brar
On Thu, Jul 21, 2011 at 4:59 PM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: PL330 has fixed channels to peripherals. So FIFO addresses(burst_sz too?) should already be set via platform data. Client drivers shouldn't bother. That's utter crap, and isn't what the DMA engine API

Re: [PATCH V4 03-1/13] DMA: PL330: Support DMA_SLAVE_CONFIG command

2011-07-21 Thread Jassi Brar
On Thu, Jul 21, 2011 at 8:53 PM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Thu, Jul 21, 2011 at 08:42:40PM +0530, Jassi Brar wrote: On Thu, Jul 21, 2011 at 4:59 PM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: Does your hardware have a hardware block from the device

Re: [PATCH V4 03-1/13] DMA: PL330: Support DMA_SLAVE_CONFIG command

2011-07-21 Thread Jassi Brar
On Wed, Jul 20, 2011 at 4:16 PM, Boojin Kim boojin@samsung.com wrote: Signed-off-by: Boojin Kim boojin@samsung.com Signed-off-by: Kukjin Kim kgene@samsung.com ---  drivers/dma/pl330.c |   53 +-  1 files changed, 39 insertions(+), 14

Re: [PATCH V4 01/13] DMA: PL330: Add support runtime PM for PL330 DMAC

2011-07-20 Thread Jassi Brar
On Wed, Jul 20, 2011 at 4:16 PM, Boojin Kim boojin@samsung.com wrote: Signed-off-by: Boojin Kim boojin@samsung.com Cc: Vinod Koul vinod.k...@intel.com Cc: Dan Williams dan.j.willi...@intel.com Signed-off-by: Kukjin Kim kgene@samsung.com Acked-by: Jassi Brar jassisinghb

Re: [PATCH V4 03-1/13] DMA: PL330: Support DMA_SLAVE_CONFIG command

2011-07-20 Thread Jassi Brar
On Wed, Jul 20, 2011 at 4:16 PM, Boojin Kim boojin@samsung.com wrote: Signed-off-by: Boojin Kim boojin@samsung.com Signed-off-by: Kukjin Kim kgene@samsung.com ---  drivers/dma/pl330.c |   53 +-  1 files changed, 39 insertions(+), 14

Re: [PATCH V4 03-1/13] DMA: PL330: Support DMA_SLAVE_CONFIG command

2011-07-20 Thread Jassi Brar
On Thu, Jul 21, 2011 at 9:43 AM, Boojin Kim boojin@samsung.com wrote: -       pl330_tasklet((unsigned long) pch); +               list_splice_tail_init(list, pdmac-desc_pool); +               spin_unlock_irqrestore(pch-lock, flags); +               break; +       case

Re: [PATCH] ASoC: SAMSUNG: 24-bit audio playback on Exynos4210

2011-07-13 Thread Jassi Brar
On Wed, Jul 13, 2011 at 4:52 PM, Giridhar Maruthy giridhar.maru...@linaro.org wrote: Using 256fs or 512fs will result in distortion of 24-bit audio samples. This is because the lrclk generated is not proper. Using 384 fs generates proper output. Signed-off-by: Giridhar Maruthy

Re: [PATCH 3/7] DMA: PL330: Add DMA capabilities

2011-07-13 Thread Jassi Brar
On Thu, Jul 14, 2011 at 6:27 AM, boojin boojin@samsung.com wrote: Jassi Brar wrote: On Tue, Jul 5, 2011 at 12:03 PM, Chanho Park parkc...@gmail.com wrote: Kukjin Kim kgene.kim at samsung.com writes: (snip) +             if (slave_config-direction == DMA_TO_DEVICE

Re: [PATCH 6/7] spi/s3c64xx: Add support DMA engine API

2011-07-05 Thread Jassi Brar
On Tue, Jul 5, 2011 at 12:35 PM, Kukjin Kim kgene@samsung.com wrote: Grant Likely wrote: On Mon, Jul 04, 2011 at 09:51:43PM +0200, Heiko Stübner wrote: Am Montag 04 Juli 2011, 19:02:17 schrieb Grant Likely: On Mon, Jul 04, 2011 at 06:59:11PM +0200, Heiko Stübner wrote: Am Montag 04

Re: [PATCH 6/7] spi/s3c64xx: Add support DMA engine API

2011-07-05 Thread Jassi Brar
On Tue, Jul 5, 2011 at 4:57 PM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Tue, Jul 05, 2011 at 04:46:47PM +0530, Jassi Brar wrote: Ideally, like PL330 for S5P, drivers/dma/pl080 should be enabled for s3c64xx And new generic dma api drivers written for S3C24xx in drivers/dma

Re: [PATCH 2/2] SPI: SAMSUNG: Bug fix for SPI with different FIFO level

2011-07-01 Thread Jassi Brar
On Fri, Jul 1, 2011 at 11:29 AM, padma venkat padma@gmail.com wrote: Hi Jassi, On Fri, Jul 1, 2011 at 11:22 AM, Jassi Brar jassisinghb...@gmail.com wrote: On Fri, Jul 1, 2011 at 11:16 AM, padma venkat padma@gmail.com wrote: Hi Tony, On Thu, Jun 30, 2011 at 4:30 PM, Tony Nadackal ton

Re: [PATCH 2/2] SPI: SAMSUNG: Bug fix for SPI with different FIFO level

2011-06-30 Thread Jassi Brar
On Thu, Jun 30, 2011 at 6:08 PM, Padmavathi Venna padm...@samsung.com wrote: Fixed the bug in transmission status check for 64 bytes FIFO level. Signed-off-by: Padmavathi Venna padm...@samsung.com ---  drivers/spi/spi_s3c64xx.c |    4 +---  1 files changed, 1 insertions(+), 3 deletions(-)

Re: [PATCH 0/7] ARM: SAMSUNG: Cleanup SPI platform specific code

2011-06-30 Thread Jassi Brar
On Thu, Jun 30, 2011 at 5:55 PM, Padmavathi Venna padm...@samsung.com wrote: This patchset does the following: 1. Move duplicated code to common place [PATCH 1/7] ARM: SAMSUNG: Move SPI device definitions to plat-samsung SPI platform devices are defined in respective machine folder of

Re: [PATCH 3/7] ARM: SAMSUNG: Add SPI clock definitions for SAMSUNG SoCs

2011-06-30 Thread Jassi Brar
On Thu, Jun 30, 2011 at 3:00 PM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Thu, Jun 30, 2011 at 08:25:19AM -0400, Padmavathi Venna wrote: SPI Clocks were defined in dev-spi.c of machine specific folder. To make SPI devices common across all SoCs,dev-spi.c is moved from machine

Re: [PATCH 2/2] SPI: SAMSUNG: Bug fix for SPI with different FIFO level

2011-06-30 Thread Jassi Brar
On Thu, Jun 30, 2011 at 2:35 PM, padma venkat padma@gmail.com wrote: Hi, On Thu, Jun 30, 2011 at 12:38 PM, Jassi Brar jassisinghb...@gmail.com wrote: On Thu, Jun 30, 2011 at 6:08 PM, Padmavathi Venna padm...@samsung.com wrote: Fixed the bug in transmission status check for 64 bytes FIFO

Re: [PATCH 0/7] ARM: SAMSUNG: Cleanup SPI platform specific code

2011-06-30 Thread Jassi Brar
On Thu, Jun 30, 2011 at 2:57 PM, padma venkat padma@gmail.com wrote: Hi, On Thu, Jun 30, 2011 at 1:01 PM, Jassi Brar jassisinghb...@gmail.com wrote: On Thu, Jun 30, 2011 at 5:55 PM, Padmavathi Venna padm...@samsung.com wrote: This patchset does the following: 1. Move duplicated code

Re: [PATCH] ARM:SAMSUNG: DMA Cleanup as per sparse

2011-06-30 Thread Jassi Brar
On Thu, Jun 30, 2011 at 3:46 PM, Sangwook Lee sangwook@linaro.org wrote: Function declaration differs between file:s3c-pl330.c and file:dma.h and SPARSE (Documentation/sparse.txt) gives error messages Signed-off-by: Sangwook Lee sangwook@linaro.org Acked-by: Jassi Brar jassisinghb

Re: [PATCH 2/2] SPI: SAMSUNG: Bug fix for SPI with different FIFO level

2011-06-30 Thread Jassi Brar
On Fri, Jul 1, 2011 at 11:16 AM, padma venkat padma@gmail.com wrote: Hi Tony, On Thu, Jun 30, 2011 at 4:30 PM, Tony Nadackal ton...@gmail.com wrote: Hi Padma, With regards to your patch, even though one can check the tx done status using the TX_DONE bit, the present macro itself would

Re: [PATCH V2 1/4] ASoC: SAMSUNG: Modify I2S driver to support idma

2011-06-18 Thread Jassi Brar
On Wed, Jun 15, 2011 at 2:13 PM, Sangbeom Kim sbki...@samsung.com wrote: +#define AHB_INTENLVL0          (1 24) +#define AHB_LVL0INT            (1 20) +#define AHB_CLRLVL0INT         (1 16) +#define AHB_DMARLD             (1 5) +#define AHB_INTMASK            (1 3) +#define AHB_DMAEN  

Re: [PATCH 4/5] ARM: EXYNOS4: Add SPDIF for SMDKV310

2011-06-10 Thread Jassi Brar
*smdkv310_devices[] __initdata = {        exynos4_device_pd[PD_CAM],        exynos4_device_pd[PD_TV],        exynos4_device_pd[PD_GPS], +       exynos4_device_spdif,        exynos4_device_sysmmu,        exynos4_device_pcm0,        samsung_asoc_dma, Acked-by: Jassi Brar jassisinghb

Re: [PATCH 5/5] ASoC: SMDKV310: Enable SPDIF device

2011-06-10 Thread Jassi Brar
(MACH_SMDKC100 || MACH_SMDKC110 || MACH_SMDKV210) +       depends on SND_SOC_SAMSUNG (MACH_SMDKC100 || MACH_SMDKC110 || MACH_SMDKV210 || MACH_SMDKV310)        select SND_SAMSUNG_SPDIF        help          Say Y if you want to add support for SoC S/PDIF audio on the SMDK. Acked-by: Jassi Brar

Re: [PATCH 3/4] ASoC: SAMSUNG: Change platform driver for SMDKs

2011-06-10 Thread Jassi Brar
On Thu, Jun 9, 2011 at 1:39 PM, Sangbeom Kim sbki...@samsung.com wrote: Change platform driver to support internal dma for smdk_wm8994 and smdk_wm8580 Signed-off-by: Sangbeom Kim sbki...@samsung.com --- NAK. It will break the most common user - SMDK6410, as s3c6410 doesn't have any I2S

Re: [alsa-devel] [PATCH 3/4] ASoC: SAMSUNG: Change platform driver for SMDKs

2011-06-10 Thread Jassi Brar
On Fri, Jun 10, 2011 at 12:46 PM, Sangbeom Kim sbki...@samsung.com wrote: On Thu, Jun 9, 2011 at 4:04 PM, Jassi Brar wrote: NAK. It will break the most common user - SMDK6410, as s3c6410 doesn't have any I2S internal DMA. Please try to test the changes before submitting. I know it's boring

Re: [PATCH 2/4] ASoC: SAMSUNG: Add I2S0 internal dma driver

2011-06-10 Thread Jassi Brar
On Thu, Jun 9, 2011 at 1:39 PM, Sangbeom Kim sbki...@samsung.com wrote: I2S in Exynos4 and S5PC110(S5PV210) has a internal dma. It can be used low power audio mode and 2nd channel transfer. For my convenience, could you please tell how does it differ from my original implementation? Most

Re: [alsa-devel] [PATCH 3/4] ASoC: SAMSUNG: Change platform driver for SMDKs

2011-06-10 Thread Jassi Brar
On Fri, Jun 10, 2011 at 3:19 PM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Fri, Jun 10, 2011 at 12:56:45PM +0530, Jassi Brar wrote: On Fri, Jun 10, 2011 at 12:46 PM, Sangbeom Kim sbki...@samsung.com wrote: I only focused on S5PV210 and S5PV310. I didn't consider s3c and s5p

Re: [PATCH 1/4] ASoC: SAMSUNG: Modify I2S driver to support idma

2011-06-10 Thread Jassi Brar
On Thu, Jun 9, 2011 at 1:39 PM, Sangbeom Kim sbki...@samsung.com wrote:        case 2: +               if (substream-stream == SNDRV_PCM_STREAM_PLAYBACK) +                       i2s-dma_playback.dma_size = 4; +               else +                       i2s-dma_capture.dma_size = 4; +      

Re: [PATCH] ARM:SAMSUNG: Move S3C DMA driver to drivers/dma

2011-06-07 Thread Jassi Brar
On Tue, Jun 7, 2011 at 1:18 PM, root alim.akh...@samsung.com wrote: Signed-off-by: alim.akhtar alim.akh...@samsung.com ---  arch/arm/configs/exynos4_defconfig |    1 +  arch/arm/configs/s5p64x0_defconfig |    1 +  arch/arm/configs/s5pc100_defconfig |    1 +  

Re: [PATCH] ARM:SAMSUNG: Move S3C DMA driver to drivers/dma

2011-06-07 Thread Jassi Brar
On Tue, Jun 7, 2011 at 1:30 PM, Kyungmin Park kmp...@infradead.org wrote: As I know there's are PL330 DMA implementation by MODULE_AUTHOR(Jaswinder Singh jassi.b...@samsung.com); Thanks for CC'ing me, though my current contact is jaswinder.si...@linaro.org or jassisinghb...@gmail.com Perhaps I

Re: [PATCH] ARM:SAMSUNG: Move S3C DMA driver to drivers/dma

2011-06-07 Thread Jassi Brar
On Tue, Jun 7, 2011 at 1:45 PM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Tue, Jun 07, 2011 at 01:39:43PM +0530, Jassi Brar wrote: Unfortunately, no. There are some features of Samsung's DMA API that the drivers have come to rely upon. Besides, I am not particularly a fan

  1   2   >