Now that there is a .dtsi fragment file for the tps65090 PMU,
include it in the Exynos Snow DTS file to reduce duplication.
Signed-off-by: Javier Martinez Canillas
---
arch/arm/boot/dts/exynos5250-snow.dts | 108 +-
1 file changed, 54 insertions(+), 54 deletions
e FET
parent output voltage if the child voltage is queried.
Signed-off-by: Javier Martinez Canillas
---
arch/arm/boot/dts/cros-tps65090.dtsi | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/arch/arm/boot/dts/cros-tps65090.dtsi
b/arch/arm/boot/dts/cros-tps65090.dtsi
Peach Pit and Pi machines have the same regulators connection
and regulator name so the cros-tps65090 dtsi file can be used
to remove duplicated code.
Signed-off-by: Javier Martinez Canillas
---
arch/arm/boot/dts/exynos5420-peach-pit.dts | 95 +++---
arch/arm/boot/dts
Many Exynos5 boards (e.g: Snow, Peach Pit and Pi) have
a SBS-compliant gas gauge battery. Enable to built it
so the needed support is available for these boards.
Suggested-by: Doug Anderson
Signed-off-by: Javier Martinez Canillas
Acked-by: Kukjin Kim
Reviewed-by: Doug Anderson
---
Changes
Hello Doug,
On 08/11/2014 05:57 PM, Doug Anderson wrote:
> Javier,
>
> On Mon, Aug 11, 2014 at 4:38 AM, Javier Martinez Canillas
> wrote:
>> Both Exynos5420 Peach Pit and Exynos5800 Peach Pi boards
>> have a tps65090 PMU that has a number of switches (FETs)
>> th
Hello Bartlomiej,
On 08/11/2014 07:28 PM, Bartlomiej Zolnierkiewicz wrote:
>
> Hi,
>
> On Monday, August 11, 2014 06:23:01 PM Javier Martinez Canillas wrote:
>> Hello,
>>
>> On 08/11/2014 05:59 PM, Doug Anderson wrote:
>> > Bartlomiej,
>> >
Hello Mark,
On 08/11/2014 06:02 PM, Mark Brown wrote:
> On Mon, Aug 11, 2014 at 08:57:24AM -0700, Doug Anderson wrote:
>> On Mon, Aug 11, 2014 at 4:38 AM, Javier Martinez Canillas
>
>> > After the switch is turned on, a safety timer is started
>> > and before t
Hello,
On 08/11/2014 05:59 PM, Doug Anderson wrote:
> Bartlomiej,
>
> On Mon, Aug 11, 2014 at 8:42 AM, Bartlomiej Zolnierkiewicz
> wrote:
>>
>> Hi,
>>
>> On Monday, August 11, 2014 02:52:27 PM Javier Martinez Canillas wrote:
>>> Hello Bartlomie
Hello Bartlomiej,
On 08/11/2014 02:40 PM, Bartlomiej Zolnierkiewicz wrote:
>> index fc7d168..c390bb9 100644
>> --- a/arch/arm/configs/exynos_defconfig
>> +++ b/arch/arm/configs/exynos_defconfig
>> @@ -77,6 +77,7 @@ CONFIG_SPI_S3C64XX=y
>> CONFIG_I2C_S3C2410=y
>> CONFIG_DEBUG_GPIO=y
>> CONFIG_PO
e FET
parent output voltage if the child voltage is queried.
Signed-off-by: Javier Martinez Canillas
Acked-by: Mark Brown
---
arch/arm/boot/dts/exynos5420-peach-pit.dts | 12 ++--
arch/arm/boot/dts/exynos5800-peach-pi.dts | 12 ++--
2 files changed, 12 insertions(+), 12 deletions(-)
as bounded limits for the timeout. That is what
is used in the board schematics and should be in the DT too.
Signed-off-by: Javier Martinez Canillas
---
arch/arm/boot/dts/exynos5420-peach-pit.dts | 14 ++
arch/arm/boot/dts/exynos5800-peach-pi.dts | 14 ++
2 files changed
Many Exynos5 boards (e.g: Snow, Peach Pit and Pi) have
a SBS-compliant gas gauge battery. Enable it as module
so the needed support is available for these boards.
Suggested-by: Doug Anderson
Signed-off-by: Javier Martinez Canillas
Acked-by: Kukjin Kim
---
arch/arm/configs/exynos_defconfig | 1
Hello Linus,
On 08/11/2014 10:32 AM, Linus Walleij wrote:
> I guess this discussion is about drivers/pinctrl/samsung/pinctrl-exynos.c?
>
> Or else I'm not really following this... $SUBJECT is a bit confusing.
>
Yes, the thing is that at the beginning I (wrongly) thought that the IRQ trigger
typ
ned-off-by: Javier Martinez Canillas
---
This patch solves the issue explained in https://lkml.org/lkml/2014/8/8/461
drivers/pinctrl/samsung/pinctrl-exynos.c | 69 ---
drivers/pinctrl/samsung/pinctrl-samsung.h | 1 +
2 files changed, 64 insertions(+), 6 deletions(-)
Hello Doug,
On 08/08/2014 10:54 PM, Doug Anderson wrote:
> Hi,
>>
>> To fix the issue a variation of patch [0] will be posted that moves the IRQ
>> pinmux setup from .irq_set_type to the .irq_request_resources function
>> handler.
>> That way the pin will be setup as IRQ regardless of the the tri
Hello,
On 08/08/2014 06:38 PM, Javier Martinez Canillas wrote:
>
>
> It seems as if the first call to exynos_irq_set_type() that is made by OF is a
> no-op while the second call is the one that actually setups the hw correctly.
> Does this make any sense? Maybe is related to th
+Thomas Gleixner, Jason Cooper, Benjamin Herrenschmidt and Thomas Abraham
Hello Dmitry,
On 08/08/2014 06:21 PM, Dmitry Torokhov wrote:
> On Fri, Aug 08, 2014 at 03:07:33PM +0100, Nick Dyer wrote:
>> On 07/08/14 08:44, Javier Martinez Canillas wrote:
>> > The Atmel maXTouch d
number of GPIOs on the device. The number
> 4 is wrong, the protocol does allow for up to 8 GPIOs. But it is a hard limit.
>
Thanks a lot for the explanation, then I guess s/4/8 is enough.
>>
>> Signed-off-by: Javier Martinez Canillas
>> ---
>> Documentation/dev
Hello,
On 08/07/2014 06:47 PM, Dmitry Torokhov wrote:
>
> Actually, I take this back. In mainline everything as it should: if
> pdata does not specify particular trigger the flags requested end up
> being IRQF_ONESHOT, which should preserve trigger bits previously set up
> by the board or OF code
On 08/08/2014 02:24 PM, Bartlomiej Zolnierkiewicz wrote:
>
> It seems that Daniel Drake has already fixed ODROID dtsi with:
>
> [PATCH 1/2] ARM: dts: Enable PMIC interrupts on ODROID
> http://www.mail-archive.com/linux-samsung-soc@vger.kernel.org/msg34191.html
>
> and
>
> [PATCH 2/2] ARM:
Hello Krzysztof,
On 08/08/2014 12:54 PM, Krzysztof Kozlowski wrote:
>> >>
>> >> Not sufficient. You have to also fix RTC driver (OOPS from Trats2
>> >> attached). Also consider adding checks for (max77686->irq) to the
>> >> suspend and resume.
>> >>
>> >
>> > Right, the max77686 RTC driver assu
Hello,
On 08/08/2014 10:58 AM, Javier Martinez Canillas wrote:
>
>>
>> Not sufficient. You have to also fix RTC driver (OOPS from Trats2
>> attached). Also consider adding checks for (max77686->irq) to the
>> suspend and resume.
>>
>
> Right, the max7
Hello Krzysztof and Bartlomiej,
On 08/08/2014 09:59 AM, Krzysztof Kozlowski wrote:
> On czw, 2014-08-07 at 18:09 +0200, Bartlomiej Zolnierkiewicz wrote:
>> Before commit 6f1c1e71d933 ("mfd: max77686: Convert to use regmap_irq")
>> max77686_irq_init() return value was never checked so devices witho
Hello,
On 08/04/2014 05:42 PM, Doug Anderson wrote:
>
>
>> For the touchpad it seems DT support has landed in the input tree as
>> "atmel,maxtouch". Backporting just that patch does not make it work
>> though. (Tried the rejected pinctrl approach to be on the safe side.)
>> https://code.google.c
Hello Dmitry,
On 08/07/2014 08:09 AM, Dmitry Torokhov wrote:
>>
>> > irq_of_parse_and_map() already sets up IRQ trigger type based on DT
>> > data, by calling irq_create_of_mapping() which in turn calls
>> > irq_set_irq_type().
>> >
>>
>> Right but somehow when the IRQ is actually requested the
type
than IRQ_TYPE_NONE. The right approach is to get the IRQ flags
that was parsed by OF from the "interrupt" Device Tree propery.
Signed-off-by: Javier Martinez Canillas
---
This patch was first sent as a part of a two part series along
with [PATCH 2/2] Input: atmel_mxt_ts - Add keyc
Hello Fabio,
On 08/07/2014 03:35 AM, Fabio Estevam wrote:
> On Wed, Aug 6, 2014 at 10:08 PM, Javier Martinez Canillas
> wrote:
>
>> +&hsi2c_8 {
>> + status = "okay";
>> + clock-frequency = <333000>;
>
> Doesn't it work a
Hello Tomasz,
Thanks a lot for your feedback.
On 08/07/2014 03:14 AM, Tomasz Figa wrote:
> Hi Javier,
>
>
> Have you observed an actual failure due to this? I believe that
Yes, I found this issue since the driver was not taking into account the value
defined in the edge/level type cells from t
From: Sjoerd Simons
The Peach Pit and Pi boards have an Atmel maXTouch device.
Add the needed Device Tree nodes to support it.
Signed-off-by: Sjoerd Simons
[javier.martinez: added linux,gpio-keymap property and changed IRQ type]
Signed-off-by: Javier Martinez Canillas
---
With only this
four entries but the driver dynamically allocates the
keymap array and does not limit the array size.
Signed-off-by: Javier Martinez Canillas
---
Documentation/devicetree/bindings/input/atmel,maxtouch.txt | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/Documentation
type
than IRQ_TYPE_NONE. The right approach is to get the IRQ flags
that was parsed by OF from the "interrupt" Device Tree propery.
Signed-off-by: Javier Martinez Canillas
---
drivers/input/touchscreen/atmel_mxt_ts.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
di
Hello Doug,
On 08/04/2014 05:42 PM, Doug Anderson wrote:
>
>
>> Both of you mentioned limitations of cros_ec i2c passthrough leading to
>> a forked tps65090 driver downstream - I don't think I can be of help
>> there, as I guess simply copying a driver will not be an option. ;)
>> https://code.g
Hello Doug,
On 08/04/2014 05:22 PM, Doug Anderson wrote:
>> +
>> +&pinctrl_0 {
>> + s5m8767_dvs: s5m8767-dvs {
>> + samsung,pins = "gpd1-0", "gpd1-1", "gpd1-2";
>> + samsung,pin-function = <0>;
>> + samsung,pin-pud = <1>;
>> + samsung,p
d-by: Olof Johansson
Signed-off-by: Javier Martinez Canillas
---
drivers/power/sbs-battery.c | 115
1 file changed, 115 insertions(+)
diff --git a/drivers/power/sbs-battery.c b/drivers/power/sbs-battery.c
index b5f2a76..08feb38 100644
--- a/drivers
: Simon Que
Reviewed-by: Simon Glass
Reviewed-by: Todd Broch
Signed-off-by: Javier Martinez Canillas
---
drivers/power/sbs-battery.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/drivers/power/sbs-battery.c b/drivers/power/sbs-battery.c
index 08feb38..c7b7b40
This series add the model_name, manufacturer and voltage_min_design
files from the power supply monitor class sysfs interface that were
missing for the sbs-battery driver. The commits were taken from the
Chrome OS 3.8 downstream kernel and patches were squashed when they
just fixed bugs introduced
Cc: Doug Anderson
> Cc: Javier Martinez Canillas
> Cc: Andreas Faerber
> Cc: Sachin Kamat
> Signed-off-by: Thomas Abraham
> ---
> arch/arm/boot/dts/exynos4210-origen.dts |4 +++
> arch/arm/boot/dts/exynos4210-trats.dts |4 +++
> arch/arm/boo
ies looks good to me. So
for the remaining patches:
Reviewed-by: Javier Martinez Canillas
NOTE: I thought that Tomasz Figa gave you his Reviewed-by on v5 for the whole
series as well but I didn't see his tag on the v6 patches.
Best regards,
Javier
--
To unsubscribe from this list: send th
Hello Andreas,
Sorry for missing your v5.
On 08/02/2014 02:52 AM, Andreas Färber wrote:
>
> chosen {
> + bootargs = "console=tty1";
> };
While I agree with you that having a chosen node with a default bootargs is
better than having an empty one, I second Doug that this
Hello Wolfram,
On 08/01/2014 07:59 PM, Wolfram Sang wrote:
>>
>> +#define I2C_MAX_RETRIES 3
>
> I think a define for this is overkill, yet I don't really mind.
>
> Acked-by: Wolfram Sang
>
Thanks a lot.
> I assume this goes via MFD, let me know if I should take it.
>
Yes, if possible I pre
gt;
True, these also matches the .supply_name used when registering the
LDO[1-2] regulators in the tps65090 driver. So clearly the example was
wrong while the property specification is correct.
Reviewed-by: Javier Martinez Canillas
Best regards,
Javier
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
ed. So the regulator core needs to fetch
the FET parent output voltage if the child voltage is queried.
[0]: http://www.ti.com/lit/gpn/tps65090
Signed-off-by: Javier Martinez Canillas
---
Changes since RFC:
- Use better names to describe the macro used to create the regulator desc.
Suggested by
as bounded limits for the timeout. That is what
is used in the board schematics and should be in the DT too.
Signed-off-by: Javier Martinez Canillas
---
arch/arm/boot/dts/exynos5420-peach-pit.dts | 14 ++
arch/arm/boot/dts/exynos5800-peach-pi.dts | 14 ++
2 files changed
e FET
parent output voltage if the child voltage is queried.
Signed-off-by: Javier Martinez Canillas
Acked-by: Mark Brown
---
arch/arm/boot/dts/exynos5420-peach-pit.dts | 12 ++--
arch/arm/boot/dts/exynos5800-peach-pi.dts | 12 ++--
2 files changed, 12 insertions(+), 12 deletions(-)
aints for the switches.
Javier Martinez Canillas (2):
ARM: dts: Improve Peach Pit and Pi power scheme model
ARM: dts: Add tps65090 FET constraints on Peach Pit and Pi
arch/arm/boot/dts/exynos5420-peach-pit.dts | 26 --
arch/arm/boot/dts/exynos5800-peach-pi.dts
On 07/29/2014 08:26 PM, Mark Brown wrote:
> On Tue, Jul 29, 2014 at 06:28:55PM +0200, Javier Martinez Canillas wrote:
>> Load switches are modeled as regulators but they just provide
>> the voltage of their parent input supply. So the drivers for
>
> Applied, thanks. The te
On 07/29/2014 07:36 PM, Mark Brown wrote:
> On Tue, Jul 29, 2014 at 06:28:58PM +0200, Javier Martinez Canillas wrote:
>
>> +#define tps65090_REG_VAR(_id, _sname, en_reg, _en_bits, _ops) \
>> +tps65090_REG_DESC(_id, _sname, en_reg, _en_bits, 0, 0, _ops)
>
> I
On 07/29/2014 07:20 PM, Mark Brown wrote:
> On Tue, Jul 29, 2014 at 06:28:59PM +0200, Javier Martinez Canillas wrote:
>> The DeviceTree files for the Peach Pit and Pi machines have
>> a simplistic model of the connections between the different
>> regulators since not all th
Hello Mark, thanks a lot for all your feedback.
On 07/29/2014 07:18 PM, Mark Brown wrote:
> On Tue, Jul 29, 2014 at 06:28:57PM +0200, Javier Martinez Canillas wrote:
>>
>> But for load switches that don't define a voltage output, the parent
>> supply voltage is used
rrent voltage rail.
So, if the output voltage for a regulator is not available and
it has a parent supply, then pass the voltage of its parent.
Signed-off-by: Javier Martinez Canillas
---
drivers/regulator/core.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/regulator/core.c b/dr
provide this
information (e.g: cpufreq and mmc subsystems).
If the voltage count and list are not available for a regulator
and it has a parent input supply, then use the parent values.
Signed-off-by: Javier Martinez Canillas
---
drivers/regulator/core.c | 23 +--
1 file
utput, the parent
supply voltage is used so the constraints should only be applied if
they were defined for the child regulators.
Signed-off-by: Javier Martinez Canillas
---
drivers/regulator/core.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/regulator/core.c
ent supply voltage is used.
[0]: http://www.ti.com/lit/gpn/tps65090
Signed-off-by: Javier Martinez Canillas
---
drivers/regulator/tps65090-regulator.c | 34 +-
1 file changed, 21 insertions(+), 13 deletions(-)
diff --git a/drivers/regulator/tps65090-regulator.c
supply from the DCDC1 and DCDC2 output voltage rails.
This information has to be present in the DTS since fets
are switches that don't provide an output voltage so when
this is needed, the parent input supply voltage is queried.
Signed-off-by: Javier Martinez Canillas
---
arch/arm/boo
5420 Peach Pit board
and is composed of the following patches:
Javier Martinez Canillas (5):
regulator: core: Get voltage from parent if not available
regulator: core: Allow to get voltage count and list from parent
regulator: core: Only apply constraints if available on list voltage
Hello Andreas,
On Tue, Jul 29, 2014 at 3:00 PM, Andreas Färber wrote:
> Hi Javier and Doug,
>
>
> Hm, in different context it was stated that device trees shouldn't rely
> on bootloader behavior (for a /memory node on Zynq we ended up
> specifying the size cell with the real value despite U-Boot
Hello Andreas,
On 07/29/2014 02:34 PM, Andreas Färber wrote:
> Hi Javier,
>
> Am 28.07.2014 14:19, schrieb Javier Martinez Canillas:
>> From: Todd Broch
>>
>> If the EC device tree node has sub-nodes, try to instantiate them as
>> MFD sub-devices. We can conf
Hi Andreas,
On 07/29/2014 02:27 PM, Andreas Färber wrote:
> Hi Javier,
>
> Am 28.07.2014 14:19, schrieb Javier Martinez Canillas:
>> The patches in this series are authored by different people
>> (all on cc) and consist of the following:
>>
>> Andrew Bresti
From: Todd Broch
Previous algorithm was a bit conservative and complicating with
respect to identifying key ghosting. This CL uses the bitops hamming
weight function (hweight8) to count the number of matching rows for
colM & colN. If that number is > 1 ghosting is present.
Additionally it remo
From: Andrew Bresticker
Instead of having users of the ChromeOS EC call the interface-specific
cmd_xfer() callback directly, introduce a central cros_ec_cmd_xfer()
to use instead. This will allow us to put all the locking and retry
logic in one place instead of duplicating it across the differen
This is a second batch of cleanups patches for the mfd cros_ec
driver and its subdevices drivers. The first batch of cleanups
was posted by Doug Anderson [0] and have already been merged.
The patches were picked from the ChromeOS 3.8 kernel and after
these no cleanups patches for cros_ec are left,
From: Andrew Bresticker
Now that there's a central cros_ec_cmd_xfer(), move the locking
out of the SPI and LPC drivers.
Signed-off-by: Andrew Bresticker
Reviewed-by: Simon Glass
---
drivers/mfd/cros_ec.c | 10 +-
drivers/mfd/cros_ec_spi.c | 11 ---
2 files changed, 9 inser
From: Doug Anderson
If someone sends a EC_CMD_REBOOT_EC to the EC, the EC will likely be
unresponsive for quite a while. Add a delay to the end of the command
to prevent random failures of future commands.
NOTES:
* This could be optimized a bit by simply delaying the next command
sent, but EC
From: Todd Broch
If the EC device tree node has sub-nodes, try to instantiate them as
MFD sub-devices. We can configure the EC features provided by the board.
Signed-off-by: Todd Broch
---
drivers/mfd/cros_ec.c | 40 ++--
1 file changed, 30 insertions(+), 1
From: Derek Basehore
Since the i2c bus can get wedged on the EC sometimes, set the number of retries
to 3. Since we un-wedge the bus immediately after the wedge happens, this is the
correct fix since only one transfer will fail.
Signed-off-by: Derek Basehore
Reviewed-by: Doug Anderson
---
dri
From: Andrew Bresticker
When an EC command returns EC_RES_IN_PROGRESS, we need to query
the state of the EC until it indicates that it is no longer busy.
Do this in cros_ec_cmd_xfer() under the EC's mutex so that other
commands (e.g. keyboard, I2C passtru) aren't issued to the EC while
it is work
Hello Mike,
On 07/26/2014 12:31 AM, Mike Turquette wrote:
> Quoting Javier Martinez Canillas (2014-07-14 04:35:56)
>> This series are based on drivers added by Simon Glass to the Chrome OS
>> kernel and adds support for the Maxim 77802 Power Management IC, their
>> regulators
Hello Doug,
On Fri, Jul 25, 2014 at 6:43 PM, Doug Anderson wrote:
> Javier,
>
> On Fri, Jul 25, 2014 at 9:35 AM, Javier Martinez Canillas
> wrote:
>> Hello Andreas,
>>
>> On Fri, Jul 18, 2014 at 7:20 PM, Andreas Färber wrote:
>>>
>>> +
Hello Andreas,
On Fri, Jul 18, 2014 at 7:20 PM, Andreas Färber wrote:
>
> + memory {
> + reg = <0x4000 0x8000>;
> + };
> +
> + chosen {
> + };
> +
Is there a reason for an empty chosen node? Same for the Spring DTS.
Best regards,
Javier
--
To unsubs
Many Exynos5 boards (e.g: Snow, Peach Pit and Pi) have
a SBS-compliant gas gauge battery. Enable it as module
so the needed support is available for these boards.
Suggested-by: Doug Anderson
Signed-off-by: Javier Martinez Canillas
---
arch/arm/configs/exynos_defconfig | 1 +
1 file changed, 1
, clocks outputs and the RTC.
This patch adds support for MAX77802 to the MAX77686 driver and is
based on a driver added to the Chrome OS kernel 3.8 by Simon Glass.
Signed-off-by: Javier Martinez Canillas
Reviewed-by: Krzysztof Kozlowski
Acked-by: Lee Jones
---
This patch was part of a series [0
e(mmc->supply.vmmc) and
regulator_disable(mmc->supply.vmmc) by mmc_regulator_set_ocr(mmc,
mmc->supply.vmmc, ios->vdd) and mmc_regulator_set_ocr(mmc,
mmc->supply.vmmc, 0) respectively in your original patch.
Best regards,
Javier
[0]: http://lxr.free-electrons.com/source/drivers/mmc/c
On 07/22/2014 02:10 AM, Mark Brown wrote:
> On Mon, Jul 21, 2014 at 02:44:07PM +0200, Javier Martinez Canillas wrote:
>> On 07/14/2014 01:35 PM, Javier Martinez Canillas wrote:
>
>> Mark, Mike and Alessandro,
>
>> This is a gentle reminder to look at the patches t
Hello Lee,
On 07/14/2014 01:35 PM, Javier Martinez Canillas wrote:
>
> * Patches 1-7 from v7 are not included since those were improvements to
> the max77686 mfd driver and can be applied independently. Lee Jones said
> that he is going to pick them from the posted v7 series.
>
Hello Russell,
On Fri, Jul 18, 2014 at 12:44 AM, Russell King - ARM Linux
wrote:
> On Fri, Jul 18, 2014 at 12:31:48AM +0200, Javier Martinez Canillas wrote:
>> In the case of the MAX77686, the mfd, regulator and clock drivers use
>> subsys_initcall() instead of module_init() but
4xx: for DT platofrms always get the chipselect info from
> DT node) to work properly and match the documented bindings. See
> <https://patchwork.kernel.org/patch/4346701/> and
> <https://patchwork.kernel.org/patch/4346711/>
>
> Signed-off-by: Doug Anderson
>
Hello,
On Tue, Jul 15, 2014 at 5:59 PM, Doug Anderson wrote:
>
> Is there a reason not to add more of the max77686 configs?
>
> +CONFIG_RTC_DRV_MAX77686=y
> +CONFIG_COMMON_CLK_MAX77686=y
AFAIK for the multi-platform defconfig we should try to build as a
module as many config options as possible
Hello,
On 07/14/2014 09:24 PM, Doug Anderson wrote:
>
>> [WARN] [2.296011] tps65090-charger tps65090-charger: Unable to get
>> charger irq = -22
>> [WARN] [2.313705] tps65090-charger: probe of tps65090-charger
>> failed with error -22
>
> I have resent the patch to fix this 4 times with
Hello Mark,
On 07/17/2014 08:46 PM, Mark Brown wrote:
> On Wed, Jul 16, 2014 at 05:19:07PM +0200, Javier Martinez Canillas wrote:
>> This reverts commit 3146beec21b64f4551fcf0ac148381d54dc41b1b.
>
> For the benefit of those who haven't memorized the SHA1s of every commit
&g
el.org/patch/4042751/> and the
> rest of the series has long since landed.
>
Looks good to me. Also since this patch makes optional to get an IRQ, the
following annoying message is not shown anymore:
[2.132944] tps65090-charger tps65090-charger: Unable to get charger irq = -6
Review
Hello Naveen,
On Thu, Jul 17, 2014 at 6:21 AM, Naveen Krishna Ch
wrote:
>
> Can you pull the 3/4 and 4/4 patches.
>
Patch 4/4 depends on the max77802 support series [0] since the ADC
uses the max77802 ldo9 regulator as its voltage supply. So that patch
can't be merged before the series land in m
On 07/16/2014 06:02 PM, Mark Brown wrote:
> On Wed, Jul 16, 2014 at 05:19:06PM +0200, Javier Martinez Canillas wrote:
>
> *sigh* Yesterday Naveen submitted another, different, patch series also
> attempting to improve things which I'm not seeing any reference to here.
> Pl
with the
same name (cs-gpio) on different nodes is confusing at least.
d) The new property was not added to the DT binding doc:
Documentation/devicetree/bindings/spi/spi-samsung.txt
Signed-off-by: Javier Martinez Canillas
Reviewed-by: Tomasz Figa
---
drivers/spi/spi-s3c64xx.c | 37
broke
the DT binding backward compatibility in the first place.
Signed-off-by: Naveen Krishna Chatradhi
[javier.marti...@collabora.co.uk: split changes and improve commit message]
Signed-off-by: Javier Martinez Canillas
Reviewed-by: Tomasz Figa
---
drivers/spi/spi-s3c64xx.c | 49
f-by: Naveen Krishna Chatradhi
Reviewed-by: Javier Martinez Canillas
Reviewed-by: Tomasz Figa
---
arch/arm/boot/dts/exynos4210-smdkv310.dts | 2 +-
arch/arm/boot/dts/exynos4412-trats2.dts | 2 +-
arch/arm/boot/dts/exynos5250-smdk5250.dts | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
From: Naveen Krishna Chatradhi
Samsung SPI driver now uses the generic SPI "cs-gpios"
binding so update the documentation accordingly.
Signed-off-by: Naveen Krishna Chatradhi
[javier.marti...@collabora.co.uk: split changes and improve commit message]
Signed-off-by: Javier Martine
work them to provide
an easier to understand patch series.
The series is composed of the following patches:
Javier Martinez Canillas (1):
Revert "spi: s3c64xx: Added provision for dedicated cs pin"
Naveen Krishna Chatradhi (3):
spi: s3c64xx: use the generic SPI "cs-g
Hello Naveen,
On 07/15/2014 07:49 PM, Tomasz Figa wrote:
>
> In general, I liked previous version of this series much more, as it was
> doing what it should as opposed to this one.
>
> Best regards,
> Tomasz
>
I agree with Tomasz. I think version v6 of your series was (almost) correct
while th
Hello Mark,
I agree that the commit message could have a better description and I
understand your concerns. I'm not an SPI expert by any means but I did
my best to review the patches and provide feedback to Naveen on the
first iterations of the series.
On Mon, Jul 14, 2014 at 7:25 PM, Mark Brown
This patch adds a dt-binding include for Maxim 77686
PMIC clock IDs that can be used by both the max77686
clock driver and Device Tree source files.
Signed-off-by: Javier Martinez Canillas
Reviewed-by: Krzysztof Kozlowski
Reviewed-by: Mike Turquette
---
Changes since v6: None
Changes since
driver was original merged in
commit fca1dd03 ("rtc: max77686: add Maxim 77686 driver").
So, since this code has never been built, let's just remove it.
Signed-off-by: Javier Martinez Canillas
Reviewed-by: Krzysztof Kozlowski
---
drivers/rtc/rtc-m
The MAX77802 PMIC has two 32.768kHz Buffered Clock Outputs with
Low Jitter Mode. This patch adds support for these two clocks.
Signed-off-by: Javier Martinez Canillas
Reviewed-by: Krzysztof Kozlowski
---
Changes since v6: None
Changes since v5: None
Changes since v4: None
Changes since v3
The MAX77802 PMIC has 10 high-efficiency Buck and 32 Low-dropout
(LDO) regulators. This patch adds support for all these regulators
found on the MAX77802 PMIC and is based on a driver added by Simon
Glass to the Chrome OS kernel 3.8 tree.
Signed-off-by: Javier Martinez Canillas
Tested-by: Naveen
ks outputs.
Also, explain that the clocks identifiers are defined in a
header file that can be included by Device Tree source with
client nodes to avoid using magic numbers.
Finally, add "clock-output-names" as an optional property
since now is supported by the clock driver.
Signed-off
Maxim Integrated Power Management ICs are very similar with
regard to their clock outputs. Most of the clock drivers for
these chips are duplicating code and are simpler enough that
can be converted to use a generic driver to consolidate code
and avoid duplication.
Signed-off-by: Javier Martinez
up before the max77686 wakeup runs.
Signed-off-by: Doug Anderson
Reviewed-by: Javier Martinez Canillas
Reviewed-by: Krzysztof Kozlowski
---
Changes since v6: None
Changes since v5:
- Fix $SUBJECT since the patch does not actually touch the mfd subsys.
Suggested by Lee Jones.
Changes sinc
Add Device Tree binding documentation for the clocks
outputs in the Maxim 77802 Power Management IC.
Signed-off-by: Javier Martinez Canillas
---
Changes since v6: None
Changes since v5:
- Fix typo error in DT binding. Suggested by Andreas Farber.
- Add "clock-output-names" as a
The MAX7802 PMIC has a Real-Time-Clock (RTC) with two alarms.
This patch adds support for the RTC and is based on a driver
added by Simon Glass to the Chrome OS kernel 3.8 tree.
Signed-off-by: Javier Martinez Canillas
Reviewed-by: Krzysztof Kozlowski
---
Changes since v6:
- Remove unused code
Clocks drivers for Maxim PMIC are very similar so they can
be converted to use the generic Maxim clock driver.
Also, while being there use module_platform_driver() helper
macro to eliminate more boilerplate code.
Signed-off-by: Javier Martinez Canillas
Reviewed-by: Krzysztof Kozlowski
.
Signed-off-by: Javier Martinez Canillas
Tested-by: Naveen Krishna Chatradhi
---
Changes since v7:
- Change Buck2 and 3 regulator name to "vdd_arm" and "vdd_int".
Suggested by Naveen Krishna Chatradhi.
- Remove DVS properties since this is going to be added as a follow u
1101 - 1200 of 1393 matches
Mail list logo
