On Thu, 2015-09-03 at 13:33 +0800, Yakir Yang wrote:
[]
> diff --git a/drivers/gpu/drm/exynos/exynos_dp_core.c
[]
> @@ -155,24 +156,22 @@ static int exynos_dp_read_edid(struct
> exynos_dp_device *dp)
> }
> exynos_dp_read_byte_from_dpcd(dp, DP_TEST_RE
On Thu, 2015-08-06 at 09:04 -0500, Yakir Yang wrote:
> make checkpatch.pl script happy
That should not be the primary reason to submit a patch.
Making it easier for human code reader to understand
what the code does should be though.
> diff --git a/drivers/gpu/drm/exynos/exynos_dp_core.c
> b/dr
On Sun, 2014-12-07 at 20:20 +0100, Julia Lawall wrote:
> These patches replace what appears to be a reference to the name of the
> current function but is misspelled in some way by either the name of the
> function itself, or by %s and then __func__ in an argument list.
At least a few of these see
On Fri, 2014-09-19 at 21:27 +0200, Javier Martinez Canillas wrote:
> Hello Joe,
Hello Javier.
> On 09/19/2014 04:39 PM, Joe Perches wrote:
> > On Fri, 2014-09-19 at 12:26 +0200, Javier Martinez Canillas wrote:
> >> The function max77686_rtc_calculate_wday() is used to
>
On Fri, 2014-09-19 at 12:26 +0200, Javier Martinez Canillas wrote:
> The function max77686_rtc_calculate_wday() is used to
> calculate the day of the week to be filled in struct
> rtc_time but that function only calculates the number
> of bits shifted. So the ffs() function can be used to
> find th
-off-by: Arnd Bergmann
> Cc: Joe Perches
> Cc: Greg Kroah-Hartman
> Cc: Doug Anderson
> Cc: Kukjin Kim
>
> diff --git a/drivers/tty/serial/samsung.c b/drivers/tty/serial/samsung.c
> index 3293377..c1d3ebd 100644
> --- a/drivers/tty/serial/samsung.c
> +++ b/drivers/t
On Sat, 2014-03-22 at 14:01 -0500, Vince Bridgers wrote:
> See comments inline
Do please trim your comments instead of quoting the
_whole_ email.
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo i
On Tue, 2014-03-18 at 11:19 -0700, Byungho An wrote:
> From: Siva Reddy
>
> This patch adds support for Samsung 10Gb ethernet driver(sxgbe).
More trivia, nothing that should stop this from
being applied and updated later...
> diff --git a/drivers/net/ethernet/samsung/sxgbe/sxgbe_mdio.c
> b/dri
On Mon, 2014-03-17 at 23:47 -0700, Byungho An wrote:
> Hi all,
Hello all.
> drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c| 2382
>
The patches are wrapped again and can not be applied.
It really would be more convenient if you could use
git send-email for these.
Plea
) a lot of these things.
I would ignore the Non-standard signature, CamelCase and the
long line warnings, but I suppose the rest could be improved.
I get:
WARNING: Non-standard signature: Neatening-by:
#99:
Neatening-by: Joe Perches
CHECK: Avoid CamelCase:
#292: FILE: drivers/net/ethernet/samsung/
On Mon, 2014-03-17 at 13:43 -0700, Byungho An wrote:
> From: Siva Reddy
>
> This patch adds support for Samsung 10Gb ethernet driver(sxgbe).
Sorry about the brevity, but this driver is very long and
I don't like to read that much at a time, so this is very
superficial and I didn't read the whole
On Thu, 2014-03-13 at 05:53 -0700, Joe Perches wrote:
> Maybe this was supposed to be something like
>
> ns = p->tstamp_lo
> ns |= ((u64)tstamp_hi) << 32;
>
> If not, maybe it warrants a comment around
> here or on the descriptor definition
[]
On Thu, 2014-03-13 at 15:55 +0900, Byungho An wrote:
> This patch adds support for Samsung 10Gb ethernet driver(sxgbe).
> - sxgbe core initialization
> - Tx and Rx support
> - MDIO support
> - ISRs for Tx and Rx
> - ifconfig support to driver
[]
> diff --git a/drivers/net/ethernet/samsung/sxgbe_des
On Wed, 2014-03-12 at 22:27 +0900, Byungho An wrote:
> Hi all,
[]
> drivers/net/ethernet/samsung/sxgbe_main.c | 2447
>
The patch set is word wrapped and can not be applied.
Please resend without the word wrapping.
Using Outlook can make this difficult.
If possible
Alignment to parenthesis and adding parenthesis where appropriate.
Added a conversion of if (foo < x) bar ; else return baz to
if (foo >= x) return baz; and unindented.
git diff -w shows trivial changes.
Added a few > 80 column lines.
Signed-off-by: Joe Perches
---
drivers/net
Fix a couple of typos
Fix some comments that seem to have been kernel-doc style.
Fix alignment where noticed.
Signed-off-by: Joe Perches
---
drivers/net/ethernet/samsung/xgmac_core.c | 1 -
drivers/net/ethernet/samsung/xgmac_desc.c | 14 +++---
drivers/net/ethernet/samsung/xgmac_desc.h
Use netdev_ and netif_ where appropriate.
Remove else and unnecessary indentation around if goto else.
Signed-off-by: Joe Perches
---
drivers/net/ethernet/samsung/xgmac_ethtool.c | 2 +-
drivers/net/ethernet/samsung/xgmac_main.c | 185 --
drivers/net/ethernet
Mostly neatening and logging cleanups on top of the initial submittal.
Joe Perches (5):
samsung: xgmac: Neatening
samsung: xgmac: Fix pr_ uses
samsung: xgmac: Use more current logging style
samsung: xgmac: Neaten comments
samsung: xgmac: Mostly whitespace neatening
drivers/net
Quiet checkpatch noise:
o Multi-line statement alignment
o Add braces
o Move logical continuations
o Remove externs from .h
o Remove unnecessary blank lines around braces
Typo fixes where noticed.
Change logic to return first to reduce indentation.
Signed-off-by: Joe Perches
---
drivers/net
Use pr_fmt to prefix messages consistently with "samsung_xgmac: ".
Add missing newlines.
Use print_hex_dump_debug.
Alignment neatening of pr_ uses.
Signed-off-by: Joe Perches
---
drivers/net/ethernet/samsung/xgmac_core.c | 8 ++--
drivers/net/ethernet/samsung/xgmac_desc.
On Wed, 2014-03-05 at 20:28 +0900, Byungho An wrote:
> From: Siva Reddy
Just a few trivial comments on a brief scan.
> +/* Context descriptor structure */
> +struct xgmac_tx_ctxt_desc {
> + u32 tstamp_lo:32;
> + u32 tstamp_hi:32;
I think u32 foo:32; is odd at best
and may cause compiler
On Thu, 2013-10-24 at 12:10 -0700, Dmitry Torokhov wrote:
> On Thu, Oct 24, 2013 at 11:45:39AM -0700, Joe Perches wrote:
> > On Thu, 2013-10-24 at 11:37 -0700, Dmitry Torokhov wrote:
> > > Hi Joe,
> > >
> > > On Wed, Oct 23, 2013 at 12:14:50PM -0700, Joe Pe
On Thu, 2013-10-24 at 20:46 +0200, Uwe Kleine-König wrote:
> On Thu, Oct 24, 2013 at 11:43:38AM -0700, Joe Perches wrote:
[]
> > Any k.alloc without __GFP_NOWARN does a generic OOM message
> > and a dump_stack() so there could already be 2 messages anyway.
> Then mention that in
On Thu, 2013-10-24 at 11:37 -0700, Dmitry Torokhov wrote:
> Hi Joe,
>
> On Wed, Oct 23, 2013 at 12:14:50PM -0700, Joe Perches wrote:
> > Emitting an OOM message isn't necessary after input_allocate_device
> > as there's a generic OOM and a dump_stack already d
On Thu, 2013-10-24 at 20:26 +0200, Uwe Kleine-König wrote:
> Hello Joe,
>
> On Wed, Oct 23, 2013 at 12:14:50PM -0700, Joe Perches wrote:
> > Emitting an OOM message isn't necessary after input_allocate_device
> > as there's a generic OOM and a dump_stack already
Joe Perches (8):
Documentation: Remove OOM message after input_allocate_device
cell: Remove OOM message after input_allocate_device
hid: Remove OOM message after input_allocate_device
input: Remove OOM message after input_allocate_device
media: Remove OOM message after
Emitting an OOM message isn't necessary after input_allocate_device
as there's a generic OOM and a dump_stack already done.
Signed-off-by: Joe Perches
---
drivers/input/joystick/as5011.c | 2 --
drivers/input/joystick/db9.c| 1 -
drivers/input/joystick
On Wed, 2013-08-07 at 08:51 +0530, Sachin Kamat wrote:
> +CC Joe Perches
>
> On 7 August 2013 01:32, Russell King - ARM Linux
> wrote:
> > Also note:
> >
> > On Tue, Aug 06, 2013 at 05:01:13PM +0530, Sachin Kamat wrote:
> >> @@ -984,7 +984,7 @
On Tue, 2013-07-16 at 08:23 +0900, Jingoo Han wrote:
> On Monday, July 15, 2013 9:10 PM, Joe Perches wrote:
> > On Mon, 2013-07-15 at 15:11 +0900, Jingoo Han wrote:
> > []
> > > diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c
> > []
> &g
On Mon, 2013-07-15 at 15:11 +0900, Jingoo Han wrote:
[]
> diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c
[]
> @@ -338,8 +338,10 @@ static int acquire_dma(struct s3c64xx_spi_driver_data
> *sdd)
[]
> - sdd->rx_dma.ch = (void *)sdd->ops->request(sdd->rx_dma.dmach, &req,
> dev
On Thu, 2013-06-13 at 19:32 +0200, Tomasz Figa wrote:
[]
> Similarly for Kukjin, he's listed as the main Samsung maintainer already,
> but AFAIK in this case the script can't infer this based on directory
> structure. Let's see how it's done for other Samsung drivers:
A pattern could be added th
On Sun, 2013-01-06 at 15:50 -0800, Amit Daniel Kachhap wrote:
> Below fixes are done to support falling threshold interrupt,
> * Falling interrupt status macro corrected according to exynos5 data sheet.
> * The get trend function modified to calculate trip temperature correctly.
> * The clearing of
On Tue, 2012-01-31 at 15:25 +0900, Kukjin Kim wrote:
> Kukjin Kim wrote:
> > This should be added for EXYNOS4212 and EXYNOS4412 SoCs.
> >
> > Cc: Thomas Abraham
> > Cc: Greg Kroah-Hartman
> > Cc: sta...@kerne.org
>
> Oops, should be 'Cc: sta...@kernel.org'
You mean it should be 'cc: sta...@vge
On Wed, 2011-12-14 at 00:05 +0200, Denis Kuzmenko wrote:
> On 12/13/2011 11:40 PM, Joe Perches wrote:
> > On Tue, 2011-12-13 at 23:33 +0200, Denis Kuzmenko wrote:
> >> On 12/13/2011 11:28 PM, Joe Perches wrote:
> >>> The LEDF_ACTLOW use is dependent on it being #defin
On Tue, 2011-12-13 at 23:33 +0200, Denis Kuzmenko wrote:
> On 12/13/2011 11:28 PM, Joe Perches wrote:
> > The LEDF_ACTLOW use is dependent on it being #defined
> > to 1 when using ^. I think that's unintelligible.
> Sorry, can't understand. Can you pleas
On Tue, 2011-12-13 at 23:21 +0200, Denis Kuzmenko wrote:
> Hi Joe,
> Thank you for review.
>
> On 12/13/2011 11:06 PM, Joe Perches wrote:
> > On Tue, 2011-12-13 at 22:22 +0200, Denis Kuzmenko wrote:
> >> Make s3c24xx LEDS driver use gpiolib. Fix error disabl
On Tue, 2011-12-13 at 22:22 +0200, Denis Kuzmenko wrote:
> Make s3c24xx LEDS driver use gpiolib. Fix error disabling pull during probe.
[]
> diff --git a/drivers/leds/leds-s3c24xx.c b/drivers/leds/leds-s3c24xx.c
[]
> @@ -45,23 +45,35 @@ static void s3c24xx_led_set(struct led_classdev *led_cdev,
> +
On Thu, 2011-11-10 at 15:14 +0530, Vinod Koul wrote:
> On Thu, 2011-11-03 at 15:48 +0900, Boojin Kim wrote:
> > This patch adds to fix the build warning as following.
> >
> > drivers/dma/pl330.c: In function 'pl330_probe':
> > drivers/dma/pl330.c:859: warning: comparison of distinct pointer types
38 matches
Mail list logo
