RE: [PATCH RE-SEND] ARM: S5P: Move OneNAND device definitions in plat-s5p

2010-08-22 Thread Kyungmin Park
it if required. Thank you, Kyungmin Park -Original Message- From: Kukjin Kim [mailto:kgene@samsung.com] Sent: Monday, August 23, 2010 9:07 AM To: linux-arm-ker...@lists.infradead.org; linux-samsung-soc@vger.kernel.org Cc: ben-li...@fluff.org; Kukjin Kim; Kyungmin Park Subject: [PATCH

Re: [PATCH 2/3] ARM: S5P: Add initial map for GPIO2 and GPIO3

2010-08-22 Thread Kyungmin Park
On Mon, Aug 23, 2010 at 11:15 AM, Kukjin Kim kgene@samsung.com wrote: Kyungmin Park wrote: On Mon, Aug 23, 2010 at 9:18 AM, Kukjin Kim kgene@samsung.com wrote: Kyungmin Park wrote: NAK. I don't know why I need your ack for this...if any opinions, just comments is enough

Re: [PATCH RE-SEND] ARM: S5P: Move OneNAND device definitions in plat-s5p

2010-08-22 Thread Kyungmin Park
On Mon, Aug 23, 2010 at 11:35 AM, Kukjin Kim kgene@samsung.com wrote: Kyungmin Park wrote: Note: S5PC110 and S5PC210 have same OneNAND driver. Yes I also think it's same device. At least Spec is same. But I heard it has some different feature related with DMA operation. I'm not yet

Re: [PATCH 3/3] ARM: S5PV310: Add support HSMMC on SMDKC210 and SMDKV310

2010-08-21 Thread Kyungmin Park
On Fri, Aug 20, 2010 at 9:33 PM, Kukjin Kim kgene@samsung.com wrote: From: Hyuk Lee hyuk1@samsung.com This patch adds support HSMMC on SMDKC210 and SMDKV310, and adds setup functions for it. S5PV310/S5PC210 can support 4 hsmmc such as hsmmc0, hsmmc1, hsmmc2 and hsmmc3.

Re: [PATCH 1/3] ARM: SAMSUNG: Change the 3rd HSMMC interrupt name for compatibility

2010-08-21 Thread Kyungmin Park
Acked-by: Kyungmin Park kyungmin.p...@samsung.com On Fri, Aug 20, 2010 at 9:33 PM, Kukjin Kim kgene@samsung.com wrote: This patch changes the 3rd HSMMC interrupt name for compatibility from IRQ_MMC to IRQ_HSMMC3. Signed-off-by: Kukjin Kim kgene@samsung.com ---  arch/arm/mach-s5pv210

Re: 'error: 'SDHCI_QUIRK_NO_HISPD_BIT' undeclared' and 'undefined reference to `sdhci_card_detect''

2010-08-18 Thread Kyungmin Park
On Thu, Aug 19, 2010 at 3:33 AM, Andrew Morton a...@linux-foundation.org wrote: On Fri, 13 Aug 2010 10:13:04 +0200 Marek Szyprowski m.szyprow...@samsung.com wrote: Hello, On Friday, August 13, 2010 9:32 AM Kukjin Kim wrote: This is just information about Samsung sdmmc stuff building error

Re: 'error: 'SDHCI_QUIRK_NO_HISPD_BIT' undeclared' and 'undefined reference to `sdhci_card_detect''

2010-08-18 Thread Kyungmin Park
On Thu, Aug 19, 2010 at 10:10 AM, Kyungmin Park kmp...@infradead.org wrote: On Thu, Aug 19, 2010 at 3:33 AM, Andrew Morton a...@linux-foundation.org wrote: On Fri, 13 Aug 2010 10:13:04 +0200 Marek Szyprowski m.szyprow...@samsung.com wrote: Hello, On Friday, August 13, 2010 9:32 AM Kukjin

Re: [PATCH v4] ARM: S5PV310: Add Samsung UNIVERSAL_C210 support

2010-08-06 Thread Kyungmin Park
On Fri, Aug 6, 2010 at 9:14 PM, Kukjin Kim kgene@samsung.com wrote: From: Kyungmin Park kyungmin.p...@samsung.com This patch adds Samsung Mobile S5PC210 Reference Board, UNIVERSAL_C210 board support. Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com [kgene@samsung.com: changed

Re: [PATCH v6 5/7] ARM: S5PV210: Access for DMCx registers

2010-08-04 Thread Kyungmin Park
@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com ---  arch/arm/mach-s5pv210/cpu.c              |   12 +++-  arch/arm/mach-s5pv210/include/mach/map.h |    4  2 files changed, 15 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach-s5pv210/cpu.c b/arch/arm

Re: [PATCH] ARM: SAMSUNG: Fix on inclusion mach/gpio.h for Samsung SoCs

2010-08-04 Thread Kyungmin Park
Acked-by: Kyungmin Park kyungmin.p...@samsung.com On Thu, Aug 5, 2010 at 8:07 AM, Kukjin Kim kgene@samsung.com wrote: This patch fixes on inclusion mach/gpio.h to linux/gpio.h. Signed-off-by: Kukjin Kim kgene@samsung.com Cc: Ben Dooks ben-li...@fluff.org ---  arch/arm/mach-s3c64xx

Re: [PATCH v4 3/8] ARM: Samsung: Add platform definitions and helpers for FIMC driver

2010-08-02 Thread Kyungmin Park
to memory operations, color conversion, resizing and rotation. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com --- This is patch is a v3 version rebased onto latest kgene

Re: Please remind 'WARNING: about Samsung merge window over'

2010-08-02 Thread Kyungmin Park
On Tue, Aug 3, 2010 at 9:53 AM, Kukjin Kim kgene@samsung.com wrote: Russell King wrote: On Mon, Aug 02, 2010 at 05:35:37PM +0900, Kyungmin Park wrote: As the maintainer, he merged his features freely but others can't get the chance if the implementation is not fit his taste or company

Re: [PATCH v4 3/8] ARM: Samsung: Add platform definitions and helpers for FIMC driver

2010-08-02 Thread Kyungmin Park
On Tue, Aug 3, 2010 at 10:05 AM, Kukjin Kim kgene@samsung.com wrote: Kyungmin Park wrote: On Tue, Aug 3, 2010 at 9:46 AM, Kukjin Kim kgene@samsung.com wrote: Kyungmin Park wrote: On Tue, Aug 3, 2010 at 8:58 AM, Kukjin Kim kgene@samsung.com wrote: Marek Szyprowski wrote

Re: [PATCH v3 1/8] ARM: Samsung: Add register definitions for Samsung S5P SoC camera interface

2010-08-02 Thread Kyungmin Park
which are only used by one driver in arch/arm/*/include is silly. I also happy with this method. Thank you, Kyungmin Park -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH v3 3/3] ARM: SAMSUNG: i2c/busses: Add HAVE_S3C2410_I2C option to include I2C for Samsung SoCs

2010-07-29 Thread Kyungmin Park
. Thank you, Kyungmin Park Signed-off-by: Naveen Krishna Ch ch.nav...@samsung.com Signed-off-by: Kukjin Kim kgene@samsung.com Cc: Ben Dooks ben-li...@fluff.org --- Changes since v2: - Added HAVE_S3C2410_I2C in drivers Kconfig - Made I2C bus driver dependency SoC specific - Selected

Re: [PATCH v3 3/3] ARM: SAMSUNG: i2c/busses: Add HAVE_S3C2410_I2C option to include I2C for Samsung SoCs

2010-07-29 Thread Kyungmin Park
On Fri, Jul 30, 2010 at 10:03 AM, Kukjin Kim kgene@samsung.com wrote: Kyungmin Park wrote: On Thu, Jul 29, 2010 at 6:42 PM, Kukjin Kim kgene@samsung.com wrote: From: Naveen Krishna Ch ch.nav...@samsung.com This patch adds HAVE_S3C2410_I2C to control inclusion of I2C bus driver

Re: [PATCH v4 5/8] ARM: S5PV310: Add Timer support

2010-07-26 Thread Kyungmin Park
pin is changed to i2c function at bootloader to access the i2c chips. Then below code is working? Thank you, Kyungmin Park On Mon, Jul 26, 2010 at 9:42 PM, Kukjin Kim kgene@samsung.com wrote: From: Changhwan Youn chaos.y...@samsung.com This patch adds timer support for S5PV310.  Until now

Re: [PATCH v4 5/8] ARM: S5PV310: Add Timer support

2010-07-26 Thread Kyungmin Park
it in detail? In the spec, PWM2 is muxed with I2C_7. I muxed it I2C pin to use i2c chip. Thank you, Kyungmin Park Thanks and regards, Sangbeom Kim Kyungmin Park kmp...@infradead.org wrote: Can you confirm that during boot time, change the pwm2 pin to i2c functions and still it's working correctly? 1

Re: [PATCH v4 5/8] ARM: S5PV310: Add Timer support

2010-07-26 Thread Kyungmin Park
You mean we can use pwm2 and I2c simultaneously since we don't use the Tout. Do you also consider low power audio case? In the previous time to this reason, HRT uses the RTC and systimer. anyway thank you for clarification. Thank you, Kyungmin Park On Tue, Jul 27, 2010 at 1:58 PM, Sangbeom Kim

Re: [PATCH v3 3/3] sdhci-s3c: Add SDHCI_QUIRK_NO_WP_BIT quirk for Samsung SoC

2010-07-23 Thread Kyungmin Park
true whether WP use or not. Thank you, Kyungmin Park        ret = sdhci_add_host(host);        if (ret) {                dev_err(dev, sdhci_add_host() failed\n); diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c index f9ca4c6..7fba401 100644 --- a/drivers/mmc/host/sdhci.c

Re: [PATCH] ARM: SAMSUNG: Make RTC driver dependency SoC specific instead of machine specific

2010-07-21 Thread Kyungmin Park
I don't see the Samsung SoCs don't have RTC feature. I think S3C_RTC only depends on PLAT_SAMSUNG so PLAT_SAMSUNG select HAVE_S3C_RTC is enough. Thank you, Kyungmin Park On Wed, Jul 21, 2010 at 6:00 PM, Kukjin Kim kgene@samsung.com wrote: From: Atul Dahiya atul.dah...@samsung.com

Re: [PATCH v2 2/3] ARM: S5PV210: Add support for I2C devices on SMDKV210 and SMDKC110

2010-07-21 Thread Kyungmin Park
which tree do you use? If not fix the s5pv210_IIC2_IRQ correcly, it can't compile it. but I'm not see related patch at mailing list. Thank you, Kyungmin Park On Wed, Jul 21, 2010 at 9:58 PM, Kukjin Kim kgene@samsung.com wrote: From: Naveen Krishna Ch ch.nav...@samsung.com This patch adds

Re: [PATCH v3 2/8] ARM: S5PV310: Add new CPU initialization support

2010-07-21 Thread Kyungmin Park
On Wed, Jul 21, 2010 at 9:55 PM, Kukjin Kim kgene@samsung.com wrote: Kyungmin Park wrote: On Tue, Jul 20, 2010 at 9:11 PM, Kukjin Kim kgene@samsung.com wrote: From: Changhwan Youn chaos.y...@samsung.com This patch adds Samsung S5PV310/S5PC210 CPU support. The S5PV310/S5PC210

Re: [PATCH] ARM: SAMSUNG: Make RTC driver dependency SoC specific instead of machine specific

2010-07-21 Thread Kyungmin Park
On Wed, Jul 21, 2010 at 9:29 PM, Kukjin Kim kgene@samsung.com wrote: Kyungmin Park wrote: I don't see the Samsung SoCs don't have RTC feature. Yes, you're right... But it doesn't mean the RTC driver can support every Samsung SoCs now. Vice versa, if there's problem, we can fix it easily

Re: [PATCH v2 3/3] i2c/busses: Select I2C bus support for S5PV210 and S5P6440.

2010-07-21 Thread Kyungmin Park
are created. but I expect we also need to define new PLAT_SAMSUNG2 Thank you, Kyungmin Park On Wed, Jul 21, 2010 at 9:59 PM, Kukjin Kim kgene@samsung.com wrote: From: Naveen Krishna Ch ch.nav...@samsung.com This patch is to select support I2C channels 0, 1 and 2 for S5PV210 and S5P6440

Re: [PATCH v3 1/7] ARM: S5PV210: Add a Kconfig entry S5PC110_EVT0_WORKAROUND

2010-07-21 Thread Kyungmin Park
idea, give your opinions. Thank you, Kyungmin Park -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 3/3] i2c/busses: Select I2C bus support for S5PV210 and S5P6440.

2010-07-21 Thread Kyungmin Park
On Wed, Jul 21, 2010 at 10:55 PM, Kukjin Kim kgene@samsung.com wrote: Kyungmin Park wrote: I don't want to modify Kconfig anymore. it's simple to modify driver itself. Yeah, I think so. Think the usage of I2c. I think there's no case don't use it. At this time modify Kconfig once

Re: [PATCH v3 2/8] ARM: S5PV310: Add new CPU initialization support

2010-07-20 Thread Kyungmin Park
On Tue, Jul 20, 2010 at 9:11 PM, Kukjin Kim kgene@samsung.com wrote: From: Changhwan Youn chaos.y...@samsung.com This patch adds Samsung S5PV310/S5PC210 CPU support. The S5PV310/S5PC210 integrates a ARM Cortex A9 multi-core. Signed-off-by: Changhwan Youn chaos.y...@samsung.com

Re: [PATCH v3 1/7] ARM: S5PV210: Add a Kconfig entry S5PC110_EVT0_WORKAROUND

2010-07-19 Thread Kyungmin Park
-by: Kyungmin Park kyungmin.p...@samsung.com ---  arch/arm/mach-s5pv210/Kconfig |    7 +++  1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-s5pv210/Kconfig b/arch/arm/mach-s5pv210/Kconfig index 631019a..18802e7 100644 --- a/arch/arm/mach-s5pv210/Kconfig +++ b

Re: [PATCH 3/3] i2c/busses: Select I2C bus support for S5PV210 and S5P6440.

2010-07-16 Thread Kyungmin Park
. Thank you, Kyungmin Park        help          Say Y here to include support for I2C controller in the          Samsung S3C2410 based System-on-Chip devices. -- 1.6.2.5 -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord

Re: [PATCH v2 2/5] ARM: S5P: Added default pll values for APLL 800/1000MHz

2010-07-16 Thread Kyungmin Park
that the CPU is EVT1, users may use code for EVT0 later. Note that at 1GHz of ARMCLK, APLL should be 1GHz and for other lower ARMCLK, APLL should be 800MHz. Signed-off-by: MyungJoo Ham myungjoo@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com ---  arch/arm/plat-s5p

Re: [PATCH v2 2/8] ARM: S5PV310: Add new CPU initialization support

2010-07-16 Thread Kyungmin Park
, can you make it similar way? Thank you, Kyungmin Park On Fri, Jul 16, 2010 at 8:52 PM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Fri, Jul 16, 2010 at 05:58:28PM +0900, Kukjin Kim wrote: diff --git a/arch/arm/mach-s5pv310/platsmp.c b/arch/arm/mach-s5pv310/platsmp.c new file

Re: [PATCH 1/3] arm: s5pv210: GONI: add support for framebuffer

2010-07-14 Thread Kyungmin Park
in 480x800x16bpp mode is defined. Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com ---  arch/arm/mach-s5pv210/Kconfig     |    2 +  arch/arm/mach-s5pv210/mach-goni.c |   39 +  2 files changed, 41

Re: [PATCH v2] ARM: s5pv210_defconfig: Update for removing s5pc110_defconfig

2010-07-14 Thread Kyungmin Park
-Konig. No need to update board_defconfig since the latest merge removes the all arm *_defconfig. Thank you, Kyungmin Park  arch/arm/configs/s5pc110_defconfig |   66  arch/arm/configs/s5pv210_defconfig |    4 ++  arch/arm/mach-s5pv210/Kconfig      |   28

Re: About SECTION_SIZE_BITS for Sparsemem

2010-07-12 Thread Kyungmin Park
/min_free_kbytes 1820 # echo 1700 /proc/sys/vm/min_free_kbytes # cat /proc/sys/vm/min_free_kbytes 1700 No kernel panic. Thank you, Kyungmin Park On Mon, Jul 12, 2010 at 5:32 PM, Kukjin Kim kgene@samsung.com wrote: Russell, Hi, Kukjin Kim wrote: Russell wrote: So, memory starts at 0x2000

Re: About SECTION_SIZE_BITS for Sparsemem

2010-07-12 Thread Kyungmin Park
On Mon, Jul 12, 2010 at 6:58 PM, Kukjin Kim kgene@samsung.com wrote: Kyungmin Park wrote: Interesting. I got tested with #define MAX_PHYSMEM_BITS        31 #define SECTION_SIZE_BITS       27 # cat /proc/sys/vm/min_free_kbytes 1832 # echo 1828 /proc/sys/vm/min_free_kbytes # cat

Re: [PATCH v2] ARM: s5pv210_defconfig: Update for removing s5pc110_defconfig

2010-07-12 Thread Kyungmin Park
Question? Are there difference between smdkc110 and smdkv210? Thank you, Kyungmin Park On Tue, Jul 13, 2010 at 11:22 AM, Kukjin Kim kgene@samsung.com wrote: Now that S5PC110 machines and S5PV210 machines can be built into one kernel, update mach-s5pv210/Kconfig and s5pv210_defconfig

Requested features for next merge on s5pc110

2010-07-07 Thread Kyungmin Park
, and cpufreq. Of course I hope it's included. 3. Aquila goni board support. If possible all feature are included at current maineline kernel implemented. If I'm missing one features, please let me know, Give your opinions. Thank you, Kyungmin Park -- To unsubscribe from this list: send

Re: Requested features for next merge on s5pc110

2010-07-07 Thread Kyungmin Park
On Thu, Jul 8, 2010 at 12:39 PM, Jassi Brar jassisinghb...@gmail.com wrote: On Thu, Jul 8, 2010 at 12:05 PM, Kyungmin Park kmp...@infradead.org wrote: 3. Aquila goni board support.    If possible all feature are included at current maineline kernel implemented. Without doubt it's pleasing

Re: [PATCH] ARM: S5PV210: Fix on SECTION_SIZE_BITS on S5PV210/S5PC110.

2010-07-06 Thread Kyungmin Park
, then memory chip0 has an address range of 0x2000_ ~ 0x27FF_. Thank you, Kyungmin Park As you know, the size of a section should be a power of 2 and a physical address space of a section should be contiguous. If a section size is greater than 16MiB, a section have a hole. So

Re: [PATCH] ARM: SAMSUNG: updates sdhci.h for Samsung SoCs

2010-07-05 Thread Kyungmin Park
, Kyungmin Park On Mon, Jul 5, 2010 at 9:18 PM, Kukjin Kim kgene@samsung.com wrote: This patch updates sdhci.h as Maurus suggestion like following: From:        #ifdef ...        function()        {                blahblah;        }        #else        function() { }        #endif

Re: [PATCH] ARM: S5P: Add PMU device

2010-07-05 Thread Kyungmin Park
directory? It makes a single kernel simple. Thank you, Kyungmin Park Thanks. Best regards, Kgene. -- Kukjin Kim kgene@samsung.com, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. ___ linux-arm-kernel mailing list

Re: [PATCH] ARM: S5P: Add PMU device

2010-07-05 Thread Kyungmin Park
On Tue, Jul 6, 2010 at 12:12 PM, Kukjin Kim kgene@samsung.com wrote: Kyungmin Park wrote: On Mon, Jul 5, 2010 at 9:57 PM, Kukjin Kim kgene@samsung.com wrote: Maurus Cuelenaere wrote:  Op 05-07-10 03:46, Joonyoung Shim schreef: This patch adds an initcall for the s5p platforms

Re: [PATCH v2] SDHCI-S3C fixes and enhancements (driver specific code)

2010-07-05 Thread Kyungmin Park
Hi Andrew, I hope to merge it at next merge windows. Others any comments? Thank you, Kyungmin Park On Wed, Jun 16, 2010 at 3:49 PM, Marek Szyprowski m.szyprow...@samsung.com wrote: Hello, This series includes various fixes to sdhci-s3c driver as well as a major feature enhancement

Re: [PATCH] ARM: S5PV210: Fix on SECTION_SIZE_BITS on S5PV210/S5PC110.

2010-07-05 Thread Kyungmin Park
the problem? Even though 80MiB is used at logical size. it used the physical 128MiB so. it's reasonable to use 128MiB align instead of 16MiB. Are there boards use 64MiB or less? I think if decrease the SECTIONS_SIZE_BITS, it wastes the memory. Thank you, Kyungmin Park Reported-by: Kyongho Cho pullip

Re: [PATCH 0/8] ARM: S5PV310: Add support for Samsung S5PV310 SoC

2010-07-01 Thread Kyungmin Park
the chip carefully. it's misleading the chips. Thank you, Kyungmin Park On Fri, Jun 25, 2010 at 11:27 PM, Kukjin Kim kgene@samsung.com wrote: This patch set adds support for Samsung S5PV310/S5PC210. The S5PV310 integrates a ARM Cortex A9 microprocessor with several other peripherals

Re: [PATCH 8/8] ARM: S5PV310: Add serial port support

2010-07-01 Thread Kyungmin Park
Hi, As previous description. it's also same except the udivslot calculation and clock selection. How about to just modify current v210 serial codes by just adding the V310 or C210 type? Thank you, Kyungmin Park On Fri, Jun 25, 2010 at 11:27 PM, Kukjin Kim kgene@samsung.com wrote: From

Re: [PATCH v2 0/4] ARM: S5P: Support gpio interrupts

2010-06-23 Thread Kyungmin Park
doesn't support GPIO interrupt. Thank you, Kyungmin Park -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/3] ARM: S5P: Add System define for arch_reset()

2010-06-23 Thread Kyungmin Park
. Thank you, Kyungmin Park Signed-off-by: Jongpill Lee boyko@samsung.com Signed-off-by: Kukjin Kim kgene@samsung.com ---  arch/arm/plat-s5p/cpu.c                       |    5 +  arch/arm/plat-s5p/include/plat/system-reset.h |   24  2 files changed, 29

Re: Samsung SoCs: preparation for single kernel

2010-06-23 Thread Kyungmin Park
. Question. recently it's changed to use MMC0, MMC2, MMC3, then how to define it? More basically, where these info are defined for chip or board? If chip, the how to handle several variants? Thank you, Kyungmin Park I hope Ben will be able to finish it soon and all Samsung platforms can be converted

Samsung SoCs: preparation for single kernel

2010-06-22 Thread Kyungmin Park
and use it at runtime? Personally I want to use cpu_is_*. but you reject it to use. Other way is that we can create the base address variables and assign it at init time. Please give your opinions. Thank you, Kyungmin Park e.g., cpu_is_* usage at OMAP tree static void omap_init_mcspi(void

Re: Samsung SoCs: preparation for single kernel

2010-06-22 Thread Kyungmin Park
On Wed, Jun 23, 2010 at 10:54 AM, Eric Miao eric.y.m...@gmail.com wrote: On Wed, Jun 23, 2010 at 9:47 AM, Kyungmin Park kmp...@infradead.org wrote: On Wed, Jun 23, 2010 at 9:50 AM, Eric Miao eric.y.m...@gmail.com wrote: On Wed, Jun 23, 2010 at 7:27 AM, Kyungmin Park kmp...@infradead.org wrote

Re: [PATCH] ARM: s5pv210_defconfig: Update for removing s5pc110_defconfig

2010-06-15 Thread Kyungmin Park
Acked-by: Kyungmin Park kyungmin.p...@samsung.com P.s. How about the define C110_COMMON select to reduce Kconfig lines? in case of c110 has almost same features. sparemem, 24 fb, rtc, and so on. On Wed, Jun 16, 2010 at 8:42 AM, Kukjin Kim kgene@samsung.com wrote: Now that S5PC110 machines

Re: [PATCH 2/2 RE-SEND] ARM: S5PV210: Add support HSMMC on Samsung SMDKV210

2010-06-14 Thread Kyungmin Park
apply previous gpio helper functions? Thank you, Kyungmin Park +} -- 1.6.2.5 -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] sdhci-s3c: Add SDHCI_QUIRK_DATA_TIMEOUT_USES_SDCLK quirk for Samsung SoC

2010-06-11 Thread Kyungmin Park
On Fri, Jun 11, 2010 at 5:08 PM, Kukjin Kim kgene@samsung.com wrote: Kyungmin Park wrote: Hi, On Thu, Jun 10, 2010 at 8:39 PM, Kukjin Kim kgene@samsung.com wrote: From: Lee Hyuk hyuk1@samsung.com On Samsung's SDMMC hosts the timeout clock is derivied from the SD Clock

Re: [PATCH 1/3] s3c64xx: Fix build without SDHCI controllers

2010-06-10 Thread Kyungmin Park
: implicit declaration of function ‘s3c6410_default_sdhci2’ Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com ---  arch/arm/plat-samsung/include/plat/sdhci.h |    1 +  1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/arch

Re: [PATCH] sdhci-s3c: Add SDHCI_QUIRK_DATA_TIMEOUT_USES_SDCLK quirk for Samsung SoC

2010-06-10 Thread Kyungmin Park
-quirks |= SDHCI_QUIRK_DATA_TIMEOUT_USES_SDCLK; How do you know Samsung SoCs use SDCLK in the spec? Is it also true at s3c64xx series? Thank you, Kyungmin Park +        ret = sdhci_add_host(host);        if (ret) {                dev_err(dev, sdhci_add_host() failed\n); -- 1.6.2.5

RE: [PATCH 1/3] s3c64xx: Fix build without SDHCI controllers

2010-06-10 Thread Kyungmin Park
-Original Message- From: Kukjin Kim [mailto:kgene@samsung.com] Sent: Friday, June 11, 2010 12:59 PM To: 'Kyungmin Park' Cc: 'Marek Szyprowski'; linux-arm-ker...@lists.infradead.org; linux- samsung-...@vger.kernel.org; linux-...@vger.kernel.org; ben- li...@fluff.org Subject

Re: [PATCH 1/5] sdhci-s3c: depend on plat-samsung

2010-06-10 Thread Kyungmin Park
in the Kconfig (and updating it again when support for the new SoC variant is added). Hi, Marek Kyungmin Park already submitted same patch. Hmm, Mr Park and Co really need to learn how to handle the treatment of patches. I'm really disapointed that these patches get submitted without the proper

Re: [PATCH v2] ARM: S5PV210: Add Power Management Support

2010-05-31 Thread Kyungmin Park
On Tue, Jun 1, 2010 at 1:16 PM, Ben Dooks b...@trinity.fluff.org wrote: On Tue, Jun 01, 2010 at 12:23:39PM +0900, Kyungmin Park wrote: On Tue, Jun 1, 2010 at 11:03 AM, Ben Dooks ben-li...@fluff.org wrote: On Tue, Jun 01, 2010 at 10:36:04AM +0900, Kukjin Kim wrote: From: Jongpill Lee boyko

Re: [PATCH 05/15] ARM: S5P6442: Change to using s3c_gpio_cfgpin_range()

2010-05-28 Thread Kyungmin Park
), S3C_GPIO_SFN(2)); -               s3c_gpio_cfgpin(S5P6442_GPB(2), S3C_GPIO_SFN(2)); -               s3c_gpio_cfgpin(S5P6442_GPB(3), S3C_GPIO_SFN(2)); +               s3c_gpio_cfgpin_range(S5P6442_GPB(0), 4, S3C_GPIO_SFN(2)); Where's the GPB(1)??? Thank you, Kyungmin Park

Re: [PATCH 1/7] ARM: S5PV210: add support for software reset

2010-05-20 Thread Kyungmin Park
the watchdog reset for other purpose so we don't want to use watchdog reset at normal reset condition. Thank you, Kyungmin Park -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH v5] ARM: S5PV210: Add Ext interrupt support.

2010-05-16 Thread Kyungmin Park
). It is designed to be inlined into * the specific handlers s5p_irq_demux_eintX_Y. #define IRQ_EINT(x) ((x) 16 ? S5P_IRQ_VIC0(x) : \ (S5P_IRQ_EINT_BASE + (x)-16)) Thank you, Kyungmin Park  #define IRQ_EINT16_31                S5P_IRQ_VIC0(16

Re: [PATCH v2 11/11] Input: s3c24xx_ts - Uses Feature field instead TYPE for Samsung SoCs

2010-05-14 Thread Kyungmin Park
file for board files to use? +  /* Per-touchscreen data. */  /** @@ -81,17 +83,11 @@ struct s3c2410ts {        int irq_tc;        int count;        int shift; +       int feat;  }; What's the 'feat'? How about to write 'features' exactly. It's for plurals for future. Thank you, Kyungmin

Re: [PATCH 11/11] ARM: S5P6440: Remove redundant defines

2010-05-12 Thread Kyungmin Park
. This makes it easier   to verify the value against the manual and easier to compare   against simialr code. Then define it at c code and use the macro. I also don't like the hard-coded values. Thank you, Kyungmin Park -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc

Re: [PATCH 09/10] ARM: S5PV210: Add S5PC110 configuration file

2010-01-19 Thread Kyungmin Park
On Tue, Jan 19, 2010 at 11:28 AM, Kukjin Kim kgene@samsung.com wrote: This patch adds S5PC110 default configuration file. Signed-off-by: Kukjin Kim kgene@samsung.com ---  arch/arm/configs/s5pc110_defconfig |  895  1 files changed, 895

Re: [clocks] ARM: S3C64XX: Use new clock-clksrc.c code for clocks.

2009-12-01 Thread Kyungmin Park
to use the proper macro, I think it means the offset and required mask bit? Others are same. Thank you, Kyungmin Park        .sources        = clk_src_apll,  }; @@ -98,7 +82,7 @@ static struct clk *clk_src_epll_list[] = {        [1] = clk_fout_epll,  }; -static struct clk_sources

<    1   2   3