Re: [PATCH 2/2] [media] media-device: split media initialization and registration

2015-12-28 Thread Mauro Carvalho Chehab
Em Mon, 28 Dec 2015 08:26:33 -0200 Mauro Carvalho Chehab escreveu: > Em Mon, 28 Dec 2015 03:14:53 +0200 > Sakari Ailus escreveu: > > > Hi Mauro, > > > > On Tue, Dec 15, 2015 at 09:13:42AM -0200, Mauro Carvalho Chehab wrote: > > > Em Thu, 10 Sep 2015 20:14:0

[PATCH] [media] call media_device_init() before registering the V4L2 device

2015-12-28 Thread Mauro Carvalho Chehab
call media_device_init() before registering the V4L2 device. So, move the call for media_device_init() to happen earlier on exynos4-is and s3c-camif. This is just a cleanup patch. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/platform/exynos4-is/media-dev.c | 4 ++-- drivers/media/platform/s3c-

Re: [PATCH 2/2] [media] media-device: split media initialization and registration

2015-12-28 Thread Mauro Carvalho Chehab
Em Mon, 28 Dec 2015 03:14:53 +0200 Sakari Ailus escreveu: > Hi Mauro, > > On Tue, Dec 15, 2015 at 09:13:42AM -0200, Mauro Carvalho Chehab wrote: > > Em Thu, 10 Sep 2015 20:14:04 +0300 > > Sakari Ailus escreveu: > > > > > Hi Javier, > > > &

[PATCH v2] [media] media-device: handle errors at media_device_init()

2015-12-15 Thread Mauro Carvalho Chehab
x27;s revert to WARN_ON() and fix the init code in a way that, if something goes wrong during device init, driver probe will fail without causing the Kernel to BUG. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/media-device.c | 8 --- drivers/media/platform/exynos4-is/m

[PATCH] [media] media-device: handle errors at media_device_init()

2015-12-15 Thread Mauro Carvalho Chehab
x27;s revert to WARN_ON() and fix the init code in a way that, if something goes wrong during device init, driver probe will fail without causing the Kernel to BUG. Signed-off-by: Mauro Carvalho Chehab --- Javier is in vacations. So, instead of waiting for him to fixup those issues, let's address

Re: [PATCH 2/2] [media] media-device: split media initialization and registration

2015-12-15 Thread Mauro Carvalho Chehab
Em Thu, 10 Sep 2015 20:14:04 +0300 Sakari Ailus escreveu: > Hi Javier, > > Thanks for the set! A few comments below. > > Javier Martinez Canillas wrote: > > The media device node is registered and so made visible to user-space > > before entities are registered and links created which means tha

[PATCH 03/10] media framework: rename pads init function to media_entity_pads_init()

2015-12-11 Thread Mauro Carvalho Chehab
d-off-by: Mauro Carvalho Chehab --- Documentation/media-framework.txt | 18 +++--- Documentation/video4linux/v4l2-framework.txt | 8 Documentation/zh_CN/video4linux/v4l2-framework.txt | 8 drivers/media/dvb-core/dvbdev.c| 4 ++--

Re: [PATCH v8 32/55] [media] media: use macros to check for V4L2 subdev entities

2015-12-08 Thread Mauro Carvalho Chehab
Em Sun, 06 Dec 2015 04:16:15 +0200 Laurent Pinchart escreveu: > Hi Mauro, > > Thank you for the patch. > > On Sunday 30 August 2015 00:06:43 Mauro Carvalho Chehab wrote: > > Instead of relying on media subtype, use the new macros to detect > > if an entity is a

Re: [PATCH v2 3/3] [media] include/media: move platform_data to linux/platform_data/media

2015-11-17 Thread Mauro Carvalho Chehab
Em Mon, 16 Nov 2015 13:28:10 +0100 Arnd Bergmann escreveu: > I think we can also move some of the existing platform data headers to the > same > place, but that could be a separate patch: > > $ git grep linux/platform_data drivers/media/ > drivers/media/platform/coda/coda-common.c:#include >

[PATCH v2 3/3] [media] include/media: move platform_data to linux/platform_data/media

2015-11-16 Thread Mauro Carvalho Chehab
| \\"; ( cd include/$MAIN_DIR; for j in $DIRS; do for i in $(ls $j); do echo " perl -ne 's,include/$PREV_DIR($i)\b,include/$MAIN_DIR$j\1,; print \$_' |\\";

Re: [PATCH 2/2] [media] include/media: move platform driver headers to a separate dir

2015-11-13 Thread Mauro Carvalho Chehab
Em Fri, 13 Nov 2015 22:31:15 +0100 Arnd Bergmann escreveu: > On Friday 13 November 2015 17:13:41 Mauro Carvalho Chehab wrote: > > Em Wed, 11 Nov 2015 21:26:31 +0100 > > Arnd Bergmann escreveu: > > > > > include/media/{ => drv-intf}/cx2341x.h

Re: [PATCH 2/2] [media] include/media: move platform driver headers to a separate dir

2015-11-13 Thread Mauro Carvalho Chehab
Em Wed, 11 Nov 2015 21:26:31 +0100 Arnd Bergmann escreveu: > On Wednesday 11 November 2015 15:14:48 Mauro Carvalho Chehab wrote: > > rename include/media/{ => platform}/exynos-fimc.h (100%) > > rename include/media/{ => platform}/mmp-camera.h (100%) > > rename

[PATCH 2/2] [media] include/media: move platform driver headers to a separate dir

2015-11-11 Thread Mauro Carvalho Chehab
rm/ common_drv/; do for i in $(ls $j); do echo "perl -ne 's,(include [\\\"\\<]media/)($i)([\\\"\\>]),\1$j\2\3,; print \$_' |\\"; done; done; echo "cat > a && mv a \$i; done") >script && . ./script Signed-off-by: Mauro Carvalho Chehab

Re: [PATCH v8 32/55] [media] media: use macros to check for V4L2 subdev entities

2015-10-12 Thread Mauro Carvalho Chehab
Em Mon, 12 Oct 2015 18:35:05 +0300 Sakari Ailus escreveu: > Hi Mauro, > > On Sun, Oct 11, 2015 at 09:56:25PM -0300, Mauro Carvalho Chehab wrote: > > Em Mon, 12 Oct 2015 00:07:52 +0300 > > Sakari Ailus escreveu: > > > > > Hi Mauro, > > > > >

Re: [PATCH 1/1] media: Correctly determine whether an entity is a sub-device

2015-10-12 Thread Mauro Carvalho Chehab
t > media_entity *entity) > case MEDIA_ENT_F_LENS: > case MEDIA_ENT_F_ATV_DECODER: > case MEDIA_ENT_F_TUNER: > + case MEDIA_ENT_F_V4L2_SUBDEV_UNKNOWN: > return true; OK. Reviewed-by: Mauro Carvalho Chehab > > default: -- To unsubscri

Re: [PATCH v8 32/55] [media] media: use macros to check for V4L2 subdev entities

2015-10-11 Thread Mauro Carvalho Chehab
Em Mon, 12 Oct 2015 00:07:52 +0300 Sakari Ailus escreveu: > Hi Mauro, > > On Sun, Aug 30, 2015 at 12:06:43AM -0300, Mauro Carvalho Chehab wrote: > > Instead of relying on media subtype, use the new macros to detect > > if an entity is a subdev or an A/V DMA entity. >

[PATCH 5/7] [media] mipi-csis: make sparse happy

2015-10-01 Thread Mauro Carvalho Chehab
:709:17:got void [noderef] * Signed-off-by: Mauro Carvalho Chehab diff --git a/drivers/media/platform/exynos4-is/mipi-csis.c b/drivers/media/platform/exynos4-is/mipi-csis.c index d74e1bec3d86..4b85105dc159 100644 --- a/drivers/media/platform/exynos4-is/mipi-csis.c +++ b/drivers/media/platform

Re: Chromebook snow issues

2015-09-29 Thread Mauro Carvalho Chehab
ncy of EXYNOS_IOMMU to the MFC driver. Regards, Mauro > > On 29/09/15 16:01, Mauro Carvalho Chehab wrote: > > Em Tue, 29 Sep 2015 15:37:51 +0200 > > Sylwester Nawrocki escreveu: > > > >> Hi Mauro, > >> > >> On 29/09/15 14:43, Mauro Carvalho

Re: [PATCH] ARM: dts: Add Exynos5250 Snow Rev5+ support

2015-09-29 Thread Mauro Carvalho Chehab
> Mainline only supports Rev4 so this patch moves the common device nodes to > a DTSI file and adds a DTS for the Exynos5250 Snow Rev5. > > The Snow Rev5 DTS is based on the DTS found in the ChromiumOS 3.8 tree. > > Signed-off-by: Javier Martinez Canillas Tested-by: Mauro

Re: [PATCH 4/4] ARM64: dts: exynos5433: add jpeg node

2015-09-21 Thread Mauro Carvalho Chehab
Em Mon, 21 Sep 2015 11:59:27 +0200 Andrzej Pietrasiewicz escreveu: > Hi Hans, > > W dniu 21.09.2015 o 11:50, Hans Verkuil pisze: > > On 18-09-15 16:21, Andrzej Pietrasiewicz wrote: > >> From: Marek Szyprowski > >> > >> Add Exynos 5433 jpeg h/w codec node. > >> > >> Signed-off-by: Marek Szyprows

Re: [PATCH 2/2] [media] media-device: split media initialization and registration

2015-09-11 Thread Mauro Carvalho Chehab
Em Fri, 11 Sep 2015 09:31:36 +0200 Javier Martinez Canillas escreveu: > Hello Sakari, > > On 09/11/2015 07:51 AM, Sakari Ailus wrote: > > Hi Javier, > > > > Javier Martinez Canillas wrote: > >> Hello Sakari, > >> > >> On 09/10/2015 07:14 PM, Sakari Ailus wrote: > >>> Hi Javier, > >>> > >>> Than

Re: [PATCH v8 00/55] MC next generation patches

2015-08-30 Thread Mauro Carvalho Chehab
Em Sun, 30 Aug 2015 00:06:11 -0300 Mauro Carvalho Chehab escreveu: > That's the 8th version of the MC next generation patches. > > Differences from version 7: > > - Patches reworked to make the reviewers happy; > - Bug fixes; > - ALSA changes got their own separate p

[PATCH v8 00/55] MC next generation patches

2015-08-29 Thread Mauro Carvalho Chehab
field [media] omap3isp: separate links creation from entities init [media] omap3isp: create links after all subdevs have been bound Mauro Carvalho Chehab (49): [media] media: create a macro to get entity ID [media] media: add a common struct to be embed on media graph objects [media] media

[PATCH v8 11/55] [media] media: use entity.graph_obj.mdev instead of .parent

2015-08-29 Thread Mauro Carvalho Chehab
; @@ - me->parent + me->graph_obj.mdev @@ struct media_entity *link; @@ - link->source->entity->parent + link->source->entity->graph_obj.mdev @@ struct exynos_video_entity *ve; @@ - ve->vdev.entity.parent + ve->vdev.entity.graph_obj.mdev Suggested-by: Mauro Carvalho

[PATCH v8 10/55] [media] media: rename the function that create pad links

2015-08-29 Thread Mauro Carvalho Chehab
shell script: for i in $(find drivers/media -name '*.[ch]' -type f) $(find drivers/staging/media -name '*.[ch]' -type f) $(find include/ -name '*.h' -type f) ; do sed s,media_entity_create_link,media_create_pad_link,g <$i >a && mv a $i; done Si

[PATCH v8 32/55] [media] media: use macros to check for V4L2 subdev entities

2015-08-29 Thread Mauro Carvalho Chehab
t for ALSA and FB/DRM too. Ok, on the current pipelines supported by those drivers, just V4L stuff are there, but, assuming that some day a pipeline that also works with other subsystems will ever added, it is better to add explicit checks for the AV_DMA stuff. Signed-off-by: Mauro Carvalho Che

Re: [PATCH v7 10/44] [media] media: rename the function that create pad links

2015-08-28 Thread Mauro Carvalho Chehab
Em Wed, 26 Aug 2015 11:54:03 -0300 Mauro Carvalho Chehab escreveu: > Em Tue, 25 Aug 2015 12:55:41 -0600 > Shuah Khan escreveu: > > > On 08/23/2015 02:17 PM, Mauro Carvalho Chehab wrote: > > > Now that a link can be either between two different graph > > >

Re: [PATCH v7 11/44] [media] media: use entity.graph_obj.mdev instead of .parent

2015-08-26 Thread Mauro Carvalho Chehab
Em Tue, 25 Aug 2015 13:25:15 -0600 Shuah Khan escreveu: > On Tue, Aug 25, 2015 at 12:36 AM, Hans Verkuil wrote: > > On 08/23/2015 10:17 PM, Mauro Carvalho Chehab wrote: > >> From: Javier Martinez Canillas > >> > >> The struct media_entity has a .parent fie

Re: [PATCH v7 10/44] [media] media: rename the function that create pad links

2015-08-26 Thread Mauro Carvalho Chehab
Em Tue, 25 Aug 2015 12:55:41 -0600 Shuah Khan escreveu: > On 08/23/2015 02:17 PM, Mauro Carvalho Chehab wrote: > > Now that a link can be either between two different graph > > objects, we'll need to add more functions to create links. > > Is this an incomplete sentenc

[PATCH v7 11/44] [media] media: use entity.graph_obj.mdev instead of .parent

2015-08-23 Thread Mauro Carvalho Chehab
; @@ - me->parent + me->graph_obj.mdev @@ struct media_entity *link; @@ - link->source->entity->parent + link->source->entity->graph_obj.mdev @@ struct exynos_video_entity *ve; @@ - ve->vdev.entity.parent + ve->vdev.entity.graph_obj.mdev Suggested-by: Mauro C

[PATCH v7 28/44] [media] media: use macros to check for V4L2 subdev entities

2015-08-23 Thread Mauro Carvalho Chehab
t for ALSA and FB/DRM too. Ok, on the current pipelines supported by those drivers, just V4L stuff are there, but, assuming that some day a pipeline that also works with other subsystems will ever added, it is better to add explicit checks for the AV_DMA stuff. Signed-off-by: Mauro Carvalho Che

[PATCH v7 10/44] [media] media: rename the function that create pad links

2015-08-23 Thread Mauro Carvalho Chehab
for i in $(find drivers/media -name '*.[ch]' -type f) $(find drivers/staging/media -name '*.[ch]' -type f) $(find include/ -name '*.h' -type f) ; do sed s,media_entity_create_link,media_create_pad_link,g <$i >a && mv a $i; done Signed-off-by: Mauro Ca

Re: [PATCH 0/4] [media] Media entity cleanups and build fixes

2015-08-19 Thread Mauro Carvalho Chehab
Hi Javier, Em Wed, 19 Aug 2015 17:35:18 +0200 Javier Martinez Canillas escreveu: > Hello, > > This series contains a couple of build fixes and cleanups for the > Media Controller framework. The goal of the series is to get rid of > the struct media_entity .parent member since now that a media_g

[PATCH v6 8/8] [media] media: rename the function that create pad links

2015-08-19 Thread Mauro Carvalho Chehab
for i in $(find drivers/media -name '*.[ch]' -type f) $(find drivers/staging/media -name '*.[ch]' -type f) $(find include/ -name '*.h' -type f) ; do sed s,media_entity_create_link,media_create_pad_link,g <$i >a && mv a $i; done Signed-off-by: Mauro Car

[PATCH RFC v5 8/8] [media] media: rename the function that create pad links

2015-08-18 Thread Mauro Carvalho Chehab
for i in $(find drivers/media -name '*.[ch]' -type f) $(find drivers/staging/media -name '*.[ch]' -type f) $(find include/ -name '*.h' -type f) ; do sed s,media_entity_create_link,media_create_pad_link,g <$i >a && mv a $i; done Signed-off-by: Mauro C

[PATCH v4 1/6] media: get rid of unused "extra_links" param on media_entity_init()

2015-08-14 Thread Mauro Carvalho Chehab
ed to change the implementation of the links. So, before doing that, let's first remove that extra unused parameter, in order to cleanup the interface first. Signed-off-by: Mauro Carvalho Chehab Acked-by: Sakari Ailus diff --git a/Documentation/media-framework.txt b/Documentation/media-framework

Re: [PATCH RFC v3 07/16] media: get rid of unused "extra_links" param on media_entity_init()

2015-08-14 Thread Mauro Carvalho Chehab
Em Fri, 14 Aug 2015 13:33:48 +0300 Sakari Ailus escreveu: > Hi Mauro, > > On Wed, Aug 12, 2015 at 05:14:51PM -0300, Mauro Carvalho Chehab wrote: > > Currently, media_entity_init() creates an array with the links, > > allocated at init time. It provides a parameter (extra_

[PATCH RFC v3 11/16] media: rename the function that create pad links

2015-08-12 Thread Mauro Carvalho Chehab
for i in $(find drivers/media -name '*.[ch]' -type f) $(find drivers/staging/media -name '*.[ch]' -type f) $(find include/ -name '*.h' -type f) ; do sed s,media_entity_create_link,media_create_pad_link,g <$i >a && mv a $i; done Signed-off-by: Mauro Carv

[PATCH RFC v3 07/16] media: get rid of unused "extra_links" param on media_entity_init()

2015-08-12 Thread Mauro Carvalho Chehab
ed to change the implementation of the links. So, before doing that, let's first remove that extra unused parameter, in order to cleanup the interface first. Signed-off-by: Mauro Carvalho Chehab diff --git a/Documentation/media-framework.txt b/Documentation/media-framework.txt index f5

[PATCH RFC v3 10/16] media: rename link source/sink to pad0_source/pad1_sink

2015-08-12 Thread Mauro Carvalho Chehab
h]' -type f) $(find include/ -name '*.h' -type f) ; do sed "s,link->sink,link->pad1_sink,g; s,link->source,link->pad0_source,g;" <$i >a && mv a $i; done Signed-off-by: Mauro Carvalho Chehab diff --git a/drivers/media/dvb-core/dvb_frontend.c b/d

Re: [PATCH RFC v2 09/16] media: use media_graph_obj for link endpoints

2015-08-11 Thread Mauro Carvalho Chehab
Em Tue, 11 Aug 2015 14:25:18 +0200 Hans Verkuil escreveu: > Hi Mauro, > > Thanks for posting the missing patches. Thanks for reviewing this patch series! > > On 08/11/15 14:09, Mauro Carvalho Chehab wrote: > > As we'll need to create links between entities and

[PATCH RFC v2 09/16] media: use media_graph_obj for link endpoints

2015-08-11 Thread Mauro Carvalho Chehab
ing links, so no problems are expected so far. Yet, as we introduce links between entities and interfaces, we may need to change some existing code to work with links that aren't pad to pad. Signed-off-by: Mauro Carvalho Chehab diff --git a/drivers/media/dvb-core/dvb_frontend.c b/

[PATCH RFC v2 10/16] media: rename the function that create pad links

2015-08-11 Thread Mauro Carvalho Chehab
for i in $(find drivers/media -name '*.[ch]' -type f) $(find drivers/staging/media -name '*.[ch]' -type f) $(find include/ -name '*.h' -type f) ; do sed s,media_entity_create_link,media_create_pad_link,g <$i >a && mv a $i; done Signed-off-by: Mauro Carv

[PATCH RFC v2 07/16] media: get rid of unused "extra_links" param on media_entity_init()

2015-08-07 Thread Mauro Carvalho Chehab
ed to change the implementation of the links. So, before doing that, let's first remove that extra unused parameter, in order to cleanup the interface first. Signed-off-by: Mauro Carvalho Chehab diff --git a/Documentation/media-framework.txt b/Documentation/media-framework.txt index f5

[PATCH 9/9] [media] mm: Move get_vaddr_frames() behind a config option

2015-06-10 Thread Mauro Carvalho Chehab
: Mauro Carvalho Chehab create mode 100644 mm/frame_vector.c diff --git a/drivers/gpu/drm/exynos/Kconfig b/drivers/gpu/drm/exynos/Kconfig index 0a6780367d28..fc678289cf79 100644 --- a/drivers/gpu/drm/exynos/Kconfig +++ b/drivers/gpu/drm/exynos/Kconfig @@ -71,6 +71,7 @@ config DRM_EXYNOS_VIDI config

[PATCH 8/9] [media] drm/exynos: Convert g2d_userptr_get_dma_addr() to use get_vaddr_frames()

2015-06-10 Thread Mauro Carvalho Chehab
Kara Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab diff --git a/drivers/gpu/drm/exynos/exynos_drm_g2d.c b/drivers/gpu/drm/exynos/exynos_drm_g2d.c index 81a250830808..810e1ee7c07d 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_g2d.c +++ b/drivers/gpu/drm/exynos/exynos_drm_g2d.c

[PATCH 10/14] s3c-camif: Check if fmt is NULL before use

2015-04-28 Thread Mauro Carvalho Chehab
As reported by smatch: drivers/media/platform/s3c-camif/camif-capture.c:463 queue_setup() warn: variable dereferenced before check 'fmt' (see line 460) Signed-off-by: Mauro Carvalho Chehab diff --git a/drivers/media/platform/s3c-camif/camif-capture.c b/drivers/media/platform

Re: [PATCH] media / PM: Replace CONFIG_PM_RUNTIME with CONFIG_PM

2014-12-04 Thread Mauro Carvalho Chehab
now be changed to depend on > CONFIG_PM. > > The alternative of CONFIG_PM_SLEEP and CONFIG_PM_RUNTIME may be > replaced with CONFIG_PM too. > > Make these changes everywhere under drivers/media/. > > Signed-off-by: Rafael J. Wysocki Acked-by: Mauro Carvalho Chehab F

Re: [PATCH] media: exynos-gsc: fix build warning

2014-11-25 Thread Mauro Carvalho Chehab
g build warnings: gsc-core.c:350:17: warning: 'low_plane' may be used uninitialized gsc-core.c:371:31: warning: 'high_plane' may be used uninitialized Reported-by: Prabhakar Lad Signed-off-by: Mauro Carvalho Chehab diff --git a/drivers/media/platform/exynos-gsc/gsc-core.c b/drivers

[PATCH] [media] exynos4-is: fix some warnings when compiling on arm64

2014-09-24 Thread Mauro Carvalho Chehab
^ drivers/media/platform/exynos4-is/fimc-is.c:696:2: note: in expansion of macro ‘pr_debug’ pr_debug("shared region: %#x, parameter region: %#x\n", ^ Signed-off-by: Mauro Carvalho Chehab diff --git a/drivers/media/platform/exynos4-is/fimc-is.c b/drivers/media/platform/exynos4-

[PATCH 17/18] [media] s3c-camif: fix dma_addr_t printks

2014-09-24 Thread Mauro Carvalho Chehab
’ pr_debug("dst_buf[%d]: %#X, cb: %#X, cr: %#X\n", ^ Signed-off-by: Mauro Carvalho Chehab diff --git a/drivers/media/platform/s3c-camif/camif-capture.c b/drivers/media/platform/s3c-camif/camif-capture.c index f33641384e15..4f81b4c9d113 100644 --- a/drivers/media/platform/s3c-camif/camif-capt

[PATCHv3 2/3] [media] s5p-jpeg: Fix compilation with COMPILE_TEST

2014-09-09 Thread Mauro Carvalho Chehab
So, let's use udelay() instead. Reported-by: Stephen Rothwell Acked-by: Sylwester Nawrocki Signed-off-by: Mauro Carvalho Chehab diff --git a/drivers/media/platform/s5p-jpeg/jpeg-hw-exynos4.c b/drivers/media/platform/s5p-jpeg/jpeg-hw-exynos4.c index e51c078360f5..ab6d6f43c96f 100644 --- a/d

Re: [PATCH 2/3] [media] s5p-jpeg: Fix compilation with COMPILE_TEST

2014-09-09 Thread Mauro Carvalho Chehab
Em Tue, 09 Sep 2014 19:54:19 +0200 Arnd Bergmann escreveu: > On Tuesday 09 September 2014 12:09:36 Mauro Carvalho Chehab wrote: > > -exynos4.c > > > > index e51c078360f5..01eeacf28843 100644 > > > > --- a/drivers/media/platform/s5p-jpeg/jpeg-hw-exynos4.c > &g

[PATCHv2 2/3] [media] s5p-jpeg: Fix compilation with COMPILE_TEST

2014-09-09 Thread Mauro Carvalho Chehab
So, let's use ndelay() instead. Reported-by: Stephen Rothwell Signed-off-by: Mauro Carvalho Chehab diff --git a/drivers/media/platform/s5p-jpeg/jpeg-hw-exynos4.c b/drivers/media/platform/s5p-jpeg/jpeg-hw-exynos4.c index e51c078360f5..ab6d6f43c96f 100644 --- a/drivers/media/platform/s5p-jpe

Re: [PATCH 2/3] [media] s5p-jpeg: Fix compilation with COMPILE_TEST

2014-09-09 Thread Mauro Carvalho Chehab
Em Tue, 09 Sep 2014 16:58:58 +0200 Sylwester Nawrocki escreveu: > On 09/09/14 16:38, Mauro Carvalho Chehab wrote: > > ERROR: "__bad_ndelay" [drivers/media/platform/s5p-jpeg/s5p-jpeg.ko] > > undefined! > > > > Yet, it sounds a bad idea to use ndelay to

[PATCH 2/3] [media] s5p-jpeg: Fix compilation with COMPILE_TEST

2014-09-09 Thread Mauro Carvalho Chehab
ERROR: "__bad_ndelay" [drivers/media/platform/s5p-jpeg/s5p-jpeg.ko] undefined! Yet, it sounds a bad idea to use ndelay to wait for 100 us for the device to reset. Reported-by: Stephen Rothwell Signed-off-by: Mauro Carvalho Chehab diff --git a/drivers/media/platform/s5p-jpeg/jpeg-hw

[PATCH 40/46] [media] marvel-ccic: just return 0 instead of using a var

2014-09-03 Thread Mauro Carvalho Chehab
Instead of allocating a var to store 0 and just return it, change the code to return 0 directly. Signed-off-by: Mauro Carvalho Chehab diff --git a/drivers/media/platform/exynos4-is/fimc-isp-video.c b/drivers/media/platform/exynos4-is/fimc-isp-video.c index 93f9cf2ebcd6..9d8d885558e5 100644

Re: [PATCH v5] exynos-scaler: Add m2m functionality for the SCALER driver

2014-01-02 Thread Mauro Carvalho Chehab
Em Fri, 18 Oct 2013 11:19:24 +0530 Arun Kumar K escreveu: > From: Shaik Ameer Basha > > This patch adds the Makefile and memory to memory (m2m) interface > functionality for the SCALER driver. > > Signed-off-by: Shaik Ameer Basha > Signed-off-by: Arun Kumar K > --- > This patch is part of th

Re: [PATCH v4 2/4] [media] exynos-scaler: Add core functionality for the SCALER driver

2014-01-02 Thread Mauro Carvalho Chehab
Em Fri, 4 Oct 2013 17:56:32 +0530 Shaik Ameer Basha escreveu: > This patch adds the core functionality for the SCALER driver. > > Signed-off-by: Shaik Ameer Basha > --- > drivers/media/platform/exynos-scaler/scaler.c | 1238 > + > drivers/media/platform/exynos-scaler/

Re: [PATCH v4 1/4] [media] exynos-scaler: Add new driver for Exynos5 SCALER

2014-01-02 Thread Mauro Carvalho Chehab
Em Fri, 4 Oct 2013 17:56:31 +0530 Shaik Ameer Basha escreveu: > This patch adds support for SCALER device which is a new device > for scaling, blending, color fill and color space conversion > on EXYNOS5410 and EXYNOS5420 SoCs. > > This device supports the followings as key feature. > inpu

Re: [PATCH v3 4/6] exynos4-is: Add clock provider for the external clocks

2014-01-02 Thread Mauro Carvalho Chehab
Em Thu, 17 Oct 2013 20:06:49 +0200 Sylwester Nawrocki escreveu: > This patch adds clock provider to expose the sclk_cam0/1 clocks > for external image sensor devices. > > Signed-off-by: Sylwester Nawrocki > Signed-off-by: Kyungmin Park > --- > Changes since v2: > - use 'camera' DT node drirec

Re: [PATCH] dma-buf: avoid using IS_ERR_OR_NULL

2013-12-22 Thread Mauro Carvalho Chehab
uf *dmabuf) > > { > > @@ -566,7 +568,9 @@ void *dma_buf_vmap(struct dma_buf *dmabuf) > > BUG_ON(dmabuf->vmap_ptr); > > > > ptr = dmabuf->ops->vmap(dmabuf); > > - if (IS_ERR_OR_NULL(ptr)) > > + if (WARN_ON_ONCE(IS_ERR(p

Re: [PATCH v2] videobuf2: Add missing lock held on vb2_fop_relase

2013-10-31 Thread Mauro Carvalho Chehab
Em Sat, 19 Oct 2013 18:07:57 +0200 Ricardo Ribalda escreveu: > vb2_fop_relase does not held the lock although it is modifying the > queue->owner field. > > This could lead to race conditions on the vb2_perform_io function > when multiple applications are accessing the video device via > read/wri

Re: [PATCH 19/51] DMA-API: media: dt3155v4l: replace dma_set_mask()+dma_set_coherent_mask() with new helper

2013-10-31 Thread Mauro Carvalho Chehab
> > with a call to the new helper dma_set_mask_and_coherent(). > > > > Signed-off-by: Russell King > > Acked-by: Hans Verkuil Somehow, I lost your original post (I got unsubscribed on a few days from all vger mailing lists at the end of september). I suspect that you want to sent this via

Re: [PATCH V3] i2c: move of helpers into the core

2013-08-24 Thread Mauro Carvalho Chehab
lly register child nodes in the core instead of doing this manually > in each driver. So, fix the drivers and documentation, too. > > Acked-by: Rob Herring > Reviewed-by: Felipe Balbi > Acked-by: Rafael J. Wysocki > Tested-by: Sylwester Nawrocki > Signed-off-by: Wolfram Sang

Re: [PATCH 11/30] [media] exynos: remove unnecessary header inclusions

2013-04-10 Thread Mauro Carvalho Chehab
e inclusions. > > Signed-off-by: Arnd Bergmann > Cc: linux-me...@vger.kernel.org > Cc: Mauro Carvalho Chehab Acked-by: Mauro Carvalho Chehab > --- > drivers/media/platform/exynos-gsc/gsc-regs.c | 1 - > drivers/media/platform/s5p-tv/sii9234_drv.c | 3 --- > 2 files changed, 4 de

DMABUF V4L2 patches got merged

2012-11-25 Thread Mauro Carvalho Chehab
Hi all, Today, I finally merged the DMABUF V4L2 patches from Tomasz. The DMABUF allows replacing the old V4L2 Overlay method by something more robust and safer. It was a long road to get them ready for their upstream inclusion, and to be able to test on both embedded and personal computers. Alo

Re: [PATCH 0/19 v4] s5p-fimc driver conversion to media controller and control framework

2011-09-08 Thread Mauro Carvalho Chehab
Em 08-09-2011 03:48, Sylwester Nawrocki escreveu: > On 09/06/2011 10:52 PM, Mauro Carvalho Chehab wrote: >> Em 03-09-2011 13:32, Sylwester Nawrocki escreveu: >>> On 09/01/2011 05:30 PM, Sylwester Nawrocki wrote: >>>> Hello, >>>> >>>> follow

Re: [PATCH 0/19 v4] s5p-fimc driver conversion to media controller and control framework

2011-09-06 Thread Mauro Carvalho Chehab
Em 03-09-2011 13:32, Sylwester Nawrocki escreveu: > On 09/01/2011 05:30 PM, Sylwester Nawrocki wrote: >> Hello, >> >> following is a fourth version of the patchset converting s5p-fimc driver >> to the media controller API and the new control framework. >> >> Mauro, could you please have a look at t

Re: [PATCH 3/7] [media] s5p-fimc: Remove to support fimc for S5PC100

2011-05-18 Thread Mauro Carvalho Chehab
/feature-removal-schedule.txt $ Mauro. > > Cc: Sylwester Nawrocki > Cc: Kyungmin Park > Cc: Mauro Carvalho Chehab > Signed-off-by: Kukjin Kim > --- > drivers/media/video/s5p-fimc/fimc-core.c | 14 -- > 1 files changed, 0 insertions(+), 14 deletions(-) &

Re: [PATCH v3 1/8] ARM: Samsung: Add register definitions for Samsung S5P SoC camera interface

2010-08-02 Thread Mauro Carvalho Chehab
Em 02-08-2010 07:52, Russell King - ARM Linux escreveu: > On Mon, Aug 02, 2010 at 12:32:20PM +0200, Pawel Osciak wrote: >> Well, some of them are indeed unused, but it's not an uncommon practice in >> kernel and might help future developers. > > On the other hand, arch/arm is getting soo big that

Re: [PATCH/RFC v2.1 0/2] Mem-to-mem device framework

2010-02-03 Thread Mauro Carvalho Chehab
Hiremath, Vaibhav wrote: >> -Original Message- >> From: Pawel Osciak [mailto:p.osc...@samsung.com] >> Sent: Monday, December 28, 2009 8:19 PM >> To: 'Hans Verkuil' >> Cc: linux-me...@vger.kernel.org; linux-samsung-soc@vger.kernel.org; >> linux-arm-ker...@lists.infradead.org; Marek Szyprowsk