RE: [PATCH v3 00/30] usb: updates for dwc2 gadget driver

2015-01-09 Thread Paul Zimmerman
CCing more of the Samsung folks and linux-kernel. Robert, Marek, can you test this series on your platform, please? If I don't hear from you soon, I'll just ack it and we can deal with any breakage later. -- Paul From: Mian Yousaf Kaukab [mailto:yousaf.kau...@intel.com] Sent: Friday, January

RE: [PATCH] usb: dwc2: add support for initial state for dual-role mode

2015-01-05 Thread Paul Zimmerman
From: Marek Szyprowski [mailto:m.szyprow...@samsung.com] Sent: Wednesday, December 17, 2014 5:50 AM DWC2 module on Exynos SoCs is used only as peripheral controller (UDC), so add support for selecting default initial state for dual-role mode. The default init mode can be overridden by

RE: [PATCH v5] usb: dwc2/gadget: rework disconnect event handling

2014-11-18 Thread Paul Zimmerman
+ */ + s3c_hsotg_disconnect(hsotg); } if (gintsts GINTSTS_ENUMDONE) { writel(GINTSTS_ENUMDONE, hsotg-regs + GINTSTS); s3c_hsotg_irq_enumdone(hsotg); + hsotg-connected = 1; } if (gintsts GINTSTS_CONIDSTSCHNG) { Acked-by: Paul

RE: [PATCH v3 1/2] usb: dwc2/gadget: add mutex to serialize init/deinit calls

2014-11-18 Thread Paul Zimmerman
s3c_hsotg_resume(struct platform_device *pdev) s3c_hsotg_core_connect(hsotg); spin_unlock_irqrestore(hsotg-lock, flags); + mutex_unlock(hsotg-init_mutex); + return ret; } Acked-by: Paul Zimmerman pa...@synopsys.com -- To unsubscribe from this list: send the line unsubscribe

RE: [PATCH v4] usb: dwc2/gadget: rework disconnect event handling

2014-11-14 Thread Paul Zimmerman
-Original Message- From: Marek Szyprowski [mailto:m.szyprow...@samsung.com] Sent: Friday, November 14, 2014 4:20 AM This patch adds a call to s3c_hsotg_disconnect() from 'end session' interrupt (GOTGINT_SES_END_DET) to correctly notify gadget subsystem about unplugged usb cable.

RE: [PATCH v3 1/2] usb: dwc2/gadget: add mutex to serialize init/deinit calls

2014-11-14 Thread Paul Zimmerman
From: Marek Szyprowski [mailto:m.szyprow...@samsung.com] Sent: Friday, November 14, 2014 1:19 AM On 2014-11-13 21:55, Paul Zimmerman wrote: From: Marek Szyprowski [mailto:m.szyprow...@samsung.com] Sent: Thursday, November 13, 2014 7:18 AM On 2014-10-31 19:46, Paul Zimmerman wrote

RE: [PATCH v4] usb: dwc2/gadget: rework disconnect event handling

2014-11-14 Thread Paul Zimmerman
From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Felipe Balbi Sent: Friday, November 14, 2014 11:05 AM On Fri, Nov 14, 2014 at 07:01:37PM +, Paul Zimmerman wrote: -Original Message- From: Marek Szyprowski [mailto:m.szyprow

RE: [PATCH v4] usb: dwc2/gadget: rework disconnect event handling

2014-11-14 Thread Paul Zimmerman
From: Paul Zimmerman Sent: Friday, November 14, 2014 1:21 PM From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Felipe Balbi Sent: Friday, November 14, 2014 11:05 AM On Fri, Nov 14, 2014 at 07:01:37PM +, Paul Zimmerman wrote

RE: [PATCH v3] usb: dwc2/gadget: report disconnect event from 'end session' irq

2014-11-13 Thread Paul Zimmerman
From: Marek Szyprowski [mailto:m.szyprow...@samsung.com] Sent: Thursday, November 13, 2014 5:40 AM On 2014-10-31 19:15, Paul Zimmerman wrote: From: Marek Szyprowski [mailto:m.szyprow...@samsung.com] Sent: Friday, October 31, 2014 1:04 AM To: linux-...@vger.kernel.org; linux-samsung-soc

RE: [PATCH v3 1/2] usb: dwc2/gadget: add mutex to serialize init/deinit calls

2014-11-13 Thread Paul Zimmerman
From: Marek Szyprowski [mailto:m.szyprow...@samsung.com] Sent: Thursday, November 13, 2014 7:18 AM On 2014-10-31 19:46, Paul Zimmerman wrote: From: Marek Szyprowski [mailto:m.szyprow...@samsung.com] Sent: Friday, October 31, 2014 3:13 AM This patch adds mutex, which protects

RE: [PATCH v3] usb: dwc2/gadget: report disconnect event from 'end session' irq

2014-10-31 Thread Paul Zimmerman
From: Marek Szyprowski [mailto:m.szyprow...@samsung.com] Sent: Friday, October 31, 2014 1:04 AM To: linux-...@vger.kernel.org; linux-samsung-soc@vger.kernel.org Cc: Marek Szyprowski; Kyungmin Park; Robert Baldyga; Paul Zimmerman; Krzysztof Kozlowski; Felipe Balbi Subject: [PATCH v3] usb

RE: [PATCH v3 1/2] usb: dwc2/gadget: add mutex to serialize init/deinit calls

2014-10-31 Thread Paul Zimmerman
From: Marek Szyprowski [mailto:m.szyprow...@samsung.com] Sent: Friday, October 31, 2014 3:13 AM This patch adds mutex, which protects initialization and deinitialization procedures against suspend/resume methods. Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com ---

RE: [PATCH v2 02/10] usb: dwc2/gadget: fix enumeration issues

2014-10-24 Thread Paul Zimmerman
); - dev_info(hsotg-dev, %s: USBRst\n, __func__); + dev_dbg(hsotg-dev, %s: USBRst\n, __func__); dev_dbg(hsotg-dev, GNPTXSTS=%08x\n, readl(hsotg-regs + GNPTXSTS)); Acked-by: Paul Zimmerman pa...@synopsys.com -- To unsubscribe from this list: send

RE: [PATCH v2 05/10] usb: dwc2/gadget: move setting last reset time to s3c_hsotg_core_init

2014-10-24 Thread Paul Zimmerman
, flags); - hsotg-last_rst = jiffies; s3c_hsotg_phy_enable(hsotg); s3c_hsotg_core_init(hsotg); spin_unlock_irqrestore(hsotg-lock, flags); Acked-by: Paul Zimmerman pa...@synopsys.com -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body

RE: [PATCH v2 06/10] usb: dwc2/gadget: decouple setting soft-disconnect from s3c_hsotg_core_init

2014-10-24 Thread Paul Zimmerman
(hsotg); spin_unlock_irqrestore(hsotg-lock, flags); return ret; Acked-by: Paul Zimmerman pa...@synopsys.com -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http

RE: [PATCH v2 07/10] usb: dwc2/gadget: move phy control calls out of pullup() method

2014-10-24 Thread Paul Zimmerman
-by: Paul Zimmerman pa...@synopsys.com -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

RE: [PATCH v2 08/10] usb: dwc2/gadget: use soft-disconnect udc feature in pullup() method

2014-10-24 Thread Paul Zimmerman
(hsotg); s3c_hsotg_core_connect(hsotg); } else { + s3c_hsotg_core_disconnect(hsotg); clk_disable(hsotg-clk); } Acked-by: Paul Zimmerman pa...@synopsys.com -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body

RE: [PATCH v2 09/10] usb: dwc2/gadget: fix calls to phy control functions in suspend/resume code

2014-10-24 Thread Paul Zimmerman
-by: Paul Zimmerman pa...@synopsys.com -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

RE: [PATCH v2 10/10] usb: dwc2/gadget: rework suspend/resume code to correctly restore gadget state

2014-10-24 Thread Paul Zimmerman
From: Marek Szyprowski [mailto:m.szyprow...@samsung.com] Sent: Monday, October 20, 2014 3:46 AM Suspend/resume code assumed that the gadget was always enabled and connected to usb bus. This means that the actual state of the gadget (soft-enabled/disabled or connected/disconnected) was not

RE: [PATCH v2 01/10] usb: dwc2/gadget: report disconnect event from 'end session' irq

2014-10-24 Thread Paul Zimmerman
From: Marek Szyprowski [mailto:m.szyprow...@samsung.com] Sent: Monday, October 20, 2014 3:46 AM This patch adds a call to s3c_hsotg_disconnect() from 'end session' interrupt (GOTGINT_SES_END_DET) to correctly notify gadget subsystem about unplugged usb cable. 'disconnected' interrupt

RE: [PATCH v2 04/10] usb: dwc2/gadget: disable phy before turning off power regulators

2014-10-23 Thread Paul Zimmerman
in the device shutdown procedure. Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com Paul, can I have your Acked-by here so I can send this to v3.18-rc1 ? Sorry, I've been working on a really hot issue at $work and didn't have time yet to review this series. Acked-by: Paul Zimmerman

RE: [PATCH v2 03/10] usb: dwc2/gadget: fix gadget unregistration in udc_stop() function

2014-10-23 Thread Paul Zimmerman
gadgets and enabling/disabling gadgets by writing to /sys/class/udc/*hsotg/soft_connect interface. Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com Also here. In fact, this is much more important :-) Acked-by: Paul Zimmerman pa...@synopsys.com Are there any more patches in this series

RE: [PATCH] usb: dwc3: Keeping 'resource' related code together

2014-06-03 Thread Paul Zimmerman
From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Vivek Gautam Sent: Tuesday, June 03, 2014 3:40 AM Putting together the code related to getting the 'IORESOURCE_MEM' and assigning the same to dwc-xhci_resources, for increasing the readability.

RE: [RFC PATCHv1] usb: dwc2: Combine the dwc2 and s3c_hsotg into a single USB DRD driver.

2014-02-05 Thread Paul Zimmerman
From: Dinh Nguyen [mailto:dingu...@altera.com] Sent: Tuesday, February 04, 2014 10:14 PM On Wed, 2014-02-05 at 00:42 +, Paul Zimmerman wrote: From: dingu...@altera.com [mailto:dingu...@altera.com] Sent: Tuesday, February 04, 2014 1:46 PM From: Dinh Nguyen dingu...@altera.com

RE: [RFC PATCHv1] usb: dwc2: Combine the dwc2 and s3c_hsotg into a single USB DRD driver.

2014-02-04 Thread Paul Zimmerman
From: dingu...@altera.com [mailto:dingu...@altera.com] Sent: Tuesday, February 04, 2014 1:46 PM From: Dinh Nguyen dingu...@altera.com This means that the driver can be in host or peripheral mode when the appropriate connector is used. When an A-cable is plugged in, the driver behaves in

RE: [RFC PATCH 0/2] dwc2/s3c-hsotg: Initial steps to combine the 2 driver

2014-01-14 Thread Paul Zimmerman
From: Dinh Nguyen [mailto:dingu...@altera.com] Sent: Tuesday, January 14, 2014 12:46 PM On Tue, 2014-01-14 at 06:21 -0800, Greg KH wrote: On Tue, Jan 14, 2014 at 05:01:00AM -0600, dingu...@altera.com wrote: From: Dinh Nguyen dingu...@altera.com Hi, I'm starting work

RE: [RFC PATCH 0/2] dwc2/s3c-hsotg: Initial steps to combine the 2 driver

2014-01-14 Thread Paul Zimmerman
From: Dinh Nguyen [mailto:dingu...@altera.com] Sent: Tuesday, January 14, 2014 1:30 PM On Tue, 2014-01-14 at 13:14 -0800, Greg KH wrote: On Tue, Jan 14, 2014 at 08:57:12PM +, Paul Zimmerman wrote: From: Dinh Nguyen [mailto:dingu...@altera.com] Sent: Tuesday, January 14, 2014 12