Re: [PATCH v6 1/6] thermal: add generic cpufreq cooling implementation

2012-08-17 Thread Zhang Rui
On 四, 2012-08-16 at 17:11 +0530, Amit Daniel Kachhap wrote: > This patchset introduces a new generic cooling device based on cpufreq > that can be used on non-ACPI platforms. As a proof of concept, we have > drivers for the following platforms using this mechanism now: > > * Samsung Exynos (Exyn

Re: [PATCH v6 1/6] thermal: add generic cpufreq cooling implementation

2012-08-19 Thread Zhang Rui
On 五, 2012-08-17 at 11:56 +0300, Valentin, Eduardo wrote: > Hello, > >>> + > >>> + > >>> +1.2 CPU cooling action notifier register/unregister interface > >>> +1.2.1 int cputherm_register_notifier(struct notifier_block *nb, > >>> + unsigned int list) > >>> + > >>> +This interface registers

[PATCH RESEND] thermal: add generic cpufreq cooling implementation

2012-09-09 Thread Zhang Rui
ipping frequency . The drivers can also register to recieve notification about any cooling action called. Cc: Guenter Roeck Cc: SangWook Ju Cc: Durgadoss Cc: Len Brown Cc: Jean Delvare Cc: Kyungmin Park Cc: Kukjin Kim Signed-off-by: Zhang Rui Signed-off-by: Andrew Morton Signed-off-b

Re: [PATCH RESEND] thermal: add generic cpufreq cooling implementation

2012-09-10 Thread Zhang Rui
On 一, 2012-09-10 at 09:50 +0300, Valentin, Eduardo wrote: > Hello Rui and Amit, > > On Mon, Sep 10, 2012 at 9:25 AM, Zhang Rui wrote: > > Refreshed to remove the notifier mechanism as we do not have a real user of > > it. > > if there is no problem, I'll appl

Re: [PATCH 1/4] thermal: Add new thermal trend type to support quick cooling

2012-11-07 Thread Zhang Rui
On Thu, 2012-11-08 at 09:56 +0530, Amit Daniel Kachhap wrote: > This modification adds 2 new thermal trend type THERMAL_TREND_RAISE_FULL > and THERMAL_TREND_DROP_FULL. This thermal trend can be used to quickly > jump to the upper or lower cooling level instead of incremental increase > or decrease.

Re: [PATCH 1/4] thermal: Add new thermal trend type to support quick cooling

2012-11-08 Thread Zhang Rui
On Thu, 2012-11-08 at 11:56 +0530, Amit Kachhap wrote: > On 8 November 2012 11:31, Zhang Rui wrote: > > On Thu, 2012-11-08 at 09:56 +0530, Amit Daniel Kachhap wrote: > >> This modification adds 2 new thermal trend type THERMAL_TREND_RAISE_FULL > >> and THERMAL_TREND_DR

Re: [PATCH 1/4] thermal: Add new thermal trend type to support quick cooling

2012-11-11 Thread Zhang Rui
On Fri, 2012-11-09 at 11:51 +0530, Amit Kachhap wrote: > On 9 November 2012 09:21, Zhang Rui wrote: > > On Thu, 2012-11-08 at 11:56 +0530, Amit Kachhap wrote: > >> On 8 November 2012 11:31, Zhang Rui wrote: > >> > On Thu, 2012-11-08 at 09:56 +0530, Amit Dani

RE: [PATCH 1/4] thermal: Add new thermal trend type to support quick cooling

2012-11-11 Thread Zhang Rui
On Sun, 2012-11-11 at 22:55 -0700, R, Durgadoss wrote: > Hi Amit/Rui, > > > -Original Message- > > From: Amit Kachhap [mailto:amit.kach...@linaro.org] > > Sent: Friday, November 09, 2012 11:52 AM > > To: Zhang, Rui > > Cc: linux...@lists.linux-

Re: [PATCH-Resend] thermal: Exynos: Add missing dependency

2012-11-14 Thread Zhang Rui
On Thu, 2012-11-15 at 12:31 +0530, Amit Kachhap wrote: > On 15 November 2012 12:09, Sachin Kamat wrote: > > CPU_FREQ_TABLE depends on CPU_FREQ. Selecting CPU_FREQ_TABLE without > > checking > > for dependencies gives the following compilation warnings: > > warning: (ARCH_TEGRA_2x_SOC && ARCH_TEGR

RE: [PATCH 0/4] thermal: Add support for interrupt based notification to thermal layer

2012-11-21 Thread Zhang, Rui
] On Behalf Of Amit Daniel Kachhap > Sent: Thursday, November 08, 2012 12:26 PM > To: linux...@lists.linux-foundation.org > Cc: linux-samsung-soc@vger.kernel.org; linux-ker...@vger.kernel.org; R, > Durgadoss; l...@kernel.org; Zhang, Rui; linux-a...@vger.kernel.org; > amit.kach...@linaro.

Re: [PATCH 1/4] thermal: Add new thermal trend type to support quick cooling

2012-11-22 Thread Zhang Rui
On Thu, 2012-11-22 at 10:11 +0530, Amit Kachhap wrote: > On 22 November 2012 06:52, Zhang Rui wrote: > > On Thu, 2012-11-08 at 09:56 +0530, Amit Daniel Kachhap wrote: > >> This modification adds 2 new thermal trend type THERMAL_TREND_RAISE_FULL > >> and THERMAL_TREND_DR

Re: [PATCH 1/4] thermal: Add new thermal trend type to support quick cooling

2012-11-22 Thread Zhang Rui
On Thu, 2012-11-08 at 09:56 +0530, Amit Daniel Kachhap wrote: > This modification adds 2 new thermal trend type THERMAL_TREND_RAISE_FULL > and THERMAL_TREND_DROP_FULL. This thermal trend can be used to quickly > jump to the upper or lower cooling level instead of incremental increase > or decrease.

Re: [PATCH 1/4] thermal: Add new thermal trend type to support quick cooling

2012-11-22 Thread Zhang Rui
On Fri, 2012-11-23 at 09:35 +0530, Amit Kachhap wrote: > On 22 November 2012 13:42, Zhang Rui wrote: > > On Thu, 2012-11-22 at 10:11 +0530, Amit Kachhap wrote: > >> On 22 November 2012 06:52, Zhang Rui wrote: > >> > On Thu, 2012-11-08 at 09:56 +0530, Amit Dani

Re: [PATCH V2 0/6] thermal: exynos: Add kernel thermal support for exynos platform

2012-04-09 Thread Zhang Rui
Hi, Amit, On 三, 2012-04-04 at 10:02 +0530, Amit Kachhap wrote: > Hi Len/Rui, > > Any comment or feedback from your side about the status of this patch? > Is it merge-able or major re-work is needed? I have fixed most of the > comments in this patchset and currently working on some of the minor >

Re: [PATCH V2 0/6] thermal: exynos: Add kernel thermal support for exynos platform

2012-04-15 Thread Zhang Rui
On 三, 2012-04-11 at 18:17 +0530, Amit Kachhap wrote: > Hi Rui, > > Thanks for looking into the patches. > > On 10 April 2012 06:28, Zhang Rui wrote: > > Hi, Amit, > > > > On 三, 2012-04-04 at 10:02 +0530, Amit Kachhap wrote: > >> Hi Len/Rui, > >>

RE: [PATCH v3 0/6] thermal: exynos: Add kernel thermal support for exynos platform

2012-05-08 Thread Zhang, Rui
, May 08, 2012 9:18 AM To: a...@linux-foundation.org; linux...@lists.linux-foundation.org Cc: R, Durgadoss; linux-a...@vger.kernel.org; l...@kernel.org; Zhang, Rui; amit.kach...@linaro.org; linaro-...@lists.linaro.org; linux-ker...@vger.kernel.org; linux-arm-ker...@lists.infradead.org; linux-samsung-soc

Re: [PATCH 1/2] thermal: sysfs: Add a new sysfs node emul_temp

2013-01-15 Thread Zhang Rui
Hi, Amit, On Sun, 2013-01-06 at 16:08 -0800, Amit Daniel Kachhap wrote: > This patch adds support to set the emulated temperature method in > thermal zone (sensor). After setting this feature thermal zone must > report this temperature and not the actual temperature. The actual > implementation of

Re: [PATCH 1/2] thermal: sysfs: Add a new sysfs node emul_temp

2013-01-21 Thread Zhang Rui
On Wed, 2013-01-16 at 11:30 -0800, amit kachhap wrote: > Hi Rui, > > Thanks for the review comments, > On Tue, Jan 15, 2013 at 11:33 PM, Zhang Rui wrote: > > Hi, Amit, > > > > On Sun, 2013-01-06 at 16:08 -0800, Amit Daniel Kachhap wrote: > >> This

Re: [PATCH V2 1/2] thermal: sysfs: Add a new sysfs node emul_temp for thermal emulation

2013-02-01 Thread Zhang Rui
On Sun, 2013-01-27 at 19:28 -0800, Amit Daniel Kachhap wrote: > This patch adds support to set the emulated temperature method in > thermal zone (sensor). After setting this feature thermal zone may > report this temperature and not the actual temperature. The emulation > implementation may be base

Re: [PATCH V2 2/2] thermal: exynos: Use the framework for temperature emulation support

2013-02-03 Thread Zhang Rui
On Sun, 2013-01-27 at 19:28 -0800, Amit Daniel Kachhap wrote: > This removes the driver specific sysfs support of the temperature > emulation and uses the newly added core thermal framework for thermal > emulation. A platform specific handler is added to support this. > > Signed-off-by: Amit Danie

Re: [PATCH V3 1/2] thermal: sysfs: Add a new sysfs node emul_temp for thermal emulation

2013-02-03 Thread Zhang Rui
On Sun, 2013-02-03 at 16:30 -0800, Amit Daniel Kachhap wrote: > This patch adds support to set the emulated temperature method in > thermal zone (sensor). After setting this feature thermal zone may > report this temperature and not the actual temperature. The emulation > implementation may be base

Re: [PATCH V2 2/2] thermal: exynos: Use the framework for temperature emulation support

2013-02-07 Thread Zhang Rui
On Mon, 2013-02-04 at 10:14 +0800, Zhang Rui wrote: > On Sun, 2013-01-27 at 19:28 -0800, Amit Daniel Kachhap wrote: > > This removes the driver specific sysfs support of the temperature > > emulation and uses the newly added core thermal framework for thermal > > emulation

Re: [PATCH V3 1/2] Thermal: exynos: Add support for temperature falling interrupt.

2013-02-19 Thread Zhang Rui
On Thu, 2013-02-07 at 17:13 -0800, Amit Daniel Kachhap wrote: > From: Jonghwa Lee > > This patch introduces using temperature falling interrupt in exynos > thermal driver. Former patch, it only use polling way to check > whether if system themperature is fallen. However, exynos SOC also > provide

Re: [PATCH V3 2/2] thermal: exynos: Use the new thermal trend type for quick cooling action.

2013-02-19 Thread Zhang Rui
On Thu, 2013-02-07 at 17:13 -0800, Amit Daniel Kachhap wrote: > This patch uses the quick thermal cooling trend type macros. This is needed > as exynos5 and other thermal sensors now supports only interrupt method for > thresold temperature check. > > Acked-by: Kukjin Kim > Signed-off-by: Amit Da

Re: [PATCH] thermal: exynos: fix handling of invalid frequency table entries

2013-04-09 Thread Zhang Rui
Hi, Andrew, can you please verify commit fc35b35cbe24ef021ea9acfba21e54da958df747 commit 57df8106932b57427df1eaaa13871857f75b1194 at http://git.kernel.org/cgit/linux/kernel/git/rzhang/linux.git/log/?h=thermal fixes the problem for you? thanks, rui On Tue, 2013-04-09 at 14:59 -0700, Andrew

Re: [PATCH 14/30] thermal/exynos: remove unnecessary header inclusions

2013-04-11 Thread Zhang Rui
by only the exynos platform. Fortunately a number > > of drivers that include those headers do not actually need > > them, so we can just remove the inclusions. > > > > Signed-off-by: Arnd Bergmann > > Cc: linux...@vger.kernel.org > > Cc: Zhang Rui > > This patc

Re: [PATCH v2 2/4] Thermal: exynos: Support for TMU regulator defined at device tree

2013-04-26 Thread Zhang Rui
Hi, all, what is the status now? which one is preferred, this one or the one from Amit's patch set? thanks, rui On Thu, 2013-04-25 at 18:29 +0200, Lukasz Majewski wrote: > Hi Eduardo, > > > Amit, Lukasz, > > > > On 25-04-2013 09:29, Lukasz Majewski wrote: > > > Hi Amit, > > > > > >> Hi Luka

Re: [PATCH V2 01/20] thermal: exynos: Moving exynos thermal files into samsung directory

2013-05-06 Thread Zhang Rui
On Fri, 2013-04-26 at 16:07 +0530, Amit Daniel Kachhap wrote: > This movement of files is done for easy maintenance and adding more > new sensor's support for exynos platform easily . This will also help in > bifurcating exynos common, sensor driver and sensor data related parts. > > Acked-by: Kuk

Re: [PATCH V2 02/20] thermal: exynos: Bifurcate exynos thermal common and tmu controller code

2013-05-06 Thread Zhang Rui
On Fri, 2013-04-26 at 16:07 +0530, Amit Daniel Kachhap wrote: > This code bifurcates exynos thermal implementation into common and sensor > specific parts. The common thermal code interacts with core thermal layer and > core cpufreq cooling parts and is independent of SOC specific driver. This > ch

Re: [PATCH V2 03/20] thermal: exynos: Rename exynos_thermal.c to exynos_tmu.c

2013-05-06 Thread Zhang Rui
On Fri, 2013-04-26 at 16:07 +0530, Amit Daniel Kachhap wrote: > This patch renames exynos_thermal.c to exynos_tmu.c. This change is needed as > this file now just contains exynos tmu driver related codes and thermal zone > or cpufreq cooling registration related changes are not there anymore. > >

Re: [PATCH V2 04/20] thermal: exynos: Move exynos_thermal.h from include/* to driver/* folder

2013-05-06 Thread Zhang Rui
On Fri, 2013-04-26 at 16:07 +0530, Amit Daniel Kachhap wrote: > This patch renames and moves include/linux/platform_data/exynos_thermal.h to > drivers/thermal/samsung/exynos_tmu.h. This file movement is needed as exynos > SOC's are not supporting non-DT based platforms. Also the rename is needed a

Re: [PATCH V2 05/20] thermal: exynos: Bifurcate exynos tmu driver and configuration data

2013-05-06 Thread Zhang Rui
On Fri, 2013-04-26 at 16:07 +0530, Amit Daniel Kachhap wrote: > This code splits the exynos tmu driver code into SOC specific data parts. > This will simplify adding new SOC specific data to the same TMU controller. > > Acked-by: Kukjin Kim > Signed-off-by: Amit Daniel Kachhap I'm okay with all

Re: [PATCH V3 02/21] thermal: exynos: Bifurcate exynos thermal common and tmu controller code

2013-05-07 Thread Zhang Rui
On Tue, 2013-05-07 at 18:30 +0530, Amit Daniel Kachhap wrote: > This code bifurcates exynos thermal implementation into common and sensor > specific parts. The common thermal code interacts with core thermal layer and > core cpufreq cooling parts and is independent of SOC specific driver. This > ch

RE: [PATCH v2 0/5] thermal: exynos: Fixes for v3.12

2013-10-13 Thread Zhang, Rui
3 1:47 PM > To: Zhang, Rui; Eduardo Valentin; kgene@samsung.com > Cc: Lukasz Majewski; Linux PM list; Lukasz Majewski; linux-kernel; > Bartlomiej Zolnierkiewicz; devicet...@vger.kernel.org; Amit Daniel > Kachhap; linux-samsung-soc@vger.kernel.org > Subject: Re: [PATCH v2 0/5] the

Re: [PATCH 23/25] thermal: exynos: fix error return code

2014-01-01 Thread Zhang Rui
On Sun, 2013-12-29 at 23:47 +0100, Julia Lawall wrote: > From: Julia Lawall > > Set the return variable to an error code as done elsewhere in the function. > > A simplified version of the semantic match that finds this problem is as > follows: (http://coccinelle.lip6.fr/) > > // > ( > if@p1 (\

Re: [PATCH] thermal:samsung: fix compilation warning

2014-01-01 Thread Zhang Rui
On Fri, 2013-12-20 at 17:42 +0530, Naveen Krishna Chatradhi wrote: > This patch fixes a compilation warning. > > warning: passing argument 5 of 'thermal_zone_device_register' discards 'const' > qualifier from pointer target type [enabled by default] > include/linux/thermal.h:270:29: note: expected

Re: [PATCH v12 1/4] thermal: samsung: replace inten_ bit fields with intclr_

2014-01-01 Thread Zhang Rui
On Thu, 2013-12-19 at 11:35 +0530, Naveen Krishna Chatradhi wrote: > This patch replaces the inten_rise_shift/mask and inten_fall_shift/mask > with intclr_rise_shift/mask and intclr_fall_shift/mask respectively. > Currently, inten_rise_shift/mask and inten_fall_shift/mask bits are only used > to co

Re: [PATCH] thermal: exynos: handle gate clock for misplaced TRIMINFO register

2014-01-01 Thread Zhang Rui
On Thu, 2013-11-07 at 18:12 +0530, Naveen Krishna Chatradhi wrote: > On Exynos5420 the TMU(4) for GPU has a seperate clock enable bit from > the other TMU channels(0 ~ 3). Hence, accessing TRIMINFO for base_second > should be acompanied by enabling the respective clock. > > This patch which allow

Re: [PATCH v12 0/7] cpufreq:boost: CPU Boost mode support

2014-01-09 Thread Zhang Rui
On Wed, 2014-01-08 at 01:35 +0100, Rafael J. Wysocki wrote: > On Tuesday, January 07, 2014 07:58:24 AM Lukasz Majewski wrote: > > Hi Rafael, > > Hi, > > > > This patch series introduces support for CPU overclocking technique > > > called Boost. > > > > > > It is a follow up of a LAB governor pro

Re: [PATCH v12 7/7] thermal:exynos:boost: Automatic enable/disable of BOOST feature (at Exynos4412)

2014-01-09 Thread Zhang Rui
W managed shut down of the system. > If the last trip point is crossed, the PMU HW generates the power off > signal. > > Signed-off-by: Lukasz Majewski > Signed-off-by: Myungjoo Ham > Acked-by: Eduardo Valentin Reviewed-by: Zhang Rui thanks, rui > > --- > Changes for

Re: [PATCH] thermal: samsung: Only update available threshold limits

2014-05-15 Thread Zhang Rui
On 四, 2014-04-24 at 11:48 +0530, Amit Kachhap wrote: > On 4/14/14, Tushar Behera wrote: > > Currently the threshold limits are updated in 2 stages, once for all > > software trigger levels and again for hardware trip point. > I guess the first stage is bootloader as could not find this in this fil

Re: [PATCH 00/10] thermal: exynos: various cleanups

2014-05-15 Thread Zhang Rui
On 一, 2014-05-05 at 13:15 +0200, Bartlomiej Zolnierkiewicz wrote: > Hi, > > This patch series contains various cleanups for EXYNOS thermal > driver. Overall it decreases driver's LOC by 13%. It is based > on next-20140428 kernel. It should not cause any functionality > changes. > Amit, what d

Re: [PATCH v2 0/9] thermal: exynos: various cleanups

2014-06-30 Thread Zhang Rui
Eduardo, what do you think of this patch set? thanks, rui On Tue, 2014-06-17 at 19:27 +0200, Bartlomiej Zolnierkiewicz wrote: > Hi, > > This patch series contains various cleanups for EXYNOS thermal > driver. Overall it decreases driver's LOC by 12%. It is based > on next-20140617 kernel. It

RE: [PATCH v2] thermal: consistently use int for temperatures

2015-07-23 Thread Zhang, Rui
As the original patch has not been in upstream, I'd prefer a refreshed patch, rather than an incremental fix. Thanks, rui > -Original Message- > From: Sascha Hauer [mailto:s.ha...@pengutronix.de] > Sent: Thursday, July 23, 2015 6:38 PM > To: Zhang, Rui > Cc:

RE: [PATCH v2] thermal: consistently use int for temperatures

2015-07-21 Thread Zhang, Rui
> -Original Message- > From: Punit Agrawal [mailto:punit.agra...@arm.com] > Sent: Tuesday, July 21, 2015 6:52 PM > To: Sascha Hauer > Cc: linux...@vger.kernel.org; Zhang, Rui; Eduardo Valentin; linux- > ker...@vger.kernel.org; Jean Delvare; Peter Feuerer; Heiko

Re: [RESEND PATCH] thermal: samsung: Add TMU support for Exynos3250 SoC

2014-07-20 Thread Zhang Rui
On Fri, 2014-07-18 at 09:00 +0900, Chanwoo Choi wrote: > This patch adds the registers, bit fields and compatible strings > required to support for the 1 TMU channels on Exynos3250. > > Signed-off-by: Chanwoo Choi > [Add MUX address setting bits by Jonghwa Lee] > Signed-off-by: Jonghwa Lee > Ack

RE: [PATCH V7 00/30] thermal: exynos: Re-structure driver and add support for exynos5440

2013-06-27 Thread Zhang, Rui
> -Original Message- > From: amit.kach...@gmail.com [mailto:amit.kach...@gmail.com] On Behalf > Of amit daniel kachhap > Sent: Friday, June 28, 2013 1:20 PM > To: Zhang, Rui > Cc: Eduardo Valentin; Kukjin Kim; linux...@vger.kernel.org; linux- > samsung-...@vger.

Re: [PATCH] thermal: exynos_tmu: fix wrong error check for mapped memory

2013-08-15 Thread Zhang Rui
On 三, 2013-08-07 at 14:01 +0530, Naveen Krishna Chatradhi wrote: > The error check is checking for a "base" mapped memory base > instead of "base_common". Fixing the same. > > Signed-off-by: Naveen Krishna Chatradhi applied. Thanks! BTW, can you rebase the other three exynos patches you submitte

Re: [PATCH 3/5] drivers: thermal: make usage of CONFIG_THERMAL_HWMON optional

2013-08-27 Thread Zhang Rui
On 二, 2013-08-27 at 23:17 +0200, Rafael J. Wysocki wrote: > On Tuesday, August 27, 2013 02:26:41 PM Eduardo Valentin wrote: > > On 23-08-2013 19:08, Rafael J. Wysocki wrote: > > > On Friday, August 23, 2013 06:03:14 PM Eduardo Valentin wrote: > > >> When registering a new thermal_device, the therma