Re: [PATCH 05/15] ARM: S5P6442: Change to using s3c_gpio_cfgpin_range()

2010-05-30 Thread Kyungmin Park
On Mon, May 31, 2010 at 10:09 AM, Ben Dooks wrote: > On Fri, May 28, 2010 at 03:24:02PM +0900, Kyungmin Park wrote: >> Hi, >> >> Looks good but I'm afraid it's more difficult to find pin >> configuration from typo. > > Do you meant that there's now no explicit mention of all pins invovled? When d

Re: [PATCH 05/15] ARM: S5P6442: Change to using s3c_gpio_cfgpin_range()

2010-05-30 Thread Ben Dooks
On Fri, May 28, 2010 at 03:24:02PM +0900, Kyungmin Park wrote: > Hi, > > Looks good but I'm afraid it's more difficult to find pin > configuration from typo. Do you meant that there's now no explicit mention of all pins invovled? Note, may decided to drop or re-do this series. -- Ben Q:

Re: [PATCH 05/15] ARM: S5P6442: Change to using s3c_gpio_cfgpin_range()

2010-05-27 Thread Ben Dooks
On Fri, May 28, 2010 at 03:24:02PM +0900, Kyungmin Park wrote: > Hi, > > Looks good but I'm afraid it's more difficult to find pin > configuration from typo. I'm not sure if that's really so much of a problem. > On Fri, May 28, 2010 at 2:56 PM, Ben Dooks wrote: > > Change the code setting rang

Re: [PATCH 05/15] ARM: S5P6442: Change to using s3c_gpio_cfgpin_range()

2010-05-27 Thread Kyungmin Park
Hi, Looks good but I'm afraid it's more difficult to find pin configuration from typo. On Fri, May 28, 2010 at 2:56 PM, Ben Dooks wrote: > Change the code setting ranges of GPIO pins using s3c_gpio_cfgpin() to > use the recently introduced s3c_gpio_cfgpin_range(). > > Signed-off-by: Ben Dooks >

[PATCH 05/15] ARM: S5P6442: Change to using s3c_gpio_cfgpin_range()

2010-05-27 Thread Ben Dooks
Change the code setting ranges of GPIO pins using s3c_gpio_cfgpin() to use the recently introduced s3c_gpio_cfgpin_range(). Signed-off-by: Ben Dooks --- arch/arm/mach-s5p6442/dev-audio.c | 30 ++ arch/arm/mach-s5p6442/dev-spi.c |4 +--- 2 files changed, 11 ins