Re: [PATCH 5/5] mmc: sdhci-s3c: setup pins using pinctrl interface

2012-03-19 Thread Stephen Warren
On 03/11/2012 06:46 AM, Thomas Abraham wrote: The platform specific callback to setup the sdhci pin mux and pin config is removed and the pinctrl subsystem interface is used to setup the mux and config. @@ -643,8 +649,13 @@ static int __devinit sdhci_s3c_probe(struct platform_device *pdev)

Re: [PATCH 5/5] mmc: sdhci-s3c: setup pins using pinctrl interface

2012-03-12 Thread Mark Brown
On Sun, Mar 11, 2012 at 06:16:05PM +0530, Thomas Abraham wrote: The platform specific callback to setup the sdhci pin mux and pin config is removed and the pinctrl subsystem interface is used to setup the mux and config. You've only added pinctrl support for Exynos but this driver is also used

Re: [PATCH 5/5] mmc: sdhci-s3c: setup pins using pinctrl interface

2012-03-12 Thread Thomas Abraham
On 12 March 2012 19:51, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Sun, Mar 11, 2012 at 06:16:05PM +0530, Thomas Abraham wrote: The platform specific callback to setup the sdhci pin mux and pin config is removed and the pinctrl subsystem interface is used to setup the mux and

Re: [PATCH 5/5] mmc: sdhci-s3c: setup pins using pinctrl interface

2012-03-12 Thread Mark Brown
On Mon, Mar 12, 2012 at 08:01:34PM +0530, Thomas Abraham wrote: Yes, I agree with your comment. I did refer to manuals of s3c24xx to Exynos to ensure that the samsung pinctrl driver is generic and reusable on all samsung soc's. I hope I have not missed out something important that would

[PATCH 5/5] mmc: sdhci-s3c: setup pins using pinctrl interface

2012-03-11 Thread Thomas Abraham
The platform specific callback to setup the sdhci pin mux and pin config is removed and the pinctrl subsystem interface is used to setup the mux and config. Signed-off-by: Thomas Abraham thomas.abra...@linaro.org --- drivers/mmc/host/sdhci-s3c.c | 15 +-- 1 files changed, 13

Re: [PATCH 5/5] mmc: sdhci-s3c: setup pins using pinctrl interface

2012-03-11 Thread Kukjin Kim
Thomas Abraham wrote: The platform specific callback to setup the sdhci pin mux and pin config is removed and the pinctrl subsystem interface is used to setup the mux and config. Signed-off-by: Thomas Abrahamthomas.abra...@linaro.org --- drivers/mmc/host/sdhci-s3c.c | 15

Re: [PATCH 5/5] mmc: sdhci-s3c: setup pins using pinctrl interface

2012-03-11 Thread Kyungmin Park
On 3/11/12, Thomas Abraham thomas.abra...@linaro.org wrote: The platform specific callback to setup the sdhci pin mux and pin config is removed and the pinctrl subsystem interface is used to setup the mux and config. Signed-off-by: Thomas Abraham thomas.abra...@linaro.org ---

Re: [PATCH 5/5] mmc: sdhci-s3c: setup pins using pinctrl interface

2012-03-11 Thread Thomas Abraham
2012/3/12 Kukjin Kim kgene@samsung.com: Thomas Abraham wrote: The platform specific callback to setup the sdhci pin mux and pin config is removed and the pinctrl subsystem interface is used to setup the mux and config. Signed-off-by: Thomas Abrahamthomas.abra...@linaro.org ---  

Re: [PATCH 5/5] mmc: sdhci-s3c: setup pins using pinctrl interface

2012-03-11 Thread Thomas Abraham
On 12 March 2012 08:08, Kyungmin Park kmp...@infradead.org wrote: On 3/11/12, Thomas Abraham thomas.abra...@linaro.org wrote: The platform specific callback to setup the sdhci pin mux and pin config is removed and the pinctrl subsystem interface is used to setup the mux and config.