On Sun, 16 Mar 2014 20:53:25 -0700
Byungho An bh74...@samsung.com wrote:
They are used but they always point to the same set of methods.
Those methods could thus be directly called.
Yes, those methods can be called directly.
But I think it is acceptable for manageability and extension
Andrew.an bh74...@samsung.com :
[...]
+struct sxgbe_core_ops {
+ /* MAC core initialization */
+ void (*core_init)(void __iomem *ioaddr);
[...]
+ /* adjust SXGBE speed */
+ void (*set_speed)(void __iomem *ioaddr, unsigned char speed);
+};
This indirection level is never
Francois Romieu rom...@fr.zoreil.com :
[...]
+struct sxgbe_core_ops {
+ /* MAC core initialization */
+ void (*core_init)(void __iomem *ioaddr);
[...]
+ /* adjust SXGBE speed */
+ void (*set_speed)(void __iomem *ioaddr, unsigned char
speed); };
Francois Romieu rom...@fr.zoreil.com
Byungho An bh74...@samsung.com :
From: Siva Reddy siva.kal...@samsung.com
This patch adds support for Samsung 10Gb ethernet driver(sxgbe).
- sxgbe core initialization
- Tx and Rx support
- MDIO support
- ISRs for Tx and Rx
- ifconfig support to
On Thu, 2014-03-13 at 15:55 +0900, Byungho An wrote:
This patch adds support for Samsung 10Gb ethernet driver(sxgbe).
- sxgbe core initialization
- Tx and Rx support
- MDIO support
- ISRs for Tx and Rx
- ifconfig support to driver
[]
diff --git a/drivers/net/ethernet/samsung/sxgbe_desc.c
On Thu, 2014-03-13 at 05:53 -0700, Joe Perches wrote:
Maybe this was supposed to be something like
ns = p-tstamp_lo
ns |= ((u64)tstamp_hi) 32;
If not, maybe it warrants a comment around
here or on the descriptor definition
[]
+struct sxgbe_rx_ctxt_desc {
+ u32
Byungho An bh74...@samsung.com :
From: Siva Reddy siva.kal...@samsung.com
This patch adds support for Samsung 10Gb ethernet driver(sxgbe).
- sxgbe core initialization
- Tx and Rx support
- MDIO support
- ISRs for Tx and Rx
- ifconfig support to driver
You'll find a partial review below.
