RE: [RFC/PATCH v6 3/4] MFC: Add MFC 5.1 V4L2 driver

2011-02-19 Thread Jaeryul Oh
...@samsung.com; kgene@samsung.com Subject: RE: [RFC/PATCH v6 3/4] MFC: Add MFC 5.1 V4L2 driver From: Jaeryul Oh [mailto:jaeryul...@samsung.com] Kamil, I have a question about MFC state FINISHING FINISHED as below. Hi Peter, I have answered your question below

RE: [RFC/PATCH v6 3/4] MFC: Add MFC 5.1 V4L2 driver

2011-02-18 Thread Kamil Debski
From: Jaeryul Oh [mailto:jaeryul...@samsung.com] Kamil, I have a question about MFC state FINISHING FINISHED as below. Hi Peter, I have answered your question below. -Original Message- From: linux-media-ow...@vger.kernel.org [mailto:linux-media- ow...@vger.kernel.org] On

RE: [RFC/PATCH v6 3/4] MFC: Add MFC 5.1 V4L2 driver

2011-02-17 Thread Jaeryul Oh
Kamil, I have a question about MFC state FINISHING FINISHED as below. -Original Message- From: linux-media-ow...@vger.kernel.org [mailto:linux-media- ow...@vger.kernel.org] On Behalf Of Kamil Debski Sent: Saturday, January 08, 2011 1:26 AM To: linux-me...@vger.kernel.org;

RE: [RFC/PATCH v6 3/4] MFC: Add MFC 5.1 V4L2 driver

2011-01-18 Thread Kamil Debski
Hi, From: Jaeryul Oh [mailto:jaeryul...@samsung.com] Hi, Kamil I have a comment about s5p_mfc_stop_streaming()function. -Original Message- From: linux-media-ow...@vger.kernel.org [mailto:linux-media- ow...@vger.kernel.org] On Behalf Of Kamil Debski Sent: Saturday, January

RE: [RFC/PATCH v6 3/4] MFC: Add MFC 5.1 V4L2 driver

2011-01-17 Thread Jaeryul Oh
; kyungmin.p...@samsung.com; kgene@samsung.com Subject: RE: [RFC/PATCH v6 3/4] MFC: Add MFC 5.1 V4L2 driver Hi, I don't see the need to do DQBUF on the source buffer that has the I-frame with changed resolution. I think that one could notify the application by setting size=0 on the CAPTURE

RE: [RFC/PATCH v6 3/4] MFC: Add MFC 5.1 V4L2 driver

2011-01-16 Thread Kamil Debski
To: 'Jonghun Han'; 'Kamil Debski'; linux-me...@vger.kernel.org; linux- samsung-...@vger.kernel.org Cc: 'Marek Szyprowski'; pa...@osciak.com; kyungmin.p...@samsung.com; kgene@samsung.com Subject: RE: [RFC/PATCH v6 3/4] MFC: Add MFC 5.1 V4L2 driver I added my comments. I guess that Kamil's way

RE: [RFC/PATCH v6 3/4] MFC: Add MFC 5.1 V4L2 driver

2011-01-14 Thread Jonghun Han
/PATCH v6 3/4] MFC: Add MFC 5.1 V4L2 driver Hi, -Original Message- From: Jonghun Han [mailto:jonghun@samsung.com] Hi, Kamil Debski wrote: snip +/* Reqeust buffers */ +static int vidioc_reqbufs(struct file *file, void *priv

RE: [RFC/PATCH v6 3/4] MFC: Add MFC 5.1 V4L2 driver

2011-01-14 Thread Jaeryul Oh
...@vger.kernel.org Cc: 'Marek Szyprowski'; pa...@osciak.com; kyungmin.p...@samsung.com; jaeryul...@samsung.com; kgene@samsung.com Subject: RE: [RFC/PATCH v6 3/4] MFC: Add MFC 5.1 V4L2 driver Hi, I was confused the source and destination. I agree with you mostly. In my opinion

RE: [RFC/PATCH v6 3/4] MFC: Add MFC 5.1 V4L2 driver

2011-01-13 Thread Jonghun Han
Hi, Kamil Debski wrote: snip +/* Reqeust buffers */ +static int vidioc_reqbufs(struct file *file, void *priv, + struct v4l2_requestbuffers *reqbufs) +{ + struct s5p_mfc_dev *dev = video_drvdata(file); + struct s5p_mfc_ctx *ctx = priv; +

RE: [RFC/PATCH v6 3/4] MFC: Add MFC 5.1 V4L2 driver

2011-01-13 Thread Kamil Debski
Hi, -Original Message- From: Jonghun Han [mailto:jonghun@samsung.com] Hi, Kamil Debski wrote: snip +/* Reqeust buffers */ +static int vidioc_reqbufs(struct file *file, void *priv, + struct v4l2_requestbuffers *reqbufs) +{ +