Re: [PATCH 4/7] arm: dts: Add syscon-{reboot, poweroff} nodes for exynos5410 SoC

2015-10-19 Thread Javier Martinez Canillas
>; > + offset = <0x0400>; > + mask = <0x1>; > + }; > + Reviewed-by: Javier Martinez Canillas Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 5/7] ARM: exynos_defconfig: Normalize exynos defconfig

2015-10-19 Thread Javier Martinez Canillas
> -CONFIG_CHROME_PLATFORMS=y > CONFIG_CROS_EC_CHARDEV=y > CONFIG_COMMON_CLK_MAX77686=y > CONFIG_COMMON_CLK_MAX77802=y > @@ -190,7 +187,6 @@ CONFIG_PWM_SAMSUNG=y > CONFIG_PHY_EXYNOS5250_SATA=y > CONFIG_EXT2_FS=y > CONFIG_EXT3_FS=y > -CONFIG_EXT4_FS=y > CONFIG_MSDOS_FS=y

Re: [PATCH 7/7] ARM: EXYNOS: Remove code for restart and poweroff for exynos SoCs

2015-10-19 Thread Javier Martinez Canillas
Hello Krzysztof, On 10/19/2015 03:28 PM, Krzysztof Kozlowski wrote: > 2015-10-19 18:56 GMT+09:00 Javier Martinez Canillas : >> Hello, >> >> On 10/19/2015 09:00 AM, Krzysztof Kozlowski wrote: >>> On 19.10.2015 15:03, Alim Akhtar wrote: >>>> Now we c

Re: [PATCH 5/7] ARM: exynos_defconfig: Normalize exynos defconfig

2015-10-19 Thread Javier Martinez Canillas
Hello Alim, On 10/19/2015 05:58 PM, Alim Akhtar wrote: > Hi Javier, > > On Mon, Oct 19, 2015 at 6:55 PM, Javier Martinez Canillas > wrote: >> Hello Alim, >> >> On 10/19/2015 08:03 AM, Alim Akhtar wrote: >>> make savedefconfig result in some diffe

Re: [PATCH 7/7] ARM: EXYNOS: Remove code for restart and poweroff for exynos SoCs

2015-10-19 Thread Javier Martinez Canillas
Hello Alim, On 10/19/2015 06:13 PM, Alim Akhtar wrote: > Hi Javier, > > On Mon, Oct 19, 2015 at 7:37 PM, Javier Martinez Canillas > wrote: >> Hello Krzysztof, >> >> On 10/19/2015 03:28 PM, Krzysztof Kozlowski wrote: >>> 2015-10-19 18:56 GMT+09:00 Jav

Re: [PATCH v6 0/17] Add Analogix Core Display Port Driver

2015-10-20 Thread Javier Martinez Canillas
Hello Yakir, On 10/20/2015 04:10 AM, Yakir Yang wrote: > Hi Javier, > > On 10/19/2015 06:40 PM, Javier Martinez Canillas wrote: >> Hello Yakir, >> >> On 10/10/2015 05:35 PM, Yakir Yang wrote: >>> Hi all, >>> >>> The Samsung Exynos eDP c

Re: [PATCH v2 0/6] Switch to generic syscon regmap based drivers

2015-10-20 Thread Javier Martinez Canillas
d XU. Reboot and poweroff are working correctly on both boards with these patches. Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord..

Re: [PATCH v2 3/6] arm: dts: Add syscon-{reboot, poweroff} nodes for exynos5

2015-10-20 Thread Javier Martinez Canillas
Hello Alim, On 10/20/2015 11:24 AM, Alim Akhtar wrote: > This patch adds syscon-{reboot, poweroff} nodes to allow the > generic syscon-{reboot, poweroff} driver to reset/poweroff exynos5 SoCs. > > Signed-off-by: Alim Akhtar > Reviewed-by: Pankaj Dubey > Reviewed-by: Javier

Re: [PATCH v2 5/6] ARM: exynos: select POWER_RESET_SYSCON and POWER_RESET_SYSCON_POWEROFF

2015-10-20 Thread Javier Martinez Canillas
off} drivers depends on it. > > Signed-off-by: Alim Akhtar > --- > Patch looks good to me. Reviewed-by: Javier Martinez Canillas Tested-by: Javier Martinez Canillas Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America -- To unsubscribe from

Re: [PATCH v2 6/6] ARM: EXYNOS: Remove code for restart and poweroff for exynos SoCs

2015-10-20 Thread Javier Martinez Canillas
ards with older dtbs > with a newer kernel. > > Signed-off-by: Alim Akhtar > Reviewed-by: Javier Martinez Canillas > Acked-by: Moritz Fischer > --- > arch/arm/mach-exynos/pmu.c | 43 --- > 1 file changed, 43 deletions(-) > Tes

Re: [PATCH 1/2] dt-bindings: Consolidate Exynos SoC bindings under Samsung directory

2015-10-21 Thread Javier Martinez Canillas
f-by: Krzysztof Kozlowski > Cc: Kukjin Kim > --- Patch looks good to me. Reviewed-by: Javier Martinez Canillas Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in

Re: [PATCH 2/2] dt-bindings: EXYNOS: Document compatibles from other vendors

2015-10-21 Thread Javier Martinez Canillas
Hello Krzysztof, On 10/21/2015 03:30 AM, Krzysztof Kozlowski wrote: > Document compatibles used on other Exynos-based boards (non-Samsung): > FriendlyARM, Google, Hardkernel and Insignal. > > Signed-off-by: Krzysztof Kozlowski > Cc: Kukjin Kim > Cc: Javier Martinez Canillas

Re: [PATCH] MAINTAINERS: ARM: EXYNOS: Add documentation and dt-bindings

2015-10-21 Thread Javier Martinez Canillas
c/samsung/* > +F: Documentation/arm/Samsung/ That there is also a Documentation/arm/Samsung-S3C24XX/ so I think this should be Documentation/arm/Samsung*/ instead. > +F: Documentation/devicetree/bindings/arm/samsung/ > N: exynos > > ARM/SAMSUNG MOBILE MACHINE SUPPORT > R

Re: [PATCH v2 0/6] Switch to generic syscon regmap based drivers

2015-10-21 Thread Javier Martinez Canillas
c and the card shouldn't be left in an unknown state. So the problem here is not that the system is not being reset (that I think that works) but that on reboot, the system is not able to boot again since the ROM is not able to read the second stage bootloader. Markus, Can you please test follo

Re: [PATCH] MAINTAINERS: ARM: EXYNOS: Add documentation and dt-bindings

2015-10-21 Thread Javier Martinez Canillas
Hello Krzysztof, On 10/21/2015 02:43 PM, Krzysztof Kozlowski wrote: > 2015-10-21 17:45 GMT+09:00 Javier Martinez Canillas : >> >> Hello Krzysztof, >> >> Patch looks good to me, I've only one comment. >> >> On 10/21/2015 03:33 AM, Krzysztof Kozlowski wro

Re: [PATCH v2 0/6] Switch to generic syscon regmap based drivers

2015-10-21 Thread Javier Martinez Canillas
oot is later changed to prio 128 and the watchdog handlers to 0. Best regards, [0]: http://lxr.free-electrons.com/source/kernel/reboot.c#L113 Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America -- To unsubscribe from this list: send the line "unsubscribe linu

Re: [PATCH v2 0/6] Switch to generic syscon regmap based drivers

2015-10-21 Thread Javier Martinez Canillas
atch fixes the issue, reboot works now on U3. >>> >> Good to know that. >> Thanks >>> >>> Tested-by: Markus Reichl >>> >>> Thanks, >>> -- >>> Markus >>> >>> >>>> >>>> Best regards,

Re: [PATCH v2 0/6] Switch to generic syscon regmap based drivers

2015-10-21 Thread Javier Martinez Canillas
Hello Alim, On 10/21/2015 04:50 PM, Alim Akhtar wrote: [snip] >> >> [0]: >> From c9b250ee03bae338339b70693e906145c719f783 Mon Sep 17 00:00:00 2001 >> From: Javier Martinez Canillas >> Date: Wed, 21 Oct 2015 11:59:44 +0200 >> Subject: [RFT PATCH] mmc: p

[PATCH] mmc: pwrseq: Use highest priority for eMMC restart handler

2015-10-21 Thread Javier Martinez Canillas
e the priority 128, there are other restart handlers (such as the syscon-reboot one) that use a higher priority. So, use the highest priority to make sure that the eMMC hw is reset before a system reboot. Signed-off-by: Javier Martinez Canillas Tested-by: Markus Reichl Tested-by: Anand Moon Reviewed-by:

Re: [PATCH] mmc: pwrseq: Use highest priority for eMMC restart handler

2015-10-21 Thread Javier Martinez Canillas
Hello Krzysztof, Thanks for your feedback. On 10/22/2015 02:36 AM, Krzysztof Kozlowski wrote: > On 22.10.2015 00:15, Javier Martinez Canillas wrote: >> The pwrseq_emmc driver does a eMMC card reset before a system reboot to >> allow broken or limited ROM boot-loaders (that don

Re: [PATCH] mmc: pwrseq: Use highest priority for eMMC restart handler

2015-10-21 Thread Javier Martinez Canillas
Hello Krzysztof, On 10/22/2015 03:43 AM, Krzysztof Kozlowski wrote: > On 22.10.2015 10:20, Javier Martinez Canillas wrote:> Hello Krzysztof, >> >> Thanks for your feedback. >> >> On 10/22/2015 02:36 AM, Krzysztof Kozlowski wrote: >>> On 22.10.2015 00:15, J

Re: [PATCH] mmc: pwrseq: Use highest priority for eMMC restart handler

2015-10-22 Thread Javier Martinez Canillas
Hello Anand, On 10/22/2015 07:03 AM, Anand Moon wrote: > Hi Javier, > > On 22 October 2015 at 08:22, Javier Martinez Canillas > wrote: >> Hello Krzysztof, >> >> On 10/22/2015 03:43 AM, Krzysztof Kozlowski wrote: >>> On 22.10.2015 10:20, Javier Ma

Re: [PATCH] mmc: pwrseq: Use highest priority for eMMC restart handler

2015-10-22 Thread Javier Martinez Canillas
Hello Marek, On 10/22/2015 12:07 PM, Marek Szyprowski wrote: > On 2015-10-22 06:14, Alim Akhtar wrote: >> On 10/22/2015 08:22 AM, Javier Martinez Canillas wrote: >>> On 10/22/2015 03:43 AM, Krzysztof Kozlowski wrote: >>>> On 22.10.2015 10:20, Javier Martinez Ca

Re: [PATCH] mmc: pwrseq: Use highest priority for eMMC restart handler

2015-10-22 Thread Javier Martinez Canillas
ms that most default system restart handlers use 128 and that's the reason why gpio-restart and mmc-pwrseq-emmc use 129 and other restart handlers that can be registered via DT use 192 (which is in the middle of 128 and 255). So I actually thought to use a number in between 192 and 255 (i

Re: [PATCH] mmc: pwrseq: Use highest priority for eMMC restart handler

2015-10-22 Thread Javier Martinez Canillas
Hello Doug, On 10/22/2015 07:33 PM, Doug Anderson wrote: > On Thu, Oct 22, 2015 at 9:07 AM, Javier Martinez Canillas [snip] >> >> Do you know why the priority 200 was chosen for veyron gpi-restart ooi? > > In David Riley's original patch the example had 200: >

Re: [PATCH] mmc: pwrseq: Use highest priority for eMMC restart handler

2015-10-28 Thread Javier Martinez Canillas
Hello Ulf, On 10/27/2015 11:10 AM, Ulf Hansson wrote: > On 21 October 2015 at 17:15, Javier Martinez Canillas > wrote: >> The pwrseq_emmc driver does a eMMC card reset before a system reboot to >> allow broken or limited ROM boot-loaders (that don't have an eMMC reset

Re: [PATCH 1/2] arm64: dts: exynos7: Add pmic s2mps15 device tree node

2015-11-02 Thread Javier Martinez Canillas
_ldo1"; > + regulator-min-microvolt = <50>; > + regulator-max-microvolt = <90>; > + regulator-always-on; I see that all regulators are marked as regulator-always-on but that will prevent

Re: [PATCH 2/2] arm64: dts: exynos7: Enable HS200 mode operation

2015-11-02 Thread Javier Martinez Canillas
&mmc_0 { > status = "okay"; > num-slots = <1>; > - broken-cd; > cap-mmc-highspeed; > + mmc-hs200-1_8v; > non-removable; > card-detect-delay = <200>; > clock-frequency = <8>; > Reviewed-by: Ja

Re: [PATCH v2 0/6] ARM: dts: Use correct CD properties for SDIO and eMMC in Snow and Peach

2015-11-08 Thread Javier Martinez Canillas
Hello Kukjin, On 10/19/2015 12:04 AM, Alim Akhtar wrote: > Hi Javier, > > On 10/15/2015 10:21 PM, Javier Martinez Canillas wrote: >> Hello, >> >> The Exynos Chromebooks DTS don't use the correct card detection properties >> since these were carried from the

[PATCH] ARM: multi_v7_defconfig: Build ChromeOS EC drivers as modules

2015-11-17 Thread Javier Martinez Canillas
Since the multi_v7_defconfig is used to build an image for different platforms, the options should be enabled as module whenever possible. Signed-off-by: Javier Martinez Canillas --- The patch was tested on an Exynos5800 Peach Pi Chromebook and the drivers' modules were correctly autol

[RESEND PATCH v2 5/6] ARM: dts: Remove broken-cd from eMMC node in exynos5420-peach-pi

2015-11-18 Thread Javier Martinez Canillas
that is not needed with non-removable. Signed-off-by: Javier Martinez Canillas Reviewed-by: Krzysztof Kozlowski Reviewed-by: Alim Akhtar Tested-by: Alim Akhtar --- arch/arm/boot/dts/exynos5420-peach-pit.dts | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/arm/boot/dts/exynos5420

[RESEND PATCH v2 6/6] ARM: dts: Mark eMMC as non-removable in exynos5250-snow-common

2015-11-18 Thread Javier Martinez Canillas
The eMMC is non-removable so mark it using the non-removable DT property to avoid having to redetect it after a suspend/resume. Also remove the card-detect-delay property that is not needed with non-removable. Signed-off-by: Javier Martinez Canillas Reviewed-by: Tomeu Vizoso Tested-by: Tomeu

[RESEND PATCH v2 2/6] ARM: dts: Mark SDIO as non-removable in exynos5420-peach-pit

2015-11-18 Thread Javier Martinez Canillas
following warnings is shown after a resume: [ 181.944636] mmc2: error -2 during resume (card was removed?) Also remove the card-detect-delay property that is not needed with non-removable. Signed-off-by: Javier Martinez Canillas Reviewed-by: Krzysztof Kozlowski Reviewed-by: Alim Akhtar ---

[RESEND PATCH v2 4/6] ARM: dts: Remove broken-cd from eMMC node in exynos5800-peach-pi

2015-11-18 Thread Javier Martinez Canillas
that is not needed with non-removable. Signed-off-by: Javier Martinez Canillas Reviewed-by: Krzysztof Kozlowski Reviewed-by: Alim Akhtar Tested-by: Alim Akhtar --- arch/arm/boot/dts/exynos5800-peach-pi.dts | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/arm/boot/dts/exynos5800

[RESEND PATCH v2 3/6] ARM: dts: Mark SDIO as non-removable in exynos5250-snow-common

2015-11-18 Thread Javier Martinez Canillas
following warnings is shown after a resume: [ 181.944636] mmc2: error -2 during resume (card was removed?) Also remove the card-detect-delay property that is not needed with non-removable. Signed-off-by: Javier Martinez Canillas Reviewed-by: Tomeu Vizoso Tested-by: Tomeu Vizoso Reviewed-by:

Re: [RESEND PATCH v2 6/6] ARM: dts: Mark eMMC as non-removable in exynos5250-snow-common

2015-11-18 Thread Javier Martinez Canillas
Hello, On 11/18/2015 10:23 AM, Javier Martinez Canillas wrote: > The eMMC is non-removable so mark it using the non-removable DT > property to avoid having to redetect it after a suspend/resume. > > Also remove the card-detect-delay property that is not needed with > non-removab

[RESEND PATCH v2 1/6] ARM: dts: Mark SDIO as non-removable in exynos5800-peach-pi

2015-11-18 Thread Javier Martinez Canillas
following warnings is shown after a resume: [ 181.944636] mmc2: error -2 during resume (card was removed?) Also remove the card-detect-delay property that is not needed with non-removable. Signed-off-by: Javier Martinez Canillas Reviewed-by: Krzysztof Kozlowski Reviewed-by: Alim Akhtar ---

[RESEND PATCH v2 0/6] ARM: dts: Use correct CD properties for SDIO and eMMC in Snow and Peach

2015-11-18 Thread Javier Martinez Canillas
ed-by tags that were previously collected. [0]: https://lkml.org/lkml/2015/10/15/640 Best regards, Javier Javier Martinez Canillas (6): ARM: dts: Mark SDIO as non-removable in exynos5800-peach-pi ARM: dts: Mark SDIO as non-removable in exynos5420-peach-pit ARM: dts: Mark SDIO as non-removab

Re: [PATCH v2 0/7] drm/exynos: add pm runtime support

2015-11-19 Thread Javier Martinez Canillas
the machine in a bootable state again, the sha1 hash for these patches in next-20151119 are: 045febd5f813 drm/exynos: add pm_runtime to FIMD dd766fb8479b drm/exynos: add pm_runtime to Mixer Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America -- To unsubscribe from

Re: [PATCH v2 0/7] drm/exynos: add pm runtime support

2015-11-19 Thread Javier Martinez Canillas
On 11/19/2015 11:51 AM, Javier Martinez Canillas wrote: > [adding Kevin and Tyler to cc list] > > Hello Inki and Gustavo, I didn't notice before that Gustavo was not cc'ed in the original email from Inki so I'm adding him as well. Sorry to others for the noise. > >

Re: [PATCH v2 0/7] drm/exynos: add pm runtime support

2015-11-19 Thread Javier Martinez Canillas
On 11/19/2015 11:55 AM, Javier Martinez Canillas wrote: >>> >> >> This series causes a boot failure on at least an Exynos5800 Peach Pi >> Chromebook (tested myself) and seems to be the cause of other Exynos >> boards failing to boot: http://kernelci.org/boot/?exyn

Re: [PATCH v2 0/6] Switch to generic syscon regmap based drivers

2015-11-19 Thread Javier Martinez Canillas
Hello Alim, On Thu, Nov 19, 2015 at 3:06 PM, Alim Akhtar wrote: [snip] >> >> Javier, Alim, Ulf, >> >> I am not grabbing any more patches for v4.4 because I doubt that they >> could be merged to arm-soc for this cycle. My last pull requests for >> v4.4 is still pending... >> >> This means that I

Re: [PATCH v2 0/7] drm/exynos: add pm runtime support

2015-11-20 Thread Javier Martinez Canillas
Hello Inki, On 11/20/2015 07:59 AM, Inki Dae wrote: > Hi Javier, > > 2015년 11월 20일 00:51에 Javier Martinez Canillas 이(가) 쓴 글: >> On 11/19/2015 11:55 AM, Javier Martinez Canillas wrote: >>>>> >>>> >>>> This series causes a boot failure on a

Re: [PATCH v2 0/7] drm/exynos: add pm runtime support

2015-11-20 Thread Javier Martinez Canillas
Hello Inki, On 11/20/2015 08:13 AM, Inki Dae wrote: > > > 2015년 11월 20일 19:59에 Inki Dae 이(가) 쓴 글: >> Hi Javier, >> >> 2015년 11월 20일 00:51에 Javier Martinez Canillas 이(가) 쓴 글: >>> On 11/19/2015 11:55 AM, Javier Martinez Canillas wrote: >>>>>&g

Re: [PATCH 1/2] clk: exynos5420: Add IDs for clocks used in DISP1 power domain

2015-01-21 Thread Javier Martinez Canillas
Hello, On 01/20/2015 06:54 PM, Mike Turquette wrote: > Quoting Sylwester Nawrocki (2015-01-20 06:04:00) >> Hi, >> >> On 20/01/15 11:35, Javier Martinez Canillas wrote: >> > When a power domain is powered off on Exynos5420 SoC, the input clocks of >> > th

Re: [PATCH RESEND v2 5/7] mfd: cros_ec: Instantiate ChromeOS EC character device

2015-01-21 Thread Javier Martinez Canillas
Hello Lee, On 01/20/2015 06:11 PM, Javier Martinez Canillas wrote: >> >> But is it really a chardev? Don't chardevs usually live in >> drivers/char? It probably uses a chardev node in /dev, but what does >> it really do? What information can/will userspace obt

Re: [PATCH RESEND v2 3/7] mfd: cros_ec: Add cros_ec_lpc driver for x86 devices

2015-01-21 Thread Javier Martinez Canillas
Hello Lee, On 01/20/2015 05:52 PM, Javier Martinez Canillas wrote: >>> >>> Now, all those drivers may be wrong and the buses don't belong to the mfd >>> subsystem but then I think we need to document that since it seems that is >>> the correct way to d

Re: [PATCH RESEND v2 3/7] mfd: cros_ec: Add cros_ec_lpc driver for x86 devices

2015-01-22 Thread Javier Martinez Canillas
Hello Lee, On 01/22/2015 09:42 AM, Lee Jones wrote: >> > >> > I don't think the drivers you mentioned above do anything practical. >> > For instance, they are not SPI/IC2/etc drivers. They should only >> > offer some abstraction layers which are used to communicate with the >> > device. The dri

Re: [PATCH RESEND v2 3/7] mfd: cros_ec: Add cros_ec_lpc driver for x86 devices

2015-01-22 Thread Javier Martinez Canillas
Hello Lee, On 01/22/2015 10:46 AM, Lee Jones wrote: >> >> But there doesn't seem to be a LPC subsystem in the kernel so we don't have a >> nice abstraction layer in this case. > > This is the crux of the problem. However, I feel bad for MFD, as it > is, once more, being used as an "well it does

Re: [PATCH RESEND v2 3/7] mfd: cros_ec: Add cros_ec_lpc driver for x86 devices

2015-01-22 Thread Javier Martinez Canillas
Hello Lee, On 01/22/2015 11:56 AM, Lee Jones wrote: >> > >> Yes, I completely understand your point, is that I didn't think that a ~300 >> lines driver was that bad specially since the communication bits that reads >> and writes the register is not a complex logic IMHO. > > This has nothing to do

Re: [PATCH v4 9/9] drm/exynos: add support for 'hdmi' clock

2015-01-22 Thread Javier Martinez Canillas
Hello Marek, On 01/22/2015 01:41 PM, Marek Szyprowski wrote: >>> >>> + mixer_res->hdmi = devm_clk_get(dev, "hdmi"); >> You need to update the >> Documentation/devicetree/bindings/video/exynos_mixer.txt >> DT binding docs to also mention the "hdmi" clock in the list of clocks. > > Right, I'v

Re: [PATCH v4 RESEND 9/9] drm/exynos: add support for 'hdmi' clock

2015-01-22 Thread Javier Martinez Canillas
xynos4 based boards. > > Suggested-by: Andrzej Hajda > Signed-off-by: Marek Szyprowski > --- The patch looks good to me and I tested that it does not regress HDMI on other platforms (Exynos5420 Peach Pit). I've just a comment below. Reviewed-by: Javier Martinez Canillas Tested

[PATCH v3 0/7] platform/chrome: Add user-space dev inferface support

2015-01-22 Thread Javier Martinez Canillas
xpose Chrome OS Lightbar to users Javier Martinez Canillas (3): mfd: cros_ec: Use fixed size arrays to transfer data with the EC mfd: cros_ec: Add char dev and virtual dev pointers mfd: cros_ec: Instantiate ChromeOS EC character device Documentation/ioctl/ioctl-number.txt | 1 + driver

[PATCH v3 5/7] mfd: cros_ec: Instantiate ChromeOS EC character device

2015-01-22 Thread Javier Martinez Canillas
The ChromeOS EC character device is an user-space interface to allow applications to access the Embedded Controller. Add a cell for this device so it's spawned from the mfd driver. Signed-off-by: Javier Martinez Canillas --- Changes since v2: - Rename the name to "cros-ec-ctl"

[PATCH v3 6/7] platform/chrome: Create sysfs attributes for the ChromeOS EC.

2015-01-22 Thread Javier Martinez Canillas
t; reboot cat version echo rw > reboot cat version echo cold > reboot That last command will reboot the AP too. Signed-off-by: Bill Richardson Reviewed-by: Olof Johansson Signed-off-by: Javier Martinez Canillas --- Changes since v2: None Changes since v1: - Moved from

[PATCH v3 7/7] platform/chrome: Expose Chrome OS Lightbar to users

2015-01-22 Thread Javier Martinez Canillas
d-off-by: Bill Richardson Reviewed-by: Olof Johansson Tested-by: Doug Anderson Reviewed-by: Benson Leung Signed-off-by: Javier Martinez Canillas --- Changes since v2: None Changes since v1: - Moved from drivers/mfd to drivers/platform/chrome. - Modify to use the fixed-size arrays for cro

[PATCH v3 2/7] mfd: cros_ec: Add char dev and virtual dev pointers

2015-01-22 Thread Javier Martinez Canillas
The ChromeOS Embedded Controller has to be accessed by applications. A virtual character device is used as an interface with user-space. Extend the struct cros_ec_device with the fields needed by the driver of this virtual character device. Signed-off-by: Javier Martinez Canillas Acked-by: Lee

[PATCH v3 4/7] platform/chrome: Add Chrome OS EC userspace device interface

2015-01-22 Thread Javier Martinez Canillas
From: Bill Richardson This patch adds a device interface to access the Chrome OS Embedded Controller from user-space. Signed-off-by: Bill Richardson Reviewed-by: Simon Glass Signed-off-by: Javier Martinez Canillas Reviewed-by: Gwendal Grignou --- Changes since v2: - Rename the devname to

[PATCH v3 3/7] misc: Add cros_ec_lpc driver for x86 devices

2015-01-22 Thread Javier Martinez Canillas
are drivers to communicate with the EC over I2C and SPI and this driver adds support for LPC. Signed-off-by: Bill Richardson Signed-off-by: Javier Martinez Canillas --- Changes since v2: - Move out from drivers/mfd to drivers/misc. Suggested by Lee Jones. Changes since v1: None, new patch

[PATCH v3 1/7] mfd: cros_ec: Use fixed size arrays to transfer data with the EC

2015-01-22 Thread Javier Martinez Canillas
byte boundaries, use fixed size arrays instead of pointers for transferring ingoing and outgoing data with the Embedded Controller. Also, re-arrange struct members by decreasing alignment requirements to reduce the needing padding size. Signed-off-by: Javier Martinez Canillas Acked-by: Lee Jones

Re: [PATCH 1/2] clk: exynos5420: Add IDs for clocks used in DISP1 power domain

2015-01-23 Thread Javier Martinez Canillas
Hello Kukjin, On 01/23/2015 07:51 AM, Kukjin Kim wrote: >> >> >> >> Acked-by: Sylwester Nawrocki >> > >> > Acked-by: Michael Turquette >> > >> >> Thanks a lot Sylwester and Mike for your acks. >> >> Kukjin, could you please pick $subject and "Patch 2/2 ARM: dts: Add DISP1 >> power domain for e

Re: [PATCH] ARM: exynos_defconfig: Enable CONFIG_FHANDLE

2015-01-23 Thread Javier Martinez Canillas
t; Tony added that support to OMAP2+ defconfig in commit 673ce00c >> ("ARM: omap2plus_defconfig: Add support for distros with systemd") >> so the same should be done in exynos_defconfig. >> >> That can of course be a follow-up patch though, so for $subject: >> >> Revi

Re: [PATCH v3 3/7] misc: Add cros_ec_lpc driver for x86 devices

2015-01-23 Thread Javier Martinez Canillas
Hello Varka, Thanks a lot for your feedback. On 01/23/2015 04:57 AM, Varka Bhadram wrote: > (...) >> +static int cros_ec_lpc_probe(struct platform_device *pdev) >> +{ >> + struct device *dev = &pdev->dev; >> + struct cros_ec_device *ec_dev; >> + int err = -ENOTTY; >> + >> +

Re: [PATCH v4 18/18] iommu: exynos: add callback for initializing devices from device tree

2015-01-23 Thread Javier Martinez Canillas
Hello Marek, On Fri, Jan 23, 2015 at 1:40 PM, Marek Szyprowski wrote: >>> + >>> + list_add_tail(&data->owner_node, &owner->clients); >> >> This is the line that causes the kernel to hang, if I comment the >> list_add_tail() call then the kernel boots. >> >> I checked that neither data nor o

Re: [PATCH] ARM: dts: Add sd0_rst pinctrl node to exynos5420

2015-01-23 Thread Javier Martinez Canillas
Hello Jaehoon, On Fri, Jan 23, 2015 at 3:23 PM, Jaehoon Chung wrote: > Add sd0_rst node to exynos5420-pinctrl.dtsi. > (It's used on odroid-xu3 board) > It would be good to mention which device needs this pinctrl line. > Signed-off-by: Jaehoon Chung > --- > arch/arm/boot/dts/exynos5420-pinctrl

Re: [PATCH] ARM: dts: Add sd0_rst pinctrl node to exynos5420

2015-01-23 Thread Javier Martinez Canillas
Hello Sjoerd, On Fri, Jan 23, 2015 at 4:47 PM, Sjoerd Simons wrote: >> >> If this pin is used by the Odroid XU3 board, shouldn't be defined in >> the exynos5422-odroidxu3.dts instead? > > It's not just used by the XU3 though, it's also hooked up on the peach > pi chromebook for example and i woul

Re: [PATCH v4 18/18] iommu: exynos: add callback for initializing devices from device tree

2015-01-23 Thread Javier Martinez Canillas
Hello Marek, On Fri, Jan 23, 2015 at 5:15 PM, Marek Szyprowski wrote: >> >>> To check if this is caused by io page fault, please temporarily add the >>> following hack: >>> --->8--- >>> diff --git a/arch/arm/mm/dma-mapping.c b/arch/arm/mm/dma-mapping.c >>> index 7864797609b3..5e70cf7eb31b 100644

[PATCH v2 5/6] ARM: dts: exynos5250-snow: Enable wifi power-on

2015-01-28 Thread Javier Martinez Canillas
MMC/SDIO slot. Signed-off-by: Javier Martinez Canillas --- Changes since v1: - Remove cap-sdio-irq from mmc3 dev node since is a separate change. Suggested by Arend van Spriel. --- arch/arm/boot/dts/exynos5250-snow.dts | 25 - 1 file changed, 24 insertions(+), 1

[PATCH 2/5] mmc: pwrseq_simple: Extend to support more pins

2015-01-28 Thread Javier Martinez Canillas
number, it uses the of_gpio_named_count() since the MMC power sequence is only built when CONFIG_OF is enabled. Signed-off-by: Javier Martinez Canillas --- drivers/mmc/core/pwrseq_simple.c | 54 ++-- 1 file changed, 41 insertions(+), 13 deletions(-) diff --git a

[PATCH 3/5] mmc: pwrseq: Document optional clock for the simple power sequence

2015-01-28 Thread Javier Martinez Canillas
Some WLAN chips attached to a SDIO interface, need an external clock to be operational. Since this is very common, extend the simple MMC power sequence DT binding to support an optional clock. Signed-off-by: Javier Martinez Canillas --- Documentation/devicetree/bindings/mmc/mmc-pwrseq

[PATCH 4/5] mmc: pwrseq_simple: Add optional reference clock support

2015-01-28 Thread Javier Martinez Canillas
found. Signed-off-by: Javier Martinez Canillas --- drivers/mmc/core/pwrseq_simple.c | 33 - 1 file changed, 32 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/core/pwrseq_simple.c b/drivers/mmc/core/pwrseq_simple.c index 9e51fe1051c5..5ef6db7323f3 100644

[PATCH 0/5] Add multiple GPIO and external clock to MMC pwrseq_simple

2015-01-28 Thread Javier Martinez Canillas
external clock. The series depend on v4 "mmc: core: Add support for MMC power sequences": http://comments.gmane.org/gmane.linux.kernel.mmc/30665 Javier Martinez Canillas (5): mmc: pwrseq: Document that simple sequence support more than one GPIO mmc: pwrseq_simple: Extend to support more

[PATCH v2 1/6] mmc: pwrseq: Document that simple sequence support more than one GPIO

2015-01-28 Thread Javier Martinez Canillas
Many SDIO/MMC attached WLAN chips need more than one ping for their reset sequence. Extend the pwrseq_simple binding to support more than one pin. Signed-off-by: Javier Martinez Canillas --- Changes since v1: - Make the explanation clearer by adding an explicit "they". Suggested b

[PATCH v2 4/6] mmc: pwrseq_simple: Add optional reference clock support

2015-01-28 Thread Javier Martinez Canillas
found. Signed-off-by: Javier Martinez Canillas --- Changes since v1: - Rebase on top of latest changes. - Use IS_ERR() instead of checking for NULL to see if the clock exists. --- drivers/mmc/core/pwrseq_simple.c | 34 -- 1 file changed, 32 insertions(+), 2

[PATCH 5/5] ARM: dts: exynos5250-snow: Enable wifi power-on

2015-01-28 Thread Javier Martinez Canillas
MMC/SDIO slot. Signed-off-by: Javier Martinez Canillas --- arch/arm/boot/dts/exynos5250-snow.dts | 25 - 1 file changed, 24 insertions(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts index b9aeec430527

[PATCH v2 6/6] ARM: dts: exynos5250-snow: Add cap-sdio-irq to wifi mmc node

2015-01-28 Thread Javier Martinez Canillas
Enabling SDIO IRQ signalling for the wifi MMC/SDIO slot doubles the transmission transfer rate. Signed-off-by: Javier Martinez Canillas --- Changes since v1: None, new patch. --- arch/arm/boot/dts/exynos5250-snow.dts | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts

[PATCH 1/5] mmc: pwrseq: Document that simple sequence support more than one GPIO

2015-01-28 Thread Javier Martinez Canillas
Many SDIO/MMC attached WLAN chips need more than one ping for their reset sequence. Extend the pwrseq_simple binding to support more than one pin. Signed-off-by: Javier Martinez Canillas --- Documentation/devicetree/bindings/mmc/mmc-pwrseq-simple.txt | 6 +++--- 1 file changed, 3 insertions

[PATCH v2 0/6] Add multiple GPIO and external clock to MMC pwrseq_simple

2015-01-28 Thread Javier Martinez Canillas
clock. This is the second version of the series that addressed issues pointed out by Arend van Spriel and Srinivas Kandagatla. The series depend on v4 "mmc: core: Add support for MMC power sequences": http://comments.gmane.org/gmane.linux.kernel.mmc/30665 Javier Martinez Canillas

[PATCH v2 3/6] mmc: pwrseq: Document optional clock for the simple power sequence

2015-01-28 Thread Javier Martinez Canillas
Some WLAN chips attached to a SDIO interface, need an external clock to be operational. Since this is very common, extend the simple MMC power sequence DT binding to support an optional clock. Signed-off-by: Javier Martinez Canillas --- Changes since v1: None. --- Documentation/devicetree

[PATCH v2 2/6] mmc: pwrseq_simple: Extend to support more pins

2015-01-28 Thread Javier Martinez Canillas
number, it uses the of_gpio_named_count() since the MMC power sequence is only built when CONFIG_OF is enabled. Signed-off-by: Javier Martinez Canillas Signed-off-by: Srinivas Kandagatla --- Changes since v1: - Many code cleanups suggested by Srinivas Kandagatla * Rename reset_gpio array to

[PATCH 1/1] ARM: multi_v7_defconfig: Enable Exynos5420 Multi-Cluster PM support

2015-01-28 Thread Javier Martinez Canillas
Martinez Canillas --- This patch was tested on an Exynos5420 Peach Pit and with MCPM support enabled, all the 8 CPUs are powered up: Brought up 8 CPUs SMP: Total of 8 processors activated (384.00 BogoMIPS). arch/arm/configs/multi_v7_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch

Re: [PATCH 1/5] mmc: pwrseq: Document that simple sequence support more than one GPIO

2015-01-28 Thread Javier Martinez Canillas
Srinivas, On 01/28/2015 05:34 PM, Srinivas Kandagatla wrote: >> -- reset-gpios : contains a GPIO specifier. The reset GPIO is asserted at >> -initialization and prior we start the power up procedure of the card. It >> -will be de-asserted right after the power has been provided to the card

Re: [PATCH 5/5] ARM: dts: exynos5250-snow: Enable wifi power-on

2015-01-28 Thread Javier Martinez Canillas
Hello Arend, Thanks for your feedback. On 01/28/2015 03:03 PM, Arend van Spriel wrote: > On 01/28/15 11:10, Javier Martinez Canillas wrote: >> &dp { >> @@ -531,17 +538,33 @@ >> status = "okay"; >> num-slots =<1>; >> bro

Re: [PATCH 2/5] mmc: pwrseq_simple: Extend to support more pins

2015-01-28 Thread Javier Martinez Canillas
hough, did you cc linux-mmc? > May be we can merge goods in both :-) > Sure, I want $subject to be generic enough to be useful for other platforms. > On 28/01/15 10:10, Javier Martinez Canillas wrote: >> Many WLAN attached to a SDIO/MMC interface, needs more than one pin for >

Re: [PATCH 1/4] mmc: core: add support for hardware reset gpio line

2015-01-29 Thread Javier Martinez Canillas
Hello Marek, On Thu, Jan 29, 2015 at 10:15 AM, Marek Szyprowski wrote: >> Also, I wonder whether we could extend the mmc-pwrseq to cover your >> case? Did you consider that as an option? > > > I didn't consider mmc-pwrseq yet. For me it looked straightforward to I agree with Ulf that using mmc-p

[PATCH v4 5/7] mfd: cros_ec: Instantiate ChromeOS EC character device

2015-01-29 Thread Javier Martinez Canillas
The ChromeOS EC character device is an user-space interface to allow applications to access the Embedded Controller. Add a cell for this device so it's spawned from the mfd driver. Signed-off-by: Javier Martinez Canillas Acked-by: Lee Jones --- Changes since v3: None, added Acked-by tag

[PATCH v4 0/7] platform/chrome: Add user-space dev inferface support

2015-01-29 Thread Javier Martinez Canillas
owing patches: Bill Richardson (4): misc: Add cros_ec_lpc driver for x86 devices platform/chrome: Add Chrome OS EC userspace device interface platform/chrome: Create sysfs attributes for the ChromeOS EC platform/chrome: Expose Chrome OS Lightbar to users Javier Martinez Canillas (3):

[PATCH v4 3/7] misc: Add cros_ec_lpc driver for x86 devices

2015-01-29 Thread Javier Martinez Canillas
are drivers to communicate with the EC over I2C and SPI and this driver adds support for LPC. Signed-off-by: Bill Richardson Signed-off-by: Javier Martinez Canillas --- Changes since v3: - Rename MYNAME to DRV_NAME - Use devm_request_region() instead of request_region. Suggested by Varka

[PATCH v4 7/7] platform/chrome: Expose Chrome OS Lightbar to users

2015-01-29 Thread Javier Martinez Canillas
d-off-by: Bill Richardson Reviewed-by: Olof Johansson Tested-by: Doug Anderson Reviewed-by: Benson Leung Signed-off-by: Javier Martinez Canillas --- Changes since v3: None. Changes since v2: None. Changes since v1: - Moved from drivers/mfd to drivers/platform/chrome. - Modify to use the fi

[PATCH v4 6/7] platform/chrome: Create sysfs attributes for the ChromeOS EC

2015-01-29 Thread Javier Martinez Canillas
t; reboot cat version echo rw > reboot cat version echo cold > reboot That last command will reboot the AP too. Signed-off-by: Bill Richardson Reviewed-by: Olof Johansson Signed-off-by: Javier Martinez Canillas --- Changes since v3: None. Changes since v2: None. C

[PATCH v4 4/7] platform/chrome: Add Chrome OS EC userspace device interface

2015-01-29 Thread Javier Martinez Canillas
From: Bill Richardson This patch adds a device interface to access the Chrome OS Embedded Controller from user-space. Signed-off-by: Bill Richardson Reviewed-by: Simon Glass Signed-off-by: Javier Martinez Canillas Reviewed-by: Gwendal Grignou --- Changes since v3: None. Changes since v2

[PATCH v4 2/7] mfd: cros_ec: Add char dev and virtual dev pointers

2015-01-29 Thread Javier Martinez Canillas
The ChromeOS Embedded Controller has to be accessed by applications. A virtual character device is used as an interface with user-space. Extend the struct cros_ec_device with the fields needed by the driver of this virtual character device. Signed-off-by: Javier Martinez Canillas Acked-by: Lee

[PATCH v4 1/7] mfd: cros_ec: Use fixed size arrays to transfer data with the EC

2015-01-29 Thread Javier Martinez Canillas
byte boundaries, use fixed size arrays instead of pointers for transferring ingoing and outgoing data with the Embedded Controller. Also, re-arrange struct members by decreasing alignment requirements to reduce the needing padding size. Signed-off-by: Javier Martinez Canillas Acked-by: Lee Jones

Re: [PATCH v2 4/6] mmc: pwrseq_simple: Add optional reference clock support

2015-01-29 Thread Javier Martinez Canillas
Hello Ulf, Thanks a lot for your feedback. On 01/29/2015 02:05 PM, Ulf Hansson wrote: >> >> struct mmc_pwrseq_simple { >> struct mmc_pwrseq pwrseq; >> + struct clk *ext_clk; > > You need to add a bool, maybe call it clk_enabled; See why below. > Ok >> int nr_gpios; >>

[PATCH v3 6/6] ARM: dts: exynos5250-snow: Add cap-sdio-irq to wifi mmc node

2015-01-29 Thread Javier Martinez Canillas
Enabling SDIO IRQ signalling for the wifi MMC/SDIO slot doubles the transmission transfer rate. Signed-off-by: Javier Martinez Canillas --- Changes since v2: None. Changes since v1: None, new patch. --- arch/arm/boot/dts/exynos5250-snow.dts | 1 + 1 file changed, 1 insertion(+) diff --git a

[PATCH v3 5/6] ARM: dts: exynos5250-snow: Enable wifi power-on

2015-01-29 Thread Javier Martinez Canillas
MMC/SDIO slot. Signed-off-by: Javier Martinez Canillas --- Changes since v2: None. Changes since v1: - Remove cap-sdio-irq from mmc3 dev node since is a separate change. Suggested by Arend van Spriel. --- arch/arm/boot/dts/exynos5250-snow.dts | 25 - 1 file changed

[PATCH v3 0/6] Add multiple GPIO and external clock to MMC pwrseq_simple

2015-01-29 Thread Javier Martinez Canillas
clock. This is the third version of the series that addressed issues pointed out in the previous versions. The series depend on v4 "mmc: core: Add support for MMC power sequences": http://comments.gmane.org/gmane.linux.kernel.mmc/30665 Javier Martinez Canillas (6): mmc: pwrseq: Doc

[PATCH v3 4/6] mmc: pwrseq_simple: Add optional reference clock support

2015-01-29 Thread Javier Martinez Canillas
found. Signed-off-by: Javier Martinez Canillas --- Changes since v2: - Add a clk_enabled bool to struct mmc_pwrseq_simple to track clock gate/ungate since .power_off can be called prior to .pre_power_on. Suggested by Ulf Hansson. - clk_get() does not return -ENOSYS so don't check for

[PATCH v3 3/6] mmc: pwrseq: Document optional clock for the simple power sequence

2015-01-29 Thread Javier Martinez Canillas
Some WLAN chips attached to a SDIO interface, need an external clock to be operational. Since this is very common, extend the simple MMC power sequence DT binding to support an optional clock. Signed-off-by: Javier Martinez Canillas --- Changes since v2: None. Changes since v1: None

[PATCH v3 2/6] mmc: pwrseq_simple: Extend to support more pins

2015-01-29 Thread Javier Martinez Canillas
number, it uses the of_gpio_named_count() since the MMC power sequence is only built when CONFIG_OF is enabled. Signed-off-by: Javier Martinez Canillas Signed-off-by: Srinivas Kandagatla --- Changes since v2: None. Changes since v1: - Many code cleanups suggested by Srinivas Kandagatla

<    1   2   3   4   5   6   7   8   9   10   >