Re: [RFC-v2 0/4] tcm_vhost+cmwq fabric driver code for-3.6

2012-07-18 Thread Paolo Bonzini
Il 18/07/2012 21:12, Anthony Liguori ha scritto: > Is that true for all OSes? Linux may handle things gracefully if UNMAP > starts throwing errors but that doesn't mean that Windows will. There is so much USB crap (not just removable, think of ATA-to-USB enclosures) that they have to deal with pr

[GIT PULL] target fixes for v3.5

2012-07-18 Thread Nicholas A. Bellinger
Hi Linus, Here are the last handful of target fixes that have come in recently that are headed for-3.5 final. Please go ahead and pull from: git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending.git master This includes a bugfix from MDR to address a NULL pointer OOPs with FCoE abo

Re: [PATCH] target: Allow for target_submit_cmd() returning errors

2012-07-18 Thread Nicholas A. Bellinger
On Wed, 2012-07-18 at 11:10 +0200, Sebastian Andrzej Siewior wrote: > On 07/18/2012 02:05 AM, Nicholas A. Bellinger wrote: > >> index 02ace18..9ddf315 100644 > >> --- a/drivers/usb/gadget/tcm_usb_gadget.c > >> +++ b/drivers/usb/gadget/tcm_usb_gadget.c > >> @@ -1060,7 +1060,10 @@ static void usbg_cm

Re: scsi_lib: fix scsi_io_completion's SG_IO error propagation

2012-07-18 Thread Mike Snitzer
Hi James, Seems this one slipped through the cracks. Please review/apply. Thanks, Mike On Thu, May 31 2012 at 4:33pm -0400, Moger, Babu wrote: > Thanks Mike. Looks good. > > > -Original Message- > > From: Mike Snitzer [mailto:snit...@redhat.com] > > Sent: Thursday, May 31, 2012 3:24

Re: [RFC-v2 0/4] tcm_vhost+cmwq fabric driver code for-3.6

2012-07-18 Thread Nicholas A. Bellinger
On Wed, 2012-07-18 at 08:42 -0500, Anthony Liguori wrote: > On 07/17/2012 04:50 PM, Nicholas A. Bellinger wrote: > > On Tue, 2012-07-17 at 13:55 -0500, Anthony Liguori wrote: > >> On 07/17/2012 10:05 AM, Michael S. Tsirkin wrote: > >>> On Wed, Jul 11, 2012 at 09:15:00PM +, Nicholas A. Bellinger

Re: [Bug 44771] [REGRESSION] a7a20d103994fd760766e6c9d494daa569cbfe06 makes kernel 3.5 unbootable on an Intel chipset based motherboard

2012-07-18 Thread Dan Williams
On Wed, Jul 18, 2012 at 1:25 PM, Alan Stern wrote: > On Tue, 17 Jul 2012, James Bottomley wrote: > >> On Tue, 2012-07-17 at 12:51 -0700, Linus Torvalds wrote: >> > Wrong people cc'd, it looks like. >> > >> > Guys, commit a7a20d103994 ("sd: limit the scope of the async probe >> > domain") is causin

Re: [MINI SUMMIT] SCSI core performance

2012-07-18 Thread Nicholas A. Bellinger
On Wed, 2012-07-18 at 09:00 +0100, James Bottomley wrote: > On Tue, 2012-07-17 at 19:39 -0700, Nicholas A. Bellinger wrote: > > Hi KS-PCs, > > > > I'd like to propose a SCSI performance mini-summit to see how interested > > folks are in helping address the long-term issues that SCSI core is > > cu

Re: [RFC-v3 3/4] vhost: Add vhost_scsi specific defines

2012-07-18 Thread Michael S. Tsirkin
On Wed, Jul 18, 2012 at 02:17:05PM -0700, Nicholas A. Bellinger wrote: > On Wed, 2012-07-18 at 16:05 +0300, Michael S. Tsirkin wrote: > > On Wed, Jul 18, 2012 at 12:59:31AM +, Nicholas A. Bellinger wrote: > > > From: Nicholas Bellinger > > > > > > This patch adds the initial vhost_scsi_ioctl(

Re: [RFC-v3 4/4] tcm_vhost: Initial merge for vhost level target fabric driver

2012-07-18 Thread Nicholas A. Bellinger
On Wed, 2012-07-18 at 19:09 +0300, Michael S. Tsirkin wrote: > On Wed, Jul 18, 2012 at 12:59:32AM +, Nicholas A. Bellinger wrote: > > > > Changelog v2 -> v3: > > > > Unlock on error in tcm_vhost_drop_nexus() (DanC) > > Fix strlen() doesn't count the terminator (DanC) > > Call kfree()

Re: [RFC-v3 3/4] vhost: Add vhost_scsi specific defines

2012-07-18 Thread Nicholas A. Bellinger
On Wed, 2012-07-18 at 16:05 +0300, Michael S. Tsirkin wrote: > On Wed, Jul 18, 2012 at 12:59:31AM +, Nicholas A. Bellinger wrote: > > From: Nicholas Bellinger > > > > This patch adds the initial vhost_scsi_ioctl() callers for > > VHOST_SCSI_SET_ENDPOINT > > and VHOST_SCSI_CLEAR_ENDPOINT resp

Re: [Bug 44771] [REGRESSION] a7a20d103994fd760766e6c9d494daa569cbfe06 makes kernel 3.5 unbootable on an Intel chipset based motherboard

2012-07-18 Thread Alan Stern
On Tue, 17 Jul 2012, James Bottomley wrote: > On Tue, 2012-07-17 at 12:51 -0700, Linus Torvalds wrote: > > Wrong people cc'd, it looks like. > > > > Guys, commit a7a20d103994 ("sd: limit the scope of the async probe > > domain") is causing boot problems. It's timing-dependent and > > apparently s

Re: [RFC-v2 0/4] tcm_vhost+cmwq fabric driver code for-3.6

2012-07-18 Thread Rustad, Mark D
On Jul 18, 2012, at 10:17 AM, Michael S. Tsirkin wrote: >> You do have to pay very close attention to some things however. Don't change >> the device identity in any way - even version information, otherwise a >> Windows initiator will blue-screen. I made that mistake myself, so I >> remember

Re: [RFC-v2 0/4] tcm_vhost+cmwq fabric driver code for-3.6

2012-07-18 Thread Anthony Liguori
On 07/18/2012 11:47 AM, James Bottomley wrote: On Wed, 2012-07-18 at 11:00 -0500, Anthony Liguori wrote: Of course: Think about the consequences: you want to upgrade one array on your SAN. You definitely don't want to shut down your entire data centre to achieve it. In place upgrades on runnin

Re: [RFC-v2 0/4] tcm_vhost+cmwq fabric driver code for-3.6

2012-07-18 Thread Michael S. Tsirkin
On Wed, Jul 18, 2012 at 04:42:33PM +, Rustad, Mark D wrote: > On Jul 18, 2012, at 9:00 AM, Michael S. Tsirkin wrote: > > > On Wed, Jul 18, 2012 at 11:53:38AM -0400, Christoph Hellwig wrote: > >> On Wed, Jul 18, 2012 at 08:42:21AM -0500, Anthony Liguori wrote: > >>> > >>> If you add support fo

[PATCH] scsi/ibmvscsi: /sys/class/scsi_host/hostX/config doesn't show any information

2012-07-18 Thread olaf
From: Linda Xie Expected result: It should show something like this: x1521p4:~ # cat /sys/class/scsi_host/host1/config PARTITIONNAME='x1521p4' NWSDNAME='X1521P4' HOSTNAME='X1521P4' DOMAINNAME='RCHLAND.IBM.COM' NAMESERVERS='9.10.244.100 9.10.244.200' Actual result: x1521p4:~ # cat /sys/class/scsi

[PATCH] scsi/ibmvscsi: add module alias for ibmvscsic

2012-07-18 Thread olaf
From: Olaf Hering The driver is named ibmvscsic, at runtime it its name is advertised as ibmvscsi. For this reason mkinitrd wont pickup the driver properly. Reported by IBM during SLES11 beta testing: https://bugzilla.novell.com/show_bug.cgi?id=459933 LTC50724 Signed-off-by: Olaf Hering diff

Re: [RFC-v2 0/4] tcm_vhost+cmwq fabric driver code for-3.6

2012-07-18 Thread James Bottomley
On Wed, 2012-07-18 at 11:00 -0500, Anthony Liguori wrote: > On 07/18/2012 10:53 AM, Christoph Hellwig wrote: > > On Wed, Jul 18, 2012 at 08:42:21AM -0500, Anthony Liguori wrote: > >> > >> If you add support for a new command, you need to provide userspace > >> a way to disable this command. If you

Re: [RFC-v2 0/4] tcm_vhost+cmwq fabric driver code for-3.6

2012-07-18 Thread Rustad, Mark D
On Jul 18, 2012, at 9:00 AM, Michael S. Tsirkin wrote: > On Wed, Jul 18, 2012 at 11:53:38AM -0400, Christoph Hellwig wrote: >> On Wed, Jul 18, 2012 at 08:42:21AM -0500, Anthony Liguori wrote: >>> >>> If you add support for a new command, you need to provide userspace >>> a way to disable this com

Re: [RFC-v2 0/4] tcm_vhost+cmwq fabric driver code for-3.6

2012-07-18 Thread Anthony Liguori
On 07/18/2012 10:53 AM, Christoph Hellwig wrote: On Wed, Jul 18, 2012 at 08:42:21AM -0500, Anthony Liguori wrote: If you add support for a new command, you need to provide userspace a way to disable this command. If you change what gets reported for VPD, you need to provide userspace a way to

Re: [RFC-v3 0/4] tcm_vhost+cmwq fabric driver code for-3.6

2012-07-18 Thread Michael S. Tsirkin
On Wed, Jul 18, 2012 at 12:59:28AM +, Nicholas A. Bellinger wrote: > From: Nicholas Bellinger > > Hi folks, > > The following is the RFC-v3 series of tcm_vhost target fabric driver code > currently in-flight for-3.6 mainline code. So I sent some comments. I think it's in an OK state for a s

Re: [RFC-v3 4/4] tcm_vhost: Initial merge for vhost level target fabric driver

2012-07-18 Thread Michael S. Tsirkin
On Wed, Jul 18, 2012 at 12:59:32AM +, Nicholas A. Bellinger wrote: > From: Nicholas Bellinger > > This patch adds the initial code for tcm_vhost, a Vhost level TCM > fabric driver for virtio SCSI initiators into KVM guest. > > This code is currently up and running on v3.5-rc2 host+guest alon

Re: [RFC-v2 0/4] tcm_vhost+cmwq fabric driver code for-3.6

2012-07-18 Thread Michael S. Tsirkin
On Wed, Jul 18, 2012 at 11:53:38AM -0400, Christoph Hellwig wrote: > On Wed, Jul 18, 2012 at 08:42:21AM -0500, Anthony Liguori wrote: > > > > If you add support for a new command, you need to provide userspace > > a way to disable this command. If you change what gets reported for > > VPD, you ne

Re: [RFC-v2 0/4] tcm_vhost+cmwq fabric driver code for-3.6

2012-07-18 Thread Christoph Hellwig
On Wed, Jul 18, 2012 at 08:42:21AM -0500, Anthony Liguori wrote: > > If you add support for a new command, you need to provide userspace > a way to disable this command. If you change what gets reported for > VPD, you need to provide userspace a way to make VPD look like what > it did in a previo

Re: [RFC-v2 0/4] tcm_vhost+cmwq fabric driver code for-3.6

2012-07-18 Thread Michael S. Tsirkin
On Wed, Jul 18, 2012 at 08:42:21AM -0500, Anthony Liguori wrote: > On 07/17/2012 04:50 PM, Nicholas A. Bellinger wrote: > >On Tue, 2012-07-17 at 13:55 -0500, Anthony Liguori wrote: > >>On 07/17/2012 10:05 AM, Michael S. Tsirkin wrote: > >>>On Wed, Jul 11, 2012 at 09:15:00PM +, Nicholas A. Belli

Re: [RFC-v2 0/4] tcm_vhost+cmwq fabric driver code for-3.6

2012-07-18 Thread Paolo Bonzini
Il 18/07/2012 15:42, Anthony Liguori ha scritto: > If you add support for a new command, you need to provide userspace a > way to disable this command. If you change what gets reported for VPD, > you need to provide userspace a way to make VPD look like what it did in > a previous version. The QE

Re: [RFC-v2 0/4] tcm_vhost+cmwq fabric driver code for-3.6

2012-07-18 Thread Anthony Liguori
On 07/17/2012 04:50 PM, Nicholas A. Bellinger wrote: On Tue, 2012-07-17 at 13:55 -0500, Anthony Liguori wrote: On 07/17/2012 10:05 AM, Michael S. Tsirkin wrote: On Wed, Jul 11, 2012 at 09:15:00PM +, Nicholas A. Bellinger wrote: It still seems not 100% clear whether this driver will ha

Re: [RFC-v3 3/4] vhost: Add vhost_scsi specific defines

2012-07-18 Thread Michael S. Tsirkin
On Wed, Jul 18, 2012 at 12:59:31AM +, Nicholas A. Bellinger wrote: > From: Nicholas Bellinger > > This patch adds the initial vhost_scsi_ioctl() callers for > VHOST_SCSI_SET_ENDPOINT > and VHOST_SCSI_CLEAR_ENDPOINT respectively, and also adds struct > vhost_vring_target > that is used by tc

Re: [RFC-v3 0/4] tcm_vhost+cmwq fabric driver code for-3.6

2012-07-18 Thread Michael S. Tsirkin
On Wed, Jul 18, 2012 at 12:59:28AM +, Nicholas A. Bellinger wrote: > From: Nicholas Bellinger > > Hi folks, > > The following is the RFC-v3 series of tcm_vhost target fabric driver code > currently in-flight for-3.6 mainline code. > > With the merge window opening soon, the tcm_vhost code h

Re: [PATCH RESEND 0/5] Add vhost-blk support

2012-07-18 Thread Stefan Hajnoczi
On Tue, Jul 17, 2012 at 4:09 PM, Michael S. Tsirkin wrote: > On Fri, Jul 13, 2012 at 04:55:06PM +0800, Asias He wrote: >> >> Hi folks, >> >> [I am resending to fix the broken thread in the previous one.] >> >> This patchset adds vhost-blk support. vhost-blk is a in kernel virito-blk >> device acce

Re: [PATCH] target: Allow for target_submit_cmd() returning errors

2012-07-18 Thread Sebastian Andrzej Siewior
On 07/18/2012 02:05 AM, Nicholas A. Bellinger wrote: index 02ace18..9ddf315 100644 --- a/drivers/usb/gadget/tcm_usb_gadget.c +++ b/drivers/usb/gadget/tcm_usb_gadget.c @@ -1060,7 +1060,10 @@ static void usbg_cmd_work(struct work_struct *work) tpg = cmd->fu->tpg; tv_nexus = tpg->tpg

Re: [MINI SUMMIT] SCSI core performance

2012-07-18 Thread James Bottomley
On Tue, 2012-07-17 at 19:39 -0700, Nicholas A. Bellinger wrote: > Hi KS-PCs, > > I'd like to propose a SCSI performance mini-summit to see how interested > folks are in helping address the long-term issues that SCSI core is > currently facing wrt to multi-lun per host and heavy small block random