Building advansys.o triggers this warning:
drivers/scsi/advansys.c:71:2: warning: #warning this driver is still not
properly converted to the DMA API [-Wcpp]
This warning can be traced back to a patch called advansys: add warning
and convert #includes which was included in v2.6.10. That
asd_process_ctrl_a_user() attempts to find user settings in flash, and
if they are missing it prepares a substitute structure containing
default values for PHY settings. But having done so, it will still
try to read user settings - from some random address in flash, as the
local variable 'offs'
The enumeration of standard types is called enum sas_device_type and
is defined in scsi/scsi_transport_sas.h along with the Linux
internal structures, whereas the enumeration with Linux extensions is
called enum sas_dev_type and is defined in scsi/sas.h along with the
standard-defined structures.
Bart Van Assche bvanass...@acm.org writes:
On 11/02/12 22:45, Jeff Moyer wrote:
diff --git a/drivers/scsi/hosts.c b/drivers/scsi/hosts.c
index 593085a..7d7ad8b 100644
--- a/drivers/scsi/hosts.c
+++ b/drivers/scsi/hosts.c
@@ -336,16 +336,25 @@ static struct device_type scsi_host_type = {
Bart Van Assche bvanass...@acm.org writes:
On 11/02/12 22:45, Jeff Moyer wrote:
diff --git a/drivers/scsi/scsi.c b/drivers/scsi/scsi.c
index 2936b44..4db6973 100644
--- a/drivers/scsi/scsi.c
+++ b/drivers/scsi/scsi.c
@@ -173,16 +173,20 @@ static DEFINE_MUTEX(host_cmd_pool_mutex);
* NULL
Bart Van Assche bvanass...@acm.org writes:
On 11/02/12 22:45, Jeff Moyer wrote:
Signed-off-by: Jeff Moyer jmo...@redhat.com
---
drivers/scsi/sd.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
index 12f6fdf..8deb915 100644
On 11/05/12 15:12, Jeff Moyer wrote:
Bart Van Assche bvanass...@acm.org writes:
On 11/02/12 22:45, Jeff Moyer wrote:
Signed-off-by: Jeff Moyer jmo...@redhat.com
---
drivers/scsi/sd.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/sd.c
On 11/05/2012 10:57 PM, Bart Van Assche wrote:
On 11/05/12 15:12, Jeff Moyer wrote:
Bart Van Assche bvanass...@acm.org writes:
On 11/02/12 22:45, Jeff Moyer wrote:
Signed-off-by: Jeff Moyer jmo...@redhat.com
---
drivers/scsi/sd.c |2 +-
1 files changed, 1 insertions(+), 1
On Sun, Nov 04, 2012 at 09:25:53PM +0100, Julia Lawall wrote:
It looks like these patches were not a good idea, because in each case the
printk provides an error level, and WARN then provides another one.
I think this is not a problem within btrfs at the place where this has
changed.
david
--
The main issue is that bit(n) is defined as:
(u32)1 n
Thus bit(n) with n = 32 will produce 0 or 1, depending on the
architecture. This is also undefined behavior in C.
The OR with sata_reg_set (u64) then doesn't work because bit()
does a 32-bit shift, which should have been a 64-bit
The macro bit(n) is defined as ((u32)1 n), and thus it doesn't
work with n = 32, such as in mvs_94xx_assign_reg_set():
if (i = 32) {
mvi-sata_reg_set |= bit(i);
...
}
The shift ((u32)1 n) with n = 32 also leads to undefined behavior.
The result
Invoking bit(n) with n = 64 is undefined behavior, since bit(n) does
a 64-bit shift. This patch adds a check on the shifting amount.
Signed-off-by: Xi Wang xi.w...@gmail.com
---
drivers/scsi/mvsas/mv_94xx.c |8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git
Invoking ffz(x) with x = ~0 is undefined. This patch returns -1
for this case, and invokes __ffs64() instead.
Signed-off-by: Xi Wang xi.w...@gmail.com
---
drivers/scsi/mvsas/mv_94xx.h | 14 ++
1 file changed, 2 insertions(+), 12 deletions(-)
diff --git
On 10/24/2012 02:55 PM, Boaz Harrosh wrote:
On 10/24/2012 02:51 PM, Boaz Harrosh wrote:
This patch adds the support for the following two read-only sysfs attributes
to scsi_osd class members : osdname systemid
These attributes will show up as below in sysfs class hierarchy:
On 11/04/2012 10:15 PM, Xi Wang wrote:
The dereference rport-data should come after the NULL check of rport.
Signed-off-by: Xi Wang xi.w...@gmail.com
---
drivers/scsi/bnx2fc/bnx2fc_io.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/bnx2fc/bnx2fc_io.c
Hi Bjorn,
After merging the pci tree, today's linux-next build (x86_64 allmodconfig)
failed like this:
drivers/staging/telephony/ixj.c: In function 'ixj_probe_pci':
drivers/staging/telephony/ixj.c:7732:13: warning: assignment makes integer from
pointer without a cast [enabled by default]
On Tue, Nov 06, 2012 at 11:27:29AM +1100, Stephen Rothwell wrote:
Hi Bjorn,
After merging the pci tree, today's linux-next build (x86_64 allmodconfig)
failed like this:
drivers/staging/telephony/ixj.c: In function 'ixj_probe_pci':
drivers/staging/telephony/ixj.c:7732:13: warning:
17 matches
Mail list logo