Re: [PATCH 2/2] dm: Avoid use-after-free of a mapped device

2013-02-25 Thread Jun'ichi Nomura
Hello Bart, On 02/22/13 19:47, Bart Van Assche wrote: As the comment above rq_completed() explains, md members must not be touched after the dm_put() at the end of that function has been invoked. Avoid that the md-queue can be run asynchronously after the last md reference has been dropped by

[PATCH -next] [SCSI] fnic: convert to use simple_open()

2013-02-25 Thread Wei Yongjun
From: Wei Yongjun yongjun_...@trendmicro.com.cn This removes an open coded simple_open() function and replaces file operations references to the function with simple_open() instead. Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn --- drivers/scsi/fnic/fnic_debugfs.c | 19

[RESEND3 PATCH] libiscsi: avoid unnecessary multiple NULL assignments

2013-02-25 Thread Masatake YAMATO
In iscsi_free_task, NULL is assigned to task-sc twice: before and after kfifo_in invocatoin. Allocating and freeing iscsi_task are guarded with session-lock, so multiple NULL assignments cause no trouble. But people reading the source code may be confused. The second NULL assignment comes from

Re: [PATCH 2/2] dm: Avoid use-after-free of a mapped device

2013-02-25 Thread Bart Van Assche
On 02/25/13 10:49, Jun'ichi Nomura wrote: diff --git a/drivers/md/dm.c b/drivers/md/dm.c index 314a0e2..51fefb5 100644 --- a/drivers/md/dm.c +++ b/drivers/md/dm.c @@ -1973,15 +1973,27 @@ static void __bind_mempools(struct mapped_device *md, struct dm_table *t) { struct dm_md_mempools

Re: [PATCH 2/4] scsi: use 64-bit LUNs

2013-02-25 Thread Steffen Maier
Hi Hannes, I like the idea and most of the patch set, so I only have a few questions left and some review comments below. Just curious: Do you also plan to adapt systemd/udev, especially path_id for fc transport with its open coded copy of int_to_scsilun()? Since I don't see zfcp touched in

Re: [PATCH 2/4] scsi: use 64-bit LUNs

2013-02-25 Thread Hannes Reinecke
On 02/25/2013 04:33 PM, Steffen Maier wrote: Hi Hannes, I like the idea and most of the patch set, so I only have a few questions left and some review comments below. Just curious: Do you also plan to adapt systemd/udev, especially path_id for fc transport with its open coded copy of

Re: [PATCH 0/4] scsi: 64-bit LUN support

2013-02-25 Thread Douglas Gilbert
On 13-02-21 11:32 AM, James Bottomley wrote: On Thu, 2013-02-21 at 16:15 +, Elliott, Robert (Server Storage) wrote: Regarding changes like this: - printk(MYIOC_s_NOTE_FMT [%d:%d:%d:%d] + printk(MYIOC_s_NOTE_FMT [%d:%d:%d:%llu]

[PATCH V6 Resend 0/4] [SCSI] ufs: Adds glue drivers to ufshcd

2013-02-25 Thread Vinayak Holikatti
This patch set adds following features - Seggregate PCI specific code in ufshcd.c and corrected copyright - Adds PCI glue driver ufshcd-pci.c and ufshcd.c become core module - Adds Platform glue driver ufshcd-pltfrm.c - Update correct transfer size in Command UPIU Vinayak Holikatti (4):

[PATCH V6 Resend 1/4] [SCSI] drivers/scsi/ufs: Seggregate PCI Specific Code

2013-02-25 Thread Vinayak Holikatti
This patch seggregates the PCI specific code in ufshcd.c to make it ready for splitting into core ufs driver and PCI glue driver. Also copyright header modification to remove extra warranty disclaim. Reviewed-by: Arnd Bergmann a...@arndb.de Reviewed-by: Namjae Jeon linkinj...@gmail.com

[PATCH V6 Resend 3/4] [SCSI] ufs: Add Platform glue driver for ufshcd

2013-02-25 Thread Vinayak Holikatti
This patch adds Platform glue driver for ufshcd. Reviewed-by: Arnd Bergmann a...@arndb.de Reviewed-by: Namjae Jeon linkinj...@gmail.com Reviewed-by: Subhash Jadavani subha...@codeaurora.org Reviewed-by: Sujit Reddy Thumma sthu...@codeaurora.org Tested-by: Maya Erez me...@codeaurora.org

[PATCH V6 Resend 4/4] [SCSI] ufs: Correct the expected data transfersize

2013-02-25 Thread Vinayak Holikatti
This patch corrects the expected data transfer size of the command UPIU. The current implementation of cmd-transfersize is wrong as it probably equal to sector size. With this implementation the transfer size is updated correctly Reported-by: KOBAYASHI Yoshitake yoshitake.kobaya...@toshiba.co.jp

Re: [PATCH V6 Resend 0/4] [SCSI] ufs: Adds glue drivers to ufshcd

2013-02-25 Thread vinayak holikatti
James, I have rebased these patches with top scsi-misc tree. On Mon, Feb 25, 2013 at 9:44 PM, Vinayak Holikatti vinholika...@gmail.com wrote: This patch set adds following features - Seggregate PCI specific code in ufshcd.c and corrected copyright - Adds PCI glue driver ufshcd-pci.c and

Re: [PATCH V6 Resend 2/4] [SCSI] drivers/scsi/ufs: Separate PCI code into glue driver

2013-02-25 Thread James Bottomley
On Mon, 2013-02-25 at 21:44 +0530, Vinayak Holikatti wrote: This patch separates PCI code from ufshcd.c and makes it as a core driver module and adds a new file ufshcd-pci.c as PCI glue driver. You rebased this, but didn't compile it: CC [M] drivers/scsi/ufs/ufshcd-pci.o

Re: [PATCH V6 Resend 3/4] [SCSI] ufs: Add Platform glue driver for ufshcd

2013-02-25 Thread James Bottomley
On Mon, 2013-02-25 at 21:44 +0530, Vinayak Holikatti wrote: This patch adds Platform glue driver for ufshcd. Even after fixing the __devXX issues, I still get this: rivers/scsi/ufs/ufshcd-pltfrm.c:196:2: warning: initialization from incompatible pointer type [enabled by default]

Re: [PATCH 2/4] scsi: use 64-bit LUNs

2013-02-25 Thread Douglas Gilbert
On 13-02-25 10:33 AM, Steffen Maier wrote: Hi Hannes, I like the idea and most of the patch set, so I only have a few questions left and some review comments below. Just curious: Do you also plan to adapt systemd/udev, especially path_id for fc transport with its open coded copy of

[LSF/MM TOPIC] Making sure soft SCSI Targets are Valid

2013-02-25 Thread ronnie sahlberg
Hi, This is my attend request to to co-present a paper with Lee Duncan. regards ronnie sahlberg On Tue, Jan 29, 2013 at 11:13 AM, Lee Duncan ldun...@suse.com wrote: Hi: I'm not sure if there is much interest in this, but I've recently realized that there is no good free software to validate

[PATCH] [SCSI] Wake blockdev queue in scsi_internal_device_unblock() for SDEV_RUNNING

2013-02-25 Thread Roland Dreier
From: Roland Dreier rol...@purestorage.com If a SCSI device's old state is already SDEV_RUNNING and we're moving to the same SDEV_RUNNING state, still wake the blockdev queue in scsi_internal_device_unblock(). This fixes a case where we silently hang SCSI commands forever during device

[PATCH 2/3] fnic: Kernel panic due to FIP mode misconfiguration

2013-02-25 Thread Hiral Patel
If switch configured in FIP and adapter configured in non-fip mode, driver panics while queueing FIP frame in non-existing fip_frame_queue. Added config check before queueing FIP frame in misconfiguration case to avoid kernel panic. Signed-off-by: Hiral Patel hiral...@cisco.com ---

[PATCH 3/3] fnic: Incremented driver version

2013-02-25 Thread Hiral Patel
Incrementing driver versio after bug fixes and new feature commits. Signed-off-by: Brian Uchino buch...@cisco.com Signed-off-by: Hiral Patel hiral...@cisco.com --- drivers/scsi/fnic/fnic.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/fnic/fnic.h

[PATCH 1/3] fnic: FIP VLAN Discovery Feature Support

2013-02-25 Thread Hiral Patel
FIP VLAN discovery discovers the FCoE VLAN that will be used by all other FIP protocols as well as by the FCoE encapsulation for Fibre Channel payloads on the established virtual link. One of the goals of FC-BB-5 was to be as nonintrusive as possible on initiators and targets, and therefore FIP

Re: [scsi:misc 102/104] drivers/scsi/fnic/fnic_fcs.c:381:31: sparse: cast to restricted __be16

2013-02-25 Thread Hiral Patel (hiralpat)
Hey James, I have fixed FIP Vlan discovery patch for sparse warnings and resubmitted 3 pending patches. The patches 1-7 got committed to misc branch already has the fix for sparse and other problems. Thanks, Hiral On 2/24/13 12:18 AM, James Bottomley jbottom...@parallels.com wrote: On Sat,

Re: [PATCH 2/2] dm: Avoid use-after-free of a mapped device

2013-02-25 Thread Jun'ichi Nomura
On 02/26/13 00:09, Bart Van Assche wrote: Without your patch my test failed after two or three iterations. With your patch my test is still running after 53 iterations. So if you want you can add Tested-by: Bart Van Assche bvanass...@acm.org. Great. Thanks for testing. I'll submit a patch

[GIT PULL] target updates for v3.9-rc1

2013-02-25 Thread Nicholas A. Bellinger
Hi Linus, Here are the target pending updates for v3.9-rc1 code. Please go ahead and pull from: git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending.git for-next The highlights in this series include: - Improve sg_table lookup scalability in RAMDISK_MCP (martin) - Add device

[PATCH] dm: do not replace bioset for request-based dm

2013-02-25 Thread Jun'ichi Nomura
This patch fixes a regression introduced in v3.8, which causes oops like this when dm-multipath is used: general protection fault: [#1] SMP RIP: 0010:[810fe754] [810fe754] mempool_free+0x24/0xb0 Call Trace: IRQ [81187417] bio_put+0x97/0xc0 [a02247a5]