On 4/3/2014 12:35 PM, Nicholas A. Bellinger wrote:
From: Nicholas Bellinger
This patch fixes a double free bug during IBLOCK backend shutdown
where bioset_integrity_free() was incorrectly called ahead of
bioset_free(), who is already making the same call directly.
This bug was introduced with
On 4/3/2014 12:35 PM, Nicholas A. Bellinger wrote:
From: Nicholas Bellinger
In order to support local WRITE_INSERT + READ_STRIP operations for
non PI enabled fabrics, the fabric driver needs to be able signal
what protection offload operations are supported.
This is done at session initializat
On 4/3/2014 12:35 PM, Nicholas A. Bellinger wrote:
From: Nicholas Bellinger
Only expose standard INQUIRY PROTECT=1 and EVPD=0x86 TYPE1/TYPE3
PI control bits if the session + fabric support DIX PASS operations.
Cc: Martin K. Petersen
Cc: Sagi Grimberg
Cc: Or Gerlitz
Cc: Quinn Tran
Cc: Girid
On 4/3/2014 12:35 PM, Nicholas A. Bellinger wrote:
From: Nicholas Bellinger
Only expose the control modepage bit for Application Tag Owner (ATO)
if the session + fabric support DIX PASS operations.
Cc: Martin K. Petersen
Cc: Sagi Grimberg
Cc: Or Gerlitz
Cc: Quinn Tran
Cc: Giridhar Malavali
On 4/3/2014 12:35 PM, Nicholas A. Bellinger wrote:
From: Nicholas Bellinger
Only expose the PI protection type bits in READ_CAPACITY_16
if the session + fabric support DIX PASS operations.
Cc: Martin K. Petersen
Cc: Sagi Grimberg
Cc: Or Gerlitz
Cc: Quinn Tran
Cc: Giridhar Malavali
Signed-
On 4/3/2014 12:35 PM, Nicholas A. Bellinger wrote:
From: Nicholas Bellinger
This patch adds WRITE_INSERT emulation within target-core
using TYPE1 / TYPE3 PI modes.
This is useful in order for existing legacy fabrics that do not
support protection offloads to interact with backend devices that
On 4/3/2014 12:35 PM, Nicholas A. Bellinger wrote:
From: Nicholas Bellinger
This patch enables WRITE_INSERT emulation in target_execute_cmd()
in order to locally generate DIF PI before submitting the WRITE
to the underlying backend device.
This is required for fabric drivers that currently don
On 4/3/2014 12:35 PM, Nicholas A. Bellinger wrote:
From: Nicholas Bellinger
Split up __sbc_dif_verify_read() so that VERIFY READ emulation can
perform target-core specific READ_STRIP, seperate from the existing
FILEIO/RAMDISK backend emulation code.
Also add sbc_dif_read_strip() in order to de
On 4/3/2014 12:35 PM, Nicholas A. Bellinger wrote:
From: Nicholas Bellinger
This patch enables the use of READ_STRIP software emulation in
target_complete_ok_work() code for I/O READs.
This is useful when the fabric does not support READ_STRIP hardware
offload, but would still like to interact
On Mon, 2014-04-07 at 10:28 +0300, Sagi Grimberg wrote:
> On 4/3/2014 12:35 PM, Nicholas A. Bellinger wrote:
> > From: Nicholas Bellinger
> >
> > In order to support local WRITE_INSERT + READ_STRIP operations for
> > non PI enabled fabrics, the fabric driver needs to be able signal
> > what protec
On 4/7/2014 12:32 AM, Nicholas A. Bellinger wrote:
From: Nicholas Bellinger
This patch updates virtscsi_probe() to setup necessary Scsi_Host
level protection resources. (currently hardcoded to 1)
It changes virtscsi_add_cmd() to attach outgoing / incoming
protection SGLs preceeding the data pa
On Mon, 2014-04-07 at 10:36 +0300, Sagi Grimberg wrote:
> On 4/3/2014 12:35 PM, Nicholas A. Bellinger wrote:
> > From: Nicholas Bellinger
> >
> > This patch adds WRITE_INSERT emulation within target-core
> > using TYPE1 / TYPE3 PI modes.
> >
> > This is useful in order for existing legacy fabrics
On Mon, 2014-04-07 at 10:39 +0300, Sagi Grimberg wrote:
> On 4/3/2014 12:35 PM, Nicholas A. Bellinger wrote:
> > From: Nicholas Bellinger
> >
> > This patch enables WRITE_INSERT emulation in target_execute_cmd()
> > in order to locally generate DIF PI before submitting the WRITE
> > to the underly
On 4/7/2014 11:11 AM, Nicholas A. Bellinger wrote:
Looks good to me.
Reviewed-by: Sagi Grimberg
This is useless though without the code setting this prot_op in
sbc_set_prot_op_checks()...
Not sure I follow.. sbc_set_prot_op_checks() is already setting
TARGET_PROT_DOUT_INSERT when no protect
On Mon, 2014-04-07 at 10:49 +0300, Sagi Grimberg wrote:
> On 4/3/2014 12:35 PM, Nicholas A. Bellinger wrote:
> > From: Nicholas Bellinger
> >
> > This patch enables the use of READ_STRIP software emulation in
> > target_complete_ok_work() code for I/O READs.
> >
> > This is useful when the fabric
On Fri, Apr 04, 2014 at 09:23:20AM -0500, Dr. Greg Wettstein wrote:
>
> Obviously Dell/EqualLogix addresses this issue or a similar problem
> with their 6.0.6H2 firmware and VMware is urging people to upgrade.
> That may be a EqualLogix controller error fix in which case it isn't
> relevant to tho
On Mon, 2014-04-07 at 11:03 +0300, Sagi Grimberg wrote:
> On 4/7/2014 12:32 AM, Nicholas A. Bellinger wrote:
> > From: Nicholas Bellinger
> >
> > This patch updates virtscsi_probe() to setup necessary Scsi_Host
> > level protection resources. (currently hardcoded to 1)
> >
> > It changes virtscsi_
On Sun, Apr 06, 2014 at 09:32:09PM +, Nicholas A. Bellinger wrote:
> From: Nicholas Bellinger
>
> This patch updates virtscsi_probe() to setup necessary Scsi_Host
> level protection resources. (currently hardcoded to 1)
>
> It changes virtscsi_add_cmd() to attach outgoing / incoming
> protec
On Mon, 2014-04-07 at 11:45 +0300, Michael S. Tsirkin wrote:
> On Sun, Apr 06, 2014 at 09:32:09PM +, Nicholas A. Bellinger wrote:
> > From: Nicholas Bellinger
> >
> > This patch updates virtscsi_probe() to setup necessary Scsi_Host
> > level protection resources. (currently hardcoded to 1)
>
On Mon, Apr 07, 2014 at 01:56:59AM -0700, Nicholas A. Bellinger wrote:
> On Mon, 2014-04-07 at 11:45 +0300, Michael S. Tsirkin wrote:
> > On Sun, Apr 06, 2014 at 09:32:09PM +, Nicholas A. Bellinger wrote:
> > > From: Nicholas Bellinger
> > >
> > > This patch updates virtscsi_probe() to setup
On Mon, 2014-04-07 at 12:02 +0300, Michael S. Tsirkin wrote:
> On Mon, Apr 07, 2014 at 01:56:59AM -0700, Nicholas A. Bellinger wrote:
> > On Mon, 2014-04-07 at 11:45 +0300, Michael S. Tsirkin wrote:
> > > On Sun, Apr 06, 2014 at 09:32:09PM +, Nicholas A. Bellinger wrote:
> > > > From: Nicholas
On Sun, Apr 06, 2014 at 09:32:08PM +, Nicholas A. Bellinger wrote:
> From: Nicholas Bellinger
>
> This patch updates vhost_scsi_handle_vq() to check for the existance
> of virtio_scsi_cmd_req_pi comparing vq->iov[0].iov_len in order to
> calculate seperate data + protection SGLs from data_num
On Sun, Apr 06, 2014 at 09:32:04PM +, Nicholas A. Bellinger wrote:
> From: Nicholas Bellinger
>
> This patch adds a virtio_scsi_cmd_req_pi header as recommened by
> Paolo that contains do_pi_niov + di_pi_niov elements used for
> signaling when protection information buffers are expected to
>
Hi James,
This patch set seem to be fine. Please consider this patch set as Acked-by:
"Sreekanth Reddy" .
Regards,
Sreekanth
>-Original Message-
>From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi-
>ow...@vger.kernel.org] On Behalf Of Matthew Wilcox
>Sent: Friday, March 28, 2014
Any comments on this ?
ᐧ
On Tue, Mar 18, 2014 at 10:51 PM, Matei Oprea wrote:
> It's easier to use kcalloc for allocating arrays. While at it
> also remove useless casting value.
>
> Signed-off-by: Matei Oprea
> Cc: ROSEdu Kernel Community
> ---
> drivers/scsi/lpfc/lpfc_init.c |4 ++--
> 1
Hey Jens, Christoph & Co,
I raised this question at LSF but didn't get a clear answer on this matter.
So it seems to me that the hctx selection and the actual request
dispatch (queue_rq) are preemptive:
(1) blk_mq_get_ctx(q);
(2) map_queue(q, ctx->cpu);
...
(3) blk_mq_put_ctx(ctx);
(4) blk_mq_r
While the comments and code structure in scsi_io_completion suggest that
calling __scsi_queue_insert with SCSI_MLQUEUE_EH_RETRY has a different
effect from using SCSI_MLQUEUE_DEVICE_BUSY they are treated exactly the
same.
It seems like when SCSI_MLQUEUE_EH_RETRY was introduced it didn't set
device
On Wed, 2 Apr 2014, Hannes Reinecke wrote:
> On 04/01/2014 11:28 PM, Alan Stern wrote:
> > On Tue, 1 Apr 2014, Hannes Reinecke wrote:
> >
> So if the above reasoning is okay then this patch should be doing
> the trick:
>
> diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi/
This can happen:
- lport created, tport (our per-lport, per-provider context) is allocated.
tport->tpg = NULL
- tpg created
- a PRLI is received. ft_tport_create is called, tpg is found and
tport->tpg is set
- tpg removed. ft_tpg is freed in ft_del_tpg. Since tpg->tport was not
set, tport->t
://sg.danny.cz/sg/ddpt.html
http://sg.danny.cz/sg/ddpt_xcopy_odx.html
Changelog for ddpt-0.94 [20140407] [svn: r277]
- xcopy: change default to send xcopy command to dst
- add XCOPY_TO_SRC and XCOPY_TO_DST environment
variables to guide where to send xcopy command
- odx: add new offloaded
On 04/07/2014 06:44 AM, Sagi Grimberg wrote:
Hey Jens, Christoph & Co,
I raised this question at LSF but didn't get a clear answer on this matter.
So it seems to me that the hctx selection and the actual request
dispatch (queue_rq) are preemptive:
(1) blk_mq_get_ctx(q);
(2) map_queue(q, ctx->cpu
unsubscribe linux-scsi
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi,
This patch didn't apply. Please check for me.
Thanks.
Daeseok Youn
2014-03-12 2:02 GMT+09:00 Jayamohan Kallickal :
>
>
> -Original Message-
> From: Daeseok Youn [mailto:daeseok.y...@gmail.com]
> Sent: Thursday, February 20, 2014 5:13 PM
> To: jbottom...@parallels.com
> Cc: Jayamohan K
Fix the comment of sd_major to right major numbers.
Signed-off-by: root
---
drivers/scsi/sd.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
index 470954a..02ff975 100644
--- a/drivers/scsi/sd.c
+++ b/drivers/scsi/sd.c
@@ -529,7 +
On 2014/4/8 13:15, hujianyang wrote:
> Fix the comment of sd_major to right major numbers.
>
> Signed-off-by: root
>
> ---
> drivers/scsi/sd.c |2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
> index 470954a..02ff975 100644
>
Fix the comment of sd_major to right major numbers.
Signed-off-by: hujianyang
---
drivers/scsi/sd.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
index 470954a..02ff975 100644
--- a/drivers/scsi/sd.c
+++ b/drivers/scsi/sd.c
@@ -5
The 'scsi_changer' structure needs refcounting, as the device
might be removed while the fd is still open.
Signed-off-by: Hannes Reinecke
---
drivers/scsi/ch.c | 16 ++--
1 file changed, 14 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/ch.c b/drivers/scsi/ch.c
index 2a3237
On 03/18/2014 10:51 PM, Matei Oprea wrote:
> It's easier to use kcalloc for allocating arrays. While at it
> also remove useless casting value.
>
> Signed-off-by: Matei Oprea
> Cc: ROSEdu Kernel Community
> ---
> drivers/scsi/lpfc/lpfc_init.c |4 ++--
> 1 file changed, 2 insertions(+), 2 de
38 matches
Mail list logo
