[PATCH] Set correct completion code in scsi_send_eh_cmnd()

2014-05-08 Thread Hannes Reinecke
-queuecommand returns '0' for successful command submission, so we need to set the correct SCSI midlayer return value when calling scsi_log_completion(). Reported-by: Robert Elliott elli...@hp.com Cc: Stephen Cameron scame...@beardog.cce.hp.com Signed-off-by: Hannes Reinecke h...@suse.de ---

Re: [PATCH 16/16] scsi_dh_alua: Use workqueue for RTPG

2014-05-08 Thread Hannes Reinecke
On 04/29/2014 11:47 PM, Stewart, Sean wrote: On Fri, 2014-01-31 at 10:30 +0100, Hannes Reinecke wrote: @@ -797,37 +838,40 @@ static int alua_rtpg(struct scsi_device *sdev, struct alua_port_group *pg) off = 8 + (ucp[7] * 4); } - sdev_printk(KERN_INFO, sdev, -

Re: [PATCH v1] virtio_scsi: remove ACCESS_ONCE() and smp_read_barrier_depends()

2014-05-08 Thread Paolo Bonzini
Il 08/05/2014 07:24, Ming Lei ha scritto: Access to tgt-req_vq is strictly serialized by spin_lock of tgt-tgt_lock, so the ACCESS_ONCE() isn't necessary. smp_read_barrier_depends() in virtscsi_req_done was introduced to order reading req_vq and decreasing tgt-reqs, but it isn't needed now

Re: [PATCH 2/4] scsi: remove scsi_end_request

2014-05-08 Thread Hannes Reinecke
On 05/01/2014 04:51 PM, Christoph Hellwig wrote: By folding scsi_end_request into its only caller we can significantly clean up the completion logic. We can use simple goto labels now to only have a single place to finish or requeue command there instead of the previous convoluted logic.

Re: [PATCH 3/4] scsi: reintroduce scsi_driver.init_command

2014-05-08 Thread Hannes Reinecke
On 05/01/2014 04:51 PM, Christoph Hellwig wrote: Instead of letting the ULD play games with the prep_fn move back to the model of a central prep_fn with a callback to the ULD. This already cleans up and shortens the code by itself, and will be required to properly support blk-mq in the SCSI

Re: [PATCH 4/4] scsi: handle command allocation failure in scsi_reset_provider

2014-05-08 Thread Hannes Reinecke
On 05/01/2014 04:51 PM, Christoph Hellwig wrote: Signed-off-by: Christoph Hellwig h...@lst.de Reviewed-by: Nicholas Bellinger n...@linux-iscsi.org Reviewed-by: Mike Christie micha...@cs.wisc.edu Reviewed-by: Hannes Reinecke h...@suse.de Cheers, Hannes -- Dr. Hannes Reinecke

Re: [PATCH v1] virtio_scsi: remove ACCESS_ONCE() and smp_read_barrier_depends()

2014-05-08 Thread Ming Lei
On Thu, May 8, 2014 at 3:05 PM, Paolo Bonzini pbonz...@redhat.com wrote: Decrements of reqs are never concurrent with writes of req_vq: before the decrement reqs will be != 0; after the decrement the virtqueue completion routine will not use the req_vq so it can be changed by a new request.

Re: virtio-scsi: two questions related with picking up queue

2014-05-08 Thread Ming Lei
On Wed, 07 May 2014 18:43:45 +0200 Paolo Bonzini pbonz...@redhat.com wrote: Per-CPU spinlocks have bad scalability problems, especially if you're overcommitting. Writing req_vq is not at all rare. OK, thought about it further, and I believe seqcount may be a match for the case, could you

Re: [PATCH v1.1 2/16 update 3] arcmsr: Adding code to support MSI-X interrupt

2014-05-08 Thread ching
Hi Tomas, Thanks for your suggestion. I will add a new patch 17/17 at last. --- diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c --- a/drivers/scsi/arcmsr/arcmsr_hba.c 2014-05-08 17:45:34.0 +0800 +++ b/drivers/scsi/arcmsr/arcmsr_hba.c 2014-05-08

Re: virtio-scsi: two questions related with picking up queue

2014-05-08 Thread Paolo Bonzini
Il 08/05/2014 12:44, Ming Lei ha scritto: On Wed, 07 May 2014 18:43:45 +0200 Paolo Bonzini pbonz...@redhat.com wrote: Per-CPU spinlocks have bad scalability problems, especially if you're overcommitting. Writing req_vq is not at all rare. OK, thought about it further, and I believe

Re: virtio-scsi: two questions related with picking up queue

2014-05-08 Thread Ming Lei
On Thu, May 8, 2014 at 8:17 PM, Paolo Bonzini pbonz...@redhat.com wrote: Il 08/05/2014 12:44, Ming Lei ha scritto: On Wed, 07 May 2014 18:43:45 +0200 Paolo Bonzini pbonz...@redhat.com wrote: Per-CPU spinlocks have bad scalability problems, especially if you're overcommitting. Writing

Re: virtio-scsi: two questions related with picking up queue

2014-05-08 Thread Paolo Bonzini
Il 08/05/2014 14:55, Ming Lei ha scritto: On Thu, May 8, 2014 at 8:17 PM, Paolo Bonzini pbonz...@redhat.com wrote: Il 08/05/2014 12:44, Ming Lei ha scritto: On Wed, 07 May 2014 18:43:45 +0200 Paolo Bonzini pbonz...@redhat.com wrote: Per-CPU spinlocks have bad scalability problems,

Re: virtio-scsi: two questions related with picking up queue

2014-05-08 Thread Ming Lei
On Thu, May 8, 2014 at 9:21 PM, Paolo Bonzini pbonz...@redhat.com wrote: Il 08/05/2014 14:55, Ming Lei ha scritto: On Thu, May 8, 2014 at 8:17 PM, Paolo Bonzini pbonz...@redhat.com wrote: Il 08/05/2014 12:44, Ming Lei ha scritto: On Wed, 07 May 2014 18:43:45 +0200 Paolo Bonzini

[PATCH 01/19] hpsa: add new Smart Array PCI IDs (May 2014)

2014-05-08 Thread Stephen M. Cameron
From: Joe Handzik joseph.t.hand...@hp.com Signed-off-by: Scott Teel scott.t...@hp.com Signed-off-by: Joe Handzik joseph.t.hand...@hp.com Signed-off-by: Stephen M. Cameron scame...@beardog.cce.hp.com Cc: sta...@vger.kernel.org --- drivers/scsi/hpsa.c | 12 1 files changed, 12

[PATCH 12/19] hpsa: avoid unnecessary readl on every command submission

2014-05-08 Thread Stephen M. Cameron
From: root r...@rhel6u2e-s1.ldev.net for controllers which support either of the ioaccel transport methods. Signed-off-by: Stephen M. Cameron scame...@beardog.cce.hp.com --- drivers/scsi/hpsa.c |7 +++ drivers/scsi/hpsa.h | 15 ++- 2 files changed, 21 insertions(+), 1

[PATCH 11/19] hpsa: use per-cpu variable for lockup_detected

2014-05-08 Thread Stephen M. Cameron
From: Stephen M. Cameron scame...@beardog.cce.hp.com Avoid excessive locking by using per-cpu variable for lockup_detected Signed-off-by: Stephen M. Cameron scame...@beardog.cce.hp.com --- drivers/scsi/hpsa.c | 80 ++- drivers/scsi/hpsa.h |2

[PATCH 14/19] hpsa: define extended_report_lun_entry data structure

2014-05-08 Thread Stephen M. Cameron
From: Stephen M. Cameron scame...@beardog.cce.hp.com Signed-off-by: Stephen M. Cameron scame...@beardog.cce.hp.com --- drivers/scsi/hpsa.c | 21 - drivers/scsi/hpsa_cmd.h | 12 +++- 2 files changed, 19 insertions(+), 14 deletions(-) diff --git

[PATCH 09/19] hpsa: allocate reply queues individually

2014-05-08 Thread Stephen M. Cameron
From: Stephen M. Cameron scame...@beardog.cce.hp.com Now that we can allocate more than 4 reply queues (up to 64) we shouldn't try to make them share the same allocation but should allocate them separately. Signed-off-by: Stephen M. Cameron scame...@beardog.cce.hp.com --- drivers/scsi/hpsa.c |

[PATCH 16/19] hpsa: fix event filtering to prevent excessive rescans with old firmware

2014-05-08 Thread Stephen M. Cameron
From: Stephen M. Cameron scame...@beardog.cce.hp.com CTLR_STATE_CHANGE_EVENT and CTLR_STATE_CHANGE_EVENT_REDUNDANT_CNTRL do not require rescans to be initiated. Current firmware filters out these events already, but some out of date firmware doesn't, so the driver needs to filter them out too.

[PATCH 15/19] hpsa: kill annoying messages about SSD Smart Path retries

2014-05-08 Thread Stephen M. Cameron
From: Stephen M. Cameron scame...@beardog.cce.hp.com There's nothing the user can or should do about these messages, the commands are retried down the normal RAID path, and the messages just flood the logs and sap performance. Signed-off-by: Stephen M. Cameron scame...@beardog.cce.hp.com ---

[PATCH 10/19] hpsa: set irq affinity hints to route MSI-X vectors across CPUs

2014-05-08 Thread Stephen M. Cameron
From: Stephen M. Cameron scame...@beardog.cce.hp.com Signed-off-by: Stephen M. Cameron scame...@beardog.cce.hp.com --- drivers/scsi/hpsa.c | 17 - 1 files changed, 16 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 9c44f26..e8090e2

[PATCH 18/19] hpsa: report check condition even if no sense data present for ioaccel2 mode

2014-05-08 Thread Stephen M. Cameron
From: Stephen M. Cameron scame...@beardog.cce.hp.com It shouldn't happen that we get a check condition with no sense data, but if it does, we shouldn't just drop the check condition on the floor. Signed-off-by: Stephen M. Cameron scame...@beardog.cce.hp.com --- drivers/scsi/hpsa.c |7

[PATCH 00/19] hpsa driver updates May 8, 2014

2014-05-08 Thread Stephen M. Cameron
Not a lot of extensive changes in this set, some new PCI IDs, some small bug fixes, quieting some noisy messages, allowing more reply queues, setting irq affinity hints, and some minor locking improvments. drivers/scsi/hpsa.c | 266 +--

[PATCH 07/19] hpsa: remove dev_dbg() calls from hot paths

2014-05-08 Thread Stephen M. Cameron
From: Stephen M. Cameron scame...@beardog.cce.hp.com They are not completely free of cost when disabled and when enabled emitting debug output for every command submitted produces far too much output to be useful. Signed-off-by: Stephen M. Cameron scame...@beardog.cce.hp.com ---

[PATCH 17/19] hpsa: remove bad unlikely annotation from device list updating code

2014-05-08 Thread Stephen M. Cameron
From: Stephen M. Cameron scame...@beardog.cce.hp.com Signed-off-by: Stephen M. Cameron scame...@beardog.cce.hp.com --- drivers/scsi/hpsa.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 8359884..9d4a0bd 100644 ---

[PATCH 08/19] hpsa: choose number of reply queues more intelligently.

2014-05-08 Thread Stephen M. Cameron
From: Stephen M. Cameron scame...@beardog.cce.hp.com No sense having 8 or 16 reply queues if you only have 4 cpus, and likewise no sense limiting to 8 reply queues if you have many more cpus. Signed-off-by: Stephen M. Cameron scame...@beardog.cce.hp.com --- drivers/scsi/hpsa.c |2 ++

[PATCH 04/19] hpsa: allow passthru ioctls to work with bidirectional commands

2014-05-08 Thread Stephen M. Cameron
From: Stephen M. Cameron scame...@beardog.cce.hp.com Treat the the data direction bits as a bit mask allowing both READ and WRITE at the same time instead of testing for equality to see if it's a exclusively a READ or a WRITE. Signed-off-by: Stephen M. Cameron scame...@beardog.cce.hp.com ---

[PATCH 06/19] hpsa: use gcc aligned attribute instead of manually padding structs

2014-05-08 Thread Stephen M. Cameron
From: Stephen M. Cameron scame...@beardog.cce.hp.com Signed-off-by: Stephen M. Cameron scame...@beardog.cce.hp.com --- drivers/scsi/hpsa.c |3 --- drivers/scsi/hpsa_cmd.h | 33 ++--- 2 files changed, 6 insertions(+), 30 deletions(-) diff --git

[PATCH 19/19] hpsa: remove messages about volume status VPD inquiry page not supported

2014-05-08 Thread Stephen M. Cameron
From: Stephen M. Cameron scame...@beardog.cce.hp.com They are annoying and do not help anyone. Signed-off-by: Stephen M. Cameron scame...@beardog.cce.hp.com --- drivers/scsi/hpsa.c | 12 +++- 1 files changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/scsi/hpsa.c

Re: [PATCH 10/19] hpsa: set irq affinity hints to route MSI-X vectors across CPUs

2014-05-08 Thread Govindarajulu Varadarajan
On Thu, 8 May 2014, Stephen M. Cameron wrote: From: Stephen M. Cameron scame...@beardog.cce.hp.com Signed-off-by: Stephen M. Cameron scame...@beardog.cce.hp.com --- drivers/scsi/hpsa.c | 17 - 1 files changed, 16 insertions(+), 1 deletions(-) diff --git

Re: [PATCH 00/10] qla4xxx: 5.04.00-k5: Updates for scsi misc branch

2014-05-08 Thread Mike Christie
On 02/24/2014 09:06 PM, vikas.chaudh...@qlogic.com wrote: From: Vikas Chaudhary vikas.chaudh...@qlogic.com James, Please apply the following patches to the scsi tree at your earliest convenience. Tej Parkash (5): qla4xxx: Do not wait for IO completion, after issuing

RE: [PATCH 10/19] hpsa: set irq affinity hints to route MSI-X vectors across CPUs

2014-05-08 Thread Elliott, Robert (Server Storage)
-Original Message- From: Govindarajulu Varadarajan [mailto:gvara...@cisco.com] Sent: Thursday, 08 May, 2014 4:12 PM To: Stephen M. Cameron Cc: james.bottom...@hansenpartnership.com; Lindley, Justin; martin.peter...@oracle.com; linux-scsi@vger.kernel.org; stephenmcame...@gmail.com;

[PATCH] drivers: scsi: mvsas: fix compiling issue by adding 'MVS_' for enum pci_interrupt_cause

2014-05-08 Thread Chen Gang
The direct cause is IRQ_SPI is already defined as a macro in unicore32 architecture (also, blackfin and mips architectures define it). The related error (unicore32 with allmodconfig) CC [M] drivers/scsi/mvsas/mv_94xx.o In file included from drivers/scsi/mvsas/mv_94xx.c:27:

Re: [PATCH] drivers: scsi: mvsas: fix compiling issue by adding 'MVS_' for enum pci_interrupt_cause

2014-05-08 Thread Chen Gang
Oh, sorry, this patch is incorrect: IRQ_SAS_A and IRQ_SAS_B are used as 'u32' (although they are members of enum pci_interrupt_cause). I will send patch v2 for it. On 05/09/2014 07:45 AM, Chen Gang wrote: The direct cause is IRQ_SPI is already defined as a macro in unicore32 architecture

[PATCH v2] [PATCH] drivers: scsi: mvsas: fix compiling issue by adding 'MVS_' for enum pci_interrupt_cause

2014-05-08 Thread Chen Gang
The direct cause is IRQ_SPI is already defined as a macro in unicore32 architecture (also, blackfin and mips architectures define it). The related error (unicore32 with allmodconfig) CC [M] drivers/scsi/mvsas/mv_94xx.o In file included from drivers/scsi/mvsas/mv_94xx.c:27: