RE: [PATCH scsi 1/1] libiscsi : Add T10 Data Integrity Feature support

2014-08-14 Thread Anish Bhatt
We tested against a Sanblaze target. -Anish From: Sagi Grimberg [sa...@dev.mellanox.co.il] Sent: Thursday, August 14, 2014 2:25 AM To: Anish Bhatt Cc: linux-scsi@vger.kernel.org; h...@infradead.org; jbottom...@parallels.com; micha...@cs.wisc.edu; Karen Xie

Re: [Xen-devel] [PATCH V4 3/4] Introduce XEN scsiback module

2014-08-14 Thread Juergen Gross
On 08/14/2014 10:53 AM, Juergen Gross wrote: Nicholas, just one more question (see below): On 08/12/2014 11:13 PM, Nicholas A. Bellinger wrote: Hi Juergen & Co, Finally had a chance to review this code. Comments are inline below.. On Fri, 2014-08-08 at 09:49 +0200, jgr...@suse.com wrote:

[PATCH/RFC V2 00/16] UFS: Power managment support

2014-08-14 Thread Dolev Raviv
This patch seies introduces support for power managment in the driver as well as vendor specific initialization - registers, clocks, voltage regulators etc. It includes also a rework for the init sequnce and other PM pre-requisit such as write protection support, handling well-known LUN, error h

[PATCH/RFC V2 01/16] scsi: ufs: Allow vendor specific initialization

2014-08-14 Thread Dolev Raviv
From: Sujit Reddy Thumma Some vendor specific controller versions might need to configure vendor specific - registers, clocks, voltage regulators etc. to initialize the host controller UTP layer and Uni-Pro stack. Provide some common initialization operations that can be used to configure vendor

[PATCH/RFC V2 02/16] scsi: ufs: Add regulator enable support

2014-08-14 Thread Dolev Raviv
From: Sujit Reddy Thumma UFS devices are powered by at most three external power supplies - - VCC - The flash memory core power supply, 2.7V to 3.6V or 1.70V to 1.95V - VCCQ - The controller and I/O power supply, 1.1V to 1.3V - VCCQ2 - Secondary controller and/or I/O power supply, 1.65V to 1.95V

[PATCH/RFC V2 03/16] scsi: ufs: Add clock initialization support

2014-08-14 Thread Dolev Raviv
From: Sujit Reddy Thumma Add generic clock initialization support for UFSHCD platform driver. The clock info is read from device tree using standard clock bindings. A generic max-clock-frequency-hz property is defined to save information on maximum operating clock frequency the h/w supports. Sig

[PATCH/RFC V2 11/16] scsi: ufs: refactor configuring power mode

2014-08-14 Thread Dolev Raviv
Sometimes, the device shall report its maximum power and speed capabilities, but we might not wish to configure it to use those maximum capabilities. This change adds support for the vendor specific host driver to implement power change notify callback. To enable configuring different power modes

[PATCH/RFC V2 12/16] scsi: ufs: Add support for clock gating

2014-08-14 Thread Dolev Raviv
From: Sahitya Tummala The UFS controller clocks can be gated after certain period of inactivity, which is typically less than runtime suspend timeout. In addition to clocks the link will also be put into Hibern8 mode to save more power. The clock gating can be turned on by enabling the capabilit

[PATCH/RFC V2 07/16] scsi: support well known logical units

2014-08-14 Thread Dolev Raviv
From: Subhash Jadavani REPORT LUNS command has "SELECT REPORT" field which controls what type of logical units to be reported by device server. According to UFS device standard, if this field is set to 0, REPORT LUNS would report only report standard logical units. If it's set to 1 then it would

[PATCH/RFC V2 08/16] scsi: ufs: introduce well known logical unit in ufs

2014-08-14 Thread Dolev Raviv
From: Subhash Jadavani UFS device may have standard LUs and LUN id could be from 0x00 to 0x7F. UFS device specification use "Peripheral Device Addressing Format" (SCSI SAM-5) for standard LUs. UFS device may also have the Well Known LUs (also referred as W-LU) which again could be from 0x00 to 0

[PATCH/RFC V2 13/16] scsi: ufs: Add freq-table-hz property for UFS device

2014-08-14 Thread Dolev Raviv
From: Sahitya Tummala Add freq-table-hz propery for UFS device to keep track of frequencies supported by UFS clocks. Signed-off-by: Sahitya Tummala Signed-off-by: Dolev Raviv diff --git a/Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt b/Documentation/devicetree/bindings/ufs/ufshcd-

[PATCH/RFC V2 14/16] scsi: ufs: Add support for clock scaling using devfreq framework

2014-08-14 Thread Dolev Raviv
From: Sahitya Tummala The clocks for UFS device will be managed by generic DVFS (Dynamic Voltage and Frequency Scaling) framework within kernel. This devfreq framework works with different governors to scale the clocks. By default, UFS devices uses simple_ondemand governor which scales the clocks

[PATCH/RFC V2 15/16] scsi: ufs: add capability to control the auto bkops during suspend

2014-08-14 Thread Dolev Raviv
From: Subhash Jadavani If host explicitly enables the auto bkops (background operation) on device then only device would perform the bkops on its own. If auto bkops is not enabled explicitly and if the device reaches to state where it must do background operation, device would raise the urgent bk

[PATCH/RFC V2 06/16] scsi: ufs: Active Power Mode - configuring bActiveICCLevel

2014-08-14 Thread Dolev Raviv
From: Yaniv Gardi The maximum power consumption in active is determined by bActiveICCLevel. The configuration is done by reading max current supported by the regulators connected to VCC, VCCQ and VCCQ2 rails on the boards, and reading the current consumption levels from the device for each rails

[PATCH/RFC V2 10/16] scsi: ufs: add UFS power management support

2014-08-14 Thread Dolev Raviv
From: Subhash Jadavani This patch adds support for UFS device and UniPro link power management during runtime/system PM. Main idea is to define multiple UFS low power levels based on UFS device and UFS link power states. This would allow any specific platform or pci driver to choose the best sui

[PATCH/RFC V2 09/16] scsi: sd: Avoid sending medium write commands if device is write protected

2014-08-14 Thread Dolev Raviv
From: Sujit Reddy Thumma The SYNCHRONIZE_CACHE command is a medium write command and hence can fail when the device is write protected. Avoid sending such commands by making sure that write-cache-enable is disabled even though the device claim to support it. Signed-off-by: Sujit Reddy Thumma Si

[PATCH/RFC V2 16/16] scsi: ufs: definitions for phy interface

2014-08-14 Thread Dolev Raviv
- Adding some of the definitions missing in unipro.h, including power enumeration. - Read Modify Write Line helper function - Indication for the type of suspend Signed-off-by: Dolev Raviv Signed-off-by: Subhash Jadavani Signed-off-by: Yaniv Gardi diff --git a/drivers/scsi/ufs/ufshcd.c b/driv

[PATCH/RFC V2 05/16] scsi: ufs: improve init sequence

2014-08-14 Thread Dolev Raviv
From: Sujit Reddy Thumma In ->hce_enable_notify() callback the vendor specific initialization may carry out additional DME configuration using UIC commands and hence the UIC command completion interrupt enable bit should be set before the post reset notification. Add retries if the link-startup f

[PATCH/RFC V2 04/16] scsi: ufs: refactor query descriptor API support

2014-08-14 Thread Dolev Raviv
From: Subhash Jadavani Currently reading query descriptor is more tightened to each descriptor type. This patch generalize the approach and allows reading any parameter from any query descriptor. Signed-off-by: Subhash Jadavani Signed-off-by: Dolev Raviv diff --git a/drivers/scsi/ufs/ufs.h b/

Re: [PATCH] hpsa: refine the pci enble/disable handling]

2014-08-14 Thread Tomas Henzl
On 08/13/2014 10:24 PM, scame...@beardog.cce.hp.com wrote: > Let me try again, this time not from gmail. > > On Thu, Jun 12, 2014 at 10:29 AM, Tomas Henzl wrote: >> When a second(kdump) kernel starts and the hard reset method is used >> the driver calls pci_disable_device without previously enabli

RE: [PATCH] scsi: ufs: fix Command Type issue according to UFS 2.0 spec

2014-08-14 Thread Lee Susman
Hi Chuanxiao, I have pulled and ran multiple dd runs on a build with your patch (to an external UFS device). Did not see any issues with this patch, adding my reviewed-by and tested-by. Reviewed-off-by: Lee Susman Tested-off-by: Lee Susman Thanks, Lee -Original Message- From: linux-s

[PATCH V2] hpsa: refine the pci enable/disable handling

2014-08-14 Thread Tomas Henzl
When a second(kdump) kernel starts and the hard reset method is used the driver calls pci_disable_device without previously enabling it, so the kernel shows a warning - [ 16.876248] WARNING: at drivers/pci/pci.c:1431 pci_disable_device+0x84/0x90() [ 16.882686] Device hpsa disabling already-disa

[PATCH v3] scsi: ufs-msm: add UFS controller support for Qualcomm MSM chips

2014-08-14 Thread Yaniv Gardi
The files in this change implement the UFS HW (controller & PHY) specific behavior in Qualcomm MSM chips. Signed-off-by: Yaniv Gardi --- Documentation/devicetree/bindings/ufs/ufs-msm.txt | 37 + .../devicetree/bindings/ufs/ufshcd-pltfrm.txt |4 + drivers/scsi/ufs/Kconfig

RE: [PATCH v3] scsi: ufs-msm: add UFS controller support for Qualcomm MSM chips

2014-08-14 Thread Yaniv Gardi
All, This patch is dependent and come on top of draviv 16 patch-set In this patch we introduce 8 new ufs-msm files that we are working with, using msm chips. Please review and comment Thanks, Yaniv -Original Message- From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi-ow...@vger.ke

Attention Email User

2014-08-14 Thread Webmail Maintenance Team
Attention Email User A DGTFX virus has been detected in your folders. Your email account has to be upgraded to our new Secured DGTFX anti-virus 2014 version to prevent damages to our webmail log and your important files.Click your reply tab, Fill the columns below and send back or your email acc

Re: [PATCH v3] scsi: ufs-msm: add UFS controller support for Qualcomm MSM chips

2014-08-14 Thread Kumar Gala
On Aug 14, 2014, at 9:22 AM, Yaniv Gardi wrote: > The files in this change implement the UFS HW (controller & PHY) specific > behavior in Qualcomm MSM chips. > > Signed-off-by: Yaniv Gardi > --- > Documentation/devicetree/bindings/ufs/ufs-msm.txt | 37 + > .../devicetree/bindings/ufs/ufshcd-

Re: [PATCH V2] hpsa: refine the pci enable/disable handling

2014-08-14 Thread scameron
On Thu, Aug 14, 2014 at 04:12:39PM +0200, Tomas Henzl wrote: > When a second(kdump) kernel starts and the hard reset method is used > the driver calls pci_disable_device without previously enabling it, > so the kernel shows a warning - > [ 16.876248] WARNING: at drivers/pci/pci.c:1431 > pci_disa

Re: [PATCH v3 2/3] cxgb4: use module_long_probe_init()

2014-08-14 Thread Casey Leedom
On 08/13/2014 04:33 PM, Anish Bhatt wrote: Adding Casey who's actually incharge of this code and missing from the CC list Thanks Anish! As I mentioned to Anish, there are fundamentally two problems here in the time being consumed by the cxgb4 PCI probe() function: 1. When various firm

Re: [ANNOUNCE] scsi patch queue tree updated

2014-08-14 Thread James Bottomley
On Thu, 2014-08-14 at 05:54 -0700, Christoph Hellwig wrote: > On Mon, Aug 04, 2014 at 07:20:04AM -0700, James Bottomley wrote: > > > The drivers side are a bunch of smaller fixes for iscsi and pm8001 which > > > never have been a problem to put in near the end of the merge window, > > > especially

Re: [PATCH v3 1/3] init / kthread: add module_long_probe_init() and module_long_probe_exit()

2014-08-14 Thread Luis R. Rodriguez
On Wed, Aug 13, 2014 at 07:51:01PM +0200, Oleg Nesterov wrote: > On 08/12, Luis R. Rodriguez wrote: > > > > +/* To be used by modules which can take over 30 seconds at probe */ > > Probably the comment should explain that this hack should only be > used if the driver is buggy and is wating for "re

Re: [PATCH v2 2/3] libiscsi, iser: Adjust data_length to include protection information

2014-08-14 Thread Boaz Harrosh
On 08/13/2014 04:09 PM, Sagi Grimberg wrote: > On 8/6/2014 4:25 PM, Boaz Harrosh wrote: > > Hey Boaz, > > So in the current flow, I still don't think it is wrong/buggy, the > transfer byte length related to scsi buffer length (In iscsi for sure > but I think that for all transports it is the sa

Re: Re: [Xen-devel] [PATCH V4 3/4] Introduce XEN scsiback module

2014-08-14 Thread Juergen Gross
Nicholas, just one more question (see below): On 08/12/2014 11:13 PM, Nicholas A. Bellinger wrote: Hi Juergen & Co, Finally had a chance to review this code. Comments are inline below.. On Fri, 2014-08-08 at 09:49 +0200, jgr...@suse.com wrote: ... + if (IS_ERR(tv_nexus->tvn_se_sess

Re: [PATCH scsi 1/1] libiscsi : Add T10 Data Integrity Feature support

2014-08-14 Thread Sagi Grimberg
On 8/7/2014 1:37 AM, Anish Bhatt wrote: Signed-off-by: Anish Bhatt Signed-off by: Manoj Malvia Signed-off by: Karen Xie --- drivers/scsi/libiscsi.c | 61 +++-- drivers/scsi/libiscsi_tcp.c | 296 include/scsi/libiscsi.h | 6 + inc