[PATCH] scsi: storvsc: Force SPC-3 for Win8 Hosts or Later

2014-10-20 Thread Jeff Leung
This patch forces SPC-3 for Hyper-V disks on the VMBus. As Windows 10's virtual SAS bus is SPC-3 compliant and there are no negative side effects on forcing SPC-3 compliance for Win8 hosts, this patch enables SPC-3 compliance by forcing it on for hosts with versions later than Win8. Forcing SPC-3

[PATCH] scsi: storvsc: Force SPC-3 for Win8 Hosts or Later

2014-10-20 Thread Jeff Leung
This patch forces SPC-3 for Hyper-V disks on the VMBus. As Windows 10's virtual SAS bus is SPC-3 compliant and there are no negative side effects on forcing SPC-3 compliance for Win8 hosts, this patch enables SPC-3 compliance by forcing it on for hosts with versions later than Win8. Forcing SPC-3

RE: [PATCH 0/3] scsi: Add Hyper-V logical block provisioning quirks

2014-10-20 Thread Jeff Leung
> Is it OK to replace a scsi_level of SCSI-2 with SCSI_SPC_3? Additionally is > it also OK to force > SCSI_SPC_3 on Hyper-V 2008? I would patch the driver accordingly to force the SPC-3 flag. For a Win2k8 host, I don't know what the side effects are, so it's safe to say it's not a good idea to

Re: [PATCH 0/3] scsi: Add Hyper-V logical block provisioning quirks

2014-10-20 Thread Sitsofe Wheeler
On Sun, Oct 12, 2014 at 01:21:01AM +, KY Srinivasan wrote: > > > -Original Message- > > From: Jeff Leung [mailto:jle...@v10networks.ca] > > Sent: Saturday, October 11, 2014 1:22 PM > > > > > On the current release of Windows (windows 10), we are advertising > > > SPC3 compliance. > >

Re: [PATCH 2/3] scsi: add try_rc16 blacklist flag

2014-10-20 Thread Sitsofe Wheeler
On Tue, Oct 14, 2014 at 09:08:28PM -0400, Martin K. Petersen wrote: > > "Sitsofe" == Sitsofe Wheeler writes: > > Sitsofe> Microsoft Hyper-V virtual disks currently only claim SPC-2 > Sitsofe> compliance causing the kernel skip checks for features such as > Sitsofe> thin provisioning even thou

Re: [PATCH 0/3] scsi: Add Hyper-V logical block provisioning quirks

2014-10-20 Thread Sitsofe Wheeler
On Tue, Oct 14, 2014 at 09:06:37PM -0400, Martin K. Petersen wrote: > > "Sitsofe" == Sitsofe Wheeler writes: > > Sitsofe> A previous patch attempted to add a quirk to workaround this > Sitsofe> but the quirk was only enabled after the features had been > Sitsofe> scanned for, wouldn't work fo

Re: [RFC v2 2/6] driver-core: add driver async_probe support

2014-10-20 Thread Luis R. Rodriguez
> diff --git a/drivers/base/bus.c b/drivers/base/bus.c > index 83e910a..49fe573 100644 > --- a/drivers/base/bus.c > +++ b/drivers/base/bus.c > @@ -10,6 +10,7 @@ > * > */ > > +#include > #include > #include > #include > @@ -547,15 +548,12 @@ void bus_probe_device(struct device *dev) > {

[GIT PULL] target updates for v3.18-rc2

2014-10-20 Thread Nicholas A. Bellinger
Hi Linus, Here are the target updates for v3.18-rc2 code. These where originally destined for -rc1, but due to the combination of travel last week for KVM Forum and my mistake of taking the three week merge window literally, the pull request slipped.. Apologies for that. A heads-up that you'll

RE: [PATCH] vmw_pvscsi: fixup tagging

2014-10-20 Thread Arvind Kumar
Thanks Hannes and Christoph for the answers. The patch to vmw_pvscsi.c looks fine to me. Acked-by: Arvind Kumar Thanks! Arvind From: Hannes Reinecke Sent: Saturday, October 18, 2014 10:42 AM To: Arvind Kumar; Christoph Hellwig Cc: pv-driv...@vmware.com;

Re: [PATCH 2/5] scsi: bfa: bfa_fcs_lport.c: Cleaning up missing null-terminate by switching from strncpy to strzcpy

2014-10-20 Thread Rickard Strandqvist
2014-10-20 17:37 GMT+02:00 Dan Carpenter : > On Sun, Oct 19, 2014 at 12:13:10AM +0200, Rickard Strandqvist wrote: >> Ensures that the string is null-terminate in connection with the >> use of strncpy, by switching from strncpy to strzcpy. >> > > I wish the changelogs were more clear that we have no

Re: [PATCH 23/29] atari_scsi: Convert to platform device

2014-10-20 Thread Michael Schmitz
Hi Finn, >> not certain it is related to this exact patch - the driver crashes >> pretty much on the spot when selecting the first target on the bus. > > If it isn't that exact patch then it will probably be one of the other > atari_scsi patches. Most of the other relevant stuff was covered by my

Re: [PATCH v3] SG_SCSI_RESET ioctl: add no_escalate values

2014-10-20 Thread Jeremy Linton
Reviewed-by: Jeremy Linton I will test it (next week or so) when I have access to a configuration that can test it in a meaningful way. Thanks, -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo i

Re: [OPW kernel] [PATCH v2] scsi: ips.c: Use jiffies comparison instead of do_gettimeofday()

2014-10-20 Thread Arnd Bergmann
On Monday 20 October 2014 20:06:01 Ebru Akagunduz wrote: > do_gettimeofday() only can get 32-bit time types > but the driver should be able to use dates that are > after January 2038. > > Remove do_gettimeofday() and use > jiffies comparison to supply 64-bit time types. The description doesn't se

Re: [PATCH v2] scsi: ips.c: Use jiffies comparison instead of do_gettimeofday()

2014-10-20 Thread James Bottomley
On Mon, 2014-10-20 at 20:06 +0300, Ebru Akagunduz wrote: > do_gettimeofday() only can get 32-bit time types > but the driver should be able to use dates that are > after January 2038. > > Remove do_gettimeofday() and use > jiffies comparison to supply 64-bit time types. > > Signed-off-by: Ebru Ak

[PATCH v2] scsi: ips.c: Use jiffies comparison instead of do_gettimeofday()

2014-10-20 Thread Ebru Akagunduz
do_gettimeofday() only can get 32-bit time types but the driver should be able to use dates that are after January 2038. Remove do_gettimeofday() and use jiffies comparison to supply 64-bit time types. Signed-off-by: Ebru Akagunduz --- drivers/scsi/ips.c | 25 + drivers/

Re: [PATCH 2/5] scsi: bfa: bfa_fcs_lport.c: Cleaning up missing null-terminate by switching from strncpy to strzcpy

2014-10-20 Thread Dan Carpenter
On Sun, Oct 19, 2014 at 12:13:10AM +0200, Rickard Strandqvist wrote: > Ensures that the string is null-terminate in connection with the > use of strncpy, by switching from strncpy to strzcpy. > I wish the changelogs were more clear that we have no reason to think this is a real issue. > Signed-o

Re: [PATCH v4 13/25] virtio_console: enable VQs early

2014-10-20 Thread Thomas Graf
On 10/20/14 at 05:04pm, Michael S. Tsirkin wrote: > Sure enough, this helps: > > Tested-by: Michael S. Tsirkin > Acked-by: Michael S. Tsirkin > > Pls repost as a top-level patch. Thanks for fixing this so promptly. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the

Re: [PATCH v4 13/25] virtio_console: enable VQs early

2014-10-20 Thread Michael S. Tsirkin
On Mon, Oct 20, 2014 at 04:35:55PM +0300, Michael S. Tsirkin wrote: > On Mon, Oct 20, 2014 at 02:42:23PM +0200, Cornelia Huck wrote: > > On Mon, 20 Oct 2014 13:07:50 +0100 > > Thomas Graf wrote: > > > > > On 10/13/14 at 10:50am, Michael S. Tsirkin wrote: > > > > virtio spec requires drivers to se

Re: EH action after scsi_remove_host, was: Re: [PATCH v2 12/12] IB/srp: Add multichannel support

2014-10-20 Thread Bart Van Assche
On 10/17/14 13:01, Christoph Hellwig wrote: On Tue, Oct 07, 2014 at 03:07:17PM +0200, Bart Van Assche wrote: + /* +* Avoid that the SCSI error handler tries to use this channel after +* it has been freed. The SCSI error handler can namely continue +* trying to perfo

Re: [PATCH v4 13/25] virtio_console: enable VQs early

2014-10-20 Thread Michael S. Tsirkin
On Mon, Oct 20, 2014 at 02:42:23PM +0200, Cornelia Huck wrote: > On Mon, 20 Oct 2014 13:07:50 +0100 > Thomas Graf wrote: > > > On 10/13/14 at 10:50am, Michael S. Tsirkin wrote: > > > virtio spec requires drivers to set DRIVER_OK before using VQs. > > > This is set automatically after probe return

Re: [PATCH v4 13/25] virtio_console: enable VQs early

2014-10-20 Thread Thomas Graf
On 10/20/14 at 04:10pm, Michael S. Tsirkin wrote: > On Mon, Oct 20, 2014 at 01:07:50PM +0100, Thomas Graf wrote: > > On 10/13/14 at 10:50am, Michael S. Tsirkin wrote: > > > virtio spec requires drivers to set DRIVER_OK before using VQs. > > > This is set automatically after probe returns, virtio co

Re: [PATCH v4 13/25] virtio_console: enable VQs early

2014-10-20 Thread Thomas Graf
On 10/20/14 at 02:42pm, Cornelia Huck wrote: > On Mon, 20 Oct 2014 13:07:50 +0100 > Thomas Graf wrote: > > > On 10/13/14 at 10:50am, Michael S. Tsirkin wrote: > > > virtio spec requires drivers to set DRIVER_OK before using VQs. > > > This is set automatically after probe returns, virtio console

Re: [PATCH v4 13/25] virtio_console: enable VQs early

2014-10-20 Thread Michael S. Tsirkin
On Mon, Oct 20, 2014 at 04:10:16PM +0300, Michael S. Tsirkin wrote: > On Mon, Oct 20, 2014 at 01:07:50PM +0100, Thomas Graf wrote: > > On 10/13/14 at 10:50am, Michael S. Tsirkin wrote: > > > virtio spec requires drivers to set DRIVER_OK before using VQs. > > > This is set automatically after probe

Re: [PATCH v4 13/25] virtio_console: enable VQs early

2014-10-20 Thread Michael S. Tsirkin
On Mon, Oct 20, 2014 at 01:07:50PM +0100, Thomas Graf wrote: > On 10/13/14 at 10:50am, Michael S. Tsirkin wrote: > > virtio spec requires drivers to set DRIVER_OK before using VQs. > > This is set automatically after probe returns, virtio console violated this > > rule by adding inbufs, which cause

Re: [PATCH v2 12/12] IB/srp: Add multichannel support

2014-10-20 Thread Bart Van Assche
On 10/19/14 19:36, Sagi Grimberg wrote: On 10/7/2014 4:07 PM, Bart Van Assche wrote: * comp_vector, a number in the range 0..n-1 specifying the - MSI-X completion vector. Some HCA's allocate multiple (n) - MSI-X vectors per HCA port. If the IRQ affinity masks of -

Re: [PATCH v4 13/25] virtio_console: enable VQs early

2014-10-20 Thread Cornelia Huck
On Mon, 20 Oct 2014 13:07:50 +0100 Thomas Graf wrote: > On 10/13/14 at 10:50am, Michael S. Tsirkin wrote: > > virtio spec requires drivers to set DRIVER_OK before using VQs. > > This is set automatically after probe returns, virtio console violated this > > rule by adding inbufs, which causes the

Re: [PATCH v2 07/12] IB/srp: Avoid that I/O hangs due to a cable pull during LUN scanning

2014-10-20 Thread Bart Van Assche
On 10/19/14 18:27, Sagi Grimberg wrote: On 10/7/2014 4:05 PM, Bart Van Assche wrote: +static int srp_sdev_count(struct Scsi_Host *host) +{ +struct scsi_device *sdev; +int c = 0; + +shost_for_each_device(sdev, host) +c++; + +return c; +} + Is this really an SRP specific

Re: [PATCH v4 13/25] virtio_console: enable VQs early

2014-10-20 Thread Thomas Graf
On 10/13/14 at 10:50am, Michael S. Tsirkin wrote: > virtio spec requires drivers to set DRIVER_OK before using VQs. > This is set automatically after probe returns, virtio console violated this > rule by adding inbufs, which causes the VQ to be used directly within > probe. > > To fix, call virtio

Re: [PATCH v2 04/12] scsi_tcq.h: Add support for multiple hardware queues

2014-10-20 Thread Bart Van Assche
On 10/19/14 18:12, Sagi Grimberg wrote: On 10/7/2014 4:04 PM, Bart Van Assche wrote: -req = blk_queue_find_tag(sdev->request_queue, tag); +req = blk_queue_find_tag(sdev->request_queue, tag); Why is this line different? This is because the indentation has been modified fro

Re: [PATCH v2 12/12] IB/srp: Add multichannel support

2014-10-20 Thread Bart Van Assche
On 10/17/14 13:06, Christoph Hellwig wrote: } else { + if (blk_mq_unique_tag_to_hwq(rsp->tag) != ch - target->ch) + pr_err("Channel idx mismatch: tag %#llx <> ch %#lx\n", + rsp->tag, ch - target->ch); scmnd =

Re: [PATCH v2 11/12] IB/srp: Eliminate free_reqs list

2014-10-20 Thread Bart Van Assche
On 10/17/14 12:59, Christoph Hellwig wrote: On Tue, Oct 07, 2014 at 03:06:54PM +0200, Bart Van Assche wrote: The free_reqs list is no longer needed now that we are using tags assigned by the block layer. Hence remove it. Is there any good reason not to fold this into the previous patch? The

Re: [PATCH v2 10/12] IB/srp: Use block layer tags

2014-10-20 Thread Bart Van Assche
On 10/17/14 12:58, Christoph Hellwig wrote: diff --git a/drivers/infiniband/ulp/srp/ib_srp.c b/drivers/infiniband/ulp/srp/ib_srp.c index cc0bf83b..224ef25 100644 --- a/drivers/infiniband/ulp/srp/ib_srp.c +++ b/drivers/infiniband/ulp/srp/ib_srp.c @@ -853,7 +853,6 @@ static int srp_alloc_req_data(

Re: [PATCH v3] SG_SCSI_RESET ioctl: add no_escalate values

2014-10-20 Thread Hannes Reinecke
On 10/18/2014 10:11 PM, Douglas Gilbert wrote: > Further to a January 2013 thread titled: "[PATCH] SG_SCSI_RESET ioctl > should only perform requested operation" by Jeremy Linton a patch (v3) > is presented that expands the existing ioctl to include "no_escalate" > versions to the existing resets.

Re: [PATCH 23/29] atari_scsi: Convert to platform device

2014-10-20 Thread Finn Thain
On Mon, 20 Oct 2014, Michael Schmitz wrote: > Hi Finn, > > not certain it is related to this exact patch - the driver crashes > pretty much on the spot when selecting the first target on the bus. If it isn't that exact patch then it will probably be one of the other atari_scsi patches. Most o

Re: [PATCH 23/29] atari_scsi: Convert to platform device

2014-10-20 Thread Michael Schmitz
Hi Finn, not certain it is related to this exact patch - the driver crashes pretty much on the spot when selecting the first target on the bus. Panic log: Atari SCSI: resetting the SCSI bus... done scsi host0: Atari native SCSI, io_port 0x0, n_io_port 0, base 0x0, irq 0, can_queue 8, cmd_per_

Re: [PATCH 0/5] block/scsi/lio support for COMPARE_AND_WRITE

2014-10-20 Thread Sagi Grimberg
On 10/18/2014 11:32 PM, Mike Christie wrote: On 10/18/2014 03:11 AM, Bart Van Assche wrote: On 10/16/14 07:37, micha...@cs.wisc.edu wrote: The following patches implement the SCSI command COMPARE_AND_WRITE as a new bio/request type REQ_CMP_AND_WRITE. COMPARE_AND_WRITE is defined in the SCSI SBC