[PATCH] lpfc: fix memory leak and NULL dereference

2015-09-23 Thread Sudip Mukherjee
kmalloc() can return NULL and without checking we were dereferencing it. Moreover if kmalloc succeeds but the function fails in other parts then we were returning the error code but we missed freeing lcb_context. While at it fixed one related checkpatch warning. Signed-off-by: Sudip Mukherjee

Re: [PATCH 20/23] scsi_dh_alua: Recheck state on unit attention

2015-09-23 Thread Hannes Reinecke
On 09/22/2015 09:57 PM, Ewan Milne wrote: > On Thu, 2015-08-27 at 14:41 +0200, Hannes Reinecke wrote: >> When we receive a unit attention code of 'ALUA state changed' >> we should recheck the state, as it might be due to an implicit >> ALUA state transition. >> At the same time a workqueue item

Re: [RFT v3] eata: Convert eata driver as normal PCI and platform device drivers

2015-09-23 Thread Arthur Marsh
Jiang Liu wrote on 23/09/15 14:54: Hi Arthur, I have found the cause of the warning messages, it's caused by a flaw in the conversion. But according to my understanding, it isn't related to the kexec/kdump failure. Could you please help to test the attached new version? Thanks! Gerry

Re: [PATCH] storvsc: get rid of homegrown copy_{to,from}_bounce_buffer()

2015-09-23 Thread Vitaly Kuznetsov
Christoph Hellwig writes: > On Tue, Sep 22, 2015 at 06:27:50PM +0200, Vitaly Kuznetsov wrote: >> Storvsc driver needs to ensure there are no 'holes' in the presented >> sg list (all segments in the middle of the list need to be of PAGE_SIZE). > > I think it should instead set

[PATCH v2] storvsc: get rid of bounce buffer

2015-09-23 Thread Vitaly Kuznetsov
Storvsc driver needs to ensure there are no 'holes' in the presented sg list (all segments in the middle of the list need to be of PAGE_SIZE). When a hole is detected storvsc driver creates a 'bounce sgl' without holes and copies data over with copy_{to,from}_bounce_buffer() functions. Setting

RE: [PATCH v2] storvsc: get rid of bounce buffer

2015-09-23 Thread KY Srinivasan
> -Original Message- > From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] > Sent: Wednesday, September 23, 2015 5:59 AM > To: linux-scsi@vger.kernel.org > Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; KY > Srinivasan ; Haiyang Zhang >

Re: Limit max concurrent sessions

2015-09-23 Thread Emmanuel Florac
Le Wed, 23 Sep 2015 16:20:01 +0200 Gionatan Danti écrivait: > Hi all, > anyone with some ideas / infos ? > > Thanks. > > On 06/05/15 17:36, Gionatan Danti wrote: > > Hi all, > > I would like to understand if, and how to, limit the maximum number > > of simultaneous

Re: [PATCH v2 25/30] cxlflash: Fix MMIO and endianness errors

2015-09-23 Thread Brian King
Reviewed-by: Brian King -- Brian King Power Linux I/O IBM Linux Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: Limit max concurrent sessions

2015-09-23 Thread Gionatan Danti
Hi all, anyone with some ideas / infos ? Thanks. On 06/05/15 17:36, Gionatan Danti wrote: Hi all, I would like to understand if, and how to, limit the maximum number of simultaneous connections to a specific LUN, both with the old iSCSI stack (tgtadmin and friends) and the new one (targetcli

Re: [PATCH 19/23] scsi_dh_alua: Use workqueue for RTPG

2015-09-23 Thread Ewan Milne
On Tue, 2015-09-22 at 22:15 +0200, Hannes Reinecke wrote: > On 09/22/2015 09:49 PM, Ewan Milne wrote: > > On Thu, 2015-08-27 at 14:41 +0200, Hannes Reinecke wrote: > >> The current ALUA device_handler has two drawbacks: > >> - We're sending a 'SET TARGET PORT GROUP' command to every LUN, > >>

Re: [RFT v3] eata: Convert eata driver as normal PCI and platform device drivers

2015-09-23 Thread James Bottomley
On Wed, 2015-09-23 at 20:14 +0930, Arthur Marsh wrote: > > Jiang Liu wrote on 23/09/15 14:54: > > > Hi Arthur, > > I have found the cause of the warning messages, it's caused > > by a flaw in the conversion. But according to my understanding, > > it isn't related to the kexec/kdump failure.

Question about expected behavior of terminate_rport_io() in fc_function_template

2015-09-23 Thread Benjamin Block
Hello, just a short question. If a low-level driver implements the function `terminate_rport_io()` in `struct fc_function_template`, and it gets called after IO failed, is the low-level driver expected to handle this request synchronously or can it just schedule an action that is worked on

Re: [RFT v3] eata: Convert eata driver as normal PCI and platform device drivers

2015-09-23 Thread Arthur Marsh
Jiang Liu wrote on 24/09/15 13:58: Hi James, Thanks for review. How about the attached patch which addresses the three suggestions from you? Thanks! Gerry I've applied the patch, rebuilt the kernel and verified that it allows unloading of the eata module and reloading it, as well

Re: [PATCH v2 26/30] cxlflash: Fix to prevent EEH recovery failure

2015-09-23 Thread Brian King
Reviewed-by: Brian King -- Brian King Power Linux I/O IBM Linux Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH v2 27/30] cxlflash: Correct spelling, grammar, and alignment mistakes

2015-09-23 Thread Brian King
Reviewed-by: Brian King -- Brian King Power Linux I/O IBM Linux Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at

dobrý den..

2015-09-23 Thread messg
Ahoj, Muzete me kontaktovat na e-mailovou adresu nize pro vysvetlení prospesny spoluprace. e-mail: chn.j...@gmail.com -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH v2 30/30] MAINTAINERS: Add cxlflash driver

2015-09-23 Thread Brian King
Reviewed-by: Brian King -- Brian King Power Linux I/O IBM Linux Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: Question about expected behavior of terminate_rport_io() in fc_function_template

2015-09-23 Thread Hannes Reinecke
On 09/23/2015 07:06 PM, Benjamin Block wrote: > Hello, > > just a short question. If a low-level driver implements the function > `terminate_rport_io()` in `struct fc_function_template`, and it gets > called after IO failed, is the low-level driver expected to handle this > request synchronously

Re: [PATCH v2 28/30] cxlflash: Fix to prevent stale AFU RRQ

2015-09-23 Thread Brian King
Reviewed-by: Brian King -- Brian King Power Linux I/O IBM Linux Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [RFT v3] eata: Convert eata driver as normal PCI and platform device drivers

2015-09-23 Thread Jiang Liu
On 2015/9/23 22:40, James Bottomley wrote: > On Wed, 2015-09-23 at 20:14 +0930, Arthur Marsh wrote: >> >> Jiang Liu wrote on 23/09/15 14:54: >> >>> Hi Arthur, >>> I have found the cause of the warning messages, it's caused >>> by a flaw in the conversion. But according to my understanding, >>>

[PATCH 1/1] scsi subsystem : fix function __scsi_device_lookup

2015-09-23 Thread Zhengping Zhou
when a scsi_device is unpluged from scsi controller, if the scsi_device is still be used by application layer,it won't be released until users release it. In this case, scsi_device_remove just set the scsi_device's state to be SDEV_DEL. But if you plug the disk just before the old scsi_device is

[PATCH] scsi_dh: avoid allowing dh_state to pass format specs when requesting a module

2015-09-23 Thread Sasha Levin
A malicious string passed from userspace might contain format specifiers which request_module() might try to handle, which is bad. Signed-off-by: Sasha Levin --- drivers/scsi/scsi_dh.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git