Re: [PATCH v5 14/15] scsi: ufs: add device quirk delay before putting UFS rails in LPM

On 02/28/2016 09:32 PM, Yaniv Gardi wrote: > We put the UFS device in sleep state & UFS link in hibern8 state during > runtime suspaned. After this we put all the UFS rails in low power > modes immediately but it seems some devices may still draw more than > sleep current from UFS rails

Re: [PATCH v5 13/15] scsi: ufs: fix leakage during link off state

On 02/28/2016 09:32 PM, Yaniv Gardi wrote: > Currently when we try to put the link in off/disabled state during > suspend, it seems link is not being kept in low power mode. > This patch fixes the issue by putting the link in hibern8 first > (so device also puts the link in low power mode) and

Re: [PATCH v5 12/15] scsi: ufs: tune UniPro parameters to optimize hibern8 exit time

On 02/28/2016 09:32 PM, Yaniv Gardi wrote: > Optimal values of local UniPro parameters like PA_Hibern8Time & > PA_TActivate can help reduce the hibern8 exit latency. If both host and > device supports UniPro ver1.6 or later, these parameters will be > automatically tuned during link startup

Re: [PATCH v5 10/15] scsi: ufs: add retry for query descriptors

On 02/28/2016 09:32 PM, Yaniv Gardi wrote: > Query commands have 100ms timeout and it may timeout if they are > issued in parallel to ongoing read/write SCSI commands, this change > adds the retry (max: 10) in case command timeouts. > > Signed-off-by: Subhash Jadavani >

Re: [PATCH v5 09/15] scsi: ufs: add error recovery after DL NAC error

On 02/28/2016 09:32 PM, Yaniv Gardi wrote: > Some vendor's UFS device sends back to back NACs for the DL data frames > causing the host controller to raise the DFES error status. Sometimes > such UFS devices send back to back NAC without waiting for new > retransmitted DL frame from the host and

Re: [PATCH v5 08/15] scsi: ufs: make error handling bit faster

On 02/28/2016 09:32 PM, Yaniv Gardi wrote: > UFS driver's error handler forcefully tries to clear all the pending > requests. For each pending request in the queue, it waits 1 sec for it > to get cleared. If we have multiple requests in the queue then it's > possible that we might end up waiting

Re: [PATCH v5 06/15] scsi: ufs: separate device and host quirks

On 02/28/2016 09:32 PM, Yaniv Gardi wrote: > Currently we use the host quirks mechanism in order to > handle both device and host controller quirks. > In order to support various of UFS devices we should separate > handling the device quirks from the host controller's. > > Reviewed-by: Gilad

Re: [PATCH v5 07/15] scsi: ufs: disable vccq if it's not needed by UFS device

On 02/28/2016 09:32 PM, Yaniv Gardi wrote: > Some UFS devices don't require VCCQ rail for device operations hence > this change adds support to recognize such devices and remove vote for > the unused VCCQ rail. > > Signed-off-by: Subhash Jadavani > Signed-off-by: Yaniv

Re: [PATCH v5 04/15] scsi: ufs: verify hba controller hce reg value

On 02/28/2016 09:32 PM, Yaniv Gardi wrote: > Sometimes due to hw issues it takes some time to the > host controller register to update. In order to verify the register > has updated, a polling is done until its value is set. > > In addition the functions ufshcd_hba_stop() and >

Re: [PATCH v5 03/15] scsi: ufs: implement scsi host timeout handler

On 02/28/2016 09:32 PM, Yaniv Gardi wrote: > A race condition exists between request requeueing and scsi layer > error handling: > When UFS driver queuecommand returns a busy status for a request, > it will be requeued and its tag will be freed and set to -1. > At the same time it is possible that

RE: [PATCH] qlogicpti: Return correct error code

Reviewed-by: Shane Seymour -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

RE: [PATCH 1/2] scsi_transport_fc: implement 'disable_target_scan' module parameter

Reviewed-by: Shane Seymour -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

RE: [PATCH 2/2] scsi_transport_fc: Implement 'async_user_scan' module parameter

Reviewed-by: Shane Seymour -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

RE: [PATCH] snic: correctly check for array overrun on overly long version number

Reviewed-by: Shane Seymour -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] target/cxgbit: add INET dependency

Hi Arnd, On Mon, 2016-02-29 at 12:14 +0100, Arnd Bergmann wrote: > The newly added cxgbit driver directly calls functions of the > IPv4 network stack, which fails if that is disabled: > > ERROR: "ip_route_output_flow" [drivers/target/iscsi/cxgbit/cxgbit.ko] > undefined! > ERROR: "__ip_dev_find"

[Bug 112241] Under heavy load FC TARGET going to Oops

https://bugzilla.kernel.org/show_bug.cgi?id=112241 --- Comment #3 from nab --- Hi Anthony, On Mon, 2016-02-29 at 02:26 +, bugzilla-dae...@bugzilla.kernel.org wrote: > https://bugzilla.kernel.org/show_bug.cgi?id=112241 > > Anthony changed:

Re: [Bug 112241] Under heavy load FC TARGET going to Oops

Hi Anthony, On Mon, 2016-02-29 at 02:26 +, bugzilla-dae...@bugzilla.kernel.org wrote: > https://bugzilla.kernel.org/show_bug.cgi?id=112241 > > Anthony changed: > >What|Removed |Added >

Re: [PATCH v5 02/15] scsi: ufs: avoid spurious UFS host controller interrupts

On 02/28/2016 09:32 PM, Yaniv Gardi wrote: > When control reaches to Linux UFS driver during UFS boot mode, UFS host > controller interrupt status/enable registers may have left over > settings. > In order to avoid any spurious interrupts due to these left overs, > it's important to clear these

Re: [PATCH v5 01/15] scsi: ufs-qcom: add number of lanes per direction

On 02/28/2016 09:32 PM, Yaniv Gardi wrote: > Different platform may have different number of lanes > for the UFS link. > Add parameter to device tree specifying how many lanes > should be configured for the UFS link. > > Signed-off-by: Gilad Broner > Signed-off-by: Yaniv

Re: [PATCH 1/8] scsi_sysfs: add 'is_bin_visible' callback

On 03/01/2016 12:51 PM, Hannes Reinecke wrote: > Add 'is_bin_visible' callback to blank out unsupported vpd pages. > > Signed-off-by: Hannes Reinecke > --- > drivers/scsi/scsi_sysfs.c | 23 +++ > 1 file changed, 23 insertions(+) > Sorry, this is actually a

[PATCH 1/6] scsi: Add 'access_state' and 'preferred_path' attribute

Add an 'access_state' field to struct scsi_device and display them in sysfs as 'access_state' and 'preferred_path' attribute. Signed-off-by: Hannes Reinecke --- drivers/scsi/scsi_sysfs.c | 74 ++ include/scsi/scsi_device.h | 1 +

[PATCH 3/6] scsi_dh_alua: update 'access_state' field

Track attached SCSI devices and update the 'access_state' field whenever an ALUA state change has been detected. Reviewed-by: Bart Van Assche Reviewed-by: Ewan Milne Reviewed-by: Christoph Hellwig Signed-off-by: Hannes Reinecke

[PATCH 2/6] scsi_dh_alua: use common definitions for ALUA state

scsi_proto.h now contains definitions for the ALUA state, so we don't have to carry them in the device handler. Reviewed-by: Christoph Hellwig Signed-off-by: Hannes Reinecke --- drivers/scsi/device_handler/scsi_dh_alua.c | 58 +- 1 file

[PATCH 6/6] scsi_sysfs: call 'device_add' after attaching device handler

'device_add' will be evaluating the 'is_visible' callback when creating the sysfs attributes. As by this time the device handler has not been attached the 'access_state' attribute will never be visible. This patch moves the code around so that the device handler is present by the time

[PATCH 4/6] scsi_dh_rdac: update 'access_state' field

Track attached SCSI devices and update the 'access_state' whenever the path state of the device changes. Signed-off-by: Hannes Reinecke --- drivers/scsi/device_handler/scsi_dh_rdac.c | 38 -- 1 file changed, 31 insertions(+), 7 deletions(-) diff --git

[PATCH 5/6] scsi_dh_emc: update 'access_state' field

Update the 'access_state' field of the SCSI device whenever the path state changes. Signed-off-by: Hannes Reinecke --- drivers/scsi/device_handler/scsi_dh_emc.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/device_handler/scsi_dh_emc.c

[PATCH][RESEND] scsi_sysfs: add 'is_bin_visible' callback

Add 'is_bin_visible' callback to blank out unsupported vpd pages. Signed-off-by: Hannes Reinecke --- drivers/scsi/scsi_sysfs.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/drivers/scsi/scsi_sysfs.c b/drivers/scsi/scsi_sysfs.c index 00bc721..d8b275b

[PATCH 1/8] scsi_sysfs: add 'is_bin_visible' callback

Add 'is_bin_visible' callback to blank out unsupported vpd pages. Signed-off-by: Hannes Reinecke --- drivers/scsi/scsi_sysfs.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/drivers/scsi/scsi_sysfs.c b/drivers/scsi/scsi_sysfs.c index 00bc721..d8b275b

Re: [PATCH] eata: Convert eata driver as normal PCI and platform device drivers

Hi Jiang, [auto build test ERROR on scsi/for-next] [also build test ERROR on v4.5-rc6 next-20160229] [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] url: https://github.com/0day-ci/linux/commits/Jiang-Liu/eata-Convert-eata-driver

[PATCH] eata: Convert eata driver as normal PCI and platform device drivers

Previously the eata driver just grabs and accesses eata PCI devices without implementing a PCI device driver, that causes troubles with latest IRQ related Commit 991de2e59090 ("PCI, x86: Implement pcibios_alloc_irq() and pcibios_free_irq()") changes the way to allocate PCI legacy IRQ for PCI

Reviews, please

Loose ends for 4.6: aicasm: fix kbuild for separated build directories https://patchwork.kernel.org/patch/8298331/ https://patchwork.kernel.org/patch/8343891/ qlogicpti: Return correct error code https://patchwork.kernel.org/patch/8338931/ scsi_transport_fc: Implement

Re: [PATCH 0/6] ncr5380: Exception handling fixes for v4.5

> "Finn" == Finn Thain writes: Finn> These patches fix some exception handling and autosense bugs that Finn> I accidentally introduced in v4.5-rc1. Finn> drivers/scsi/NCR5380.c | 133 +++ Finn>

Re: [PATCH] be2iscsi:Add missing error check in beiscsi_eeh_resume

> "Nicholas" == Nicholas Krause writes: Nicholas> This adds the missing error check and path for if the call to Nicholas> the function hwi_init_controller fails as this error path was Nicholas> clearly missed when writing beiscsi_eeh_resume and thus we Nicholas> must add

Re: [PATCH] fcoe: fix reset of fip selection time.

> "Usha" == Usha Ketineni writes: Usha> Do not reset fip selection time for every advertisement in Usha> fcoe_ctlr_recv_adv() but set it only once for the first validated Usha> FCF. Otherwise FCF selection won't happen when the advertisements Usha> consistently

Re: [PATCH v2 0/6] hisi_sas: add abort and retry feature

> "John" == John Garry writes: John> This patchset introduces support to abort certain commands which John> have failed and retry. Certain errors require that the command be John> retried, like TRANS_TX_CREDIT_TIMEOUT_ERR in v1 hw. However, when John> these errors

Re: [PATCH v2 1/1] sd: add missing scenario for sd_config_write_same

> "Tom" == Tom Yan writes: Tom> Since you've mentioned it, why do we disable write same for all Tom> devices with a ATA Information VPD? Generally speaking, SAS controllers that properly translate SCSI WRITE SAME to ATA ditto also support modern features such as the

Re: [Lsf-pc] [LSF/MM ATTEND] Online Logical Head Depop and SMR disks chunked writepages

From: Jan Kara Date: Monday, February 29, 2016 at 22:40 To: Damien Le Moal Cc: Jan Kara , "linux-bl...@vger.kernel.org" , Bart Van Assche , Matias Bjorling

Re: [PATCHv2] iscsi_ibft: Add prefix-len attr and display netmask

On 02/29/2016 01:04 PM, Konrad Rzeszutek Wilk wrote: > On Mon, Feb 29, 2016 at 1:45 PM, Mike Christie wrote: >> On 02/25/2016 12:15 PM, Lee Duncan wrote: >>> From: Hannes Reinecke >>> >>> The iBFT table only specifies a prefix length, not a netmask. >>> And

Re: [PATCHv2] iscsi_ibft: Add prefix-len attr and display netmask

On 02/29/2016 10:45 AM, Mike Christie wrote: > On 02/25/2016 12:15 PM, Lee Duncan wrote: >> From: Hannes Reinecke >> >> The iBFT table only specifies a prefix length, not a netmask. >> And the netmask is pretty much pointless for IPv6. >> So introduce a new attribute 'prefix-len'

Re: [LSF/MM TOPIC][LSF/MM ATTEND] LIO Target Synchronization with sysfs [resend]

On 02/27/2016 01:54 PM, Nicholas A. Bellinger wrote: > On Sat, 2016-02-27 at 08:19 -0800, Lee Duncan wrote: >> [Apologies for the resend.] >> >> I would like to attend LSF/MM this year. I would like to discuss >> problems I've had dealing with LIO targets and their inherent >> asynchronicity in

Re: [PATCHv2] iscsi_ibft: Add prefix-len attr and display netmask

On Mon, Feb 29, 2016 at 1:45 PM, Mike Christie wrote: > On 02/25/2016 12:15 PM, Lee Duncan wrote: >> From: Hannes Reinecke >> >> The iBFT table only specifies a prefix length, not a netmask. >> And the netmask is pretty much pointless for IPv6. >> So introduce

Re: [Open-FCoE] [PATCH] fcoe: fix reset of fip selection time.

On Mon, Feb 29, 2016 at 03:36:52AM -0800, Usha Ketineni wrote: > Do not reset fip selection time for every advertisement > in fcoe_ctlr_recv_adv() but set it only once for the first > validated FCF. Otherwise FCF selection won't happen when the > advertisements consistently arrive with sub

Re: [PATCHv2] iscsi_ibft: Add prefix-len attr and display netmask

On 02/25/2016 12:15 PM, Lee Duncan wrote: > From: Hannes Reinecke > > The iBFT table only specifies a prefix length, not a netmask. > And the netmask is pretty much pointless for IPv6. > So introduce a new attribute 'prefix-len' and display the > netmask attribute only for IPv4

[PATCH] fcoe: fix reset of fip selection time.

Do not reset fip selection time for every advertisement in fcoe_ctlr_recv_adv() but set it only once for the first validated FCF. Otherwise FCF selection won't happen when the advertisements consistently arrive with sub FCOE_CTLR_START_DELAY periodicity. Tested-by: Narendra K

Re: [PATCH 00/35 v4] separate operations from flags in the bio/request structs

On 02/29/2016 11:13 AM, Christoph Hellwig wrote: > Any reason you've dropped my ACK for the previous version? Sorry. I think I accidentally dropped it when I rebased back over to linux-next. It looks like it only got stuck on the first patch. I will fix that up on the resend for those kbuild

Re: [PATCH 00/35 v4] separate operations from flags in the bio/request structs

Any reason you've dropped my ACK for the previous version? Jens, is this something you're fine with? Would be great to figure out a way to get this into 4.6. There's probably going to be plenty of conflicts, so having some sort of stable base tree would be nice.. (Talking about conflicts,

Re: small diff in reported GiB size of an SSD

James Bottomley: > On Mon, 2016-02-29 at 13:31 +, Toralf Förster wrote: > commit 564b026fbd0d28e9f70fb3831293d2922bb7855b > Author: James Bottomley > Date: Wed Jan 20 14:58:29 2016 -0800 > > string_helpers: fix precision loss for some inputs > > James > > cool

Re: small diff in reported GiB size of an SSD

On Mon, 2016-02-29 at 13:31 +, Toralf Förster wrote: > I'm just curious about this diff in dmesg output between 4.3.2 and > 4.3.3 at a 64 bit Gentoo hardened system: > > $ diff dmesg-4.4.[23]-hardened | grep logical > < sd 0:0:0:0: [sda] 468862128 512-byte logical blocks: (240 GB/223 > GiB) >

Re: [Lsf-pc] [LSF/MM ATTEND] Online Logical Head Depop and SMR disks chunked writepages

On Mon 29-02-16 02:02:16, Damien Le Moal wrote: > > >On Wed 24-02-16 01:53:24, Damien Le Moal wrote: > >> > >> >On Tue 23-02-16 05:31:13, Damien Le Moal wrote: > >> >> > >> >> >On 02/22/16 18:56, Damien Le Moal wrote: > >> >> >> 2) Write back of dirty pages to SMR block devices: > >> >> >> > >>

small diff in reported GiB size of an SSD

I'm just curious about this diff in dmesg output between 4.3.2 and 4.3.3 at a 64 bit Gentoo hardened system: $ diff dmesg-4.4.[23]-hardened | grep logical < sd 0:0:0:0: [sda] 468862128 512-byte logical blocks: (240 GB/223 GiB) > sd 0:0:0:0: [sda] 468862128 512-byte logical blocks: (240 GB/224

[PATCH] target/cxgbit: add INET dependency

The newly added cxgbit driver directly calls functions of the IPv4 network stack, which fails if that is disabled: ERROR: "ip_route_output_flow" [drivers/target/iscsi/cxgbit/cxgbit.ko] undefined! ERROR: "__ip_dev_find" [drivers/target/iscsi/cxgbit/cxgbit.ko] undefined! This adds a Kconfig

Re: [PATCH v2 3/3] scsi: allow scsi devices to use direct complete

On Sat, Feb 27, 2016 at 01:07:06AM -0800, dbasehore . wrote: > That's an interesting question. Part of direct complete is to leave > the device runtime suspended even after the system resumes if > possible. The comments in pm_complete_with_resume_check indicate that > the firmware may resume a