Re: Fluctuating "acceptance" on requested data length in SATA/AHCI

2016-07-14 Thread Tejun Heo
On Fri, Jul 15, 2016 at 03:10:40AM +0800, Tom Yan wrote: > I hadn't been able to "locate" a sensible and/or solid point where the > fluctuation start, but I did notice that the chance of "failure" would > rise with the requested length. Also, if I boot with > `libata.force=noncq`, the failure seems

Fluctuating "acceptance" on requested data length in SATA/AHCI

2016-07-14 Thread Tom Yan
So I recently been doing some experiment on different storage hosts (AHCI and UAS) to see how certain block layer limits in the kernel and so matters on them. I notice some behavior in SATA/AHCI which bothers me a bit. I have been testing with `sg_raw` by issuing READ (10/16) commands. But before

Re: [RFC 1/3] ata: bump ATA_MAX_SECTORS_LBA48 to 65536

2016-07-14 Thread Tejun Heo
On Fri, Jul 15, 2016 at 02:22:52AM +0800, Tom Yan wrote: > On 14 July 2016 at 01:03, Tejun Heo wrote: > > > > It's used to device max_sectors. > > > > Not really. "max_sectors" of ATA drives have been set to > BLK_DEF_MAX_SECTORS, for at least quite some time. > > > > > This is way too gratuitou

Re: [RFC 1/3] ata: bump ATA_MAX_SECTORS_LBA48 to 65536

2016-07-14 Thread Tom Yan
On 14 July 2016 at 01:03, Tejun Heo wrote: > > It's used to device max_sectors. > Not really. "max_sectors" of ATA drives have been set to BLK_DEF_MAX_SECTORS, for at least quite some time. > > This is way too gratuitous. There's no rationale for it while it has > actual real-world risks. max_

Re: [RFC 3/3] libata-scsi: add optimal transfer length to block limits VPD

2016-07-14 Thread Tom Yan
Well it's mainly to "pre-de-couple" BLK_DEF_MAX_SECTORS from ATA drives. If we left the field unset, the scsi disk driver will fall back to BLK_DEF_MAX_SECTORS when setting the block limit "max_sectors" (while its cap "max_hw_sectors" is set by libata depending on whether the drive supports LBA48 o

Re: [PATCH] usb: MAINTAINERS: Oliver Neukum is the new uas maintainer

2016-07-14 Thread Gerd Hoffmann
On Do, 2016-07-14 at 14:26 +0200, Hans de Goede wrote: > Oliver Neukum is taking over uas maintainership from me and > Gerd Hoffmann. > > Cc: Oliver Neukum > Cc: Gerd Hoffmann > Signed-off-by: Hans de Goede Acked-by: Gerd Hoffmann -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH] qla2xxx: setup data needed in ISR before setting up the ISR

2016-07-14 Thread Himanshu Madhani
On 7/13/16, 9:28 PM, "Martin K. Petersen" wrote: >> "Johannes" == Johannes Thumshirn writes: > >Johannes> qla2xxx first calls request_irq() and then does the setup of >Johannes> the queue entry data needed in the interrupt handlers in when >Johannes> using MSI-X. This could lead to a NULL

Re: [PATCH] usb: MAINTAINERS: Oliver Neukum is the new uas maintainer

2016-07-14 Thread Oliver Neukum
On Thu, 2016-07-14 at 14:26 +0200, Hans de Goede wrote: > Oliver Neukum is taking over uas maintainership from me and > Gerd Hoffmann. > > Cc: Oliver Neukum > Cc: Gerd Hoffmann > Signed-off-by: Hans de Goede Acked-by: Oliver Neukum -- To unsubscribe from this list: send the line "unsubscribe

[PATCH] usb: MAINTAINERS: Oliver Neukum is the new uas maintainer

2016-07-14 Thread Hans de Goede
Oliver Neukum is taking over uas maintainership from me and Gerd Hoffmann. Cc: Oliver Neukum Cc: Gerd Hoffmann Signed-off-by: Hans de Goede --- MAINTAINERS | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 5c728d1..9c220f0 100644 --- a/MAINTA

RE: [PATCH] mpt3sas: Fix panic when aer correct error occured

2016-07-14 Thread Chaitra Basappa
Hi, Please consider this patch as Acked-by: Chaitra P B Thanks, Chaitra -Original Message- From: Kefeng Wang [mailto:wangkefeng.w...@huawei.com] Sent: Tuesday, July 12, 2016 3:13 PM To: martin.peter...@oracle.com; suganath-prabu.subram...@broadcom.com; mpt-fusionlinux@broadcom.com

Re: [PATCH] iscsi-target: fix panic when add the second TCP connection to iSCSI session

2016-07-14 Thread Sumit Rai
Thanks for the patch Feng, I have tested this patch and below panic has also disappeared. (initially reported at http://article.gmane.org/gmane.linux.scsi.target.devel/12735). dmesg = [ 862.784477] BUG: unable to handle kernel NULL pointer dereference at 01f8 [ 862.784486] IP:

Re: [PATCH 1/1] scsi: ufs: tc-dwc-g210 driver fix for 20-bit RMMI

2016-07-14 Thread Joao Pinto
On 7/14/2016 10:17 AM, Joao Pinto wrote: > On 7/12/2016 2:55 PM, Manjunath M B wrote: >> The code was checking on PA_CONNECTEDRXLANES and >> PA_CONNECTEDTXLANES attributes to program the Lane#1 >> attributes. The correct attributes are PA_AVAILRXDATALANES and >> PA_AVAILTXDATALANES respectively. >>

Re: [PATCH 1/1] scsi: ufs: tc-dwc-g210 driver fix for 20-bit RMMI

2016-07-14 Thread Joao Pinto
On 7/12/2016 2:55 PM, Manjunath M B wrote: > The code was checking on PA_CONNECTEDRXLANES and > PA_CONNECTEDTXLANES attributes to program the Lane#1 > attributes. The correct attributes are PA_AVAILRXDATALANES and > PA_AVAILTXDATALANES respectively. > > Signed-off-by: Manjunath M B > --- > drive