[PATCH v1] ufs: introduce setup_hibern8 callback

Some UFS host controller may need to configure some things around hibern8 enter/exit Signed-off-by: Kiwoong Kim --- drivers/scsi/ufs/ufshcd.c | 10 -- drivers/scsi/ufs/ufshcd.h | 10 ++ 2 files changed, 18 insertions(+), 2 deletions(-) diff --git

[PATCH v1] ufs: introduce setup_task_mgmt

Some UFS host controller may need to configure some things before any task management request is issued Signed-off-by: Kiwoong Kim --- drivers/scsi/ufs/ufshcd.c | 1 + drivers/scsi/ufs/ufshcd.h | 10 ++ 2 files changed, 11 insertions(+) diff --git

[PATCH v1] ufs: introduce UFSHCD_QUIRK_USE_OF_HCE quirk

Some host controller might not initialize itself by setting "Host Controller Enable" to 1. They should do this to reset UIC. In such cases, 'DME reset' and 'DME enable' are required for normal subsequent operations. Signed-off-by: Kiwoong Kim --- drivers/scsi/ufs/ufshcd.c

[PATCH v1] ufs: introduce UFSHCD_QUIRK_BROKEN_REQ_LIST_CLR quirk

Some UFS host controllers may clear a transfer request slot by setting an associated bit in UTLRCLR/UTMLRCLR to 1, not 0. That's opposite to what UFS spec decribes. Signed-off-by: Kiwoong Kim --- drivers/scsi/ufs/ufshcd.c | 32

[PATCH v1] ufs: introduce UFSHCD_QUIRK_BROKEN_DWORD_UTRD quirk

Some UFS host controllers may think granularitys of PRDT length and offset as bytes, not double words. Signed-off-by: Kiwoong Kim --- drivers/scsi/ufs/ufshcd.c | 24 +++- drivers/scsi/ufs/ufshcd.h | 2 ++ 2 files changed, 21 insertions(+), 5

[PATCH v1] ufs: introcude UFSHCD_QUIRK_GET_VS_RESULT quirk

Some UFS host controllers may not report a result of UIC command completion properly. In such cases, they should get the result from UIC directly if their architectures support that. Signed-off-by: Kiwoong Kim --- drivers/scsi/ufs/ufshcd.c | 27 +++

[PATCH v1] ufs: introduce setup_xfer_req callback

Some UFS host controller may need to configure some things before any transfer request is issued. Signed-off-by: Kiwoong Kim --- drivers/scsi/ufs/ufshcd.c | 2 ++ drivers/scsi/ufs/ufshcd.h | 10 ++ 2 files changed, 12 insertions(+) diff --git

Re: [PREEMPT-RT] [REPOST PATCH 1/5] scsi: bnx2i: convert to kworker

On Mon, Nov 07, 2016 at 08:10:25PM +0100, Christoph Hellwig wrote: > On Mon, Nov 07, 2016 at 06:04:21PM +0100, Sebastian Andrzej Siewior wrote: > > So we keep things as they are right now or are we getting also rid of > > the internal list? This was tested by Johannes and Chad (claimed to do > >

[PATCH] hpsa: switch to pci_alloc_irq_vectors

Use pci_alloc_irq_vectors and drop the hand-crafted interrupt affinity routines. Signed-off-by: Hannes Reinecke Cc: Don Brace --- drivers/scsi/hpsa.c | 72 +++-- drivers/scsi/hpsa.h | 1 - 2 files changed,

[PATCH] aacraid: switch to pci_alloc_irq_vectors

Use pci_alloc_irq_vectors and drop the hand-crafted interrupt affinity routines. Signed-off-by: Hannes Reinecke Cc: Adaptec OEM Raid Solutions --- drivers/scsi/aacraid/aacraid.h | 1 - drivers/scsi/aacraid/comminit.c | 10 +++---

Re: [PATCH] Avoid that SCSI device removal through sysfs triggers a deadlock

On Mon, Nov 07, 2016 at 04:32:18PM -0800, Bart Van Assche wrote: > The SCSI core holds scan_mutex around SCSI device addition and > removal operations. sysfs serializes attribute read and write > operations against attribute removal through s_active. Avoid that > grabbing scan_mutex during

[PATCH v2 5/6] qedi: Add support for iSCSI session management.

This patch adds support for iscsi_transport LLD Login, Logout, NOP-IN/NOP-OUT, Async, Reject PDU processing and Firmware async event handling support. Signed-off-by: Nilesh Javali Signed-off-by: Adheer Chandravanshi Signed-off-by: Chad

[PATCH v2 6/6] qedi: Add support for data path.

This patch adds support for data path and TMF handling. Signed-off-by: Nilesh Javali Signed-off-by: Adheer Chandravanshi Signed-off-by: Chad Dupuis Signed-off-by: Saurav Kashyap

[PATCH] Avoid that SCSI device removal through sysfs triggers a deadlock

The SCSI core holds scan_mutex around SCSI device addition and removal operations. sysfs serializes attribute read and write operations against attribute removal through s_active. Avoid that grabbing scan_mutex during self-removal of a SCSI device triggers a deadlock by not calling

Re: [PATCH v7 09/11] scsi: ufs: connect to RPMB subsystem

On Mon, Nov 07, 2016 at 07:27:38PM +, Winkler, Tomas wrote: > I value your opinion but I'm not responsible for inventing RPMB > and/or its implementation storage devices (eMMC, UFC, NVMe), it's pretty > much done deal out there in the wild. > I'm just trying to provide common API above

Re: [PATCH] Avoid that SCSI device removal through sysfs triggers a deadlock

On Fri, 2016-11-04 at 12:17 -0600, Bart Van Assche wrote: > On 11/04/2016 07:47 AM, James Bottomley wrote: > > You know after > > > > if (device_remove_file_self(dev, attr)) > > > > returns true that s_active is held and also that KERNFS_SUICIDAL is > > set on the node, so the non-self remove

Re: [PREEMPT-RT] [REPOST PATCH 1/5] scsi: bnx2i: convert to kworker

On Mon, Nov 07, 2016 at 06:04:21PM +0100, Sebastian Andrzej Siewior wrote: > So we keep things as they are right now or are we getting also rid of > the internal list? This was tested by Johannes and Chad (claimed to do > testing) IFF the patches actually are tested as-is let's get them in. I

[PATCH v7 05/11] char: rpmb: provide a user space interface

The user space API is achieved via two synchronous IOCTLs. Simplified one, RPMB_IOC_REQ_CMD, were read result cycles is performed by the framework on behalf the user and second, RPMB_IOC_SEQ_CMD where the whole RPMB sequence including RESULT_READ is supplied by the caller. The latter is intended

Re: [PATCH 1/1] iscsi: fix regression caused by session lock patch

On 11/07/2016 04:15 PM, Chris Leech wrote: > Hi, > > I'm kicking this old thread because I don't think this ever got > resolved. I wish I had more info, but it seems to involve target > specific behavior that hasn't come up in our test labs. Thanks very much for reopening this thread! We have

iscsi: make mutex for target scanning and unbinding per-session

Currently the iSCSI transport class synchronises target scanning and unbinding with a host level mutex. For multi-session hosts (offloading iSCSI HBAs) connecting to storage arrays that may implement one target-per-lun, this can result in the target scan work for hundreds of sessions being

Re: [PATCH 1/1] iscsi: fix regression caused by session lock patch

Hi, I'm kicking this old thread because I don't think this ever got resolved. I wish I had more info, but it seems to involve target specific behavior that hasn't come up in our test labs. So what can I do at this point to help resolve this? On Sun, Nov 15, 2015 at 12:10:48PM +0200, Or Gerlitz

Re: CISS driver error introduced with kernel-4.9.0-0.rc2.git1.1.fc26

On 11/07/2016 04:44 AM, Johnny Bieren wrote: Hello, It appears that a check_unmap kernel failure for the CISS driver was introduced with kernel-4.9.0-0.rc2.git1.1.fc26. When booting this kernel, or any newer kernel, I see the following: [3.676658] HP CISS Driver (v 3.6.26) 0m] Reached

Re: [PREEMPT-RT] [REPOST PATCH 1/5] scsi: bnx2i: convert to kworker

On 2016-11-07 17:48:46 [+0100], Christoph Hellwig wrote: > On Mon, Nov 07, 2016 at 05:46:29PM +0100, Sebastian Andrzej Siewior wrote: > > sorry for the confusion in the subject. If I remember correctly you said > > that we may not have enough room for a larger / work_struct struct and I > > should

Re: [PREEMPT-RT] [REPOST PATCH 1/5] scsi: bnx2i: convert to kworker

On Mon, Nov 07, 2016 at 05:46:29PM +0100, Sebastian Andrzej Siewior wrote: > sorry for the confusion in the subject. If I remember correctly you said > that we may not have enough room for a larger / work_struct struct and I > should keep the list for now. But that was for libfc where it only has

Re: [PREEMPT-RT] [REPOST PATCH 1/5] scsi: bnx2i: convert to kworker

On 2016-11-07 17:38:48 [+0100], Christoph Hellwig wrote: > You're right it does - between the incorrect subject and the fact > that it still keeps the linked list of items arounds instead of fully > using the workqueue infrastructure I was a bit confused before my > first coffee this morning.

Re: [PATCH 3/4] qla2xxx: Add Block Multi Queue functionality.

On Fri, 2016-11-04 at 09:33 -0700, himanshu.madh...@cavium.com wrote: > From: Michael Hernandez > > Tell the SCSI layer how many hardware queues we have based on the > number of max queue pairs created. The number of max queue pairs > created will depend on number

[PATCH] scsi: fix spelling mistake in error message

From: Colin Ian King Trivial fix to spelling mistake "operatio" to "operation" in critical error message Signed-off-by: Colin Ian King --- drivers/scsi/dpt_i2o.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PREEMPT-RT] [REPOST PATCH 1/5] scsi: bnx2i: convert to kworker

On Mon, Nov 07, 2016 at 05:31:03PM +0100, Thomas Gleixner wrote: > On Mon, 7 Nov 2016, Christoph Hellwig wrote: > > > It seems like the whole damn driver should just use threaded interrupts. > > Of course it's a giant beast and not just the iSCSI one. But even > > if we don't go all the way I'd

[PATCH] target: fix spelling mistake and unwrap multi-line text

From: Colin Ian King Trivial fix to spelling mistake "Obselete" to "Obsolete" in error message and also turn multi-line text into one line. Signed-off-by: Colin Ian King --- drivers/target/target_core_pr.c | 3 +-- 1 file changed, 1

Re: [PATCH 2/4] qla2xxx: Fix mailbox command timeout due to starvation

On Fri, 2016-11-04 at 09:33 -0700, himanshu.madh...@cavium.com wrote: ... > @@ -2349,6 +2349,17 @@ uint32_t qla2x00_isp_reg_stat(struct qla_hw_data *ha) > return atomic_read(>loop_state) == LOOP_READY; > } > > +static void qla2x00_destroy_mbx_wq(struct qla_hw_data *ha) > +{ > + struct

[Bug 187231] kernel panic during hpsa MSI plus tg3 MSI

https://bugzilla.kernel.org/show_bug.cgi?id=187231 --- Comment #2 from Patrick Schaaf --- Thanks Don for the reaction! Right now, on the box that had that panic and the worst resetting/reset issues (see the other bug I linked), I'm back to 3.14.79, and want to stay there for

[Bug 187231] kernel panic during hpsa MSI plus tg3 MSI

https://bugzilla.kernel.org/show_bug.cgi?id=187231 Don changed: What|Removed |Added CC||don.br...@microsemi.com

[Bug 187231] New: kernel panic during hpsa MSI plus tg3 MSI

https://bugzilla.kernel.org/show_bug.cgi?id=187231 Bug ID: 187231 Summary: kernel panic during hpsa MSI plus tg3 MSI Product: IO/Storage Version: 2.5 Kernel Version: 4.8.6 Hardware: All OS: Linux Tree:

[Bug 187221] New: HPSA resetting logical / reset logical

https://bugzilla.kernel.org/show_bug.cgi?id=187221 Bug ID: 187221 Summary: HPSA resetting logical / reset logical Product: IO/Storage Version: 2.5 Kernel Version: 4.4.x, 4.8.x Hardware: Intel OS: Linux Tree:

CISS driver error introduced with kernel-4.9.0-0.rc2.git1.1.fc26

Hello, It appears that a check_unmap kernel failure for the CISS driver was introduced with kernel-4.9.0-0.rc2.git1.1.fc26. When booting this kernel, or any newer kernel, I see the following: [3.676658] HP CISS Driver (v 3.6.26) 0m] Reached target System Initialization.

[PATCH 07/11] hisi_sas: delete repeated configuration in free_device_v2_hw()

From: Xiang Chen Delete repeated configuration items for hisi_sas_device() when we free a device. These items are now only set in hisi_sas_dev_gone(). Signed-off-by: Xiang Chen Signed-off-by: John Garry ---

[PATCH 01/11] hisi_sas: add v2 hw support for ECC and AXI bus fatal error

From: Xiang Chen For ECC 1bit error, logic can recover it, so we only print a warning. For ECC multi-bit and AXI bus fatal error, we panic. Signed-off-by: Xiang Chen Signed-off-by: John Garry ---

[PATCH 08/11] hisi_sas: modify some values in get_ata_protocol()

From: Xiang Chen Modify and add some SATA commands according to SATA protocol. Signed-off-by: Xiang Chen Signed-off-by: John Garry --- drivers/scsi/hisi_sas/hisi_sas_v2_hw.c | 14 -- 1 file changed, 12

[PATCH 10/11] hisi_sas: use atomic64_t for hisi_sas_device.running_req

Sometimes the value of hisi_sas_device.running_req would go negative unless we have the check for running_req >= 0 before trying to decrement. This is because using running_req is not thread-safe. As such, the value for running_req may be actually incorrect, so use atomic64_t instead.

[PATCH 04/11] hisi_sas: fix port form bug in hisi_sas_port_notify_formed()

From: Xiang Chen When we form a wideport, we should use hardware PHY port_id instead of sas_phy->id. Signed-off-by: Xiang Chen Signed-off-by: John Garry --- drivers/scsi/hisi_sas/hisi_sas_main.c | 2 +- 1 file

[PATCH 03/11] hisi_sas: only process broadcast change in phy_bcast_v2_hw()

From: Xiang Chen There are many BROADCAST primitives generated by the host. We are only interested in BROADCAST (CHANGE) primitives currently, so only process this. Signed-off-by: Xiang Chen Signed-off-by: John Garry

[PATCH 00/11] hisi_sas: some fixes, improvements, and new features

This patchset introduces some misc bug fixes, improvements, and new features to the HiSilicon SAS driver. The new features include: - ECC and AXI bus fatal error handling for v2 hw - PHY (min and max) linkrate setting John Garry (1): hisi_sas: use atomic64_t for hisi_sas_device.running_req

[PATCH 06/11] hisi_sas: modify return value of hisi_sas_query_task()

From: Xiang Chen sas_scsi_find_task() only deals with return value TMF_RESP_FUNC_FAILED/TMF_RESP_FUNC_SUCC/TMF_RESP_FUNC_COMPLETE of query task. So for LLDD errors just return TMF_RESP_FUNC_FAILED. Signed-off-by: Xiang Chen Signed-off-by:

[PATCH 09/11] hisi_sas: check SATA FIS when directly attaching SATA device

From: Xiang Chen Check ERR bit of status to decide whether there is something wrong with initial register-D2H FIS. If error exists, PHY reset the channel to restart OOB. Signed-off-by: Xiang Chen Signed-off-by: John Garry

[PATCH 11/11] hisi_sas: add PHY set linkrate support for v1 and v2 hw

From: Xiang Chen Add the function to set PHY min and max linkrate through sysfs interface. Signed-off-by: Xiang Chen Signed-off-by: John Garry --- drivers/scsi/hisi_sas/hisi_sas.h | 3 +++

[PATCH 05/11] hisi_sas: replace WARN_ON() with dev_warn() for internal abort

From: Xiang Chen Replace WARN_ON() with dev_warn() print when internal abort fails. Signed-off-by: Xiang Chen Signed-off-by: John Garry --- drivers/scsi/hisi_sas/hisi_sas_main.c | 3 ++- 1 file changed, 2

[PATCH 02/11] hisi_sas: alloc queue id of slot according to device id

From: Xiang Chen Currently slots are allocated from queues in a round-robin fashion. This causes a problem for internal commands in device mode. For this mode, we should ensure that the internal abort command is the last command seen in the host for that device. We can