[Bug 151631] "Synchronizing SCSI cache" fails during(and delays) reboot/shutdown

2016-11-09 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=151631 Daniele Viganò changed: What|Removed |Added CC|

Re: [PATCH] hpsa: use pci_alloc_irq_vectors and automatic irq affinity

2016-11-09 Thread Hannes Reinecke
On 11/09/2016 07:42 PM, Christoph Hellwig wrote: > This patch converts over hpsa to use the pci_alloc_irq_vectors including > the PCI_IRQ_AFFINITY flag that automatically assigns spread out > irq affinity to the I/O queues. > > It also cleans up the per-ctrl interrupt state due to the use of the

RE: [PATCH v1] ufs: add a variety of definitions decribed in UFS spec

2016-11-09 Thread Kiwoong Kim
Hi, Subhash I'll update this patch referring what you said below except for creating of "mphy.h". > >> > These things are defined to be used by some UFS Host controllers. > >> > > >> > Signed-off-by: Kiwoong Kim > >> > --- > >> > drivers/scsi/ufs/mphy.h | 38

RE: [PATCH v1] ufs: introduce UFSHCI_QUIRK_SKIP_INTR_AGGR quirk

2016-11-09 Thread Kiwoong Kim
Hi, Subhash I'll update this patch referring what you said (including adding comments of other quirks) > > If UFS driver resets interrupt aggregation timer and counter when > > there is a pending doorbell, an interrupt of IO completion of a > > corresponding task may be missed. > > That would

RE: [PATCH v1] ufs: introduce UFSHCD_QUIRK_BROKEN_REQ_LIST_CLR quirk

2016-11-09 Thread Kiwoong Kim
> > Some UFS host controllers may clear a transfer request slot by setting > > an associated bit in UTLRCLR/UTMLRCLR to 1, not 0. > > s/UTLRCLR/UTRLCLR > s/UTMLRCLR/UTMRLCLR > Okay > > > That's opposite to what UFS spec decribes. > > > > Signed-off-by: Kiwoong Kim > >

[Bug 187381] 4.9.-rc4 produces hundreds of unusable scsi devices.

2016-11-09 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=187381 --- Comment #3 from Samuel Flory Silbory --- Seems sane now. root@pcsnode:~# uname -a Linux pcsnode 4.9.0-rc4-1-default #1 SMP Wed Nov 9 13:59:28 PST 2016 x86_64 GNU/Linux root@pcsnode:~# ls /dev/sd* /dev/sda /dev/sdc

RE: [Bug 187381] New: 4.9.-rc4 produces hundreds of unusable scsi devices.

2016-11-09 Thread Samuel Silbory
Seems sane now. root@pcsnode:~# uname -a Linux pcsnode 4.9.0-rc4-1-default #1 SMP Wed Nov 9 13:59:28 PST 2016 x86_64 GNU/Linux root@pcsnode:~# ls /dev/sd* /dev/sda /dev/sdc /dev/sde /dev/sdg /dev/sdi /dev/sdk /dev/sdk2 /dev/sdk4 /dev/sdk6 /dev/sdl /dev/sdb /dev/sdd /dev/sdf /dev/sdh

[Bug 187381] 4.9.-rc4 produces hundreds of unusable scsi devices.

2016-11-09 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=187381 --- Comment #2 from Samuel Flory Silbory --- Certainly I'll give it a try. From: James Bottomley [james.bottom...@hansenpartnership.com] Sent: Wednesday, November 09, 2016 12:49 PM

RE: [Bug 187381] New: 4.9.-rc4 produces hundreds of unusable scsi devices.

2016-11-09 Thread Samuel Silbory
Certainly I'll give it a try. From: James Bottomley [james.bottom...@hansenpartnership.com] Sent: Wednesday, November 09, 2016 12:49 PM To: bugzilla-dae...@bugzilla.kernel.org; linux-scsi@vger.kernel.org Cc: Samuel Silbory Subject: Re: [Bug 187381] New:

Re: [PATCH] hpsa: switch to pci_alloc_irq_vectors

2016-11-09 Thread Christoph Hellwig
On Tue, Nov 08, 2016 at 04:02:54PM +0100, Hannes Reinecke wrote: >> I've looked at the them but haven't started work, so feel free to go >> ahead. The MSI-X handling in mpt3sas is pretty nasty, so be careful. >> >> I've also started playing with lpfc, something I'll need to send to >> you and

RE: [PATCH] hpsa: use pci_alloc_irq_vectors and automatic irq affinity

2016-11-09 Thread Don Brace
> -Original Message- > From: Christoph Hellwig [mailto:h...@lst.de] > Sent: Wednesday, November 09, 2016 12:42 PM > To: Don Brace > Cc: h...@suse.de; linux-scsi@vger.kernel.org > Subject: [PATCH] hpsa: use pci_alloc_irq_vectors and automatic irq affinity > > EXTERNAL EMAIL > > > This

RE: [PATCH] hpsa: switch to pci_alloc_irq_vectors

2016-11-09 Thread Don Brace
> -Original Message- > From: Hannes Reinecke [mailto:h...@suse.de] > Sent: Wednesday, November 09, 2016 9:45 AM > To: Christoph Hellwig; Don Brace > Cc: Martin K. Petersen; James Bottomley; linux-scsi@vger.kernel.org; Hannes > Reinecke > Subject: Re: [PATCH] hpsa: switch to

Re: [Bug 187381] New: 4.9.-rc4 produces hundreds of unusable scsi devices.

2016-11-09 Thread James Bottomley
On Wed, 2016-11-09 at 20:20 +, bugzilla-dae...@bugzilla.kernel.org wrote: > https://bugzilla.kernel.org/show_bug.cgi?id=187381 > > Bug ID: 187381 >Summary: 4.9.-rc4 produces hundreds of unusable scsi > devices. >Product: SCSI Drivers >Version:

Re: [RFC PATCH] scsi: libsas: fix WARN on device removal

2016-11-09 Thread Dan Williams
On Wed, Nov 9, 2016 at 11:09 AM, Dan Williams wrote: > On Wed, Nov 9, 2016 at 9:36 AM, John Garry wrote: >> On 09/11/2016 12:28, John Garry wrote: >>> >>> On 03/11/2016 14:58, John Garry wrote: The following patch introduces an annoying

[Bug 187381] 4.9.-rc4 produces hundreds of unusable scsi devices.

2016-11-09 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=187381 --- Comment #1 from Samuel Flory Silbory --- Created attachment 244101 --> https://bugzilla.kernel.org/attachment.cgi?id=244101=edit Storcli output from system. Note that this occurs with really old firmware and the

[Bug 187381] New: 4.9.-rc4 produces hundreds of unusable scsi devices.

2016-11-09 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=187381 Bug ID: 187381 Summary: 4.9.-rc4 produces hundreds of unusable scsi devices. Product: SCSI Drivers Version: 2.5 Kernel Version: 4.9-rc4 Hardware: All OS: Linux

[Bug 66611] Very Slow I/O performance on SAS1064

2016-11-09 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=66611 Szőgyényi Gábor changed: What|Removed |Added CC|

Re: [RFC PATCH] scsi: libsas: fix WARN on device removal

2016-11-09 Thread Dan Williams
On Wed, Nov 9, 2016 at 9:36 AM, John Garry wrote: > On 09/11/2016 12:28, John Garry wrote: >> >> On 03/11/2016 14:58, John Garry wrote: >>> >>> The following patch introduces an annoying WARN >>> when a device is removed from the SAS topology: >>> [SCSI] libsas: prevent

Re: [PATCH v1] ufs: introcude UFSHCD_QUIRK_GET_VS_RESULT quirk

2016-11-09 Thread Subhash Jadavani
On 2016-11-08 22:46, Kiwoong Kim wrote: > Some UFS host controllers may not report a result of UIC command > completion properly. > In such cases, they should get the result from UIC directly if their > architectures support that. > > Signed-off-by: Kiwoong Kim > --- >

Re: [PATCH v1] ufs: introduce UFSHCI_QUIRK_SKIP_INTR_AGGR quirk

2016-11-09 Thread Subhash Jadavani
On 2016-11-08 21:43, Kiwoong Kim wrote: > If UFS driver resets interrupt aggregation timer and counter > when there is a pending doorbell, an interrupt of IO completion > of a corresponding task may be missed. > That would cause a command timeout. > > If UFS driver resets interrupt aggregation

Re: [PATCH v1] ufs: add a variety of definitions decribed in UFS spec

2016-11-09 Thread Subhash Jadavani
On 2016-11-08 21:40, Kiwoong Kim wrote: > These things are defined to be used by some UFS Host controllers. > > Signed-off-by: Kiwoong Kim > --- > drivers/scsi/ufs/mphy.h | 38 ++ > drivers/scsi/ufs/ufshci.h | 14 +++--- >

[PATCH] hpsa: use pci_alloc_irq_vectors and automatic irq affinity

2016-11-09 Thread Christoph Hellwig
This patch converts over hpsa to use the pci_alloc_irq_vectors including the PCI_IRQ_AFFINITY flag that automatically assigns spread out irq affinity to the I/O queues. It also cleans up the per-ctrl interrupt state due to the use of the pci_irq_vector and pci_free_irq_vectors helpers that don't

Re: [PATCH] ata: xgene: Enable NCQ support for APM X-Gene SATA controller hardware v1.1

2016-11-09 Thread Tejun Heo
Hello, On Wed, Sep 14, 2016 at 04:15:00PM +0530, Rameshwar Sahu wrote: > > @@ -821,8 +823,6 @@ static int xgene_ahci_probe(struct platform_device > > *pdev) > > dev_warn(>dev, "%s: Error reading > > device info. Assume version1\n", > >

Re: [PATCH] megaraid_sas: fix macro MEGASAS_IS_LOGICAL to avoid regression caused by commit 1e793f6fc0db920400574211c48f9157a37e3945

2016-11-09 Thread Martin K. Petersen
> "Sumit" == Sumit Saxena writes: Sumit> This patch will fix regression caused by below commit- 1e793f6 Sumit> scsi: megaraid_sas: Fix data integrity failure for JBOD Sumit> (passthrough) devices Sumit> The problem was MEGASAS_IS_LOGICAL macro does not have braces

Re: [PATCH] megaraid_sas: fix macro MEGASAS_IS_LOGICAL to avoid regression caused by commit 1e793f6fc0db920400574211c48f9157a37e3945

2016-11-09 Thread Jens Axboe
On 11/09/2016 03:59 AM, Sumit Saxena wrote: This patch will fix regression caused by below commit- 1e793f6 scsi: megaraid_sas: Fix data integrity failure for JBOD (passthrough) devices The problem was MEGASAS_IS_LOGICAL macro does not have braces and because of above commit using this macro

Re: [PATCH] megaraid_sas: fix macro MEGASAS_IS_LOGICAL to avoid regression caused by commit 1e793f6fc0db920400574211c48f9157a37e3945

2016-11-09 Thread Tomas Henzl
On 9.11.2016 11:59, Sumit Saxena wrote: > This patch will fix regression caused by below commit- > 1e793f6 scsi: megaraid_sas: Fix data integrity failure for JBOD (passthrough) > devices > > The problem was MEGASAS_IS_LOGICAL macro does not have braces and because of > above commit > using this

Re: [PATCH] hpsa: switch to pci_alloc_irq_vectors

2016-11-09 Thread Hannes Reinecke
On 11/09/2016 04:36 PM, Christoph Hellwig wrote: On Wed, Nov 09, 2016 at 03:32:48PM +, Don Brace wrote: Do we need to add an entry for map_queues? The existing driver only supports a single submission queue. If some of the devices support more than one submission queue we could enhance

Re: [PATCH] hpsa: switch to pci_alloc_irq_vectors

2016-11-09 Thread Christoph Hellwig
On Wed, Nov 09, 2016 at 03:32:48PM +, Don Brace wrote: > Do we need to add an entry for map_queues? The existing driver only supports a single submission queue. If some of the devices support more than one submission queue we could enhance the driver to support it, but we'd need docs and

RE: [PATCH] hpsa: switch to pci_alloc_irq_vectors

2016-11-09 Thread Don Brace
> -Original Message- > From: Hannes Reinecke [mailto:h...@suse.de] > Sent: Tuesday, November 08, 2016 1:12 AM > To: Martin K. Petersen > Cc: Christoph Hellwig; James Bottomley; linux-scsi@vger.kernel.org; Hannes > Reinecke; Hannes Reinecke; Don Brace > Subject: [PATCH] hpsa: switch to

Re: [RFC PATCH] scsi: libsas: fix WARN on device removal

2016-11-09 Thread John Garry
On 03/11/2016 14:58, John Garry wrote: The following patch introduces an annoying WARN when a device is removed from the SAS topology: [SCSI] libsas: prevent domain rediscovery competing with ata error handling Are there any views on this patch? I would have thought that the parties who use

Re: [PATCH] ata: xgene: Enable NCQ support for APM X-Gene SATA controller hardware v1.1

2016-11-09 Thread Rameshwar Sahu
Hi Olof/Tejun, On Thu, Oct 20, 2016 at 4:44 PM, Rameshwar Prasad Sahu wrote: > > This patch enables NCQ support for APM X-Gene SATA controller > hardware v1.1 that was broken with hardware v1.0. > > Signed-off-by: Rameshwar Prasad Sahu > --- >

[PATCH] megaraid_sas: fix macro MEGASAS_IS_LOGICAL to avoid regression caused by commit 1e793f6fc0db920400574211c48f9157a37e3945

2016-11-09 Thread Sumit Saxena
This patch will fix regression caused by below commit- 1e793f6 scsi: megaraid_sas: Fix data integrity failure for JBOD (passthrough) devices The problem was MEGASAS_IS_LOGICAL macro does not have braces and because of above commit using this macro was exposing lot of non-existing SCSI

Re: Ordering problems with 3ware controller

2016-11-09 Thread Paul Menzel
Dear Martin, On 11/09/16 00:45, Martin K. Petersen wrote: "Paul" == Paul Menzel writes: Paul> Updating from Linux 4.4.X to Linux 4.8.4, we noticed that the Paul> 3ware devices under `/dev` – `/dev/twa0`, `/dev/twa1`, … – map to Paul> the controllers differently.