[PATCH] mac_esp: fix to pass correct device identity to free_irq()

From: Wei Yongjun free_irq() expects the same device identity that was passed to corresponding request_irq(), otherwise the IRQ is not freed. Signed-off-by: Wei Yongjun Signed-off-by: Finn Thain --- Rebased on

Re: [PATCH] qla4xxx: fix spelling mistake: "Tempalate" -> "Template"

On 26/04/17 3:07 AM, "Colin King" wrote: >From: Colin Ian King > >trivial fix to spelling mistake in DEBUG2 debug message > >Signed-off-by: Colin Ian King >--- > drivers/scsi/qla4xxx/ql4_init.c | 2 +- > 1 file

[PATCH] mpt3sas_base:fix memory leak in _base_request_irq

Signed-off-by: Heloise In function _base_request_irq, variable reply_q applies for memory space 'reply_q=kzalloc()', but does not release it before the function returns, fix it. --- drivers/scsi/mpt3sas/mpt3sas_base.c | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [PATCH] scsi: stex: make S6flag static

Looks good to me. Thanks for the improvement. On 4/26/2017 1:36 AM, Colin King wrote: From: Colin Ian King This module specific flag can be made static as it does not need to be in global scope. > Reviewed-by: Charles Chiou

Re: [RFC] scsi: reduce protection of scan_mutex in scsi_remove_device

> On Apr 25, 2017, at 3:17 PM, Bart Van Assche > wrote: > > On Tue, 2017-04-25 at 21:17 +, Song Liu wrote: >> I am not sure I fully understand the problem here. If I understand the logic >> correctly, when a device is being removed, it will stay in >>

RE: [PATCH v2 1/1] aacraid: pci_alloc_consistent() failures on ARM64

> -Original Message- > From: Christoph Hellwig [mailto:h...@infradead.org] > Sent: Tuesday, April 25, 2017 12:07 AM > To: Mahesh Rajashekhara > Cc: Dave Carroll ; linux-scsi@vger.kernel.org; > j...@linux.vnet.ibm.com;

Re: [RFC] scsi: reduce protection of scan_mutex in scsi_remove_device

On Tue, 2017-04-25 at 21:17 +, Song Liu wrote: > I am not sure I fully understand the problem here. If I understand the logic > correctly, when a device is being removed, it will stay in > scsi_host->__devices > until fully the remove routine is finished. And LUN scanning in parallel will >

Re: [PATCH v5 10/10] scsi: Implement blk_mq_ops.show_rq()

On Tue, 2017-04-25 at 14:39 -0700, Omar Sandoval wrote: > On Tue, Apr 25, 2017 at 01:37:45PM -0700, Bart Van Assche wrote: > > Show the SCSI CDB, .eh_eflags and .result for pending SCSI commands > > in /sys/kernel/debug/block/*/mq/*/dispatch and */rq_list. > > Only thing I noticed was that the

Re: [PATCH v5 10/10] scsi: Implement blk_mq_ops.show_rq()

On Tue, Apr 25, 2017 at 01:37:45PM -0700, Bart Van Assche wrote: > Show the SCSI CDB, .eh_eflags and .result for pending SCSI commands > in /sys/kernel/debug/block/*/mq/*/dispatch and */rq_list. Only thing I noticed was that the only other caller I see has buf[70]. No idea if that's a meaningful

[PATCH] qla4xxx: fix spelling mistake: "Tempalate" -> "Template"

From: Colin Ian King trivial fix to spelling mistake in DEBUG2 debug message Signed-off-by: Colin Ian King --- drivers/scsi/qla4xxx/ql4_init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [RFC] scsi: reduce protection of scan_mutex in scsi_remove_device

> On Apr 25, 2017, at 1:59 PM, Bart Van Assche > wrote: > > On Fri, 2017-04-21 at 22:31 +, Song Liu wrote: >> On Apr 21, 2017, at 2:20 PM, Bart Van Assche >> wrote: >>> On Fri, 2017-04-21 at 14:13 -0700, Song Liu wrote: On the

Re: [RFC 0/8] Copy Offload with Peer-to-Peer PCI Memory

>> Yes, that's why I used 'significant'. One good thing is that given resources >> it can easily be done in parallel with other development, and will give >> additional >> insight of some form. > >Yup, well if someone wants to start working on an emulated RDMA device >that actually simulates

Re: [RFC 0/8] Copy Offload with Peer-to-Peer PCI Memory

> My first reflex when reading this thread was to think that this whole domain > lends it self excellently to testing via Qemu. Could it be that doing this in > the opposite direction might be a safer approach in the long run even though > (significant) more work up-front? While the idea of

Re: [RFC] scsi: reduce protection of scan_mutex in scsi_remove_device

> On Apr 25, 2017, at 10:52 AM, Bart Van Assche > wrote: > > On Tue, 2017-04-25 at 17:42 +, Song Liu wrote: >> I have been studying the code recently. I am wondering whether the following >> would work: >> >> 1. Introduce a new mutex for scsi_device to protect

Re: [RFC] scsi: reduce protection of scan_mutex in scsi_remove_device

On Fri, 2017-04-21 at 22:31 +, Song Liu wrote: > On Apr 21, 2017, at 2:20 PM, Bart Van Assche > wrote: > > On Fri, 2017-04-21 at 14:13 -0700, Song Liu wrote: > > > On the other hand, some devices do long latency IO during deletion, > > > for example, sd_shutdown()

[PATCH v5 1/4] Introduce scsi_start_queue()

This patch does not change any functionality. Signed-off-by: Bart Van Assche Cc: Israel Rukshin Cc: Max Gurtovoy Cc: Hannes Reinecke Cc: Song Liu --- drivers/scsi/scsi_lib.c | 25

Re: [PATCH] nvme-scsi: Use correct byte ordering for eui64 in Dev ID VPD

On 04/25/2017 02:18 PM, Jon Derrick wrote: > NVME specifies an EUI64/NGUID in little-endian format, while SCSI > specifies that the Device Identification VPD use big-endian for EUI > formats. The current code copies this bytestream directly from the > Identification Namespace page, meaning we just

[PATCH v5 4/4] Avoid that __scsi_remove_device() hangs

Since scsi_target_unblock() uses starget_for_each_device(), since starget_for_each_device() uses scsi_device_get(), since scsi_device_get() fails after unloading of the LLD kernel module has been started scsi_target_unblock() may skip devices that were affected by scsi_target_block(). Ensure that

[PATCH v5 3/4] sd: Make synchronize cache upon shutdown asynchronous

This patch avoids that sd_shutdown() hangs on the SYNCHRONIZE CACHE command if the block layer queue has been stopped by scsi_target_block(). Signed-off-by: Bart Van Assche Cc: Israel Rukshin Cc: Max Gurtovoy Cc: Hannes

[PATCH v5 2/4] Introduce scsi_execute_async()

Move the code for submitting a SCSI command from scsi_execute() into scsi_build_rq(). Introduce scsi_execute_async(). This patch does not change any functionality. Signed-off-by: Bart Van Assche Cc: Israel Rukshin Cc: Max Gurtovoy

[PATCH v5 0/4] Avoid that __scsi_remove_device() hangs

__scsi_remove_device() hangs if it is waiting for the SYNCHRONIZE CACHE command submitted by the sd driver to finish if the block layer queue is stopped and does not get restarted. This patch series avoids that that hang occurs. Changes compared to v4: - Fixed the deadlock reported by the 0-day

[PATCH v5 10/10] scsi: Implement blk_mq_ops.show_rq()

Show the SCSI CDB, .eh_eflags and .result for pending SCSI commands in /sys/kernel/debug/block/*/mq/*/dispatch and */rq_list. Signed-off-by: Bart Van Assche Cc: Martin K. Petersen Cc: James Bottomley

[PATCH 3/3] scsi: ufs: Delete an unnecessary return statement in ufshcd_exception_event_handler()

From: Markus Elfring Date: Tue, 25 Apr 2017 22:00:05 +0200 The script "checkpatch.pl" pointed information out like the following. WARNING: void function return statements are not generally useful Thus remove such a statement here. Signed-off-by: Markus Elfring

[PATCH 2/3] scsi: ufs: Delete an error message for a failed memory allocation in ufshcd_memory_alloc()

From: Markus Elfring Date: Tue, 25 Apr 2017 21:50:43 +0200 The script "checkpatch.pl" pointed information out like the following. WARNING: Possible unnecessary 'out of memory' message Thus remove such a statement here. Link:

Get back to me

Good day. Did you receive the business proposal I sent to you yesterday? I was waiting for your reply but I am not sure if you receive the message. If for some reason you did not receive my previous email, I can resend the message to you. Please confirm as this is very urgent and important.

[PATCH 1/3] scsi: ufs: Use devm_kcalloc() in ufshcd_memory_alloc()

From: Markus Elfring Date: Tue, 25 Apr 2017 21:45:25 +0200 * A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "devm_kcalloc". * Replace the

[PATCH 0/3] SCSI-UFSHCD: Fine-tuning for two function implementations

From: Markus Elfring Date: Tue, 25 Apr 2017 22:20:02 +0200 Three update suggestions were taken into account from static source code analysis. Markus Elfring (3): Use devm_kcalloc() in ufshcd_memory_alloc() Delete an error message for a failed memory allocation

[PATCH] nvme-scsi: Use correct byte ordering for eui64 in Dev ID VPD

NVME specifies an EUI64/NGUID in little-endian format, while SCSI specifies that the Device Identification VPD use big-endian for EUI formats. The current code copies this bytestream directly from the Identification Namespace page, meaning we just need to reverse the bytestream when passing it on

Re: [PATCH] ibmvscsis: Do not send aborted task response

On 04/10/2017 11:52 AM, Bryant G. Ly wrote: > The driver is sending a response to the aborted task response > along with LIO sending the tmr response. I think this could be better worded. Something like the driver is sending a response to the actual ***scsi op*** that was aborted by an abort

Re: [PATCH 20/37] smartpqi: add ptraid support

On Tue, 2017-04-25 at 14:47 -0500, Don Brace wrote: > +static inline bool pqi_is_external_raid_device(struct pqi_scsi_dev *device) > +{ > + return device->is_external_raid_device; > +} The name of this function is almost as long as its implementation. Please drop this function definition and

Re: [PATCH 18/37] smartpqi: cleanup messages

On Tue, 2017-04-25 at 14:47 -0500, Don Brace wrote: > case CISS_LV_ENCRYPTED_IN_NON_ENCRYPTED_CONTROLLER: > status = > - "Encrypted volume inaccessible - disabled on ctrl"; > + "Volume encrypted but encryption disabled on controller"; >

Re: [PATCH 16/37] smartpqi: minor driver cleanup

On Tue, 2017-04-25 at 14:47 -0500, Don Brace wrote: > From: Kevin Barnett > > - align with in-house driver This is not an appropriate patch description. A patch description should explain what has been changed and also what the purpose is of these changes. Thanks, Bart.

Re: [PATCH 12/37] smartpqi: change functions to inline

On Tue, 2017-04-25 at 14:47 -0500, Don Brace wrote: > From: Kevin Barnett > > Reviewed-by: Scott Benesh > Signed-off-by: Kevin Barnett > Signed-off-by: Don Brace > --- >

Re: [PATCH 08/37] smartpqi: add suspend and resume support

On Tue, 2017-04-25 at 14:46 -0500, Don Brace wrote: > +static int pqi_device_wait_for_pending_io(struct pqi_ctrl_info *ctrl_info, > +   struct pqi_scsi_dev *device) > +{ > +   while (atomic_read(>scsi_cmds_outstanding)) { > +   pqi_check_ctrl_health(ctrl_info); > +  

Re: [PATCH 07/37] smartpqi: enhance resets

On Tue, 2017-04-25 at 14:46 -0500, Don Brace wrote: > @@ -4655,23 +4860,46 @@ static int pqi_device_reset(struct pqi_ctrl_info > *ctrl_info, > static int pqi_eh_device_reset_handler(struct scsi_cmnd *scmd) > { > int rc; > + struct Scsi_Host *shost; > struct pqi_ctrl_info

Re: [PATCH 05/37] smartpqi: ensure controller is in SIS mode at init

On Tue, 2017-04-25 at 14:46 -0500, Don Brace wrote: > +bool sis_is_kernel_up(struct pqi_ctrl_info *ctrl_info) > +{ > + u32 status; > + bool kernel_up; > + > + status = readl(_info->registers->sis_firmware_status); > + > + if (status & SIS_CTRL_KERNEL_UP) > + kernel_up =

Re: [PATCH 02/37] smartpqi: cleanup interrupt management

On Tue, 2017-04-25 at 14:46 -0500, Don Brace wrote: > static int pqi_request_irqs(struct pqi_ctrl_info *ctrl_info) > { > - struct pci_dev *pdev = ctrl_info->pci_dev; > int i; > int rc; > + struct pci_dev *pdev = ctrl_info->pci_dev; Was this change necessary? If not, please

[PATCH 36/37] smartpqi: remove writeq/readq function definitions

From: Corentin Labbe Instead of rewriting write/readq, use existing functions Reviewed-by: Scott Benesh Signed-off-by: Corentin Labbe Signed-off-by: Kevin Barnett Signed-off-by: Don

[PATCH 37/37] smartpqi: bump driver version

From: Kevin Barnett Reviewed-by: Scott Benesh Reviewed-by: Gerry Morong Signed-off-by: Kevin Barnett Signed-off-by: Don Brace ---

[PATCH 31/37] smartpqi: enhance device add and remove messages

From: Kevin Barnett Improved formatting of information displayed when devices are added/removed from the system. Reviewed-by: Scott Benesh Signed-off-by: Kevin Barnett Signed-off-by: Don Brace

[PATCH 34/37] smartpqi: cleanup list initialization

From: Kevin Barnett Better initialization of linked list heads. Reviewed-by: Scott Benesh Signed-off-by: Kevin Barnett Signed-off-by: Don Brace ---

[PATCH 35/37] smartpqi: add module parameters

From: Kevin Barnett Add module parameters to disable heartbeat support and to disable shutting down the controller when a controller is taken offline. Reviewed-by: Scott Benesh Signed-off-by: Kevin Barnett

[PATCH 33/37] smartpqi: add raid level show

From: Kevin Barnett Display the RAID level via sysfs Reviewed-by: Scott Benesh Signed-off-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/smartpqi/smartpqi_init.c | 30

[PATCH 30/37] smartpqi: update timeout on admin commands

From: Kevin Barnett Increase the timeout on admin commands from 3 seconds to 60 seconds and added a check for controller crash in the loop where the driver polls for admin command completion. Reviewed-by: Scott Benesh Signed-off-by: Kevin

[PATCH 32/37] smartpqi: make raid bypass references consistent

From: Kevin Barnett - make all references to RAID bypass consistent throughout driver. Reviewed-by: Scott Benesh Signed-off-by: Kevin Barnett Signed-off-by: Don Brace ---

[PATCH 29/37] smartpqi: map more raid errors to SCSI errors

From: Kevin Barnett enhance mapping of RAID path errors to Linux SCSI host error codes. Reviewed-by: Scott Benesh Signed-off-by: Kevin Barnett Signed-off-by: Don Brace ---

[PATCH 28/37] smartpqi: cleanup controller branding

From: Kevin Barnett - Improve controller branding support. Reviewed-by: Scott Benesh Signed-off-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/smartpqi/smartpqi_init.c |

[PATCH 27/37] smartpqi: controller offline improvements

From: Kevin Barnett improve support for taking controller offline. Reviewed-by: Scott Benesh Signed-off-by: Kevin Barnett Signed-off-by: Don Brace ---

[PATCH 26/37] smartpqi: update device offline

From: Kevin Barnett - Improve handling of offline devices. Reviewed-by: Scott Benesh Signed-off-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/smartpqi/smartpqi_init.c

[PATCH 25/37] smartpqi: correct aio error path

From: Kevin Barnett set the internal flag that causes I/O to be sent down the RAID path when the AIO path is disabled Reviewed-by: Scott Benesh Signed-off-by: Kevin Barnett Signed-off-by: Don Brace

[PATCH 23/37] smartpqi: remove qdepth calculations for logical volumes

From: Kevin Barnett make the queue depth for LVs the same as the maximum I/Os supported by the controller Reviewed-by: Scott Benesh Signed-off-by: Kevin Barnett Signed-off-by: Don Brace

[PATCH 22/37] smartpqi: enhance kdump

From: Kevin Barnett constrain resource usage during kdump to avoid kdump failures Reviewed-by: Scott Benesh Signed-off-by: Kevin Barnett Signed-off-by: Don Brace ---

[PATCH 24/37] smartpqi: add lockup action

From: Kevin Barnett add support for actions to take when controller goes offline. Reviewed-by: Scott Benesh Signed-off-by: Kevin Barnett Signed-off-by: Don Brace ---

[PATCH 21/37] smartpqi: change return value for LUN reset operations

From: Kevin Barnett change return value for controller offline to be consistent with the rest of the driver. Reviewed-by: Scott Benesh Signed-off-by: Kevin Barnett Signed-off-by: Don Brace

[PATCH 20/37] smartpqi: add ptraid support

From: Kevin Barnett add support for PTRAID devices Reviewed-by: Scott Benesh Signed-off-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/smartpqi/smartpqi.h |8 +++---

[PATCH 19/37] smartpqi: update copyright

From: Kevin Barnett Reviewed-by: Scott Benesh Signed-off-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/smartpqi/smartpqi.h |2 +-

[PATCH 18/37] smartpqi: cleanup messages

From: Kevin Barnett - improve some error messages. Reviewed-by: Scott Benesh Signed-off-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/smartpqi/smartpqi_init.c | 40

[PATCH 17/37] smartpqi: add new PCI device IDs

From: Kevin Barnett Reviewed-by: Scott Benesh Signed-off-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/smartpqi/smartpqi_init.c | 134 +++-- 1

[PATCH 15/37] smartpqi: correct BMIC identify physical drive

From: Kevin Barnett correct the BMIC Identify Physical Device structure - missing 2 fields Reviewed-by: Scott Benesh Signed-off-by: Kevin Barnett Signed-off-by: Don Brace ---

[PATCH 16/37] smartpqi: minor driver cleanup

From: Kevin Barnett - align with in-house driver Reviewed-by: Scott Benesh Signed-off-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/smartpqi/smartpqi.h |2 +-

[PATCH 14/37] smartpqi: eliminate redundant error messages

From: Kevin Barnett eliminate redundant error message during initialization if the controller has crashed. Reviewed-by: Scott Benesh Signed-off-by: Kevin Barnett Signed-off-by: Don Brace

[PATCH 13/37] smartpqi: make pdev pointer names consistent

From: Kevin Barnett make all variable names for pointers to struct pci_dev consistent throughout the driver. Reviewed-by: Scott Benesh Signed-off-by: Kevin Barnett Signed-off-by: Don Brace

[PATCH 11/37] smartpqi: add pqi_wait_for_completion_io

From: Kevin Barnett Add check for controller lockup during waits for synchronous controller commands. Reviewed-by: Scott Benesh Signed-off-by: Kevin Barnett Signed-off-by: Don Brace ---

[PATCH 12/37] smartpqi: change functions to inline

From: Kevin Barnett Reviewed-by: Scott Benesh Signed-off-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/smartpqi/smartpqi_init.c |2 +- 1 file changed, 1 insertion(+), 1

[PATCH 07/37] smartpqi: enhance resets

From: Kevin Barnett - Block all I/O targeted at LUN reset device. - Wait until all I/O targeted at LUN reset device has been consumed by the controller. - Issue LUN reset request. - Wait until all outstanding I/Os and LUN reset completion have been received by the

[PATCH 08/37] smartpqi: add suspend and resume support

From: Kevin Barnett add support for ACPI S3 (suspend) and S4 (hibernate) system power states. Reviewed-by: Scott Benesh Signed-off-by: Kevin Barnett Signed-off-by: Don Brace ---

[PATCH 09/37] smartpqi: add heartbeat check

From: Kevin Barnett check for controller lockups Reviewed-by: Scott Benesh Signed-off-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/smartpqi/smartpqi.h | 60

[PATCH 10/37] smartpqi: correct bdma hw bug

From: Kevin Barnett add workaround for BDMA hardware bug that can cause hw to read up to 12 SGL elements (192 bytes) beyond the last element in the list. This fix avoids IOMMU violations Reviewed-by: Scott Benesh Signed-off-by: Kevin Barnett

[PATCH 06/37] smartpqi: add supporting events

From: Kevin Barnett Only register for controller events that driver supports cleanup event handling. Reviewed-by: Scott Benesh Signed-off-by: Kevin Barnett Signed-off-by: Don Brace ---

[PATCH 05/37] smartpqi: ensure controller is in SIS mode at init

From: Kevin Barnett put in SIS mode during initialization. support kexec/kdump Reviewed-by: Scott Benesh Signed-off-by: Kevin Barnett Signed-off-by: Don Brace ---

[PATCH 04/37] smartpqi: add in controller checkpoint for controller lockups.

From: Kevin Barnett tell smartpqi controller to generate a checkpoint for rare lockup conditions. Reviewed-by: Scott Benesh Signed-off-by: Kevin Barnett Signed-off-by: Don Brace ---

[PATCH 03/37] smartpqi: set pci completion timeout

From: Kevin Barnett add support for setting PCIe completion timeout. Reviewed-by: Scott Benesh Signed-off-by: Kevin Barnett Signed-off-by: Don Brace ---

[PATCH 01/37] smartpqi: correct remove scsi devices

From: Kevin Barnett correct a problem caused by holding a spinlock during device deletion. Reviewed-by: Scott Benesh Signed-off-by: Kevin Barnett Signed-off-by: Don Brace ---

[PATCH 02/37] smartpqi: cleanup interrupt management

From: Kevin Barnett minor cleanup of interrupt initialization and tear-down. Reviewed-by: Scott Benesh Signed-off-by: Kevin Barnett Signed-off-by: Don Brace ---

[PATCH 00/37] smartpqi updates

These patches are based on Linus's tree The changes are: - correct remove SCSI devices - Remove spin-lock - cleanup interrupt management - minor cleanup to align with in-house driver - set PCI completion timeout - add in controller checkpoint for controller lockups. - helps debug

[PATCH v2 07/21] crypto: shash, caam: Make use of the new sg_map helper function

Very straightforward conversion to the new function in the caam driver and shash library. Signed-off-by: Logan Gunthorpe Cc: Herbert Xu Cc: "David S. Miller" --- crypto/shash.c| 9 ++---

[PATCH v2 00/21] Introduce common scatterlist map function

Changes since v1: * Rebased onto next-20170424 * Removed the _offset version of these functions per Christoph's suggestion * Added an SG_MAP_MUST_NOT_FAIL flag which will BUG_ON in future cases that can't gracefully fail. This removes a bunch of the noise added in v1 to a couple of the

[PATCH v2 14/21] scsi: libfc, csiostor: Change to sg_copy_buffer in two drivers

These two drivers appear to duplicate the functionality of sg_copy_buffer. So we clean them up to use the common code. This helps us remove a couple of instances that would otherwise be slightly tricky sg_map usages. Signed-off-by: Logan Gunthorpe Cc: Johannes Thumshirn

[PATCH v2 16/21] mmc: sdhci: Make use of the new sg_map helper function

Straightforward conversion, except due to the lack of an error path we have to use SG_MAP_MUST_NOT_FAIL which may BUG_ON in certain cases in the future. Signed-off-by: Logan Gunthorpe Cc: Adrian Hunter Cc: Ulf Hansson ---

[PATCH v2 18/21] mmc: tmio: Make use of the new sg_map helper function

Straightforward conversion to sg_map helper. Seeing there is no cleare error path, SG_MAP_MUST_NOT_FAIL which may BUG_ON in certain cases in the future. Signed-off-by: Logan Gunthorpe Cc: Wolfram Sang Cc: Ulf Hansson

[PATCH v2 03/21] libiscsi: Make use of new the sg_map helper function

Convert the kmap and kmap_atomic uses to the sg_map function. We now store the flags for the kmap instead of a boolean to indicate atomicitiy. We use ISCSI_TCP_INTERNAL_ERR error type that was prepared earlier for this. Signed-off-by: Logan Gunthorpe Cc: Lee Duncan

[PATCH v2 09/21] staging: unisys: visorbus: Make use of the new sg_map helper function

Straightforward conversion to the new function. Signed-off-by: Logan Gunthorpe Acked-by: David Kershner --- drivers/staging/unisys/visorhba/visorhba_main.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git

[PATCH v2 21/21] memstick: Make use of the new sg_map helper function

Straightforward conversion, but we have to make use of SG_MAP_MUST_NOT_FAIL which may BUG_ON in certain cases in the future. Signed-off-by: Logan Gunthorpe Cc: Alex Dubov --- drivers/memstick/host/jmb38x_ms.c | 11 ++-

[PATCH v2 17/21] mmc: spi: Make use of the new sg_map helper function

We use the sg_map helper but it's slightly more complicated as we only check for the error when the mapping actually gets used. Such that if the mapping failed but wasn't needed then no error occurs. Signed-off-by: Logan Gunthorpe Cc: Ulf Hansson ---

[PATCH v2 11/21] scsi: ipr, pmcraid, isci: Make use of the new sg_map helper

Very straightforward conversion of three scsi drivers. Signed-off-by: Logan Gunthorpe Cc: Brian King Cc: Artur Paszkiewicz --- drivers/scsi/ipr.c | 27 ++- drivers/scsi/isci/request.c | 42

[PATCH v2 06/21] crypto: hifn_795x: Make use of the new sg_map helper function

Conversion of a couple kmap_atomic instances to the sg_map helper function. However, it looks like there was a bug in the original code: the source scatter lists offset (t->offset) was passed to ablkcipher_get which added it to the destination address. This doesn't make a lot of sense, but

[PATCH v2 15/21] xen-blkfront: Make use of the new sg_map helper function

Straightforward conversion to the new helper, except due to the lack of error path, we have to use SG_MAP_MUST_NOT_FAIL which may BUG_ON in certain cases in the future. Signed-off-by: Logan Gunthorpe Cc: Boris Ostrovsky Cc: Juergen Gross

[PATCH v2 12/21] scsi: hisi_sas, mvsas, gdth: Make use of the new sg_map helper function

Very straightforward conversion of three scsi drivers. Signed-off-by: Logan Gunthorpe Cc: Achim Leubner Cc: John Garry --- drivers/scsi/gdth.c| 9 +++-- drivers/scsi/hisi_sas/hisi_sas_v1_hw.c | 14

[PATCH v2 13/21] scsi: arcmsr, ips, megaraid: Make use of the new sg_map helper function

Very straightforward conversion of three scsi drivers Signed-off-by: Logan Gunthorpe Cc: Adaptec OEM Raid Solutions Cc: Kashyap Desai Cc: Sumit Saxena Cc: Shivasharan S

[PATCH v2 19/21] mmc: sdricoh_cs: Make use of the new sg_map helper function

This is a straightforward conversion to the new function. Signed-off-by: Logan Gunthorpe Cc: Sascha Sommer Cc: Ulf Hansson --- drivers/mmc/host/sdricoh_cs.c | 14 +- 1 file changed, 9 insertions(+), 5

[PATCH v2 20/21] mmc: tifm_sd: Make use of the new sg_map helper function

This conversion is a bit complicated. We modiy the read_fifo, write_fifo and copy_page functions to take a scatterlist instead of a page. Thus we can use sg_map instead of kmap_atomic. There's a bit of accounting that needed to be done for the offset for this to work. (Seeing sg_map takes care of

[PATCH v2 10/21] RDS: Make use of the new sg_map helper function

Straightforward conversion except there's no error path, so we make use of SG_MAP_MUST_NOT_FAIL which may BUG_ON in certain cases in the future. Signed-off-by: Logan Gunthorpe Cc: Santosh Shilimkar Cc: "David S. Miller"

[PATCH v2 01/21] scatterlist: Introduce sg_map helper functions

This patch introduces functions which kmap the pages inside an sgl. These functions replace a common pattern of kmap(sg_page(sg)) that is used in more than 50 places within the kernel. The motivation for this work is to eventually safely support sgls that contain io memory. In order for that to

[PATCH v2 08/21] dm-crypt: Make use of the new sg_map helper in 4 call sites

Very straightforward conversion to the new function in all four spots. Signed-off-by: Logan Gunthorpe Cc: Alasdair Kergon Cc: Mike Snitzer --- drivers/md/dm-crypt.c | 39 ++- 1 file changed, 26

[PATCH v2 05/21] drm/i915: Make use of the new sg_map helper function

This is a single straightforward conversion from kmap to sg_map. We also create the i915_gem_object_unmap function to common up the unmap code. Signed-off-by: Logan Gunthorpe Acked-by: Daniel Vetter --- drivers/gpu/drm/i915/i915_gem.c | 27

[PATCH v2 02/21] libiscsi: Add an internal error code

This is a prep patch to add a new error code to libiscsi. We want to rework some kmap calls to be able to fail. When we do, we'd like to use this error code. This patch simply introduces ISCSI_TCP_INTERNAL_ERR and prints "Internal Error." when it gets hit. Signed-off-by: Logan Gunthorpe

Re: [PATCH] lpfc: Fix memory corruption of the lpfc_ncmd->list pointers

On Tue, Apr 25, 2017 at 10:58:44AM -0700, Christoph Hellwig wrote: > On Fri, Apr 21, 2017 at 05:49:08PM -0700, jsmart2...@gmail.com wrote: > > This is a nvme-specific bug. The patch was cut against the > > linux-block tree, for-4.12/block tree. It should be pulled in through > > that tree. > > It

Re: [PATCH] lpfc: Fix memory corruption of the lpfc_ncmd->list pointers

On Fri, Apr 21, 2017 at 05:49:08PM -0700, jsmart2...@gmail.com wrote: > This is a nvme-specific bug. The patch was cut against the > linux-block tree, for-4.12/block tree. It should be pulled in through > that tree. It conflicts with your nvme changes that are in the nvme-4.12. Can you respin it?

Re: [PATCH] nvme/scsi: Consider LBA format in IO splitting calculation

Applied to nvme-4.12.

Re: [RFC] scsi: reduce protection of scan_mutex in scsi_remove_device

On Tue, 2017-04-25 at 17:42 +, Song Liu wrote: > I have been studying the code recently. I am wondering whether the following > would work: > > 1. Introduce a new mutex for scsi_device to protect most operations in the >list you gathered above; > > 2. For operations like

  1   2   >