Re: [PATCH v1] mpt3sas: Fix calltrace observed while running IO & host reset

2018-06-27 Thread Sreekanth Reddy
On Thu, Jun 28, 2018 at 3:48 AM, Bart Van Assche wrote: > On 06/24/18 23:10, Sreekanth Reddy wrote: >> >> Before calling scsi_internal_device_block_nowait() API; driver sets >> sas_device_priv_data->block flag as one. And in the scsih_qcmd() >> driver checks for this flag as shown below and return

[Bug 200317] New: Null pointer dereference error in linux/drivers/scsi/scsi_transport_fc.c

2018-06-27 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=200317 Bug ID: 200317 Summary: Null pointer dereference error in linux/drivers/scsi/scsi_transport_fc.c Product: SCSI Drivers Version: 2.5 Kernel Version: 4.17.3 Hardware: All

Re: mpt3sas regression...

2018-06-27 Thread David Miller
From: Chaitra Basappa Date: Wed, 27 Jun 2018 19:58:34 +0530 > Please let us know what is the issue faced and if its recreating then > share the driver logs with logging_level=0x3f8. The driver cannot even probe successfully to start scanning for disks because some busy bit never clears. I thi

Re: Possible race in completion with SRP after abort with latest upstream kernel 4.17.0+

2018-06-27 Thread Bart Van Assche
On 06/07/18 08:34, Laurence Oberman wrote: On Thu, 2018-06-07 at 15:21 +, Bart Van Assche wrote: On Thu, 2018-06-07 at 09:23 -0400, Laurence Oberman wrote: Have you seen this before, let me know what else you want from the dump while I look further. Hello Laurence, I haven't seen this be

Re: [PATCH v1] mpt3sas: Fix calltrace observed while running IO & host reset

2018-06-27 Thread Bart Van Assche
On 06/24/18 23:10, Sreekanth Reddy wrote: Before calling scsi_internal_device_block_nowait() API; driver sets sas_device_priv_data->block flag as one. And in the scsih_qcmd() driver checks for this flag as shown below and return the commands with host busy status. } else if (sas_target_priv_data

RE: aacraid driver, kernel 4.14 and up, ASR8xxx controller : doesn't work

2018-06-27 Thread Dave Carroll
> -Original Message- > From: Dave Carroll > Sent: Wednesday, June 27, 2018 12:46 PM > To: Emmanuel Florac ; linux-scsi@vger.kernel.org > Cc: dl-esc-Aacraid Linux Driver > Subject: RE: aacraid driver, kernel 4.14 and up, ASR8xxx controller : doesn't > work > > Hi Emmanual, > > > [ 34

RE: aacraid driver, kernel 4.14 and up, ASR8xxx controller : doesn't work

2018-06-27 Thread Dave Carroll
Hi Emmanual, > [ 346.869001] scsi host6: aacraid > [ 346.869500] scsi 6:0:2:0: Direct-Access ASR8885 raid3V1.0 > PQ: 0 > ANSI: 2 > [ 346.869692] sd 6:0:2:0: [sdb] Very big device. Trying to use READ > CAPACITY(16). > [ 346.869712] sd 6:0:2:0: [sdb] 632763166720 512-byte logic

Re: aacraid driver, kernel 4.14 and up, ASR8xxx controller : doesn't work

2018-06-27 Thread Emmanuel Florac
Le Wed, 27 Jun 2018 18:20:27 +0200 Emmanuel Florac écrivait: > As per my previous post, I've determined that the aacraid driver > doesn't work with current Adaptec RAID controllers (ASR8xxx family, > latest firmware) with kernels over 4.14. Kernel up to 4.15 works with > ASR7xxx family but kernel

aacraid driver, kernel 4.14 and up, ASR8xxx controller : doesn't work

2018-06-27 Thread Emmanuel Florac
As per my previous post, I've determined that the aacraid driver doesn't work with current Adaptec RAID controllers (ASR8xxx family, latest firmware) with kernels over 4.14. Kernel up to 4.15 works with ASR7xxx family but kernel 4.16 doesn't work either with ASR7xxx nor ASR8xxx controllers. I've

RE: mpt3sas regression...

2018-06-27 Thread Chaitra Basappa
David, Please let us know what is the issue faced and if its recreating then share the driver logs with logging_level=0x3f8. Thanks, Chaitra -Original Message- From: Chaitra Basappa [mailto:chaitra.basa...@broadcom.com] Sent: Tuesday, June 26, 2018 5:36 PM To: David Miller; linux-scsi

Re: [PATCH 2/2] qedi: Fix truncation of target name

2018-06-27 Thread Bart Van Assche
On Wed, 2018-06-27 at 05:14 -0700, Nilesh Javali wrote: > Use sprintf instead of snprintf to fix truncation of target name. > This fix is extension of patch > "scsi: qedi: Fix truncation of CHAP name and secret". > > Signed-off-by: Nilesh Javali > --- > drivers/scsi/qedi/qedi_main.c | 4 ++-- >

Re: [PATCH 1/2] qedi: Correct the size of target name

2018-06-27 Thread Bart Van Assche
On Wed, 2018-06-27 at 05:14 -0700, Nilesh Javali wrote: > There is potential buffer overflow while getting the target > name from the NVRAM. Correct the size of the buffer to avoid > overflow. > > Signed-off-by: Nilesh Javali > --- > drivers/scsi/qedi/qedi_iscsi.h | 2 +- > 1 file changed, 1 ins

[Bug 200307] Read only file system after failed suspend

2018-06-27 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=200307 --- Comment #3 from Antonín Dach (d...@protonmail.com) --- Created attachment 276921 --> https://bugzilla.kernel.org/attachment.cgi?id=276921&action=edit kernel config -- You are receiving this mail because: You are watching the assignee of th

[Bug 200307] Read only file system after failed suspend

2018-06-27 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=200307 --- Comment #2 from Antonín Dach (d...@protonmail.com) --- Created attachment 276919 --> https://bugzilla.kernel.org/attachment.cgi?id=276919&action=edit lshw -short -- You are receiving this mail because: You are watching the assignee of the

[Bug 200307] Read only file system after failed suspend

2018-06-27 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=200307 --- Comment #1 from Antonín Dach (d...@protonmail.com) --- Created attachment 276917 --> https://bugzilla.kernel.org/attachment.cgi?id=276917&action=edit inix -- You are receiving this mail because: You are watching the assignee of the bug.

[Bug 200307] New: Read only file system after failed suspend

2018-06-27 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=200307 Bug ID: 200307 Summary: Read only file system after failed suspend Product: SCSI Drivers Version: 2.5 Kernel Version: 4.17.0 MANJARO flavor ( vanilla with custom config ) Hardware: All

[PATCH 2/2] qedi: Fix truncation of target name

2018-06-27 Thread Nilesh Javali
Use sprintf instead of snprintf to fix truncation of target name. This fix is extension of patch "scsi: qedi: Fix truncation of CHAP name and secret". Signed-off-by: Nilesh Javali --- drivers/scsi/qedi/qedi_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/sc

[PATCH 0/2] Bug fixes for static checker warnings

2018-06-27 Thread Nilesh Javali
Martin, Please consider below patch set for next 'scsi-fixes' submission. Thanks, Nilesh Nilesh Javali (2): qedi: Correct the size of target name qedi: Fix truncation of target name drivers/scsi/qedi/qedi_iscsi.h | 2 +- drivers/scsi/qedi/qedi_main.c | 4 ++-- 2 files changed, 3 insertions

[PATCH 1/2] qedi: Correct the size of target name

2018-06-27 Thread Nilesh Javali
There is potential buffer overflow while getting the target name from the NVRAM. Correct the size of the buffer to avoid overflow. Signed-off-by: Nilesh Javali --- drivers/scsi/qedi/qedi_iscsi.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/qedi/qedi_iscsi.h b/

Re: [PATCH-next] scsi: libsas: dynamically allocate and free ata host

2018-06-27 Thread John Garry
On 26/06/2018 17:40, Martin K. Petersen wrote: John, Took a while for all the prerequisites to materialize. I just rebased 4.19/scsi-queue to v4.18-rc1 and applied your patch. Thanks! Is it possible to add this patch to the 4.18 fixes? I was on the fence on this but felt it was an intricat