Re: DISABLE_CLUSTERING in scsi drivers

On Thu, Nov 22, 2018 at 10:11:33AM +1300, Michael Schmitz wrote: > Christoph, > for Atari SCSI, commands can only be merged if the physical addresses > of all buffers are contiguous (limitation of the Falcon DMA engine). > Documentation/scsi/scsi_mid_low_api.tx does not spell out whether that > is

Re: DISABLE_CLUSTERING in scsi drivers

On Thu, Nov 22, 2018 at 09:02:13AM +1100, Finn Thain wrote: > > you in the To list maintain or wrote SCSI drivers that set the > > DISABLE_CLUSTERING flag, which basically disable merges of any > > bio segments. We already have the actual max_segment size limit > > to say which length a segment

Re: DISABLE_CLUSTERING in scsi drivers

On Fri, Nov 23, 2018 at 09:09:49AM +0100, Juergen Gross wrote: > On 21/11/2018 10:41, Christoph Hellwig wrote: > > Hi all, > > > > you in the To list maintain or wrote SCSI drivers that set the > > DISABLE_CLUSTERING flag, which basically disable merges of any > > bio segments. We already have

Re: [PATCH 3/3] target: replace fabric_ops.name with fabric_alias

On Fri, Nov 23, 2018 at 06:36:13PM +0100, David Disseldorp wrote: > iscsi_target_mod is the only LIO fabric where fabric_ops.name differs > from the fabric_ops.fabric_name string. > fabric_ops.name is used when matching target/$fabric ConfigFS create > paths, so rename it .fabric_alias and

Re: [PATCH 2/3] target: drop unnecessary get_fabric_name() accessor from fabric_ops

Looks good, Reviewed-by: Christoph Hellwig

Re: [PATCH 1/3] target: drop unused pi_prot_format attribute storage

On Fri, Nov 23, 2018 at 06:36:11PM +0100, David Disseldorp wrote: > On write, the pi_prot_format configfs attribute invokes the device > format_prot() callback if present. Read dumps the contents of > se_dev_attrib.pi_prot_format , which is always zero. > Make the configfs attribute write-only,

Re: [PATCH 6/8] qedi: Add packet filter in light L2 Rx path.

On 11/20/18 2:37 AM, Nilesh Javali wrote: > From: Manish Rangankar > > Add packet filter to avoid unnecessary packet processing in iscsiuio. > > Signed-off-by: Manish Rangankar > --- > drivers/scsi/qedi/qedi_main.c | 24 > 1 file changed, 24 insertions(+) > > diff

Re: [PATCH 5/8] qedi: Check for session online before getting iSCSI TLV data.

On 11/20/18 2:37 AM, Nilesh Javali wrote: > From: Manish Rangankar > > The kernel panic was observed after switch side perturbation, > > BUG: unable to handle kernel NULL pointer dereference at (null) > IP: [] strcmp+0x20/0x40 > PGD 0 Oops: [#1] SMP > CPU: 8 PID: 647 Comm:

Re: [PATCH 4/8] qedi: Allocate IRQs based on msix_cnt

On 11/20/18 2:37 AM, Nilesh Javali wrote: > The driver load on some systems failed with error, > [0004:01:00.5]:[qedi_request_msix_irq:2524]:8: request_irq failed. > > Allocate the IRQs based on MSIX count obtained from qed module > instead of number of queues. > > Signed-off-by: Nilesh Javali

Re: [PATCH 3/8] qedi: Replace PAGE_SIZE with QEDI_PAGE_SIZE

On 11/20/18 2:37 AM, Nilesh Javali wrote: > Use QEDI_PAGE_SIZE for enablement of module on systems with 64K page size. > > Signed-off-by: Nilesh Javali > --- > drivers/scsi/qedi/qedi_main.c | 16 +--- > 1 file changed, 9 insertions(+), 7 deletions(-) > > diff --git

Re: [PATCH 1/8] qedi: Cleanup redundant QEDI_PAGE_SIZE macro definition

On 11/20/18 2:37 AM, Nilesh Javali wrote: > Remove redundant macro definition. > > Signed-off-by: Nilesh Javali > --- > drivers/scsi/qedi/qedi.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/scsi/qedi/qedi.h b/drivers/scsi/qedi/qedi.h > index a6f96b3..e966855 100644 > ---

Re: [PATCH 2/8] qedi: Fix spelling mistake "OUSTANDING" -> "OUTSTANDING"

On 11/20/18 2:37 AM, Nilesh Javali wrote: > Fix trivial spelling mistake within macro definition. > > Signed-off-by: Nilesh Javali > --- > drivers/scsi/qedi/qedi.h | 4 ++-- > drivers/scsi/qedi/qedi_main.c | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git