Re: [PATCH] scsi-sg: pass flag to inhibit setting LUN

2014-01-19 Thread James Bottomley
On Sun, 2014-01-19 at 10:56 -0500, Douglas Gilbert wrote: > On 14-01-03 03:10 PM, Douglas Gilbert wrote: > > On 14-01-02 08:19 AM, Jiří Pinkava wrote: > >> Hi, > >> > >> This patch implements support for inhibiting setting LUN number > >> for SCSI custom command send via /dev/sgX with ioctl(.., SG_

Re: Disk spin-up optimization during system resume

2014-01-17 Thread James Bottomley
On Fri, 2014-01-17 at 05:21 -0500, Tejun Heo wrote: > Hello, > > On Fri, Jan 17, 2014 at 11:16:49AM +0100, Oliver Neukum wrote: > > The START-STOP may result in an error. What do you do in that case? > > At least for libata, worrying about suspend/resume failures don't make > whole lot of sense.

Re: [LSF/MM TOPIC][ATTEND] T10-PI RDMA offload

2014-01-16 Thread James Bottomley
On Thu, 2014-01-16 at 14:26 +0200, sagi grimberg wrote: >From: > sagi grimberg > To: > linux-scsi > , > target-devel > > Cc: > Oren Duer Actually, could you copy lsf...@lists.linux-foundation.org like the CFP requests? The reason is quite simple

Re: [PATCH 09/14] target/configfs: Expose protection device attributes

2014-01-13 Thread James Bottomley
On Mon, 2014-01-13 at 15:19 -0500, Martin K. Petersen wrote: > > "nab" == Nicholas A Bellinger writes: > > >> What proposed 16 byte scheme? The only DIF proposals I know for > >> SBC-4 are 13-185R0 and 12-369R0 and that's a couple of new algorithms > >> and types because we cannot change the

Re: [PATCH 09/14] target/configfs: Expose protection device attributes

2014-01-13 Thread James Bottomley
On Mon, 2014-01-13 at 11:27 -0800, Nicholas A. Bellinger wrote: > On Mon, 2014-01-13 at 10:52 -0800, James Bottomley wrote: > > On Mon, 2014-01-13 at 10:30 -0800, Nicholas A. Bellinger wrote: > > > Hey MKP, > > > > > > On Fri, 2014-01-10 at 1

Re: [PATCH 09/14] target/configfs: Expose protection device attributes

2014-01-13 Thread James Bottomley
On Mon, 2014-01-13 at 10:30 -0800, Nicholas A. Bellinger wrote: > Hey MKP, > > On Fri, 2014-01-10 at 16:01 -0500, Martin K. Petersen wrote: > > > "nab" == Nicholas A Bellinger writes: > > > > nab> This patch adds support for exposing DIF protection device > > nab> attributes via configfs. T

Re: [PATCH] gdth: Fixup section annotations

2014-01-13 Thread James Bottomley
On Mon, 2014-01-13 at 09:23 +0100, Hannes Reinecke wrote: > On 01/10/2014 06:07 PM, James Bottomley wrote: > > On Fri, 2014-01-10 at 16:31 +0100, Hannes Reinecke wrote: > >> Fixup section annotations so that kbuild doesn't complain anymore. > > > > This does

Re: [PATCH] gdth: Fixup section annotations

2014-01-10 Thread James Bottomley
On Fri, 2014-01-10 at 16:31 +0100, Hannes Reinecke wrote: > Fixup section annotations so that kbuild doesn't complain anymore. This doesn't look right: __devinit is now an obsolete annotation. James -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message

Re: [RFC 2/2] dual scan thread bug fix

2014-01-08 Thread James Bottomley
On Wed, 2014-01-08 at 10:57 -0500, Alan Stern wrote: > On Wed, 8 Jan 2014, James Bottomley wrote: > > > OK, Agreed, but that means modifying the 1/2 patch with the below. This > > should make the proposed diff to 2/2 correct. > > > > James > > > > ---

Re: status of block-integrity

2014-01-07 Thread James Bottomley
On Tue, 2014-01-07 at 16:34 -0700, Matthew Wilcox wrote: > On Tue, Jan 07, 2014 at 02:33:10PM +0100, Hannes Reinecke wrote: > > I would indeed like to have a discussion at LSF about the future of > > DIX. DIF is not an issue, as most HBAs support it already and we > > actually need it for proper co

Re: [RFC 2/2] dual scan thread bug fix

2014-01-07 Thread James Bottomley
On Sat, 2014-01-04 at 11:27 -0500, Alan Stern wrote: > On Fri, 3 Jan 2014, James Bottomley wrote: > > > > I'm still concerned about one thing. The previous patch does this in > > > scsi_alloc_target(): > > > > > > > found: > >

Re: Persistent reservation behaviour/compliance with redundant controllers

2014-01-06 Thread James Bottomley
On Mon, 2014-01-06 at 23:53 +0100, Matthias Eble wrote: > 2014/1/6 Lee Duncan : > > On 12/25/2013 03:00 PM, Matthias Eble wrote: > >> Here's the dmmp map > >> 360002aca6e6b dm-6 3PARdata,VV > >> size=2.0T features='0' hwhandler='0' wp=rw > >> `-+- policy='round-robin 0' prio=1 s

Re: [RFC 2/2] dual scan thread bug fix

2014-01-03 Thread James Bottomley
On Fri, 2014-01-03 at 10:58 -0500, Alan Stern wrote: > On Thu, 2 Jan 2014, James Bottomley wrote: > > > In the highly unusual case where two threads are running concurrently > > through > > the scanning code scanning the same target, we run into the situation where

Re: [RFC 0/2] target refcounting infrastructure fixes for usb

2014-01-03 Thread James Bottomley
On Fri, 2014-01-03 at 09:56 +0100, Hans de Goede wrote: > James, what is the status of getting the fix for the refcount issue into > mainline ? The plan is what I wrote in the patch intro: "Since it's a major change to the infrastructure, we'll incubate upstream first before backp

Re: [RFC 0/2] target refcounting infrastructure fixes for usb

2014-01-02 Thread James Bottomley
On Thu, 2014-01-02 at 16:45 -0800, Sarah Sharp wrote: > On Sat, Dec 21, 2013 at 03:51:25PM -0500, Alan Stern wrote: > > On Fri, 20 Dec 2013, Sarah Sharp wrote: > > > > > On Thu, Dec 19, 2013 at 11:48:47AM -0800, James Bottomley wrote: > > > > It should apply

[RFC 2/2] dual scan thread bug fix

2014-01-02 Thread James Bottomley
without reference counting, the second thread will do the wrong thing on reap. Fix this by reference counting even creates and doing the STARGET_CREATED check in the final put. Signed-off-by: James Bottomley --- drivers/scsi/scsi_scan.c | 23 --- 1 file changed, 16 insertions

[RFC 1/2] fix our current target reap infrastructure

2014-01-02 Thread James Bottomley
target disappears as soon as the last device is gone rather than waiting until final release of the device (which is often too long). Reviewed-by: Alan Stern Signed-off-by: James Bottomley --- drivers/scsi/scsi_scan.c | 95 -- drivers/scsi

[RFC 0/2] target refcounting infrastructure fixes for usb

2014-01-02 Thread James Bottomley
This set should fix our target problems with USB by making the target visibility properly reference counted. Since it's a major change to the infrastructure, we'll incubate upstream first before backporting to stable. James Bottomley (2): [SCSI] fix our current target reap infr

Re: [RFC 0/2] target refcounting infrastructure fixes for usb

2014-01-02 Thread James Bottomley
On Sat, 2013-12-21 at 15:51 -0500, Alan Stern wrote: > On Fri, 20 Dec 2013, Sarah Sharp wrote: > > > On Thu, Dec 19, 2013 at 11:48:47AM -0800, James Bottomley wrote: > > > It should apply incrementally on top of the previous two. If it > > > actually works, I&#

Re: [PATCH 3.12 033/118] usb: xhci: Link TRB must not occur within a USB payload burst

2014-01-02 Thread James Bottomley
On Thu, 2014-01-02 at 16:01 -0500, Mark Lord wrote: > On 14-01-02 02:15 PM, Sarah Sharp wrote: > > On Tue, Dec 31, 2013 at 12:40:16PM -0800, walt wrote: > .. > >> Unfortunately this patch causes a regression when copying large files to my > >> outboard USB3 drive. (Nothing at all to do with network

Re: spinlock_irqsave() && flags (Was: pm80xx: Spinlock fix)

2013-12-24 Thread James Bottomley
On Tue, 2013-12-24 at 09:13 +, Suresh Thiagarajan wrote: > > On Tue, Dec 24, 2013 at 1:59 PM, Ingo Molnar wrote: > > > > * Oleg Nesterov wrote: > > > >> On 12/23, Ingo Molnar wrote: > >> > > >> > * Oleg Nesterov wrote: > >> > > >> > > Initially I thought that this is obviously wrong, irqsav

Re: [RFC 0/2] target refcounting infrastructure fixes for usb

2013-12-19 Thread James Bottomley
On Thu, 2013-12-19 at 10:26 -0800, Sarah Sharp wrote: > On Wed, Dec 18, 2013 at 04:05:05PM -0800, James Bottomley wrote: > > On Wed, 2013-12-18 at 16:50 -0500, Alan Stern wrote: > > > On Wed, 18 Dec 2013, Sarah Sharp wrote: > > > > > > > On Mon, Dec 16, 20

Re: [PATCH 33/38] scsi: transport: add missing put_device call

2013-12-19 Thread James Bottomley
On Thu, 2013-12-19 at 16:06 +0100, Levente Kurusa wrote: > This is required so that we give up the last reference to the device. This isn't true. > Remove the kfree() as well, because the put_device() will result in > iscsi_endpoint_release being called and hence it will be kfree'd. There's no r

Re: [RFC 0/2] target refcounting infrastructure fixes for usb

2013-12-18 Thread James Bottomley
On Wed, 2013-12-18 at 16:50 -0500, Alan Stern wrote: > On Wed, 18 Dec 2013, Sarah Sharp wrote: > > > On Mon, Dec 16, 2013 at 07:10:19AM -0800, James Bottomley wrote: > > > This set should fix our target problems with USB by making the target > > > visibility prop

Re: [PATCH v4] sg: relax 16 byte cdb restriction

2013-12-17 Thread James Bottomley
On Sun, 2013-12-01 at 17:13 +0100, Douglas Gilbert wrote: > ChangeLog: > - remove the 16 byte CDB (SCSI command) length limit >from the sg driver by handling longer CDBs the same >way as the bsg driver. Remove comment from sg.h >public interface about th

Re: [PATCH 1/7] lpfc 8.3.44: Fixed IO hang when in msi mode.

2013-12-17 Thread James Bottomley
On Mon, 2013-12-02 at 12:48 -0500, James Smart wrote: > Fixed IO hang when in msi mode. > > > Signed-off-by: James Smart There seems to be a lot of tab vs space checkpatch warnings in this series: ERROR: code indent should use tabs where possible #24: FILE: drivers/scsi/lpfc/lpfc_scsi.c:4792:

Re: [PATCH 5/6] sd: don't start disks on system resume

2013-12-17 Thread James Bottomley
On Tue, 2013-12-17 at 10:01 -0500, Phillip Susi wrote: > On 12/17/2013 1:43 AM, James Bottomley wrote: > > >> -static int sd_resume(struct device *dev) +static int > >> sd_resume_runtime(struct device *dev) { struct scsi_disk *sdkp = > >> scsi_disk_get_from_dev(de

Re: [RFC 1/2] fix our current target reap infrastructure.

2013-12-17 Thread James Bottomley
On Mon, 2013-12-16 at 10:57 -0500, Alan Stern wrote: > On Mon, 16 Dec 2013, James Bottomley wrote: > > > This patch eliminates the reap_ref and replaces it with a proper kref. > > On last put of this kref, the target is removed from visibility in > > sysfs. The final

Re: [PATCH 5/6] sd: don't start disks on system resume

2013-12-16 Thread James Bottomley
On Mon, 2013-12-16 at 18:30 -0500, Phillip Susi wrote: > Instead of forcing a disk to start up with the START STOP UNIT > command when the system resumes, let it stay asleep if runtime > pm is enabled, and it will start the drive when it is accessed. > Query the drive to see if it starts up on its

[RFC 2/2] dual scan thread bug fix

2013-12-16 Thread James Bottomley
In the highly unusual case where two threads are running concurrently through the scanning code scanning the same target, we run into the situation where one may allocate the target while the other is still using it. In this case, because the reap checks for STARGET_CREATED and kills the target wi

[RFC 1/2] fix our current target reap infrastructure.

2013-12-16 Thread James Bottomley
This patch eliminates the reap_ref and replaces it with a proper kref. On last put of this kref, the target is removed from visibility in sysfs. The final call to scsi_target_reap() for the device is done from __scsi_remove_device() and only if the device was made visible. This ensures that the t

[RFC 0/2] target refcounting infrastructure fixes for usb

2013-12-16 Thread James Bottomley
This set should fix our target problems with USB by making the target visibility properly reference counted. Since it's a major change to the infrastructure, we'll incubate upstream first before backporting to stable. James --- James Bottomley (2): [SCSI] fix our current t

Re: [RFC] fix our current target reap infrastructure.

2013-12-15 Thread James Bottomley
On Sun, 2013-12-15 at 21:49 -0500, Alan Stern wrote: > On Sun, 15 Dec 2013, James Bottomley wrote: > > > No, I was thinking of the two thread scan bug (i.e. two scan threads) > > not one scan and one remove, which is a bug in the old code. > > By the way, the existin

Re: [RFC] fix our current target reap infrastructure.

2013-12-15 Thread James Bottomley
On Sun, 2013-12-15 at 21:44 -0500, Alan Stern wrote: > On Sun, 15 Dec 2013, James Bottomley wrote: > > > No, I was thinking of the two thread scan bug (i.e. two scan threads) > > not one scan and one remove, which is a bug in the old code. This is a > > race between put

Re: [RFC] fix our current target reap infrastructure.

2013-12-15 Thread James Bottomley
On Sun, 2013-12-15 at 16:32 -0500, Alan Stern wrote: > On Sat, 14 Dec 2013, James Bottomley wrote: > > > > The refcount test and state change race with scsi_alloc_target(). > > > Maybe the race won't occur in practice, but to be safe you should hold > > >

Re: [RFC] fix our current target reap infrastructure.

2013-12-14 Thread James Bottomley
On Fri, 2013-12-13 at 22:32 -0500, Alan Stern wrote: > On Fri, 13 Dec 2013, James Bottomley wrote: > > > This patch eliminates the reap_ref and replaces it with a proper kref. > > On last put of this kref, the target is removed from visibility in > > sysfs. The final

[RFC] fix our current target reap infrastructure.

2013-12-13 Thread James Bottomley
This patch eliminates the reap_ref and replaces it with a proper kref. On last put of this kref, the target is removed from visibility in sysfs. The final call to scsi_target_reap() for the device is done from __scsi_remove_device() and only if the device was made visible. This ensures that the t

Re: [usb-storage] UAS hangs khubd on USB disconnect

2013-12-13 Thread James Bottomley
On Fri, 2013-12-13 at 19:48 -0500, Alan Stern wrote: > On Fri, 13 Dec 2013, James Bottomley wrote: > > > On Fri, 2013-12-13 at 16:06 -0500, Alan Stern wrote: > > > On Fri, 13 Dec 2013, James Bottomley wrote: > > > > > > > Actually, I think I have thi

Re: [usb-storage] UAS hangs khubd on USB disconnect

2013-12-13 Thread James Bottomley
On Fri, 2013-12-13 at 16:06 -0500, Alan Stern wrote: > On Fri, 13 Dec 2013, James Bottomley wrote: > > > Actually, I think I have this figured out. There's a thinko in one of > > the scsi_target_reap() cases. The original (and still existing) problem > > with ta

Re: blk-tag.c: 89 BUG() triggering + initial analysis

2013-12-13 Thread James Bottomley
On Thu, 2013-11-14 at 12:09 +0100, Hans de Goede wrote: > Hi All, > > I hope linux-scsi is the right list for this, if not let me know. > > I've been working on getting the uas (Usb Attached Scsi) driver into > working shape for the last 3 weeks, so that it can be enabled in 3.14 . > > My latest

Re: [usb-storage] UAS hangs khubd on USB disconnect

2013-12-13 Thread James Bottomley
On Fri, 2013-12-13 at 11:18 -0800, James Bottomley wrote: > On Fri, 2013-12-13 at 13:33 -0500, Tejun Heo wrote: > > Hello, guys. > > > > (cc'ing Greg) > > > > On Fri, Dec 13, 2013 at 01:19:36PM -0500, Alan Stern wrote: > > > On Fri, 13 Dec 2013, Sa

Re: [usb-storage] UAS hangs khubd on USB disconnect

2013-12-13 Thread James Bottomley
On Fri, 2013-12-13 at 13:33 -0500, Tejun Heo wrote: > Hello, guys. > > (cc'ing Greg) > > On Fri, Dec 13, 2013 at 01:19:36PM -0500, Alan Stern wrote: > > On Fri, 13 Dec 2013, Sarah Sharp wrote: > > > > > > Given the way things work now, I suspect these warnings are truly > > > > harmless. We co

Re: [PATCH v4 2/4] Documentation: Add APM X-Gene SoC 15Gbps Multi-purpose PHY driver binding documentation

2013-12-12 Thread James Bottomley
On Thu, 2013-12-12 at 15:31 +0100, Douglas Gilbert wrote: > On 13-12-12 02:27 PM, Arnd Bergmann wrote: > > On Thursday 12 December 2013, Loc Ho wrote: > >> +- reg : First PHY memory resource is the SDS PHY access > >> + resource. > >> +

Re: [PATCH v2 2/2] pm80xx : Fixed return value issue

2013-12-11 Thread James Bottomley
On Wed, 2013-12-11 at 17:36 +0100, Tomas Henzl wrote: > On 12/10/2013 06:01 AM, Viswas G wrote: > > pm80xx_get_gsm_dump() was returning "1" in error case > > instead of negative error value. > > > > Signed-off-by: Viswas G > > Reviewed-by: Jack Wang > > Acked-by: TomasHenzl > > Hi Viswas, > >

Re: CONFIG_SCSI_MULTI_LUN default

2013-12-09 Thread James Bottomley
On Mon, 2013-12-09 at 14:28 -0500, Alan Stern wrote: > On Mon, 9 Dec 2013, James Bottomley wrote: > > > On Mon, 2013-12-09 at 13:24 -0500, Alan Stern wrote: > > > James: > > > > > > Is there any good reason why CONFIG_SCSI_MULTI_LUN still doesn't >

Re: CONFIG_SCSI_MULTI_LUN default

2013-12-09 Thread James Bottomley
On Mon, 2013-12-09 at 13:24 -0500, Alan Stern wrote: > James: > > Is there any good reason why CONFIG_SCSI_MULTI_LUN still doesn't > default to Y? Assuming we've got all the screw ups (mostly CD ROMS) blacklisted, I think the only real reason is that some SCSI-2 devices don't respond to stuff no

[GIT PULL] SCSI fixes for 3.13-rc2

2013-12-06 Thread James Bottomley
upport and then firmware has been choking on the commands). The rest are various crash, hang or warn driver fixes. The patch is available here: git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git scsi-fixes The short changelog is: Dan Williams (1): libsas: fix usage of ata_tf_to_

Re: [PATCH 01/11] hpsa: use workqueue instead of kernel thread for lockup detection

2013-12-04 Thread James Bottomley
On Wed, 2013-12-04 at 10:31 -0600, scame...@beardog.cce.hp.com wrote: > On Mon, Dec 02, 2013 at 10:00:02AM -0800, James Bottomley wrote: > > On Thu, 2013-11-07 at 10:45 -0600, Stephen M. Cameron wrote: > > > From: Stephen M. Cameron > > > > > > Much simpler an

Re: [SCSI] qla2xxx: Question about out-of-order SCSI command processing

2013-12-03 Thread James Bottomley
On Tue, 2013-12-03 at 11:46 -0600, Alireza Haghdoost wrote: > On Tue, Dec 3, 2013 at 7:25 AM, James Bottomley > wrote: > > Well, no, we could have used Ordered instead of Simple tags ... that > > would preserve submission order according to spec. This wouldn't really &g

Re: "swiotlb buffer is full" with 3.13-rc1+ but not 3.4.

2013-12-03 Thread James Bottomley
On Tue, 2013-12-03 at 12:33 -0500, Konrad Rzeszutek Wilk wrote: > On Sat, Nov 30, 2013 at 03:48:44PM -0500, James Bottomley wrote: > > On Sat, 2013-11-30 at 13:56 -0500, Konrad Rzeszutek Wilk wrote: > > > My theory is that the SWIOTLB is not full - it is just that the requ

Re: [PATCH 7/8] bfa: Fix crash when symb name set for offline vport

2013-12-03 Thread James Bottomley
On Tue, 2013-12-03 at 07:38 -0700, Vijaya Mohan Guvva wrote: > > On Tue, 2013-11-19 at 23:05 -0800, vmo...@brocade.com wrote: > > > From: Vijaya Mohan Guvva > > > > > > This patch fixes a crash when tried setting symbolic name for an > > > offline vport through sysfs. Crash is due to uninitialized

Re: [PATCH 7/8] bfa: Fix crash when symb name set for offline vport

2013-12-03 Thread James Bottomley
On Tue, 2013-11-19 at 23:05 -0800, vmo...@brocade.com wrote: > From: Vijaya Mohan Guvva > > This patch fixes a crash when tried setting symbolic name for an offline > vport through sysfs. Crash is due to uninitialized pointer lport->ns, > which gets initialized only on linkup (port online). This

Re: [SCSI] qla2xxx: Question about out-of-order SCSI command processing

2013-12-03 Thread James Bottomley
On Tue, 2013-12-03 at 13:26 +0100, Bart Van Assche wrote: > On 12/03/13 00:38, James Bottomley wrote: > > Well this would be because we don't guarantee order at any granularity > > below barriers. We won't reorder across barriers but below them we can > > reorder

Re: [SCSI] qla2xxx: Question about out-of-order SCSI command processing

2013-12-02 Thread James Bottomley
On Mon, 2013-12-02 at 16:12 -0600, Alireza Haghdoost wrote: > Hi, > >We are working on a very high I/O throughput application and facing > with a challenge to send the I/O request to a SAN drive in-order. I > would appreciate if you can help us with an explanation about this > unexpected beha

Re: [PATCH V2 4/4] pm80xx: Tasklets synchronization fix.

2013-12-02 Thread James Bottomley
On Wed, 2013-11-13 at 05:36 -0800, Anand wrote: > >From 9dda7700201be93d4d2b83c2733be3d582859bc7 Mon Sep 17 00:00:00 2001 > From: Nikith Ganigarakoppal > Date: Mon, 11 Nov 2013 15:28:14 +0530 > Subject: [PATCH V2 4/4] pm80xx: Tasklets synchronization fix. > > When multiple vectors are used, the v

Re: [PATCH 01/11] hpsa: use workqueue instead of kernel thread for lockup detection

2013-12-02 Thread James Bottomley
On Thu, 2013-11-07 at 10:45 -0600, Stephen M. Cameron wrote: > From: Stephen M. Cameron > > Much simpler and avoids races starting/stopping the thread. > > Signed-off-by: Stephen M. Cameron Actually, perhaps you do need to resubmit the series: this is rejecting against scsi-misc because of you

Re: [PATCH 03/11] hpsa: add 5 second delay after doorbell reset

2013-12-02 Thread James Bottomley
On Mon, 2013-12-02 at 11:15 -0600, Mike Miller wrote: > On Sat, Nov 30, 2013 at 04:42:02PM -0800, James Bottomley wrote: > > On Fri, 2013-11-08 at 09:31 -0600, scame...@beardog.cce.hp.com wrote: > > > On Fri, Nov 08, 2013 at 04:02:20PM +0100, Tomas Henzl wrote: > > &g

Re: [PATCH] drivers: scsi: scsi_lib.c: add prefix "SCSILIB_" to macro "SP"

2013-12-01 Thread James Bottomley
On Mon, 2013-12-02 at 08:34 +0800, Chen Gang wrote: > On 12/02/2013 12:17 AM, Bart Van Assche wrote: > > On 11/27/13 03:29, Chen Gang wrote: > >> the macro "SP" is too common to make conflict with some architectures, > >> so recommend to add prefix for it. > >> > >> The related warning (with allmod

Re: [PATCH 03/11] hpsa: add 5 second delay after doorbell reset

2013-12-01 Thread James Bottomley
On Fri, 2013-11-08 at 09:31 -0600, scame...@beardog.cce.hp.com wrote: > On Fri, Nov 08, 2013 at 04:02:20PM +0100, Tomas Henzl wrote: > > On 11/08/2013 03:44 PM, scame...@beardog.cce.hp.com wrote: > > > On Fri, Nov 08, 2013 at 02:51:37PM +0100, Tomas Henzl wrote: > > >> On 11/07/2013 05:45 PM, Steph

Re: [PATCH v2] sg: relax 16 byte cdb restriction

2013-11-30 Thread James Bottomley
On Wed, 2013-10-30 at 18:25 -0400, Douglas Gilbert wrote: > This is essentially the same patch sent 6 weeks ago: >http://marc.info/?l=linux-scsi&m=137943733409512&w=2 > re-based on '[PATCH v2] sg: O_EXCL and other lock handling'. > > ChangeLog: > - remove the 16 byte CDB (SCSI command) le

Re: "swiotlb buffer is full" with 3.13-rc1+ but not 3.4.

2013-11-30 Thread James Bottomley
On Sat, 2013-11-30 at 13:56 -0500, Konrad Rzeszutek Wilk wrote: > My theory is that the SWIOTLB is not full - it is just that the request > is for a compound page that is more than 512kB. Please note that > SWIOTLB highest "chunk" of buffer it can deal with is 512kb. > > And that is of course the

Re: [mptscsih] Watchdog detected hard LOCKUP on cpu 0

2013-11-25 Thread James Bottomley
On Mon, 2013-11-25 at 02:48 -0500, George Spelvin wrote: > I first reported this in mid-October, but I've been AFK for a month > and haven't done anything about it in that time. Basically, sustained > linear reads from 6 (7200 RPM 2 TB) disks on a BR10i controller causes > a hard lockup. > > Anyw

Re: [LWN] Linux 3.13-rc1 is out

2013-11-23 Thread James Bottomley
On Sat, 2013-11-23 at 11:52 -0500, Douglas Gilbert wrote: > With a three week window we see this: > >ChangeLog: > ... >James Bottomley (1): > first round of SCSI updates >... > > That begs the question: was there nothing suitable for > a second

Re: [PATCH] scsi: Add "missing" sysfs attribute to scsi_device structure

2013-11-18 Thread James Bottomley
On Mon, 2013-11-18 at 12:59 -0500, Ewan Milne wrote: > On Mon, 2013-11-18 at 09:45 -0800, James Bottomley wrote: > > On Mon, 2013-11-18 at 12:10 -0500, Ewan D. Milne wrote: > > > From: "Ewan D. Milne" > > > > > > This change adds a "missing"

Re: [PATCH] scsi: Add "missing" sysfs attribute to scsi_device structure

2013-11-18 Thread James Bottomley
On Mon, 2013-11-18 at 12:10 -0500, Ewan D. Milne wrote: > From: "Ewan D. Milne" > > This change adds a "missing" sysfs attribute to scsi_device > which is set when a previously scanned device no longer appears > in the REPORT LUNS inventory. A sysfs parameter with time and external input depende

Re: [PATCH] scsi: be_iscsi: fix possible memory leak and refactor code

2013-11-18 Thread James Bottomley
On Mon, 2013-11-18 at 14:18 -0200, Geyslan Gregório Bem wrote: > 2013/11/18 James Bottomley : > > On Sun, 2013-11-17 at 23:12 -0200, Geyslan Gregório Bem wrote: > >> 2013/11/17 James Bottomley : > >> > On Sun, 2013-11-17 at 19:09 -0200, Geyslan Gregório Bem w

Re: Question on SCSI target scan

2013-11-18 Thread James Bottomley
On Mon, 2013-11-18 at 00:52 -0700, Ramesh Chikkanayakanahally wrote: > Thanks for the response. > > If using RSCN sounds like a reasonable approach in this scenario > (protocol limitations), then as per the original question - would it > be acceptable to add an interface in scsi_transport_fc la

Re: [PATCH] scsi: be_iscsi: fix possible memory leak and refactor code

2013-11-18 Thread James Bottomley
On Sun, 2013-11-17 at 23:12 -0200, Geyslan Gregório Bem wrote: > 2013/11/17 James Bottomley : > > On Sun, 2013-11-17 at 19:09 -0200, Geyslan Gregório Bem wrote: > >> 2013/11/17 James Bottomley : > >> > On Sun, 2013-11-17 at 15:51 -0300, Geyslan G. Bem wrote: > &g

Re: [PATCH 1/3] sd: don't bother spinning up disks on resume

2013-11-17 Thread James Bottomley
On Sun, 2013-11-17 at 11:15 -0500, Phillip Susi wrote: > On 11/17/2013 01:43 AM, James Bottomley wrote: > > OK, so three people have now told you that's not how the code > > works. Why don't you just read it? because there's not really much > > point us readi

Re: [PATCH] scsi: be_iscsi: fix possible memory leak and refactor code

2013-11-17 Thread James Bottomley
On Sun, 2013-11-17 at 19:09 -0200, Geyslan Gregório Bem wrote: > 2013/11/17 James Bottomley : > > On Sun, 2013-11-17 at 15:51 -0300, Geyslan G. Bem wrote: > >> This patch fix memory leakage in cases 'ISCSI_NET_PARAM_VLAN_ID' and > >> 'ISCSI_NET_PARAM_VL

Re: [PATCH] scsi: be_iscsi: fix possible memory leak and refactor code

2013-11-17 Thread James Bottomley
On Sun, 2013-11-17 at 15:51 -0300, Geyslan G. Bem wrote: > This patch fix memory leakage in cases 'ISCSI_NET_PARAM_VLAN_ID' and > 'ISCSI_NET_PARAM_VLAN_PRIORITY' and refactors code 'going out' when > necessary. You pointlessly renamed a variable, which makes the diff hard to read. Please don't do

Re: [PATCH 1/3] sd: don't bother spinning up disks on resume

2013-11-16 Thread James Bottomley
On Sat, 2013-11-16 at 22:50 -0500, Phillip Susi wrote: > On 11/16/2013 01:20 PM, James Bottomley wrote: > > No disk does, neither SCSI nor ATA. The error handler is not > > automatically activated for a not ready/initializing command > > required because of multi-path. We

Re: [PATCH 11/11] pm80xx : gpio feature support for motherboard controllers

2013-11-16 Thread James Bottomley
On Mon, 2013-11-11 at 09:58 +0100, Jack Wang wrote: > Hi James, > > About this gpio feature, do you think it's OK to implement with IOCTL Definitely not via another strange ioctl > or we can use exist bsg interface in libsas and add another function call? My default thought is that it should go

Re: [PATCH 1/3] sd: don't bother spinning up disks on resume

2013-11-16 Thread James Bottomley
On Thu, 2013-11-07 at 16:16 -0500, Phillip Susi wrote: > On 11/7/2013 1:21 PM, Douglas Gilbert wrote: > > On 13-11-06 08:57 PM, Phillip Susi wrote: > >> Don't bother forcing disks to spin up on resume, as they will do > >> so automatically when accessed, and forcing them to spin up slows > >> down

Re: [PATCH 1/1] enclosure: fix WARN_ON in dual path device removing

2013-11-15 Thread James Bottomley
On Fri, 2013-11-15 at 10:46 -0600, wenxi...@linux.vnet.ibm.com wrote: > The issue is happened in dual controller configuration. We got the > sysfs warnings when rmmod the ipr module. > > enclosure_unregister() in drivers/msic/enclosure.c, call device_unregister() > for each componment deivce, devi

Re: [Bug 64171] Block SCSI Generic Driver does not keep data

2013-11-15 Thread James Bottomley
On Sat, 2013-11-02 at 17:09 +, bugzilla-dae...@bugzilla.kernel.org wrote: > https://bugzilla.kernel.org/show_bug.cgi?id=64171 > > --- Comment #2 from d gilbert --- > On 13-11-01 03:49 PM, bugzilla-dae...@bugzilla.kernel.org wrote: > > https://bugzilla.kernel.org/show_bug.cgi?id=64171 > > > >

Re: [PATCH] scsi: avoid use of reclaimed reference

2013-11-13 Thread James Bottomley
On Wed, 2013-11-13 at 18:50 -0800, David Decotigny wrote: > Hello, > > Thank you for looking into this. I could reproduce the oops on some > Dell Poweredge R720 with the following config flags, otherwise the > problem goes un-noticed: > > CONFIG_DEBUG_PAGEALLOC=y > CONFIG_DEBUG_SLAB=y > > [4

Re: [PATCH] scsi: avoid use of reclaimed reference

2013-11-12 Thread James Bottomley
On Tue, 2013-11-12 at 18:09 -0800, David Decotigny wrote: > I was considering the following scenario wherein the "if > (scsi_device_created(sdev))" test at the end would test garbage at > best (or unmapped data): Well, no, the counting isn't right: >if (!(sdev = scsi_device_lookup_by_targ

Re: [PATCH] scsi: avoid use of reclaimed reference

2013-11-12 Thread James Bottomley
On Tue, 2013-11-12 at 17:10 -0800, David Decotigny wrote: > This patch avoids to use an object after it was potentially reclaimed > by scsi_device_put(). The analysis is wrong, I'm afraid. __scsi_remove_device() does the final put for devices that are being destroyed. If the device isn't in the

[GIT PULL] First round of SCSI updates for the 3.11+ merge window

2013-11-09 Thread James Bottomley
ove 'last_reset' into host structure advansys: Remove 'last_reset' references dpt_i2o: return SCSI_MLQUEUE_HOST_BUSY when in reset dpt_i2o: Remove DPTI_STATE_IOCTL Hiral Patel (2): fnic: Incremented driver version fnic: Fnic Statistics Collection Jack Wang (1

Re: [PATCH 2/5] scsi: improved eh timeout handler

2013-11-09 Thread James Bottomley
On Thu, 2013-11-07 at 07:45 +0100, Hannes Reinecke wrote: > On 11/06/2013 06:23 PM, Mike Christie wrote: > > On 11/05/2013 10:48 PM, Hannes Reinecke wrote: > >> On 11/05/2013 08:19 PM, Mike Christie wrote: > >>> On 11/04/2013 11:05 PM, Hannes Reinecke wrote: > + > +scmd->eh_eflags

Re: [PATCH 2/3] scsi: improved eh timeout handler

2013-11-04 Thread James Bottomley
On Mon, 2013-11-04 at 16:43 +0100, Hannes Reinecke wrote: > On 11/04/2013 03:50 PM, James Bottomley wrote: > > On Mon, 2013-11-04 at 15:46 +0100, Hannes Reinecke wrote: > >> On 11/04/2013 03:25 PM, James Bottomley wrote: > >>> On Mon, 2013-11-04 at 14:36 +0100, Hanne

Re: [PATCH 2/3] scsi: improved eh timeout handler

2013-11-04 Thread James Bottomley
On Mon, 2013-11-04 at 15:46 +0100, Hannes Reinecke wrote: > On 11/04/2013 03:25 PM, James Bottomley wrote: > > On Mon, 2013-11-04 at 14:36 +0100, Hannes Reinecke wrote: > >> On 10/31/2013 04:49 PM, Christoph Hellwig wrote: > >>> Looks reasonable t

Re: [PATCH 2/3] scsi: improved eh timeout handler

2013-11-04 Thread James Bottomley
On Mon, 2013-11-04 at 14:36 +0100, Hannes Reinecke wrote: > On 10/31/2013 04:49 PM, Christoph Hellwig wrote: > > Looks reasonable to me, but a few minor nitpicks: > > > >> + spin_lock_irqsave(sdev->host->host_lock, flags); > >> + if (scsi_host_eh_past_deadline(sdev->host)) { > > > > I don't hav

Re: [PATCH] [SCSI] hpsa: fix return value check in start_controller_lockup_detector()

2013-10-29 Thread James Bottomley
On Tue, 2013-10-29 at 11:09 -0500, scame...@beardog.cce.hp.com wrote: > On Tue, Oct 29, 2013 at 02:43:56PM +0800, Wei Yongjun wrote: > > From: Wei Yongjun > > > > In case of error, the function kthread_run() returns ERR_PTR() > > and never returns NULL. The NULL test in the return value check > >

Re: [patch] [SCSI] aacraid: prevent ZERO_SIZE_PTR dereference

2013-10-29 Thread James Bottomley
On Tue, 2013-10-29 at 22:10 +0300, Dan Carpenter wrote: > If "fibsize" is zero then it leads to a ZERO_SIZE_PTR dereference when > we dereference user_srbcmd. > > Due to a missing capable() check in the compat ioctls then this error > can be triggered without CAP_SYS_RAWIO. I have fixed that in a

Re: arcmsr driver update

2013-10-29 Thread James Bottomley
On Tue, 2013-10-29 at 16:14 +0100, Markus Blank-Burian wrote: > Dear all, > > two month ago, there was a patch submitted by the company areca > regarding their in-kernel driver: > "[PATCH v1.2 1/1] arcmsr: Support Areca new SATA Raid Adapter > ARC1214/1224/1264/1284" The patch never made it to th

[GIT PULL] SCSI fixes for 3.12-rc7

2013-10-28 Thread James Bottomley
0/0x4d0 The fix is large, so at this late stage we'd like to revert the functionality and start again in the next merge window. The patch is available here: git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git scsi-fixes The short changelog is: James Bottomley (4): Revert &q

Re: [3.12-rc] sg_open: leaving the kernel with locks still held!

2013-10-25 Thread James Bottomley
On Thu, 2013-10-24 at 17:37 -0700, Simon Kirby wrote: > On Wed, Oct 23, 2013 at 10:10:47AM -0400, Douglas Gilbert wrote: > > > On 13-10-23 03:44 AM, James Bottomley wrote: > > >On Tue, 2013-10-22 at 20:41 -0400, Douglas Gilbert wrote: > > >>On 13-10-22 04:56 PM

Re: self assignment bug in aix94xx

2013-10-24 Thread James Bottomley
On Thu, 2013-10-24 at 04:55 -0400, Dave Jones wrote: > 2908d778 (James Bottomley2006-08-29 09:22:51 -0500 515) > scb->ssp_task.retry_count = scb->ssp_task.retry_count; > > Is this supposed to maybe be.. > > scb->ssp_task.retry_count =

Re: [GIT PULL] SCSI fixes for 3.12-rc6

2013-10-23 Thread James Bottomley
On Wed, 2013-10-23 at 13:42 +0100, Linus Torvalds wrote: > You need to think about *WHY* we had a "new driver" exception. And > realize that it probably will never actually be relevant for any SCSI > driver (not counting things like USB storage etc). OK, point taken, here's the new pull request -

Re: [3.12-rc] sg_open: leaving the kernel with locks still held!

2013-10-23 Thread James Bottomley
On Wed, 2013-10-23 at 05:11 -0700, Josh Boyer wrote: > On Wed, Oct 23, 2013 at 12:44 AM, James Bottomley > wrote: > > On Tue, 2013-10-22 at 20:41 -0400, Douglas Gilbert wrote: > >> On 13-10-22 04:56 PM, Simon Kirby wrote: > >> > Hello! > >> > >

Re: [GIT PULL] SCSI fixes for 3.12-rc6

2013-10-23 Thread James Bottomley
On Wed, 2013-10-23 at 13:07 +0100, Linus Torvalds wrote: > On Wed, Oct 23, 2013 at 12:27 PM, James Bottomley > wrote: > > > > The patch is available here: > > > > git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git scsi-fixes > > No it's not. &qu

Re: [PATCH 7/7] scsi: Add 'eh_deadline' to limit SCSI EH runtime

2013-10-23 Thread James Bottomley
On Wed, 2013-10-23 at 11:25 +0200, Hannes Reinecke wrote: > On 10/16/2013 09:22 PM, James Bottomley wrote: > > On Mon, 2013-07-01 at 08:50 +0200, Hannes Reinecke wrote: > >> This patchs adds an 'eh_deadline' sysfs attribute to the scsi > >> host which limi

Re: [3.12-rc] sg_open: leaving the kernel with locks still held!

2013-10-23 Thread James Bottomley
On Tue, 2013-10-22 at 20:41 -0400, Douglas Gilbert wrote: > On 13-10-22 04:56 PM, Simon Kirby wrote: > > Hello! > > > > While trying to figure out why the request queue to sda (ext4) was > > clogging up on one of our btrfs backup boxes, I noticed a megarc process > > in D state, so enabled locking

Re: [PATCH 3/3] Fix device detection issues with mvsas driver

2013-10-16 Thread James Bottomley
On Tue, 2013-10-15 at 19:40 -0700, Praveen Murali wrote: > Yes, I checked that today and was meaning to ask you about it. :) Ideally, I need someone from Marvell to ack it ... can you prod them? Thanks, James -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body

Re: [PATCH][SCSI] megaraid_sas: Fix synchronization problem between sysPD IO path and AEN path

2013-10-16 Thread James Bottomley
On Wed, 2013-10-16 at 17:04 +0530, sumit.sax...@lsi.com wrote: > There is syncronization problem between sysPD IO path and AEN path. Driver > maintains instance->pd_list[] array, which will get updated(by calling > function megasas_get_pd_list[]), whenever any of below events occurs- > > MR_EVT_

Re: [Bug] 12.864681 BUG: lock held when returning to user space!

2013-10-16 Thread James Bottomley
On Tue, 2013-10-08 at 09:45 -0400, Douglas Gilbert wrote: > On 13-10-08 02:44 AM, vaughan wrote: > > Hi Madper, > > > > CC to Douglas to get comments. > > I use the rw_semaphore o_sem to protect excl open, introduced in commit > > 15b06f9a02406e5460001db6d5af5c738cd3d4e7 since v3.12-rc1. > > Is it

Re: [PATCH 1/3] scsi: Fix erratic device offline during EH

2013-10-16 Thread James Bottomley
On Mon, 2013-09-02 at 13:58 +0200, Hannes Reinecke wrote: > Commit 18a4d0a22ed6c54b67af7718c305cd010f09ddf8 > (Handle disk devices which can not process medium access commands) > was introduced to offline any device which cannot process medium > access commands. > However, commit 3eef6257de48ff84a5

Re: [PATCH 7/7] scsi: Add 'eh_deadline' to limit SCSI EH runtime

2013-10-16 Thread James Bottomley
On Mon, 2013-07-01 at 08:50 +0200, Hannes Reinecke wrote: > This patchs adds an 'eh_deadline' sysfs attribute to the scsi > host which limits the overall runtime of the SCSI EH. > The 'eh_deadline' value is stored in the now obsolete field > 'resetting'. > When a command is failed the start time of

<    8   9   10   11   12   13   14   15   16   17   >