Re: [PATCH v2] scsi: Add 'retry_timeout' to avoid infinite command retry

2014-02-06 Thread Libo Chen
On 2014/2/7 13:46, James Bottomley wrote: On Fri, 2014-02-07 at 09:22 +0900, Eiichi Tsukata wrote: Currently, scsi error handling in scsi_io_completion() tries to unconditionally requeue scsi command when device keeps some error state. For example, UNIT_ATTENTION causes infinite retry with

Re: [PATCH v2] scsi: megaraid: check kzalloc

2013-06-04 Thread Libo Chen
On 2013/6/4 20:14, Tomas Henzl wrote: On 06/04/2013 11:33 AM, Libo Chen wrote: we should check kzalloc, avoid to hit oops Change from v1: - put kzalloc outside of mutex Signed-off-by: Libo Chen libo.c...@huawei.com Your patch looks fine to me: Acked-by: Tomas Henzl the...@redhat.com

Re: [PATCH RESEND] scsi: megaraid: check kzalloc

2013-05-29 Thread Libo Chen
On 2013/5/29 23:03, Tomas Henzl wrote: On 05/24/2013 11:40 AM, Libo Chen wrote: we should check kzalloc, avoid to hit oops Signed-off-by: Libo Chen libo.c...@huawei.com --- drivers/scsi/megaraid.c |4 1 files changed, 4 insertions(+), 0 deletions(-) instead of checking scmd

Re: [PATCH RESEND] scsi: megaraid: check kzalloc

2013-05-29 Thread Libo Chen
On 2013/5/30 9:38, Libo Chen wrote: On 2013/5/29 23:03, Tomas Henzl wrote: On 05/24/2013 11:40 AM, Libo Chen wrote: we should check kzalloc, avoid to hit oops Signed-off-by: Libo Chen libo.c...@huawei.com --- drivers/scsi/megaraid.c |4 1 files changed, 4 insertions(+), 0

Re: [PATCH] scsi: Introduce a help function local_time_seconds() to simplify the getting time stamp operation

2013-05-29 Thread Libo Chen
On 2013/5/29 17:33, Gu Zheng wrote: From 4d4caa16f3886ae910ad6dfe13353fc836f546cc Mon Sep 17 00:00:00 2001 From: Gu Zheng guz.f...@cn.fujitsu.com Date: Wed, 29 May 2013 17:34:22 +0900 Subject: [PATCH] driver/scsi: Introduce a help function local_time_seconds() to simplify the getting time

Re: [PATCH 04/24] drivers/scsi/initio: Convert to module_pci_driver

2013-05-27 Thread Libo Chen
On 2013/5/27 14:38, James Bottomley wrote: On Mon, 2013-05-27 at 10:28 +0800, Libo Chen wrote: use module_pci_driver instead of init/exit, make code clean. For the ancient drivers, like this, the principal is that we really don't touch except for tested bug fixes. For the current ones (like

[PATCH 03/24] drivers/scsi/dmx3191d: Convert to module_pci_driver

2013-05-26 Thread Libo Chen
use module_pci_driver instead of init/exit, make code clean. Signed-off-by: Libo Chen libo.c...@huawei.com --- drivers/scsi/dmx3191d.c | 13 + 1 files changed, 1 insertions(+), 12 deletions(-) diff --git a/drivers/scsi/dmx3191d.c b/drivers/scsi/dmx3191d.c old mode 100644 new mode

[PATCH 04/24] drivers/scsi/initio: Convert to module_pci_driver

2013-05-26 Thread Libo Chen
use module_pci_driver instead of init/exit, make code clean. Signed-off-by: Libo Chen libo.c...@huawei.com --- drivers/scsi/initio.c | 13 + 1 files changed, 1 insertions(+), 12 deletions(-) diff --git a/drivers/scsi/initio.c b/drivers/scsi/initio.c old mode 100644 new mode 100755

[PATCH 05/24] drivers/scsi/mvumi: Convert to module_pci_driver

2013-05-26 Thread Libo Chen
use module_pci_driver instead of init/exit, make code clean. Signed-off-by: Libo Chen libo.c...@huawei.com --- drivers/scsi/mvumi.c | 20 +--- 1 files changed, 1 insertions(+), 19 deletions(-) diff --git a/drivers/scsi/mvumi.c b/drivers/scsi/mvumi.c old mode 100644 new mode

[PATCH 01/24] drivers/scsi/a100u2w: Convert to module_pci_driver

2013-05-26 Thread Libo Chen
use module_pci_driver instead of init/exit, make code clean. --- drivers/scsi/a100u2w.c | 12 +--- 1 files changed, 1 insertions(+), 11 deletions(-) diff --git a/drivers/scsi/a100u2w.c b/drivers/scsi/a100u2w.c old mode 100644 new mode 100755 index 0163457..db3710f ---

[PATCH 02/24] drivers/scsi/dc395x: Convert to module_pci_driver

2013-05-26 Thread Libo Chen
use module_pci_driver instead of init/exit, make code clean. Signed-off-by: Libo Chen libo.c...@huawei.com --- drivers/scsi/dc395x.c | 24 +--- 1 files changed, 1 insertions(+), 23 deletions(-) diff --git a/drivers/scsi/dc395x.c b/drivers/scsi/dc395x.c old mode 100644 new

[PATCH RESEND 01/24] drivers/scsi/a100u2w: Convert to module_pci_driver

2013-05-26 Thread Libo Chen
use module_pci_driver instead of init/exit, make code clean. Signed-off-by: Libo Chen libo.c...@huawei.com --- drivers/scsi/a100u2w.c | 12 +--- 1 files changed, 1 insertions(+), 11 deletions(-) * add Signed-off-by: Libo Chen libo.c...@huawei.com diff --git a/drivers/scsi/a100u2w.c

Re: [PATCH] scsi: megaraid: check kzalloc

2013-05-24 Thread Libo Chen
On 2013/5/24 11:20, Santosh Y wrote: On Fri, May 24, 2013 at 7:52 AM, Libo Chen clbchenlibo.c...@huawei.com wrote: we should check kzalloc, avoid to hit oops Signed-off-by: Libo Chen libo.c...@huawei.com --- drivers/scsi/megaraid.c |4 1 files changed, 4 insertions(+), 0

[PATCH RESEND] scsi: megaraid: check kzalloc

2013-05-24 Thread Libo Chen
we should check kzalloc, avoid to hit oops Signed-off-by: Libo Chen libo.c...@huawei.com --- drivers/scsi/megaraid.c |4 1 files changed, 4 insertions(+), 0 deletions(-) instead of checking scmd-device, sdev is more appropriate. diff --git a/drivers/scsi/megaraid.c b/drivers/scsi

[PATCH] scsi: megaraid: check kzalloc

2013-05-23 Thread Libo Chen
we should check kzalloc, avoid to hit oops Signed-off-by: Libo Chen libo.c...@huawei.com --- drivers/scsi/megaraid.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/drivers/scsi/megaraid.c b/drivers/scsi/megaraid.c index 846f475..195b095 100644 --- a/drivers/scsi