? You didn't touch the procinfo method in the other ISDN
drivers, as far as I can see.
(If it was intentional, gigaset_procinfo() can of course be removed.)
> - iif->ctr.proc_fops = &gigaset_proc_fops;
> + iif->ctr.proc_show = gigaset_proc_show,
> INIT_LIST_HEAD(&iif->appls);
> skb_queue_head_init(&iif->sendqueue);
> atomic_set(&iif->sendqlen, 0);
Thanks,
Paul Bolle
On Thu, 2015-06-04 at 16:07 +0200, Paul Bolle wrote:
> On Wed, 2015-06-03 at 12:37 +0300, Yaniv Gardi wrote:
> > +static int ufs_qcom_probe(struct platform_device *pdev)
> > +{
> > + dev_set_drvdata(&pdev->dev, (void *)&ufs_hba_qcom_vops);
>
> (Cast to
is not needed.)
> + }
If I scanned this correctly, the dev_set_drvdata() and dev_get_drvdata()
pair adds an actual user of ufs_hba_qcom_vops. So that ends the obvious
issue I think the code currently has. And I gladly defer to the scsi
people to determine whether that is done the right way.
Thanks,
Paul Bolle
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, 2015-05-21 at 10:09 +, yga...@codeaurora.org wrote:
> > On Wed, 2015-05-20 at 10:22 +0200, Paul Bolle wrote:
> > Am I missing something obvious here? Because ufs-qcom currently looks
> > pointless to me, and I actually see little reason to even have it in the
On Wed, 2015-05-20 at 10:22 +0200, Paul Bolle wrote:
> By the way, as far as I can see, this (new) module can only be loaded
> manually (or via scripts). Is that what people want?
This comment wasn't well thought through. So I hand another look at the
code of usf-qcom.
I noticed that
qcom.ko]
> undefined!
> ERROR: "ufs_qcom_phy_save_controller_version" [drivers/scsi/ufs/ufs-qcom.ko]
> undefined!
> ERROR: "ufs_qcom_phy_enable_iface_clk" [drivers/scsi/ufs/ufs-qcom.ko]
> undefined!
> make[1]: *** [__modpost] Error 1
Thanks,
Paul Bolle
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
-20150519, drivers/scsi/ufs/ufs-qcom.c lacks
the required module specific boilerplate for this to be useful. Is that
boilerplate added in another series?
Thanks,
Paul Bolle
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord..
Hi Valentin,
On Tue, 2015-04-28 at 21:26 +0200, Valentin Rothberg wrote:
> On Tue, Apr 28, 2015 at 9:10 PM, Paul Bolle wrote:
> > Will the Erlangen bot still spot ACORNSCSI_CONSTANTS as a potential
> > issue?
>
> No, undertaker-checkpatch won't complain about this.
t; This patch removes the 'CONFIG_' prefix to apply to this convention and
> to make static analysis tools happy.
Will the Erlangen bot still spot ACORNSCSI_CONSTANTS as a potential
issue?
Paul Bolle
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
th
ied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + */
> +
> +#include
> +#include
> +#include
> +#include
This header is not included in linux-next so manually building
ufs-qcom-ice.o isn&
tification (used to match it with a driver).
> * @config: the configuration ops for this device.
Paul Bolle
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
The Kconfig symbols SCSI_TGT and SCSI_FC_TGT_ATTRS are unused since
commit 73685a458f2e ("tgt: removal"). Setting them has no effect. Remove
these symbols.
Signed-off-by: Paul Bolle
---
Tested by running "make oldconfig" on a Fedora 20 based .config.
That .config has CONFI
ies for SCSI_TGT and SCSI_FC_TGT_ATTRS untouched.
1) Both SCSI_TGT and SCSI_FC_TGT_ATTRS appear to be unused after that
commit. Is a patch to remove their Kconfig entries queued somewhere?
Paul Bolle
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
t
should edit a
header file and set related preprocessor macros. Since this is actually
a documented feature those related macros remain available.
Signed-off-by: Paul Bolle
---
Untested.
Note that the documentation still contains
insmod ncr53c8xx
Besides insmod being outdated, the modules
The code for immediate arbitration was removed from (what looks like a
predecessor of) the ncr53c8xx code in v2.6.0. Remove its remnants now.
Signed-off-by: Paul Bolle
---
Untested.
Documentation/scsi/ncr53c8xx.txt | 52
drivers/scsi/ncr53c8xx.c
The code for integrity checking was removed in v2.6.10. Remove its
remnants now.
Signed-off-by: Paul Bolle
---
Untested.
drivers/scsi/ncr53c8xx.h | 8
1 file changed, 8 deletions(-)
diff --git a/drivers/scsi/ncr53c8xx.h b/drivers/scsi/ncr53c8xx.h
index 0e008dacf679..736a9df68d58
On Sun, 2014-05-25 at 11:42 +0400, James Bottomley wrote:
> On Sat, 2014-05-24 at 15:16 +0200, Paul Bolle wrote:
> > On Sat, 2014-05-24 at 16:13 +0400, James Bottomley wrote:
> > > Wait, no, that's not a good idea. We leave obsolete drivers to bitrot.
> > > Parti
qlt_check_srr_debug() was added in v3.5. It is a stub function unless
CONFIG_QLA_TGT_DEBUG_SRR is defined. But CONFIG_QLA_TGT_DEBUG_SRR will
never be defined, because the Kconfig symbol QLA_TGT_DEBUG_SRR was never
added to the tree.
Signed-off-by: Paul Bolle
---
Compile tested.
Or was it
maybe I just never ran into that category in other
subsystems.
> However, I'll do this if the Maintainer (rmk) acks ... because if it
> breaks he gets to fix it.
Paul Bolle
[1] advansys prints a pointless compile time warning, on purpose.
Clearly no one cares about its "wide board
> This is an automatically generated Delivery Status Notification.
>
> Delivery to the following recipients failed.
>
>dc3...@twibble.org
Anyone else seeing this too?
Paul Bolle
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
This driver has always contained a check for
CONFIG_SCSI_DC395x_TRMS1040_TRADMAP. But a Kconfig symbol
SCSI_DC395x_TRMS1040_TRADMAP was never added to the tree. Besides, the
code that this check hides can't compile, since "geom" is never defined.
Remove it.
Signed-off-by: Paul Bol
possible to set SCSI_ACORNSCSI_LINK through
kconfig, or its predecessors, in the first place.
Let's remove the code involved.
Signed-off-by: Paul Bolle
---
Untested.
Also interesting: SCSI_ACORNSCSI_TAGGED_QUEUE can be set through
kconfig, but its macro will be #undef-ed at the top of acornscsi
rwarded to this recipient’s new
> Avago email account.
It seems lsi.com addresses in MAINTAINERS should be be updated.
Paul Bolle
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo inf
A check for CONFIG_FUSION_MAX_FC_SGE was added in v2.6.31. But the
related Kconfig symbol was never added to the tree. Remove this check,
as it always evaluates to false.
Signed-off-by: Paul Bolle
---
Compile tested only.
drivers/message/fusion/mptbase.h | 10 --
1 file changed, 10
re
> appropriate way to report these issues (e.g. bug tracker.)
I tried a few times to fix this warning.
In the end I just asked Fedora to disable aic94xx in their kernel builds
(which they did for Rawhide, their development branch). See
https://lists.fedoraproject.org/pipermail/kernel/2014-Jan
.
This small series does both.
Paul Bolle (2):
advansys: change buildtime warning into runtime error
MAINTAINERS: mark Advansys Orphan
CREDITS | 2 +-
MAINTAINERS | 3 +--
drivers/scsi/advansys.c | 2 +-
3 files changed, 3 insertions(+), 4 deletions(-)
--
1.8.5.
Matthew Wilcox hasn't touched the Advansys driver since v2.6.29. I have
not been able to get Matthew to respond to a trivial patch I'd like to
see go in. Mark this driver Orphan and add this driver to Matthew's
CREDITS entry.
Signed-off-by: Paul Bolle
---
CREDITS | 2 +-
work. So let's change the buildtime warning into a runtime error,
only printed for those wide boards. Perhaps that might push the people
using those wide boards to convert this driver. And for all others
there's now one less buildtime warning to ignore.
Signed-off-by: Paul Bolle
---
Compil
ine) helper function we can reorganize the
code a bit. That also allows to drop alua_ascq which, obviously, gets
rid of this warning.
Signed-off-by: Paul Bolle
---
v2: Make core_alua_state_nonoptimized() return void, as Geert
suggested.
Also keep core_alua_state_lba_dependent() inline. Setting t
, inside a while loop.
But if we add a small (inline) helper function we can reorganize the
code a bit. That also allows to drop alua_ascq which, obviously, gets
rid of this warning.
Signed-off-by: Paul Bolle
---
drivers/target/target_core_alua.c | 94 ++-
1
On Wed, 2014-02-19 at 10:59 +0100, Geert Uytterhoeven wrote:
> On Wed, Feb 19, 2014 at 10:52 AM, Paul Bolle wrote:
> > - ret = core_alua_state_nonoptimized(cmd, cdb,
> > - nonop_delay_ms
ldn't break the narrow
boards. (I happen to own neither a narrow nor a wide board.)
In seven years that buildtime warning has not resulted in a fix for wide
boards, has it? So at this point that warning is rather pointless.
Is anybody even using these wide boards?
Paul Bolle
--
To unsub
On Tue, 2013-01-29 at 11:20 +0100, Paul Bolle wrote:
> On Mon, 2012-11-05 at 11:58 +0100, Paul Bolle wrote:
> > Building advansys.o triggers this warning:
> > drivers/scsi/advansys.c:71:2: warning: #warning this driver is still
> > not properly converted to the DMA API
(Eddie was added as maintainer a few months ago, so Eddie receives this
message too.)
On Wed, 2012-06-27 at 21:26 +0200, Paul Bolle wrote:
> During each suspend and resume cycle a mysterious message is added to
> the logs:
> CPU 1 offline: Remove Rx thread
>
> Some grepp
On Fri, 2013-09-20 at 23:32 +0900, Akinobu Mita wrote:
> Yesterday, I sent a patch set which includes two fixes for this issue.
> I wish this to be merged and I'll do my best.
I hadn't yet stumbled onto these patches. Thanks!
Paul Bolle
--
To unsubscribe from this lis
On Thu, 2013-08-22 at 23:49 +0900, Akinobu Mita wrote:
> 2013/8/22 James Bottomley :
> > On Thu, 2013-08-22 at 21:42 +0900, Akinobu Mita wrote:
> >> Unfortunately, this warning isn't fixed in linux-next, either.
> >> Paul Bolle also sent a patch that fixes the s
build[2].
And now that driver is disabled in all kernels that Fedora currently
ships. I'm not familiar with any complaints about this decision.
Paul Bolle
[1] https://lists.fedoraproject.org/pipermail/kernel/2013-February/004102.html
[2]
http://pkgs.fedor
ot be used uninitialized.
Signed-off-by: Paul Bolle
---
0) v2: much simpler, and doesn't change any behavior;
v3: mention commit bebe40ea42b, as Akinobu suggested.
1) Still only compile tested.
drivers/scsi/scsi_debug.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff
it a v3, with a commit explanation that
also has one or two lines that mention commit beb40ea42b ("[SCSI]
scsi_debug: reduce duplication between prot_verify_read and
prot_verify_write")?
Paul Bolle
--
To unsubscribe from this list: send the line "unsubscribe linux-scs
dif_compute_csum() to a straightforward if/else statement we supply GCC
with enough information to determine that csum will not be used
uninitialized.
Signed-off-by: Paul Bolle
---
0) v2 because I started to worry whether v1 would change an interface
(ie, the way the "guard" module paramet
supply GCC with enough information to determine that csum will not be
used uninitialized. It also allows for a minor cleanup.
Signed-off-by: Paul Bolle
---
0) Compile tested only.
1) This warning is apparently introduced in v3.11-rc1 by commit beb40ea42b
("[SCSI] scsi_debug: reduce duplic
ift count >= width of
type [enabled by default]
These warnings are caused by a right shift of 32. Use upper_32_bits() to
suppress them.
Signed-off-by: Paul Bolle
---
0) Instead of a cast to u64, this version uses upper_32_bits() as James
suggested. I also stopped changing 0L to 0UL, because
On Wed, 2013-02-20 at 10:40 +, James Bottomley wrote:
> On Sat, 2013-02-09 at 21:09 +0100, Paul Bolle wrote:
> > --- a/drivers/scsi/aacraid/src.c
> > +++ b/drivers/scsi/aacraid/src.c
> > @@ -407,7 +407,7 @@ static int aac_src_deliver_message(struct fib *fib)
> >
ift count >= width of
type [enabled by default]
Silence these warnings by casting the 'address' variable (of type
dma_addr_t) to u64 on those two lines.
Signed-off-by: Paul Bolle
---
0) Compile tested only.
1) Changing '0L' to 'OUL' might be a bit of cargo cult
On Wed, 2013-01-30 at 08:07 +, Saurav Kashyap wrote:
> I am submitting some correction patches today and this patch will be part
> of the scsi-misc submission after that set.
Thanks.
Paul Bolle
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi"
On Mon, 2012-11-05 at 11:58 +0100, Paul Bolle wrote:
> Building advansys.o triggers this warning:
> drivers/scsi/advansys.c:71:2: warning: #warning this driver is still not
> properly converted to the DMA API [-Wcpp]
>
> This warning can be traced back to a patch called
On Mon, 2012-10-29 at 13:45 +0100, Paul Bolle wrote:
> On Mon, 2012-10-29 at 12:17 +, James Bottomley wrote:
> > mvsas has a maintainer: poke them harder
>
> According to MAINTAINERS that's you. Is Xiangliang Yu perhaps the actual
> maintainer?
Building the mvsas dr
array bounds [-Warray-bounds]
This patch was originally posted to silence two GCC warnings while
building v3.6-rc7. Basically identical warnings can still be seen while
building v3.8-rc5. What's the status of this patch?
Paul Bolle
--
To unsubscribe from this list: send the line "unsu
On Thu, 2013-01-24 at 01:07 +0900, Kouichi ONO wrote:
> At target_fabric_port_link(), struct se_device *dev is used before set?
It seems the (stable specific) patch in
http://article.gmane.org/gmane.linux.kernel.stable/40880 should fix
that.
Paul Bolle
--
To unsubscribe from this list: s
work. So let's change the buildtime warning into a runtime error,
only printed for those wide boards. Perhaps that might push the people
using those wide boards to convert this driver. And for all others
there's now one less buildtime warning to ignore.
Signed-off-by: Paul Bolle
---
Compil
> maintainerless, so it will depend on someone finding the time to test.
Thanks,
Paul Bolle
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, 2012-09-25 at 14:07 +0200, Paul Bolle wrote:
> Compiling aic94xx_sds.o (part of the aic94xx driver) triggers this GCC
> warning:
> drivers/scsi/aic94xx/aic94xx_sds.c: In function 'asd_read_flash':
> drivers/scsi/aic94xx/aic94xx_sds.c:597:21: warni
On Fri, 2012-09-21 at 14:11 +0200, Paul Bolle wrote:
> Building the mvsas driver triggers these GCC warnings:
> drivers/scsi/mvsas/mv_sas.c:1156:34: warning: comparison between 'enum
> sas_device_type' and 'enum sas_dev_type' [-Wenum-compare]
> drivers/scsi
On Fri, 2012-09-21 at 11:28 +0200, Paul Bolle wrote:
> Building the aic7xxx_old driver triggers these GCC warnings:
> drivers/scsi/aic7xxx_old.c:7901:5: warning: case value '257' not in
> enumerated type 'ahc_chip' [-Wswitch]
> drivers/scsi/aic7xxx_old.c:
nough information to keep track
of array bounds.
Signed-off-by: Paul Bolle
---
0) Updated for Saurav's request to use strncpy().
1) Still only compile tested.
drivers/scsi/qla2xxx/qla_def.h | 1 +
drivers/scsi/qla2xxx/qla_gs.c | 8
2 files changed, 5 insertions(+), 4 deletions(-)
di
on to keep track of
array bounds.
Signed-off-by: Paul Bolle
---
0) Rolf suggested to not use magic constants, to make sure things keep
working when these strings change in the future. A trivial solution is
to use preprocessor macros. I needed to add one for the manufacturer
string.
1) Still only co
here is the length
of the string, including its NUL terminator, rounded up to the next
multiple of four.
Signed-off-by: Paul Bolle
---
0) I noticed this warning while building v3.6-rc7 on current Fedora
17, using Fedora's default config.
1) Compile tested only.
drivers/scsi/qla2xxx/qla
all (and all other unneeded code) after
creating that section.
Signed-off-by: Paul Bolle
---
0) I noticed this warning while building v3.6-rc7 on current Fedora
17, using Fedora's default config.
1) Compile tested only. It might be best to run test this too, if only
to test whether the non
as_device_type' and 'enum sas_dev_type' [-Wenum-compare]
Silence these warnings by using the named constants from enum
sas_device_type with the same value as the currently used named
constants.
Signed-off-by: Paul Bolle
---
0) I noticed these warnings while building v3.6-rc6 on current
warnings by adopting the idiom used elsewhere in this driver.
Since AHC_EISA and AHC_VL are only ever set for AHC_AIC7770 this fix
should not lead to any functional change.
Signed-off-by: Paul Bolle
---
0) I noticed these warnings while building v3.6-rc6 on current Fedora
17, using Fedora's
60 matches
Mail list logo
