-on card, but plenty of USB headers
available on the mainboard. Similarly, some NASes have their operating
system located on a USB-attached device. Small offices use USB-attached
disks for backup and won't detach such a disk until rotation for off-site
deposit. Not to mention embedded compu
On Jun 26 James Bottomley wrote:
> On Fri, 2015-06-26 at 11:43 +0200, Stefan Richter wrote:
> > On Jun 22 James Bottomley wrote:
[...]
> > > Perhaps it might be wise to do this to every USB device ... for external
> > > devices, the small performance gain doe
On Dec 02 2012 Stefan Richter wrote:
> On Nov 26 Martin K. Petersen wrote:
> > >>>>> "Stefan" == Stefan Richter writes:
> > Stefan> I did not try "sg_write_same" on any of the devices; but since
> > Stefan> the two SPC-3 devices are
DES",
it is not required to blacklist WRITE SAME.
Bring the feature back by reverting the sbp2.c hunk of commit 54b2b50c20a6.
Signed-off-by: Stefan Richter
Cc: sta...@kernel.org
---
drivers/firewire/sbp2.c | 1 -
1 file changed, 1 deletion(-)
--- a/drivers/firewire/sbp2.c
+++ b/drivers/firewi
On Dec 16 Douglas Gilbert wrote:
> On 13-12-15 09:52 AM, Stefan Richter wrote:
> > On Dec 02 2012 Stefan Richter wrote:
> >> Of course it remains to be seen what happens with ATA TRIM enabled SSDs
> >> behind the newer SPC-3 compliant bridges, but at this time the ris
te the users to set the
> ->workfn fields instead of overriding work functions using
> PREPARE_DELAYED_WORK().
>
> It would probably be best to route this with other related updates
> through the workqueue tree.
>
> Compile tested.
>
> Signed-off-by: Tejun Heo
> Cc: Ste
So rather than deadlock, "the UNLOCK would simply complete". But
/why/ does it complete? It is left unclear (to me at least), why
it would do so. IOW, what mechanism will make it always proceed
to the UNLOCK? Without knowing that, it is left entirely unclear
(to me) why the dea
only the first of these two alternatives can
> +occur.
^^^
...these {,three} alternatives...
--
Stefan Richter
-=-- --=- ==---
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of
On Jan 23 Bart Van Assche wrote:
> The SCSI core never sets sc_data_direction to DMA_BIDIRECTIONAL.
>
> Signed-off-by: Bart Van Assche
> Cc: Stefan Richter
> ---
> drivers/firewire/sbp2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git
ther there are potential issues with these
bridges, but to me your problem looks like it happens on a lot higher
level (i.e. transport protocol and how the buggy PL-3507 firmware handles
it).
>
> * versions of libraries (libraw1394...), application or utility (if
> applicable)
no_write_same blacklist
flags so that these commands can be used on respectively capable
targets. I guess the Linux sbp-target could be such a target.
Signed-off-by: Stefan Richter
---
drivers/firewire/sbp2.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/firewire/sbp2.c b/dr
On Nov 26 Martin K. Petersen wrote:
> >>>>> "Stefan" == Stefan Richter writes:
> Stefan> I did not try "sg_write_same" on any of the devices; but since
> Stefan> the two SPC-3 devices are correctly identified as "fully
> S
y this weekend. I'll try to get the patch sent
> > out today.
> >
>
> Have you sent ?
>
> I am already in linux-scsi@vger.kernel.org mailing list, but it seems
> not find your patch.
It was posted at target-devel:
http://thread.gmane.org/gmane.linux.scsi.target.d
whether I can do some tests tomorrow. I can easily test master
and slave PATA drives on a single cable behind a PATA-to-1394 bridge; but
testing two drives on a single cable behind a PATA-to-PCI controller would
be a bit more involved because the case of my PATA-equipped Linux PC is
rath
On 27 Sep, Stefan Rutzinger wrote:
> On Wed, 26 Sep 2007, Stefan Richter wrote:
>> By the way, in addition to the 8 bytes offset which you found, there is
>> also a difference in the reported disk size. The USB firmware says
>> 390721969 sectors, the FireWire firmware says 39
e is out for a fight rather than
interested in help.
--
Stefan Richter
-=-=-=== =-=- -===-
http://arcgraph.de/sr/
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
SBP-2 is a SCSI transport protocol, hence ieee1394/sbp2
and firewire/fw-sbp2 are Linux SCSI low-level drivers. Anything else
would be just wrong and infeasible in this particular case.
--
Stefan Richter
-=-=-=== =-=- -
http://arcgraph.de/sr/
-
To unsubscribe from this list: send the line &q
-0 - a USB CD-ROM,
/dev/st-fw-0- a FireWire tape drive,
/dev/sda- a device whose transport driver didn't propose a name
Of course the really interesting names will still be provided by
udev-generated symlinks.
--
Stefan Richter
-=-=-=== =-=- -
http://arcgraph.de/sr/
-
To un
[EMAIL PROTECTED] wrote:
> On Mon, 15 Oct 2007, Stefan Richter wrote:
>> Low-level networking drivers suggest a default interface name (per
>> interface or as a template like eth%d into which the networking core
>> inserts a lowest spare number).
...
>> Could low-level S
driver make use of the new naming functions in
lib/, providing either just "sd", "sr" etc. or "sd-$transport-" as
name prefix
No patch yet, and alas I'm currently short of spare time.
--
Stefan Richter
-=-=-=== =-=- =
http://arcgraph.de/sr
ose once PATA went into the SCSI namespace and then this namespace
is divided again, it's not a big issue anymore whether PATA and SATA
share an ATA namespace or are distinct, except perhaps for people with
IDE drive and eSATA slots.
--
Stefan Richter
-=-=-=== =-=- =
http://arcgraph.de/
iding speaking default
names for device files, just like we already provide speaking default
names for network interfaces. (Not for all, but for many.)
--
Stefan Richter
-=-=-=== =-=- =
http://arcgraph.de/sr/
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi"
in common.
The only thing that could be common in the best case is the symlink to
the partition's device file, based on filesystem UUID or filesystem label.
¹) unless you write your own rule specific to this on particular enclosure
--
Stefan Richter
-=-=-=== =-=- =---=
http://arcgra
ed int scsi_transfer_size(struct scsi_cmnd *cmd)
> +{
> + struct request *req = cmd->request;
Whitespace police says: Here goes a blank line.
> + if (req->cmd_type == REQ_TYPE_BLOCK_PC)
> + return req->data_len;
> + return cmd->device->sect
uld be documented on their own. They're basically service
> libraries and sysfs export helpers for drivers.
^^^
(Rob, in case it's not already clear from context, James is referring
with "drivers" only to low-le
marc.info/?l=linux-scsi&m=114279682717770
--
Stefan Richter
-=-=-=== =-=- ==-=-
http://arcgraph.de/sr/
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Rob Landley wrote:
> drivers/scsi/scsi.c | 181 -
Also have a look at this:
"Fix a few misleading comments in scsi.c"
http://marc.info/?l=linux-scsi&m=119340708627893
"scsi.c: fix some typos in comments"
http://marc.info/?l=linux-scsi&a
ed.
How about this:
int (*is_visible)(...);
or
bool (*shall_be_shown)(...);
or
bool (*should_be_displayed)(...);
or whatever, so that it indicates that this function merely answers a
question, but doesn't filter nor show anything.
--
Stefan Richter
-=-=-===
James Bottomley wrote:
> OK, so is this latest revision acceptable to everyone?
No complaint from me. (I'm more or less by accident in this thread
anyway. Once this feature is available in mainline, I may have use for
it in drivers/firewire/ though.) Thanks,
--
Stefan
urn the meaning of the callback
> around?
>
> for (...) {
> if (grp->mask_out && grp->mask_out(kobj, *attr, i))
> continue;
> error |= sysfs_add_file(...);
> }
if (!grp->is_visible ||
grp->is_visib
Cornelia Huck wrote:
> On Wed, 31 Oct 2007 10:52:35 +0100,
> Stefan Richter <[EMAIL PROTECTED]> wrote:
>> if (!grp->is_visible ||
>> grp->is_visible(kobj, *attr, i))
>> add or remove();
>>
Signed-off-by: Stefan Richter <[EMAIL PROTECTED]>
---
drivers/firewire/fw-sbp2.c |7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
Index: linux/drivers/firewire/fw-sbp2.c
===
--- linux.orig/drivers/firewire/fw-
Signed-off-by: Stefan Richter <[EMAIL PROTECTED]>
---
drivers/ieee1394/sbp2.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Index: linux/drivers/ieee1394/sbp2.c
===
--- linux.orig/drivers/ieee1394/sbp2.c
+++
Replace sg->length by sg_dma_len(sg). Rename a variable for shorter
line lengths and eliminate some superfluous local variables.
Signed-off-by: Stefan Richter <[EMAIL PROTECTED]>
---
drivers/ieee1394/sbp2.c | 26 --
1 file changed, 12 insertions(+), 14
/ll_rw_blk.c::blk_queue_max_sectors().
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=block/ll_rw_blk.c;h=75c98d58f4ddf7252e2717e0924b9d6a8925b4e5#l590
--
Stefan Richter
-=-=-=== =-== --==-
http://arcgraph.de/sr/
-
To unsubscribe from this list: send the line "
ctors
trickles through the layers via LXR:
http://lxr.free-electrons.com/ident?i=max_sectors
(Not all of the LXR sites out there support search for struct members
but free-electrons' does.)
--
Stefan Richter
-=-=-=== =-== --===
http://arcgraph.de/sr/
-
To unsubscribe from this list: send th
SCAN and let any driver which is integrated with it select it.
(Not that I'm a friend of select, but here is a case where it won't hurt
too much.)
--
Stefan Richter
-=-=-=== ==-- -=---
http://arcgraph.de/sr/
-
To unsubscribe from this list: send the line "unsubscribe lin
. Fw-sbp2 only remains faster
on 1394a buses due to fw-core's gap count optimization.
Signed-off-by: Stefan Richter <[EMAIL PROTECTED]>
---
drivers/ieee1394/sbp2.c | 26 +++---
drivers/ieee1394/sbp2.h |1 -
2 files changed, 15 insertions(+), 12 deletions(-)
I
ndeed be dedicated FCoE HBAs in the future, the
following stack could exist in addition to the one above:
- SCSI core,
scsi_transport_fc
- FCoE HBA driver(s)
--
Stefan Richter
-=-==--- ---= --=--
http://arcgraph.de/sr/
-
To unsubscribe from this list: send the line "unsubscribe linu
ents, instead of struct
fc_xyz * arguments.)
²) I'm using the term interconnect from the SCSI perspective, not from
the FC perspective.
--
Stefan Richter
-=-==--- ---= --=-=
http://arcgraph.de/sr/
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Stefan Richter wrote:
> The interconnect layer could be split further:
> SCSI command set layer -- SCSI core -- SCSI transport layer (FCP) --
> Fibre Channel core -- Fibre Channel card drivers, FCoE drivers.
>
> But this would only really make sense if anybody would implement
&g
Stefan Richter wrote:
> I.e. you have SCSI command set layer -- SCSI core -- SCSI transport
> layer -- interconnect layer.
The interconnect layer could be split further:
SCSI command set layer -- SCSI core -- SCSI transport layer (FCP) --
Fibre Channel core -- Fibre Channel card drivers
t;
You don't need the second line because it says the same as the first
line. Either kill it, or replace it by an explanation _why_ the
semaphore is to be replaced by mutex. (I guess you do it because they
are lighter-weight, both in semantics and in implementation, and because
there ar
t iterations. But this would complicate the API because of the
additional locking requirements, and hence would invariably result in
buggy usages of the API.
--
Stefan Richter
-=-==--- ---= --===
http://arcgraph.de/sr/
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi&q
vitable.
I agree. Sem2mutex conversion should not be mixed with API conversion,
even if one or both seem trivial.
--
Stefan Richter
-=-==--- ---= --===
http://arcgraph.de/sr/
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Greg KH wrote:
> On Mon, Jan 07, 2008 at 02:23:33PM +0100, Stefan Richter wrote:
>> David Brownell wrote:
>> > On Monday 07 January 2008, Greg KH wrote:
>> >> Most of the non-driver core code should be converted to not use the
>> >> lock in the class at
t all like to see a respective workaround added to the sbp2
driver. Sbp2 is a transport layer which does not touch commands. Maybe
an in-kernel workaround would be considered by whoever maintains the
point where that extra INQUIRY is injected (via sd or sg, I don't know
which).
--
Stefan Richter
-==
utosuspend method has been called again.
> * Return 0 if the resume was successful, otherwise a negative
> * error code.
Who prevents them? The autoresume() implementation, or its caller?
--
Stefan Richter
-=-==--- ---= -=---
http://arcgraph.de/sr/
-
To unsubscribe from thi
ke
such a filtering, leave the workaround to userspace. And the latter is
IMO most preferrable, like James already wrote: Don't let hald issue
INQUIRY in the first place.
--
Stefan Richter
-=-==--- ---= -=---
http://arcgraph.de/sr/
-
To unsubscribe from this list: send the line "
users definitely never had that
problem. The "select SCSI" in libata's Kconfig option is not of great
help with that issue and is misguided and unnecessary as well.
--
Stefan Richter
-=-==--- ---= -=--=
http://arcgraph.de/sr/
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Stefan Richter wrote:
>>> On Wed, 2008-01-09 at 09:21 -0800, Jon Watte wrote:
>>> > I wonder if it's possible to magically turn that on when selecting
>>> > AHCI support in menuconfig? That way, it'd be harder for someone else
>>> > t
Stefan Richter wrote:
> The "select SCSI" in libata's Kconfig option is not of great
> help with that issue and is misguided and unnecessary as well.
+comment "Serial and Parallel ATA need SCSI command sets"
+ depends on SCSI=n
menuconfig ATA
texts and prompts aren't changed¹ to say what they really do, your
BLK_DEV_ATA_SD and BLK_DEV_ATA_SR are actually very nice to have.
---
¹) No patch attached. I posted something a while ago.
--
Stefan Richter
-=-==--- ---= -=--=
http://arcgraph.de/sr/
-
To unsubscribe from this list: s
Andi Kleen wrote:
> On Wed, Jan 09, 2008 at 10:41:59PM +0100, Stefan Richter wrote:
>> However, this further obfuscates the fact that libata uses Linux' SCSI
>> midlayer and highlevel. Which is a bad thing. For example, there are
>
> People are not interested in
Stefan Richter wrote:
> The Kconfig menu layouts, prompts, and help texts are there to inform/
> "educate"/ guide the user when configuring the build environment, with
> the goal that he safely and efficiently gets to a working software
> configuration.
It might have been n
Andi Kleen wrote:
> On Thu, Jan 10, 2008 at 12:03:59AM +0100, Stefan Richter wrote:
>>> Kconfig is also not an educational facility or high level
>>> design description of the code, but a pragmatic tool to get the job
>>> done.
>> I did not talk about educati
mutex_lock(&class->mutex);
> + list_for_each_entry(dev, &class->children, node)
> + if (match(dev, data) && class_device_get(dev))
> + break;
> + mutex_unlock(&class->mutex);
> +
> + return dev;
> +}
Here too?
--
Stefan
commands during that time at all.
The time from bus reset to successful reconnect is typically circa a
second, on bigger buses with lots of protocol activity after bus reset
perhaps a few seconds. (Could IMO still be optimized, in both of the
drivers/ieee1394 and drivers/firewire implementations.)
-
you can tell the SCSI core driver at boot time (or module
insertion time) and/or at runtime to
- switch on default quirk flags,
- add quirk flags for selected devices per name matching.
Alas I don't know of a good documention how to do either of this, and I
am not familiar enough with the
Bill Adair wrote:
> Is there any way under Linux of forcing use of the sd driver for a
> device on the bus instead of sg?
The INQUIRY data which the SCSI core gets from the device have to
indicate that the device implements SBC or RBC (is of peripheral device
type 00h or 0Eh).
--
Stefan R
Signed-off-by: Stefan Richter <[EMAIL PROTECTED]>
---
Replacement of patch "firewire: fw-sbp2: enable s/g chaining".
It's the same, minus '+ .use_sg_chaining = ENABLE_SG_CHAINING,' hunk
to prevent conflicts when James is going to remove .use_sg_chaining.
dr
Signed-off-by: Stefan Richter <[EMAIL PROTECTED]>
---
Replacement of patch "ieee1394: sbp2: enable s/g chaining".
It's the same, minus '+ .use_sg_chaining = ENABLE_SG_CHAINING,' hunk
to prevent conflicts when James is going to remove .use_sg_chaining.
driver
Stefan Richter wrote:
>> drivers/firewire/fw-sbp2.c |7 ---
>> 1 file changed, 4 insertions(+), 3 deletions(-)
> drivers/ieee1394/sbp2.c |3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Never mind the diffstats. I forgot to refresh them.
Perhaps from a kmem_cache.
>
> List of drivers/files:
> drivers/firewire/fw-sbp2.c
> drivers/ieee1394/sbp2.[ch]
>
> Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]>
Acked-by: Stefan Richter <[EMAIL PROTECTED]>
> ---
> drivers/firewire/fw-sbp2.c
Boaz Harrosh wrote:
> Those that meant SG_ALL == 255:
>
> [PATCH 1/8] firewire: ieee1394: Move away from SG_ALL
They simply mean SG_ALL == something, as long as it isn't unreasonably
small or large.
--
Stefan Richter
-=-==--- ---= =---=
http://arcgraph.de/sr/
-
To unsubsc
Stefan Richter wrote:
> My guess is that there won't be conflicts of this with linux1394-2.6.git
> anytime soon, so taking it into any other tree should be fine.
Wrong, there should already be a (trivial) conflict due to a patch from
December. Another (trivially) conflicting patch
We need to do something there, because this situation is not
too unusual (e.g. when several FireWire devices are being powered up
together).
I will proceed to experiment with this as spare time permits. Of course
any advice on how to best interact with the SCSI core while the
tra
t; scsi-bidi-2.6.git tree. That one's built on top of all the currently
> conflicting trees, and is scheduled to be the last thing merged in the
> merge window (or at least to wait until the others its built on have
> gone in).
Good, everything should come together nicely then.
--
Stef
Stefan Richter wrote:
> However, the first thing I shall try is to insert a "return
> SCSI_MLQUEUE_HOST_BUSY" early in sbp2_scsi_queuecommand, depending on a
> check of the logical unit's generation.
Doesn't help. Even worse, it's deadlocky.
--
Stefan Ri
FUJITA Tomonori wrote:
> On Tue, 15 Jan 2008 21:10:50 +0100 (CET)
> Stefan Richter <[EMAIL PROTECTED]> wrote:
>> +++ linux/drivers/firewire/fw-sbp2.c
>> @@ -1107,9 +1107,9 @@ sbp2_map_scatterlist(struct sbp2_command
>> * elements larger than 65535 bytes, som
t's what I wrote down on a piece of paper a long time ago; don't ask
me what it means in detail. :-)
--
Stefan Richter
-=-==--- ---= =-=--
http://arcgraph.de/sr/
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [EMAIL PR
xisting similar functions in
scsi_device.h which don't have expressive names.
--
Stefan Richter
-=-==--- ---= =-=--
http://arcgraph.de/sr/
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
on-buggy ones. The only cost of this workaround is
(1.) the code, (2.) the runtime/ bandwidth/ latency overhead for
accesses which reach the last sector.
Somebody correct me if I got something wrong.
--
Stefan Richter
-=-==--- ---= ==---
http://arcgraph.de/sr/
-
To unsubscribe from
ce for the new flag. No
wonder that it is confused with the (well named) "fix_capacity" flag.
How about "read_last_sector_separately" or something in the way?
--
Stefan Richter
-=-==--- ---= ==---
http://arcgraph.de/sr/
-
To unsubscribe from this list: send the line &q
5 files changed, 34 insertions(+), 11 deletions(-)
No, FireWire only requires 4 bytes alignment.
I will channel a reversion of the firewire and ieee1394 hunks through
linux1394-2.6.git for 2.6.26.
--
Stefan Richter
-=-==--- ---= ==-=-
http://arcgraph.de/sr/
-
To unsubscribe from this list: send th
Signed-off-by: Stefan Richter <[EMAIL PROTECTED]>
---
Not run-time tested yet.
drivers/firewire/fw-sbp2.c |7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
Index: linux-2.6.24-git3/drivers/firewire/fw-
Signed-off-by: Stefan Richter <[EMAIL PROTECTED]>
---
Not run-time tested yet.
drivers/ieee1394/sbp2.c |7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
Index: linux-2.6.24-git3/drivers/ieee1394/sbp2.c
===
---
i_Host for each target. Hence there are difficulties
with targets with multiple logical units, but I probably got them sorted
out now.
There remain frequent problems with reconnection + re-login failures
though. These failures don't happen with exactly the same bus topology
if I don'
itten in-place in sbp2_status. But I don't know if this
is a worthwhile optimization; it would reduce readability.
--
Stefan Richter
-=-==--- --=- --=--
http://arcgraph.de/sr/
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
e will never be more than one INQUIRY sent. They
start to return garbled data or crash if they get a second INQUIRY.
--
Stefan Richter
-=-==--- --=- --===
http://arcgraph.de/sr/
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [EMAIL
(adding Cc linux-hotplug)
James Bottomley wrote:
> On Thu, 2008-02-07 at 11:08 +0100, Stefan Richter wrote:
>> Mike Anderson wrote:
>> > A number of user apps like lvm scanning that execute media access commands
>> > already have filter capability to filter device
e non-udev distros slowly went out of fashion on the desktop, there
was a certain frequency of reports of the latter kind of FireWire
devices, but this was before I became aware of that kind of firmware
bug, therefore I don't have any data whether it played a role for these
cases.
--
Stefan Ri
(Adding Cc: LSML)
Jarod Wilson wrote:
> On Wednesday 06 February 2008 04:09:47 pm Stefan Richter wrote:
>> take care that __scsi_add_device does not return success
>> even though the SCSI high-level driver probing failed (sd READ_CAPACITY
>> and friends) due to bus reset.
Date:
From: Stefan Richter <[EMAIL PROTECTED]>
Subject: firewire: fw-sbp2: enforce a retry of __scsi_add_device if bus
generation changed
fw-sbp2 is unable to reconnect while performing __scsi_add_device
because there is only a single workqueue thread context available for
both at the
se
> and all that good stuff.
FYI, I now committed this patch to linux1394-2.6.git after folding patch
"firewire: fw-sbp2: retry login if scsi_device was offlined early" into it.
--
Stefan Richter
-=-==--- --=- =
http://arcgraph.de/sr/
-
To unsubscribe from this list: send the li
Fix a kernel bug when running rescan-scsi-bus while a FireWire disk is
connected: http://bugzilla.kernel.org/show_bug.cgi?id=10008
Signed-off-by: Stefan Richter <[EMAIL PROTECTED]>
---
drivers/firewire/fw-sbp2.c |4
1 file changed, 4 insertions(+)
Index: linux/drivers/firewire/f
rescan-scsi-bus used to add SBP-2 targets which weren't there.
Signed-off-by: Stefan Richter <[EMAIL PROTECTED]>
---
drivers/ieee1394/sbp2.c |3 +++
1 file changed, 3 insertions(+)
Index: linux/drivers/ieee
On 17 Feb, Stefan Richter wrote:
> Fix a kernel bug when running rescan-scsi-bus while a FireWire disk is
> connected: http://bugzilla.kernel.org/show_bug.cgi?id=10008
>
> Signed-off-by: Stefan Richter <[EMAIL PROTECTED]>
> ---
> drivers/firewire/fw-sbp2.c |4 +
James Bottomley wrote:
> On Sun, 2008-02-17 at 14:57 +0100, Stefan Richter wrote:
>> rescan-scsi-bus used to add SBP-2 targets which weren't there.
...
>> +++ linux/drivers/ieee1394/sbp2.c
>> @@ -1974,6 +1974,9 @@ static int sbp2scsi_slave_alloc(struct s
>> {
>
c
> [] ? :firewire_sbp2:sbp2_remove+0x10/0x14
...
> ---[ end trace 2a9c61e9883e29d2 ]---
>
Fix a kernel bug when unplugging an SBP-2 device after having its
scsi_device already removed via the "delete" sysfs attribute.
Signed-off-by: Stefan Richter <[EMAIL PROTECTED
>> On Sun, 2008-02-17 at 14:57 +0100, Stefan Richter wrote:
>>> rescan-scsi-bus used to add SBP-2 targets which weren't there.
PS: It probably wasn't clear: rescan-scsi-bus.sh is *not* necessary
for sbp2 (under Linux 2.6, that is). The patch merely prevents weird
thi
Fix a kernel bug when unplugging an SBP-2 device after having its
scsi_device already removed via the "delete" sysfs attribute.
Signed-off-by: Stefan Richter <[EMAIL PROTECTED]>
---
Update: A _put was missing in a failure path.
drivers/firewire/fw-sbp2.c |8
1
ther testing for
INQUIRY_data.VERSION >= something is a sufficiently safe test.
> 2. if 16-byte CDBs are supported, then use them; only drop down to 10-byte
> CDBs if 16-byte CDBs are unavailable. Don't make the decision by comparing
> the LBA on every IO.
--
Stefan Richter
On Nov 11 Stefan Richter wrote:
> On Nov 09 Elliott, Robert (Server Storage) wrote:
> > I recommend broadening this patch. T10 is discussing making READ (10),
> > WRITE (10), etc. obsolete in SBC-4 in favor of their 16-byte CDB
> > counterparts.
> >
> > The a
tivation switch is also documented by a comment.
Of course we should restrain ourselves WRT the use of #if 0 ... #endif
blocks in in-tree code, but sometimes they have sensible applications.
--
Stefan Richter
-=-=-=== -=-= ---==
http://arcgraph.de/sr/
-
To unsubscribe from this list: send the
ch an own descriptive patch title (instead of
naming them all "qla4xxx: Add IPv6 support and misc"). Also, you could
put the above descriptions into the individual patch descriptions.
--
Stefan Richter
-=-=-=== -=-= ---==
http://arcgraph.de/sr/
-
To unsubscribe from this list: send t
d_orb_map_scatterlist(orb) < 0)
> goto fail_map_payload;
> - } else if (cmd->request_bufflen > 0) {
> - if (sbp2_command_orb_map_buffer(orb) < 0)
> - goto fail_map_payload;
> - }
>
> fw_memcpy_to_be32(&
csi_host.h
> +++ b/include/scsi/scsi_host.h
> @@ -343,7 +343,7 @@ struct scsi_host_template {
> /*
>* Name of proc directory
>*/
> - char *proc_name;
> + const char *proc_name;
>
> /*
>* Used to store th
Christoph Hellwig wrote:
> On Thu, May 10, 2007 at 12:38:31PM +0200, Stefan Richter wrote:
>> Would a BUG_ON(cmd->use_sg == 0); be in order?
>
> I don't think we should put this into every driver. If you want to
> be sure this doesn't happen anymore put it ju
o in short, moving the DMA mapping into mid layer should also be fine
with the old and the new SBP-2 driver.
--
Stefan Richter
-=-=-=== -=-= -=-==
http://arcgraph.de/sr/
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [EMAIL PROTECTE
1 - 100 of 277 matches
Mail list logo
