Re: [PATCH 1/1] be2iscsi: add block valid bit to iBFT flag

2014-11-11 Thread Vikas Chaudhary
On 10/11/14 11:37 pm, "Minh Duc Tran" wrote: >>Adding Vikas to verify if qla4xxx has the same issue. > >>On 11/10/2014 12:52 AM, Minh Duc Tran wrote: >>> From: Minh Tran minhduc.t...@emulex.com >>> >>> >>>We are starting to see problems with cer

Re: [PATCH 0/4] iscsi: iscsi changes for 3.17

2014-07-30 Thread Vikas Chaudhary
e and new error >>code >> for when a iscsi ping times out. > >The series looks fine to me, I'll merge it as soon as I get the >remaining second reviews. Ack for series Acked-by: Vikas Chaudhary <>

Re: [PATCH v2 RESEND 22/23] qla4xxx: Use pci_enable_msix_exact() instead of pci_enable_msix()

2014-07-28 Thread Vikas Chaudhary
Acked-By: Vikas Chaudhary On 26/07/14 2:11 pm, "Alexander Gordeev" wrote: >On Wed, Jul 16, 2014 at 08:05:26PM +0200, Alexander Gordeev wrote: >> As result of deprecation of MSI-X/MSI enablement functions >> pci_enable_msix() and pci_enable_msi_block() all d

Re: [PATCH] qla4xxx: Return -ENOMEM on memory allocation failure

2014-07-07 Thread Vikas Chaudhary
>>> From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- >>>> ow...@vger.kernel.org] On Behalf Of Himangi Saraogi >>>> Sent: Friday, 04 July, 2014 1:28 PM >>>> To: Vikas Chaudhary; iscsi-dri...@qlogic.com; James E.J. Bottomley; >>>>linux- >>>&g

Re: [PATCH 2/2] bnx2i, be2iscsi: fix custom stats length

2014-07-02 Thread Vikas Chaudhary
dus = conn->tmfrsp_pdus_cnt; >- stats->custom_length = 3; >- strcpy(stats->custom[2].desc, "eh_abort_cnt"); >- stats->custom[2].value = conn->eh_abort_cnt; > stats->digest_err = 0; > stats->timeout_err = 0; >- stats->custom_length = 0; >+ strcpy(stats->custom[0].desc, "eh_abort_cnt"); >+ stats->custom[0].value = conn->eh_abort_cnt; >+ stats->custom_length = 1; > } > > >-- >1.7.1 Acked-by: Vikas Chaudhary <>

Re: [PATCH 4/18] qla4xxx: Use kmemdup instead of kmalloc + memcpy

2014-05-27 Thread Vikas Chaudhary
rc = -ENOMEM; > goto exit_copy; > } >- >- memcpy(conn->link_local_ipv6_addr, >- fw_ddb_entry->link_local_ipv6_addr, IPv6_ADDR_LEN); > } else { > conn->ipv4_tos = fw_ddb_entry->ipv4_tos; > } Acked-by: Vikas Chaudhary <>

Re: [PATCH] iscsi_ibft: search for broadcom specific ibft sign

2014-05-13 Thread Vikas Chaudhary
On 09/05/14 6:50 pm, "Konrad Rzeszutek Wilk" wrote: >On Fri, May 09, 2014 at 11:50:20AM +, Vikas Chaudhary wrote: >> >> >> On 08/05/14 2:27 am, "Mike Christie" wrote: >> >> >On 05/07/2014 03:30 PM, Mike Christie wrote: >> &g

Re: [PATCH] iscsi_ibft: search for broadcom specific ibft sign

2014-05-09 Thread Vikas Chaudhary
wrote: >>>>> On Wed, May 07, 2014 at 07:12:31PM +, James Bottomley wrote: >>>>>> On Wed, 2014-05-07 at 09:47 -0400, Konrad Rzeszutek Wilk wrote: >>>>>>> On Wed, May 07, 2014 at 05:00:20AM -0400, >>>>>>>vikas.chaud

Re: [PATCH v2 RESEND 22/23] qla4xxx: Use pci_enable_msix_exact() instead of pci_enable_msix()

2014-04-15 Thread Vikas Chaudhary
nable_msi_exact() >and pci_enable_msix_range() or pci_enable_msix_exact() >interfaces. > >Signed-off-by: Alexander Gordeev >Cc: Vikas Chaudhary >Cc: iscsi-dri...@qlogic.com >Cc: linux-scsi@vger.kernel.org >Cc: linux-...@vger.kernel.org >--- > drivers/scsi/qla4xxx/ql4_nx.c |

Re: [PATCH 21/22] qla4xxx: Use pci_enable_msix_range()

2014-02-18 Thread Vikas Chaudhary
ix_range() >interfaces. > >Signed-off-by: Alexander Gordeev >Cc: Vikas Chaudhary >Cc: iscsi-dri...@qlogic.com >Cc: linux-scsi@vger.kernel.org >Cc: linux-...@vger.kernel.org >--- > drivers/scsi/qla4xxx/ql4_nx.c |5 +++-- > 1 files changed, 3 insertions(+), 2 deletion

Re: [PATCH 16/24] qla4xxx: Fix failure of mbox 0x31

2014-01-17 Thread Vikas Chaudhary
On 17/01/14 2:00 PM, "Mike Christie" wrote: > >> +static void qla4xxx_destroy_ddb(struct scsi_qla_host *ha, >> +struct ddb_entry *ddb_entry) >> +{ >> +struct dev_db_entry *fw_ddb_entry = NULL; >> +dma_addr_t fw_ddb_entry_dma; >> +unsigned long wtime; >> +uint32_t ddb

Re: [patch] [SCSI] qla4xxx: overflow in qla4xxx_set_chap_entry()

2013-11-13 Thread Vikas Chaudhary
h] [SCSI] qla4xxx: overflow in qla4xxx_set_chap_entry() >On Wed, Nov 13, 2013 at 03:08:12PM +0300, Dan Carpenter wrote: >> On Wed, Nov 13, 2013 at 11:52:37AM +, Vikas Chaudhary wrote: >> > >> > >> > -Original Message- >> > From: Dan Carpen

Re: [patch] [SCSI] qla4xxx: overflow in qla4xxx_set_chap_entry()

2013-11-13 Thread Vikas Chaudhary
-Original Message- From: Dan Carpenter Date: Wednesday, 13 November 2013 1:18 pm To: Vikas , Adheer Chandravanshi Cc: Dept-Eng iSCSI Driver , "James E.J. Bottomley" , scsi , "kernel-janit...@vger.kernel.org" Subject: [patch] [SCSI] qla4xxx: overflow in qla4xxx_set_chap_entry() >We sho

Re: [PATCH 1/1] scsi: qla4xxx: change some variables to hexadecimal string via %pm, %pmR and %pM formats

2013-07-10 Thread Vikas Chaudhary
@ qla4xxx_sysfs_ddb_get_param(struct >iscsi_bus_flash_session *fnode_sess, > rc = sprintf(buf, "%u\n", fnode_conn->keepalive_timeout); > break; > case ISCSI_FLASHNODE_ISID: >- rc = sprintf(buf, "%02x%02x%02x%02x%02x%02x\n", >- fnode_sess->isid[0], fnode_sess->isid[1], >- fnode_sess->isid[2], fnode_sess->isid[3], >- fnode_sess->isid[4], fnode_sess->isid[5]); >+ rc = sprintf(buf, "%pm\n", fnode_sess->isid); > break; > case ISCSI_FLASHNODE_TSID: > rc = sprintf(buf, "%u\n", fnode_sess->tsid); >-- >1.7.9.5 Thanks for the patch. Acked-by: Vikas Chaudhary <>

Re: [PATCH V1 1/4] scsi_transport_iscsi: Exporting new attrs for iscsi session and connection in sysfs

2013-07-01 Thread Vikas Chaudhary
-Original Message- From: James Bottomley Date: Saturday 29 June 2013 1:24 AM To: Vikas Cc: Mike Christie , scsi , Lalit Chandivade , Adheer Chandravanshi Subject: Re: [PATCH V1 1/4] scsi_transport_iscsi: Exporting new attrs for iscsi session and connection in sysfs >On Wed, 2013-06-26

Re: [PATCH 0/8] qla4xxx: Updates for scsi "misc" branch

2013-06-26 Thread Vikas Chaudhary
-Original Message- From: Vikas Date: Thursday 9 May 2013 3:32 PM To: "jbottom...@parallels.com" , Mike Christie Cc: scsi , Admin , Lalit Chandivade , Ravi Anand Subject: [PATCH 0/8] qla4xxx: Updates for scsi "misc" branch >From: Vikas Chaudhary > >James

Re: [PATCH 4/8] scsi_transport_iscsi: Exporting new attrs for iscsi session and connection in sysfs

2013-05-28 Thread Vikas Chaudhary
-Original Message- From: Mike Christie Date: Tuesday 28 May 2013 2:27 PM To: Vikas Cc: "jbottom...@parallels.com" , scsi , Lalit Chandivade , Ravi Anand , Adheer Chandravanshi Subject: Re: [PATCH 4/8] scsi_transport_iscsi: Exporting new attrs for iscsi session and connection in sysfs

Re: [PATCH 2/8] iscsi_transport: Additional parameters for net settings

2013-05-28 Thread Vikas Chaudhary
-Original Message- From: Mike Christie Date: Tuesday 28 May 2013 2:19 PM To: Vikas Cc: "jbottom...@parallels.com" , scsi , Lalit Chandivade , Ravi Anand , Harish Zunjarrao Subject: Re: [PATCH 2/8] iscsi_transport: Additional parameters for net settings >Come on man, same comments as l

Re: [PATCH] scsi: add put_device() after device_find_child()

2013-05-08 Thread Vikas Chaudhary
patch? It is only compile tested. If it is ok, Vikas, >please test. We have tested this patch and it looks good in our testing. I am resending this patch for inclusion with our next patch-set which I am sending in next email. Thanks for fixing this. Acked-by: Vikas Chaudhary <>

[PATCH 2/5] qla4xxx: Fix sparse warning for qla4xxx_sysfs_ddb_tgt_create

2013-04-17 Thread vikas . chaudhary
From: Vikas Chaudhary Fix following warning: drivers/scsi/qla4xxx/ql4_os.c:5507:5: warning: symbol 'qla4xxx_sysfs_ddb_tgt_create' was not declared. Should it be static? Signed-off-by: Vikas Chaudhary --- drivers/scsi/qla4xxx/ql4_os.c | 6 +++--- 1 file changed, 3 insertions(+), 3

[PATCH 4/5] qla4xxx: Assign values using correct datatype

2013-04-17 Thread vikas . chaudhary
From: Adheer Chandravanshi Assign values using correct datatype in function qla4xxx_copy_to_fwddb_param() Signed-off-by: Adheer Chandravanshi Signed-off-by: Vikas Chaudhary --- drivers/scsi/qla4xxx/ql4_os.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers

[PATCH 5/5] qla4xxx: Update driver version to 5.03.00-k9

2013-04-17 Thread vikas . chaudhary
From: Vikas Chaudhary Signed-off-by: Vikas Chaudhary --- drivers/scsi/qla4xxx/ql4_version.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/qla4xxx/ql4_version.h b/drivers/scsi/qla4xxx/ql4_version.h index 83e0fec..fe873cf 100644 --- a/drivers/scsi/qla4xxx

[PATCH 1/5] qla4xxx: Silence gcc warning

2013-04-17 Thread vikas . chaudhary
From: Vikas Chaudhary Fix followig gcc warning:- drivers/scsi/qla4xxx/ql4_os.c: In function ‘qla4xxx_sysfs_ddb_get_param’: drivers/scsi/qla4xxx/ql4_os.c:6279: warning: comparison is always true due to limited range of data type drivers/scsi/qla4xxx/ql4_os.c:6290: warning: comparison is always

[PATCH 3/5] qla4xxx: Fix smatch warnings

2013-04-17 Thread vikas . chaudhary
sess' (see line 6584) drivers/scsi/qla4xxx/ql4_os.c:6632 qla4xxx_sysfs_ddb_delete() error: potential NULL dereference 'fw_ddb_entry'. Signed-off-by: Adheer Chandravanshi Signed-off-by: Vikas Chaudhary --- drivers/scsi/qla4xxx/ql4_os.c | 17 + 1 file changed, 1 inser

[PATCH 0/5] qla4xxx: Updates for scsi "misc" branch

2013-04-17 Thread vikas . chaudhary
From: Vikas Chaudhary James, Please apply the following patches to the scsi tree at your earliest convenience. Adheer Chandravanshi (2): qla4xxx: Fix smatch warnings qla4xxx: Assign values using correct datatype Vikas Chaudhary (3): qla4xxx: Silence gcc warning

[PATCH 5/5] qla4xxx: Update driver version to 5.03.00-k8

2013-04-05 Thread vikas . chaudhary
From: Vikas Chaudhary Signed-off-by: Vikas Chaudhary --- drivers/scsi/qla4xxx/ql4_version.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/qla4xxx/ql4_version.h b/drivers/scsi/qla4xxx/ql4_version.h index 18ad425..83e0fec 100644 --- a/drivers/scsi/qla4xxx

[PATCH 1/5] qla4xxx: Use correct flash ddb offset for ISP40XX

2013-04-05 Thread vikas . chaudhary
From: Adheer Chandravanshi Use correct flash ddb offset to add and delete flash target entries for ISP40XX Signed-off-by: Adheer Chandravanshi Signed-off-by: Vikas Chaudhary --- drivers/scsi/qla4xxx/ql4_mbx.c | 7 -- drivers/scsi/qla4xxx/ql4_os.c | 57

[PATCH 3/5] qla4xxx: Use correct value for max flash node entries

2013-04-05 Thread vikas . chaudhary
From: Adheer Chandravanshi Use correct value for max flash node entries supported based on adapter type. Signed-off-by: Adheer Chandravanshi Signed-off-by: Vikas Chaudhary --- drivers/scsi/qla4xxx/ql4_os.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi

[PATCH 4/5] qla4xxx: Added print statements to display AENs

2013-04-05 Thread vikas . chaudhary
From: Vikas Chaudhary Added print statements for following AENs: 1. MBOX_ASTS_INITIALIZATION_FAILED 2. MBOX_ASTS_SYSTEM_WARNING_EVENT 3. MBOX_ASTS_DCBX_CONF_CHANGE 4. MBOX_ASTS_IPV6_DEFAULT_ROUTER_CHANGED Signed-off-by: Vikas Chaudhary --- drivers/scsi/qla4xxx/ql4_fw.h | 4 drivers

[PATCH 2/5] qla4xxx: Restrict logout from boot target session using session id

2013-04-05 Thread vikas . chaudhary
From: Adheer Chandravanshi Signed-off-by: Adheer Chandravanshi Signed-off-by: Vikas Chaudhary --- drivers/scsi/qla4xxx/ql4_os.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/scsi/qla4xxx/ql4_os.c b/drivers/scsi/qla4xxx/ql4_os.c index 5f7a2bc..f82efcb 100644 --- a/drivers

[PATCH 0/5] qla4xxx: Updates for scsi "misc" branch

2013-04-05 Thread vikas . chaudhary
From: Vikas Chaudhary James, Please apply the following patches to the scsi tree at your earliest convenience. Adheer Chandravanshi (3): qla4xxx: Use correct flash ddb offset for ISP40XX qla4xxx: Restrict logout from boot target session using session id qla4xxx: Use correct

[PATCH 2/3] qla4xxx: Replace dev type macros with generic portal type macros

2013-03-25 Thread vikas . chaudhary
From: Adheer Chandravanshi Signed-off-by: Adheer Chandravanshi Signed-off-by: Vikas Chaudhary --- drivers/scsi/qla4xxx/ql4_def.h | 3 --- drivers/scsi/qla4xxx/ql4_os.c | 26 ++ 2 files changed, 14 insertions(+), 15 deletions(-) diff --git a/drivers/scsi/qla4xxx

[PATCH 1/3] scsi_transport_iscsi: Declare portal type string macros for generic use

2013-03-25 Thread vikas . chaudhary
From: Adheer Chandravanshi Signed-off-by: Adheer Chandravanshi Signed-off-by: Vikas Chaudhary --- include/scsi/iscsi_if.h | 4 1 file changed, 4 insertions(+) diff --git a/include/scsi/iscsi_if.h b/include/scsi/iscsi_if.h index f1b0183..fe7f06c 100644 --- a/include/scsi/iscsi_if.h +++ b

Re: [PATCH 0/4] qla4xxx: Patches for iSCSI flash node mgmt support

2013-03-25 Thread Vikas Chaudhary
On 03/22/2013 06:41 AM, vikas.chaudh...@qlogic.com wrote: >> From: Vikas Chaudhary >> >> James, >> >> Following patches allows iscsiadm to manage iSCSI target information >> stored on adapter flash on per host basis and and perform various >> operations

[PATCH 2/4] libiscsi: export function iscsi_switch_str_param

2013-03-22 Thread vikas . chaudhary
From: Adheer Chandravanshi Signed-off-by: Adheer Chandravanshi Signed-off-by: Vikas Chaudhary --- drivers/scsi/libiscsi.c |3 ++- include/scsi/libiscsi.h |1 + 2 files changed, 3 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/libiscsi.c b/drivers/scsi/libiscsi.c index

[PATCH 1/4] scsi_transport_iscsi: Add flash node mgmt support

2013-03-22 Thread vikas . chaudhary
-::/ Signed-off-by: Adheer Chandravanshi Signed-off-by: Manish Rangankar Signed-off-by: Vikas Chaudhary --- drivers/scsi/scsi_transport_iscsi.c | 1002 ++- include/scsi/iscsi_if.h | 113 include/scsi/scsi_transport_iscsi.h | 151 ++ 3 files

[PATCH 0/4] qla4xxx: Patches for iSCSI flash node mgmt support

2013-03-22 Thread vikas . chaudhary
From: Vikas Chaudhary James, Following patches allows iscsiadm to manage iSCSI target information stored on adapter flash on per host basis and and perform various operations like add, delete, login, logout, and update the target information. Please apply these patches to the scsi tree "

[PATCH 3/4] qla4xxx: Skip retry of initialize_adapter for ISP80XX

2013-03-22 Thread vikas . chaudhary
From: Nilesh Javali While probe Skip retry of initialize_adapter only for ISP82XX and ISP83XX. We need to retry initialize_adapter for ISP40XX. Signed-off-by: Nilesh Javali Signed-off-by: Vikas Chaudhary --- drivers/scsi/qla4xxx/ql4_os.c | 5 - 1 file changed, 4 insertions(+), 1 deletion

[PATCH 2/4] qla4xxx: Assign correct CHAP table address to FLT

2013-03-22 Thread vikas . chaudhary
From: Vikas Chaudhary Issue: If flash read for FLT fails, we are assigning wrong default address for CHAP table in FLT, which will cause CHAP table read/write to wrong address. Fix: Assign correct default CHAP table address to FLT. Signed-off-by: Vikas Chaudhary --- drivers/scsi/qla4xxx

[PATCH 4/4] qla4xxx: Update driver version to 5.03.00-k6

2013-03-22 Thread vikas . chaudhary
From: Vikas Chaudhary Signed-off-by: Vikas Chaudhary --- drivers/scsi/qla4xxx/ql4_version.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/qla4xxx/ql4_version.h b/drivers/scsi/qla4xxx/ql4_version.h index 4540028..0cd824f 100644 --- a/drivers/scsi/qla4xxx

[PATCH 0/4] qla4xxx: Updates for scsi "misc" branch

2013-03-22 Thread vikas . chaudhary
From: Vikas Chaudhary James, Please apply the following patches to the scsi tree at your earliest convenience. Nilesh Javali (1): qla4xxx: Skip retry of initialize_adapter only for ISP8XXX Vikas Chaudhary (3): qla4xxx: Added missing check for ISP83XX in CHAP related functions

[PATCH 1/4] qla4xxx: Added missing check for ISP83XX in CHAP related functions

2013-03-22 Thread vikas . chaudhary
From: Vikas Chaudhary Signed-off-by: Vikas Chaudhary --- drivers/scsi/qla4xxx/ql4_mbx.c | 2 +- drivers/scsi/qla4xxx/ql4_os.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/qla4xxx/ql4_mbx.c b/drivers/scsi/qla4xxx/ql4_mbx.c index 446511d..ce46545

[PATCH 5/8] qla4xxx: Pass correct LUN address to firmware in case of lun_reset

2013-03-07 Thread vikas . chaudhary
From: Vikas Chaudhary Use function int_to_scsilun() in qla4xxx_reset_lun() to convert integer value comming from scsi_transport to scsi LUN address format. Signed-off-by: Vikas Chaudhary --- drivers/scsi/qla4xxx/ql4_mbx.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff

[PATCH 6/8] qla4xxx: Fix debug level to avoid floods of same message

2013-03-07 Thread vikas . chaudhary
From: Vikas Chaudhary Move "Incorrect function ID" print message in case INTX interrupt from DEBUG2 to DEBUG7. This will avoid floods of this message if DEBUG2 is enabled. Signed-off-by: Vikas Chaudhary --- drivers/scsi/qla4xxx/ql4_dbg.h | 7 +++ drivers/scsi/qla4xxx/ql4

[PATCH 0/8] qla4xxx: Updates for scsi "misc" branch

2013-03-07 Thread vikas . chaudhary
From: Vikas Chaudhary James, Please apply the following patches to the scsi tree at your earliest convenience. Thanks, Vikas. Manish Dusane (1): qla4xxx: Take E-port out of reset before disabling pause frames Tej Parkash (1): qla4xxx: Fixed request queue count manipulation on

[PATCH 7/8] qla4xxx: Fixed request queue count manipulation on response path

2013-03-07 Thread vikas . chaudhary
. This scenario leads fw hang during IO. Solution: Request queue count manipulation has to be done in IO path only, keeping req_in and req_out pointer two IOCB count away Signed-off-by: Tej Parkash Signed-off-by: Shyam Sundar Signed-off-by: Vikas Chaudhary --- drivers/scsi/qla4xxx/ql4_glbl.h | 2

[PATCH 8/8] qla4xxx: Update driver version to 5.03.00-k5

2013-03-07 Thread vikas . chaudhary
From: Vikas Chaudhary Signed-off-by: Vikas Chaudhary --- drivers/scsi/qla4xxx/ql4_version.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/qla4xxx/ql4_version.h b/drivers/scsi/qla4xxx/ql4_version.h index 6775a45..4540028 100644 --- a/drivers/scsi/qla4xxx

[PATCH 4/8] qla4xxx: Fix double reset in case of firmware hung for ISP83XX

2013-03-07 Thread vikas . chaudhary
From: Vikas Chaudhary In case of firmware hung we need to call "mailbox_premature_completion" to complete any pending mbox command as firmware is not alive. Signed-off-by: Vikas Chaudhary --- drivers/scsi/qla4xxx/ql4_os.c | 18 -- 1 file changed, 16 insertions(+), 2

[PATCH 3/8] qla4xxx: Set graceful reset bit for ISP83XX

2013-03-07 Thread vikas . chaudhary
From: Vikas Chaudhary For ISP83XX set graceful reset bit in IDC_DRV_CTRL if reset is issued by application Signed-off-by: Vikas Chaudhary --- drivers/scsi/qla4xxx/ql4_os.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/scsi/qla4xxx/ql4_os.c b/drivers/scsi/qla4xxx

[PATCH 1/8] qla4xxx: Take E-port out of reset before disabling pause frames

2013-03-07 Thread vikas . chaudhary
-off-by: Vikas Chaudhary --- drivers/scsi/qla4xxx/ql4_83xx.c | 28 drivers/scsi/qla4xxx/ql4_83xx.h | 10 ++ 2 files changed, 38 insertions(+) diff --git a/drivers/scsi/qla4xxx/ql4_83xx.c b/drivers/scsi/qla4xxx/ql4_83xx.c index 5d8fe4f..d607eb8 100644 --- a

[PATCH 2/8] qla4xxx: Boot from SAN fix for ISP83XX

2013-03-07 Thread vikas . chaudhary
From: Vikas Chaudhary Issue: ISP83XX check is missing in function get_fw_boot_info() because of this qla4xxx will not export boot target to sysfs and iscsistart cannot issue login to boot target. Fix: Added check for ISP83XX in function get_fw_boot_info() Signed-off-by: Vikas Chaudhary

Re: [patch] [SCSI] qla4xxx: don't free NULL dma pool

2013-01-30 Thread Vikas Chaudhary
p_table = dma_pool_alloc(ha->chap_dma_pool, GFP_KERNEL, &chap_dma); >- if (chap_table == NULL) { >- ret = -ENOMEM; >- goto exit_get_chap; >- } >+ if (chap_table == NULL) >+ return -ENOMEM; > > c

[PATCH 03/10] qla4xxx: Quiesce driver activities while loopback

2013-01-20 Thread vikas . chaudhary
From: Nilesh Javali Quiesce all different activities performed by driver upon the link events while loopback diagnostics is in progress. Signed-off-by: Nilesh Javali Signed-off-by: Vikas Chaudhary --- drivers/scsi/qla4xxx/ql4_def.h |4 +++- drivers/scsi/qla4xxx/ql4_fw.h |4

[PATCH 07/10] qla4xxx: Added support for force firmware dump

2013-01-20 Thread vikas . chaudhary
From: Vikas Chaudhary This patch force driver to collect firmware dump using following command:- "echo 2 > /sys/class/scsi_host/hostX/device/fw_dump" Signed-off-by: Vikas Chaudhary --- drivers/scsi/qla4xxx/ql4_83xx.c |2 +- drivers/scsi/qla4xxx/ql4_attr.c | 16 +++-

[PATCH 05/10] qla4xxx: Throttle active IOCBs to firmware limits

2013-01-20 Thread vikas . chaudhary
-off-by: Vikas Chaudhary --- drivers/scsi/qla4xxx/ql4_def.h |2 ++ drivers/scsi/qla4xxx/ql4_iocb.c |2 +- drivers/scsi/qla4xxx/ql4_mbx.c | 20 ++-- 3 files changed, 21 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/qla4xxx/ql4_def.h b/drivers/scsi/qla4xxx

[PATCH 08/10] qla4xxx: wait for boot target login response during probe.

2013-01-20 Thread vikas . chaudhary
From: Manish Rangankar Boot from SAN fails in some cases where boot target login response is slow. In this case, probe finishes early and triggers init, which doesn't find remote disk to mount root which leads to BFS failure. Signed-off-by: Manish Rangankar Signed-off-by: Vikas Chau

[PATCH 10/10] qla4xxx: Update driver version to 5.03.00-k4

2013-01-20 Thread vikas . chaudhary
From: Vikas Chaudhary Signed-off-by: Vikas Chaudhary --- drivers/scsi/qla4xxx/ql4_version.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/qla4xxx/ql4_version.h b/drivers/scsi/qla4xxx/ql4_version.h index 765bb77..6775a45 100644 --- a/drivers/scsi

[PATCH 09/10] qla4xxx: Fix return code for qla4xxx_session_get_param.

2013-01-20 Thread vikas . chaudhary
From: Manish Rangankar While reading sysfs chap_in_idx and chap_out_idx attribute, if chap authentication is not set we get an error as "Invalid argument". Signed-off-by: Manish Rangankar Signed-off-by: Vikas Chaudhary --- drivers/scsi/qla4xxx/ql4_os.c | 12 ++-- 1 files

[PATCH 04/10] qla4xxx: Remove unnecessary code from qla4xxx_init_local_data

2013-01-20 Thread vikas . chaudhary
From: Karen Higgins Removed unnecessary calls to qla4xxx_get_firmware_status from function qla4xxx_init_local_data Signed-off-by: Karen Higgins Signed-off-by: Vikas Chaudhary --- drivers/scsi/qla4xxx/ql4_init.c |7 ++- 1 files changed, 2 insertions(+), 5 deletions(-) diff --git a

[PATCH 06/10] qla4xxx: Re-register IRQ handler while retrying initialize of adapter

2013-01-20 Thread vikas . chaudhary
retried. Signed-off-by: Poornima Vonti Signed-off-by: Vikas Chaudhary --- drivers/scsi/qla4xxx/ql4_nx.c |2 +- drivers/scsi/qla4xxx/ql4_os.c | 27 --- 2 files changed, 5 insertions(+), 24 deletions(-) diff --git a/drivers/scsi/qla4xxx/ql4_nx.c b/drivers/scsi/qla4xxx

[PATCH 01/10] qla4xxx: Add spurious interrupt messages under debug level 2

2013-01-20 Thread vikas . chaudhary
expected in such scenario. Hence put these messages under debug level 2 for INTx interrupt mode. Signed-off-by: Nilesh Javali Signed-off-by: Vikas Chaudhary --- drivers/scsi/qla4xxx/ql4_isr.c | 13 +++-- 1 files changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/scsi/qla4xxx

[PATCH 02/10] qla4xxx: Rename MBOX_ASTS_IDC_NOTIFY to MBOX_ASTS_IDC_REQUEST_NOTIFICATION

2013-01-20 Thread vikas . chaudhary
From: Nilesh Javali Signed-off-by: Nilesh Javali Signed-off-by: Vikas Chaudhary --- drivers/scsi/qla4xxx/ql4_fw.h |2 +- drivers/scsi/qla4xxx/ql4_isr.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/qla4xxx/ql4_fw.h b/drivers/scsi/qla4xxx/ql4_fw.h

[PATCH 00/10] qla4xxx: Updates for scsi "misc" branch

2013-01-20 Thread vikas . chaudhary
From: Vikas Chaudhary James, Please apply the following patches to the scsi tree at your earliest convenience. Thanks, Vikas. Karen Higgins (2): qla4xxx: Remove unnecessary code from qla4xxx_init_local_data qla4xxx: Throttle active IOCBs to firmware limits Manish Rangankar (2

[PATCH 1/3] qla4xxx: Pass correct function param to qla4_8xxx_rd_direct

2012-12-28 Thread vikas . chaudhary
From: Vikas Chaudhary Signed-off-by: Vikas Chaudhary --- drivers/scsi/qla4xxx/ql4_os.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/qla4xxx/ql4_os.c b/drivers/scsi/qla4xxx/ql4_os.c index 6096866..640d257 100644 --- a/drivers/scsi/qla4xxx/ql4_os.c +++ b

[PATCH 3/3] qla4xxx: Update driver version to 5.03.00-k3

2012-12-28 Thread vikas . chaudhary
From: Vikas Chaudhary Signed-off-by: Vikas Chaudhary --- drivers/scsi/qla4xxx/ql4_version.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/qla4xxx/ql4_version.h b/drivers/scsi/qla4xxx/ql4_version.h index 4a20b88..765bb77 100644 --- a/drivers/scsi

[PATCH 2/3] qla4xxx: Correct the validation to check in get_sys_info mailbox

2012-12-28 Thread vikas . chaudhary
From: Nilesh Javali Check mbox_sts[3] instead of mbox_sts[4] for ISP83xx to validate size of data returned Signed-off-by: Nilesh Javali Signed-off-by: Vikas Chaudhary --- drivers/scsi/qla4xxx/ql4_nx.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi

[PATCH 0/3] qla4xxx: Updates for scsi "misc" branch

2012-12-28 Thread vikas . chaudhary
From: Vikas Chaudhary James, Please apply the following patches to the scsi tree at your earliest convenience. Thanks, Vikas. Nilesh Javali (1): qla4xxx: Correct the validation to check in get_sys_info mailbox Vikas Chaudhary (2): qla4xxx: Pass correct function param to

[PATCH 3/5] qla4xxx: Fix memory corruption issue in qla4xxx_get_ep_fwdb.

2012-11-23 Thread vikas . chaudhary
hold sizeof(struct sockaddr_in6). Reported-by: Dan Carpenter Signed-off-by: Manish Rangankar Signed-off-by: Vikas Chaudhary --- drivers/scsi/qla4xxx/ql4_os.c | 11 +++ 1 files changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/qla4xxx/ql4_os.c b/drivers/scsi/qla4xxx

[PATCH 1/5] qla4xxx: Fix MBOX intr switching from polling to intr mode for ISP83XX

2012-11-23 Thread vikas . chaudhary
From: Vikas Chaudhary Issue: Mailbox command timed out after switching from polling mode to interrupt mode. Events:- 1. Mailbox interrupts are disabled 2. FW generates AEN and at same time driver enables Mailbox Interrupt 3. Driver issues new mailbox to Firmware In above case driver will

[PATCH 5/5] qla4xxx: Update driver version to 5.03.00-k2

2012-11-23 Thread vikas . chaudhary
From: Vikas Chaudhary Signed-off-by: Vikas Chaudhary --- drivers/scsi/qla4xxx/ql4_version.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/qla4xxx/ql4_version.h b/drivers/scsi/qla4xxx/ql4_version.h index f6df2ea..4a20b88 100644 --- a/drivers/scsi

[PATCH 4/5] scsi_transport_iscsi: export iscsi class session's target_id in sysfs.

2012-11-23 Thread vikas . chaudhary
From: Manish Rangankar Signed-off-by: Manish Rangankar Signed-off-by: Vikas Chaudhary --- drivers/scsi/scsi_transport_iscsi.c | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/drivers/scsi/scsi_transport_iscsi.c b/drivers/scsi/scsi_transport_iscsi.c index

[PATCH 2/5] qla4xxx: Allow reset in link down case

2012-11-23 Thread vikas . chaudhary
From: Harish Zunjarrao Issue: Reset operation fails if port is in Link Down state Fix: Do not wait till HBA comes online after reset command is invoked. Signed-off-by: Harish Zunjarrao Signed-off-by: Vikas Chaudhary --- drivers/scsi/qla4xxx/ql4_os.c |8 1 files changed, 0

[PATCH 0/5] qla4xxx: Updates for scsi "misc" branch

2012-11-23 Thread vikas . chaudhary
From: Vikas Chaudhary James, Please apply the following patches to the scsi tree at your earliest convenience. Thanks, Vikas. Harish Zunjarrao (1): qla4xxx: Allow reset in link down case Manish Rangankar (2): qla4xxx: Fix memory corruption issue in qla4xxx_get_ep_fwdb

[PATCH 7/7] qla4xxx: Update driver version to 5.03.00-k2

2012-10-10 Thread vikas . chaudhary
From: Vikas Chaudhary Signed-off-by: Vikas Chaudhary --- drivers/scsi/qla4xxx/ql4_version.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/qla4xxx/ql4_version.h b/drivers/scsi/qla4xxx/ql4_version.h index f6df2ea..4a20b88 100644 --- a/drivers/scsi

[PATCH 3/7] qla4xxx: Invoke Set Address Control Block using BSG

2012-10-10 Thread vikas . chaudhary
From: Harish Zunjarrao Signed-off-by: Harish Zunjarrao Signed-off-by: Vikas Chaudhary --- drivers/scsi/qla4xxx/ql4_bsg.c | 77 drivers/scsi/qla4xxx/ql4_bsg.h |1 + 2 files changed, 78 insertions(+), 0 deletions(-) diff --git a/drivers/scsi

[PATCH 5/7] qla4xxx: Add get default DDB support using BSG.

2012-10-10 Thread vikas . chaudhary
From: Manish Rangankar Signed-off-by: Manish Rangankar Signed-off-by: Vikas Chaudhary --- drivers/scsi/qla4xxx/ql4_bsg.c | 79 +++ drivers/scsi/qla4xxx/ql4_bsg.h |1 + drivers/scsi/qla4xxx/ql4_glbl.h |2 + drivers/scsi/qla4xxx/ql4_mbx.c | 26

[PATCH 6/7] qla4xxx: Add get DDB support using BSG.

2012-10-10 Thread vikas . chaudhary
From: Manish Rangankar Signed-off-by: Manish Rangankar Signed-off-by: Vikas Chaudhary --- drivers/scsi/qla4xxx/ql4_bsg.c | 84 +++ drivers/scsi/qla4xxx/ql4_bsg.h |1 + drivers/scsi/qla4xxx/ql4_glbl.h |4 ++ drivers/scsi/qla4xxx/ql4_mbx.c | 40

[PATCH 2/7] qla4xxx: Added new BSG command QLISCSI_VND_ABOUT_FIRMWARE

2012-10-10 Thread vikas . chaudhary
From: Adheer Chandravanshi Signed-off-by: Adheer Chandravanshi Signed-off-by: Vikas Chaudhary --- drivers/scsi/qla4xxx/ql4_bsg.c | 62 +++ drivers/scsi/qla4xxx/ql4_bsg.h |1 + drivers/scsi/qla4xxx/ql4_glbl.h |2 +- drivers/scsi/qla4xxx

[PATCH 4/7] qla4xxx: Invoke DisableACB using BSG

2012-10-10 Thread vikas . chaudhary
From: Harish Zunjarrao Signed-off-by: Harish Zunjarrao Signed-off-by: Vikas Chaudhary --- drivers/scsi/qla4xxx/ql4_bsg.c | 42 drivers/scsi/qla4xxx/ql4_bsg.h |1 + 2 files changed, 43 insertions(+), 0 deletions(-) diff --git a/drivers/scsi

[PATCH 1/7] qla4xxx: Allow reset in link down case

2012-10-10 Thread vikas . chaudhary
From: Harish Zunjarrao Signed-off-by: Harish Zunjarrao Signed-off-by: Vikas Chaudhary --- drivers/scsi/qla4xxx/ql4_os.c |8 1 files changed, 0 insertions(+), 8 deletions(-) diff --git a/drivers/scsi/qla4xxx/ql4_os.c b/drivers/scsi/qla4xxx/ql4_os.c index ad2da9c..fbfa948 100644

[PATCH 0/7] qla4xxx: Updates for scsi "misc" branch

2012-10-10 Thread vikas . chaudhary
From: Vikas Chaudhary James, Please apply the following patches to the scsi tree at your earliest convenience. Thanks, Vikas. Adheer Chandravanshi (1): qla4xxx: Added new BSG command QLISCSI_VND_ABOUT_FIRMWARE Harish Zunjarrao (3): qla4xxx: Allow reset in link down case

[PATCH 07/13] qla4xxx: Fail probe_adapter if IRQ allocation fails

2012-09-20 Thread vikas . chaudhary
From: Poornima Vonti If IRQ allocation fails, it means system has run out of interrupt vectors, so fail probe_adapter in case of IRQ allocation failure and dont retry adapter initialization. Signed-off-by: Poornima Vonti Signed-off-by: Vikas Chaudhary --- drivers/scsi/qla4xxx/ql4_os.c |6

[PATCH 05/13] qla4xxx: Update idc reg in case of PCI AER

2012-09-20 Thread vikas . chaudhary
From: Vikas Chaudhary Camram is reset by FW to default values after reboot/cold boot/pci reset. In case of AER, PCI may need to reset so we need to set correct idc reg value after PCIE error. Signed-off-by: Vikas Chaudhary --- drivers/scsi/qla4xxx/ql4_glbl.h |1 + drivers/scsi/qla4xxx

[PATCH 06/13] qla4xxx: Prevent MSI/MSI-X falling back to INTx for ISP82XX

2012-09-20 Thread vikas . chaudhary
From: Vikas Chaudhary For ISP82xx mixed interrupt mode is not supported. Hence prevent MSI/MSI-x from falling back to INTx mode. Signed-off-by: Vikas Chaudhary --- drivers/scsi/qla4xxx/ql4_isr.c | 13 ++--- 1 files changed, 10 insertions(+), 3 deletions(-) diff --git a/drivers/scsi

[PATCH 08/13] qla4xxx: Fix panic while rmmod

2012-09-20 Thread vikas . chaudhary
From: Vikas Chaudhary Issue: System panic on rmmod if probe_adapter had failed during driver load. Call Trace: [] qla4xxx_abort_active_cmds+0x4a/0xa0 [qla4xxx] [] qla4xxx_free_adapter+0x1b/0x1b0 [qla4xxx] [] qla4xxx_remove_adapter+0x294/0x2c7 [qla4xxx] [] pci_device_remove+0x37/0x70

[PATCH 12/13] qla4xxx: Disable generating pause frames for ISP83XX

2012-09-20 Thread vikas . chaudhary
From: Tej Parkash In case of FW hung ISP83XX generates continuous pause frames which causes switch to disable port. Added fix to disable generating pause frames in case of FW hung Signed-off-by: Tej Parkash Signed-off-by: Vikas Chaudhary --- drivers/scsi/qla4xxx/ql4_83xx.c | 144

[PATCH 11/13] qla4xxx: Fix double clearing of risc_intr for ISP83XX

2012-09-20 Thread vikas . chaudhary
process_mbox_intr(). Signed-off-by: Manish Dusane Signed-off-by: Vikas Chaudhary --- drivers/scsi/qla4xxx/ql4_83xx.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/qla4xxx/ql4_83xx.c b/drivers/scsi/qla4xxx/ql4_83xx.c index f963b06..8b367ef 100644 --- a

[PATCH 10/13] qla4xxx: IDC implementation for Loopback

2012-09-20 Thread vikas . chaudhary
From: Nilesh Javali Handle IDC Request Notify AEN and post IDC Acknowledgement while participating in Loopback IDC. Signed-off-by: Nilesh Javali Signed-off-by: Vikas Chaudhary --- drivers/scsi/qla4xxx/ql4_83xx.h |8 drivers/scsi/qla4xxx/ql4_def.h |3 ++- drivers/scsi

[PATCH 09/13] qla4xxx: update LICENSE.qla4xxx

2012-09-20 Thread vikas . chaudhary
From: Vikas Chaudhary Signed-off-by: Vikas Chaudhary --- Documentation/scsi/LICENSE.qla4xxx |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Documentation/scsi/LICENSE.qla4xxx b/Documentation/scsi/LICENSE.qla4xxx index ab89959..78c169f 100644 --- a/Documentation/scsi

[PATCH 13/13] qla4xxx: Update driver version to 5.03.00-k1

2012-09-20 Thread vikas . chaudhary
From: Vikas Chaudhary Signed-off-by: Vikas Chaudhary --- drivers/scsi/qla4xxx/ql4_version.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/qla4xxx/ql4_version.h b/drivers/scsi/qla4xxx/ql4_version.h index 0c329ac..f6df2ea 100644 --- a/drivers/scsi

[PATCH 02/13] qla4xxx: Print correct IDC version

2012-09-20 Thread vikas . chaudhary
From: Vikas Chaudhary Signed-off-by: Vikas Chaudhary --- drivers/scsi/qla4xxx/ql4_nx.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/qla4xxx/ql4_nx.c b/drivers/scsi/qla4xxx/ql4_nx.c index 20825d5..9b67aad 100644 --- a/drivers/scsi/qla4xxx/ql4_nx.c +++ b

[PATCH 03/13] qla4xxx: Clear interrupt while unloading driver for ISP83XX

2012-09-20 Thread vikas . chaudhary
From: Vikas Chaudhary Signed-off-by: Vikas Chaudhary --- drivers/scsi/qla4xxx/ql4_os.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/drivers/scsi/qla4xxx/ql4_os.c b/drivers/scsi/qla4xxx/ql4_os.c index d2d7b25..c1093eb 100644 --- a/drivers/scsi/qla4xxx/ql4_os.c

[PATCH 01/13] qla4xxx: Added new mbox cmd to pass driver version to FW

2012-09-20 Thread vikas . chaudhary
From: Manish Dusane Signed-off-by: Manish Dusane Signed-off-by: Vikas Chaudhary --- drivers/scsi/qla4xxx/ql4_fw.h |3 +++ drivers/scsi/qla4xxx/ql4_glbl.h |1 + drivers/scsi/qla4xxx/ql4_mbx.c | 37 + drivers/scsi/qla4xxx/ql4_os.c |4

[PATCH 00/13] qla4xxx: Updates for scsi "misc" branch

2012-09-20 Thread vikas . chaudhary
From: Vikas Chaudhary James, Please apply the following patches to the scsi tree at your earliest convenience. Thanks, Vikas. Manish Dusane (2): qla4xxx: Added new mbox cmd to pass driver version to FW qla4xxx: Fix double clearing of risc_intr for ISP83XX Nilesh Javali (1

[PATCH 04/13] qla4xxx: Fix double IDC locking in qla4_8xxx_error_recovery

2012-09-20 Thread vikas . chaudhary
From: Poornima Vonti Issue: In qla4_8xxx_error_recovery() IDC lock recovery is initiated as IDC lock is held while enabling the interrupts Fix: Correctly handle IDC locking mechanism in qla4_8xxx_error_recovery(). Signed-off-by: Poornima Vonti Signed-off-by: Vikas Chaudhary --- drivers/scsi

[PATCH 04/12] qla4xxx: Rename 82XX macros

2012-08-22 Thread vikas . chaudhary
From: Vikas Chaudhary Signed-off-by: Vikas Chaudhary --- drivers/scsi/qla4xxx/ql4_attr.c |6 +- drivers/scsi/qla4xxx/ql4_def.h |2 +- drivers/scsi/qla4xxx/ql4_fw.h | 10 ++-- drivers/scsi/qla4xxx/ql4_mbx.c |2 +- drivers/scsi/qla4xxx/ql4_nx.c | 152

Re: [PATCH 0/12] qla4xxx: Updates for scsi "misc" branch.

2012-08-22 Thread Vikas Chaudhary
stie Cc: scsi , Vikas , Lalit Chandivade , Ravi Anand Subject: [PATCH 0/12] qla4xxx: Updates for scsi "misc" branch. >From: Vikas Chaudhary > >James, > >Please apply the following patches to the scsi tree at your earliest >convenience. > >Following patches are to add

[PATCH 11/12] qla4xxx: Update Copyright header

2012-08-22 Thread vikas . chaudhary
From: Vikas Chaudhary Signed-off-by: Vikas Chaudhary --- drivers/scsi/qla4xxx/ql4_dbg.c |2 +- drivers/scsi/qla4xxx/ql4_dbg.h |2 +- drivers/scsi/qla4xxx/ql4_def.h |2 +- drivers/scsi/qla4xxx/ql4_fw.h |2 +- drivers/scsi/qla4xxx/ql4_glbl.h|2 +- drivers

[PATCH 12/12] qla4xxx: Update driver version to 5.03.00-k0

2012-08-22 Thread vikas . chaudhary
From: Vikas Chaudhary Signed-off-by: Vikas Chaudhary --- drivers/scsi/qla4xxx/ql4_version.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/qla4xxx/ql4_version.h b/drivers/scsi/qla4xxx/ql4_version.h index 51d8995..0c329ac 100644 --- a/drivers/scsi

[PATCH 09/12] qla4xxx: Added new function qla4_8xxx_get_minidump

2012-08-22 Thread vikas . chaudhary
From: Vikas Chaudhary Move minidump code from qla4_8xxx_device_bootstrap() to new function qla4_8xxx_get_minidump() to make code more modular. Signed-off-by: Lalit Chandivade Signed-off-by: Vikas Chaudhary --- drivers/scsi/qla4xxx/ql4_nx.c | 24 +++- 1 files changed, 15

  1   2   >