[PATCH v3 1/4] target: use consistent left-aligned ASCII INQUIRY data

2018-11-19 Thread David Disseldorp
spc5r17.pdf specifies: 4.3.1 ASCII data field requirements ASCII data fields shall contain only ASCII printable characters (i.e., code values 20h to 7Eh) and may be terminated with one or more ASCII null (00h) characters. ASCII data fields described as being left-aligned shall have any

[PATCH v3 2/4] target: don't assume t10_wwn.vendor is null terminated

2018-11-19 Thread David Disseldorp
Signed-off-by: David Disseldorp --- drivers/target/target_core_stat.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/target/target_core_stat.c b/drivers/target/target_core_stat.c index f0db91ebd735..89f35167f036 100644 ---

[PATCH v3 4/4] target: remove hardcoded T10 Vendor ID in INQUIRY response

2018-11-19 Thread David Disseldorp
Use the value stored in t10_wwn.vendor, which defaults to "LIO-ORG", but can be reconfigured via the vendor_id ConfigFS attribute. Signed-off-by: David Disseldorp --- drivers/target/target_core_spc.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git

[PATCH v3 0/4] target: user configurable T10 Vendor ID

2018-11-19 Thread David Disseldorp
This patchset allows for the modification of the T10 Vendor Identification string returned in the SCSI INQUIRY response, via the target/core/$backstore/$name/wwn/vendor_id ConfigFS path. Changes since v2: - https://www.spinics.net/lists/target-devel/msg10720.html - Support eight byte vendor ID

[PATCH v3 3/4] target: add device vendor_id configfs attribute

2018-11-19 Thread David Disseldorp
The vendor_id attribute will allow for the modification of the T10 Vendor Identification string returned in inquiry responses. Its value can be viewed and modified via the ConfigFS path at: target/core/$backstore/$name/wwn/vendor_id "LIO-ORG" remains the default value, which is set when the

Re: [PATCH v4 1/5] qla2xxx_nvmet: Add FC-NVMe Target Link Service request handling

2018-11-19 Thread James Smart
On 10/31/2018 9:40 AM, Himanshu Madhani wrote: From: Anil Gurumurthy This patch provides link service pass through feature handling in the driver. This feature is implemented mainly by the firmware and the same implementation is handled in the driver via an IOCB interface. Signed-off-by:

Re: [PATCHv3 2/3] scsi: Do not rely on blk-mq for double completions

2018-11-19 Thread Keith Busch
On Mon, Nov 19, 2018 at 12:58:15AM -0800, Christoph Hellwig wrote: > > index 5d83a162d03b..c1d5e4e36125 100644 > > --- a/drivers/scsi/scsi_lib.c > > +++ b/drivers/scsi/scsi_lib.c > > @@ -1635,8 +1635,11 @@ static blk_status_t scsi_mq_prep_fn(struct request > > *req) > > > > static void

Re: [PATCHv3 2/3] scsi: Do not rely on blk-mq for double completions

2018-11-19 Thread Jens Axboe
On 11/19/18 1:58 AM, Christoph Hellwig wrote: >> index 5d83a162d03b..c1d5e4e36125 100644 >> --- a/drivers/scsi/scsi_lib.c >> +++ b/drivers/scsi/scsi_lib.c >> @@ -1635,8 +1635,11 @@ static blk_status_t scsi_mq_prep_fn(struct request >> *req) >> >> static void scsi_mq_done(struct scsi_cmnd *cmd)

RE: [PATCH 6/8] bsg-lib: handle bidi requests without block layer help

2018-11-19 Thread Avri Altman
> -Original Message- > From: linux-scsi-ow...@vger.kernel.org > On Behalf Of Christoph Hellwig > Sent: Sunday, November 11, 2018 3:32 PM > To: ax...@kernel.dk; martin.peter...@oracle.com; o...@electrozaur.com > Cc: Johannes Thumshirn ; Benjamin Block > ; linux-scsi@vger.kernel.org;

RE: [PATCH 5/8] bsg: refactor bsg_ioctl

2018-11-19 Thread Avri Altman
> On Sun, Nov 11, 2018 at 02:32:08PM +0100, Christoph Hellwig wrote: > > Move all actual functionality into helpers, just leaving the dispatch > > in this function. > > > > Signed-off-by: Christoph Hellwig > > --- > > block/bsg.c | 158 >

Re: [PATCH v5] target: add emulate_pr backstore attr to toggle PR support

2018-11-19 Thread David Disseldorp
Ping, did anyone get a chance to look at this one? Cheers, David

[PATCH -next] scsi: dpt_i2o: remove set but not used variable ''

2018-11-18 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning: drivers/scsi/dpt_i2o.c: In function 'adpt_slave_configure': drivers/scsi/dpt_i2o.c:414:12: warning: variable 'pHba' set but not used [-Wunused-but-set-variable] It never used since git history start. Signed-off-by: YueHaibing ---

[PATCH -next] [SCSI] initio: remove set but not used variable 'prev'

2018-11-18 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning: drivers/scsi/initio.c: In function 'initio_find_busy_scb': drivers/scsi/initio.c:883:30: warning: variable 'prev' set but not used [-Wunused-but-set-variable] It never used since introduction in commit 72d39fea9017 ("[SCSI] initio: Convert into a

9305-16i fault 0x5853 (regression from 4.17.2 to 4.19.2)

2018-11-18 Thread Matt Corallo
(not subscribed to lists, please keep me on CC) When upgrading from 4.17.2 to 4.19.2, my 9305-16i started faulting on load (well, not so much load given its all spinning disks, but once every hour or five during a btrfs rebalance). Mostly the disks would all come back online and it would just

Compliment of the day,

2018-11-16 Thread Mr.Philippines
Compliment of the day, I am Mr.Philippine.Kabore I Have a Business Proposal of $5.3 million For You. I am aware of the unsafe nature of the internet, and was compelled to use this medium due to the nature of this project. I have access to very vital information that can be used to transfer this

Re: [PATCH 16/23] zfcp: use enum zfcp_erp_steps for struct zfcp_erp_action.step

2018-11-16 Thread Hannes Reinecke
On 11/16/18 3:19 PM, Steffen Maier wrote: On 11/16/2018 12:17 PM, Hannes Reinecke wrote: On 11/8/18 3:44 PM, Steffen Maier wrote: Use the already defined enum for this purpose to get at least some build checking (even though an enum is type equivalent to an int in C). v2.6.27 commit

Re: [PATCH v2] megaraid_sas: Add support for MegaRAID Aero controllers

2018-11-16 Thread Hannes Reinecke
On 11/9/18 6:47 PM, Shivasharan S wrote: This patch adds support for MegaRAID Aero controller PCI IDs. Throw a message when a Configurable secure type controller is encountered. Signed-off-by: Shivasharan S --- Changes in v2: Change dev_warn to dev_info. drivers/scsi/megaraid/megaraid_sas.h

Re: [RFC PATCH 0/3] target: remove some unused stats

2018-11-16 Thread David Disseldorp
Hi Mike On Tue, 30 Oct 2018 10:54:07 -0500, Mike Christie wrote: > >> This patchset removes a couple of unused error stat counters and a > >> redundant cumulative counter. > >> I've tagged this patchset RFC, as it may be considered a kernel<->user > >> (configfs) API change. > > > > Ping, any

Re: [PATCH 12/23] zfcp: update kernel message for invalid FCP_CMND length, it's not the CDB

2018-11-16 Thread Steffen Maier
On 11/16/2018 12:13 PM, Hannes Reinecke wrote: On 11/8/18 3:44 PM, Steffen Maier wrote: The CDB is just a part inside of FCP_CMND, see zfcp_fc_scsi_to_fcp(). While at it, fix the device driver reaction: adapter not LUN shutdown. Signed-off-by: Steffen Maier Reviewed-by: Benjamin Block ---  

Re: [PATCH 16/23] zfcp: use enum zfcp_erp_steps for struct zfcp_erp_action.step

2018-11-16 Thread Steffen Maier
On 11/16/2018 12:17 PM, Hannes Reinecke wrote: On 11/8/18 3:44 PM, Steffen Maier wrote: Use the already defined enum for this purpose to get at least some build checking (even though an enum is type equivalent to an int in C). v2.6.27 commit 287ac01acf22 ("[SCSI] zfcp: Cleanup code in

Re: [PATCH 23/23] zfcp: drop old default switch case which might paper over missing case

2018-11-16 Thread Hannes Reinecke
On 11/8/18 3:44 PM, Steffen Maier wrote: This was introduced with v2.6.27 commit 287ac01acf22 ("[SCSI] zfcp: Cleanup code in zfcp_erp.c") but would now suppress helpful -Wswitch compiler warnings when building with W=1 such as the following forced example: drivers/s390/scsi/zfcp_erp.c: In

Re: [PATCH 22/23] zfcp: drop default switch case which might paper over missing case

2018-11-16 Thread Hannes Reinecke
On 11/8/18 3:44 PM, Steffen Maier wrote: This was introduced with v4.18 commit 8c3d20aada70 ("scsi: zfcp: fix missing REC trigger trace for all objects in ERP_FAILED") but would now suppress helpful -Wswitch compiler warnings when building with W=1 such as the following forced example:

Re: [PATCH 21/23] zfcp: silence -Wimplicit-fallthrough in zfcp_erp_lun_strategy()

2018-11-16 Thread Hannes Reinecke
On 11/8/18 3:44 PM, Steffen Maier wrote: For some reason the already existing substring "fall through" in the comment is not sufficient for GCC to silence -Wimplicit-fallthrough. CC [M] drivers/s390/scsi/zfcp_erp.o drivers/s390/scsi/zfcp_erp.c: In function 'zfcp_erp_lun_strategy':

Re: [PATCH 19/23] zfcp: silence all W=1 build warnings for existing kdoc

2018-11-16 Thread Hannes Reinecke
On 11/8/18 3:44 PM, Steffen Maier wrote: While at it also improve some copy kdoc mistakes. Signed-off-by: Steffen Maier Reviewed-by: Benjamin Block --- drivers/s390/scsi/zfcp_dbf.c | 13 - drivers/s390/scsi/zfcp_erp.c | 6 +++--- drivers/s390/scsi/zfcp_fc.c | 2 +-

Re: [PATCH 20/23] zfcp: silence remaining kdoc warnings in header files

2018-11-16 Thread Hannes Reinecke
On 11/8/18 3:44 PM, Steffen Maier wrote: Improve whatever the following simple invocation reported: $ ./scripts/kernel-doc -none drivers/s390/scsi/*.h While at it, improve some related kdoc, including struct zfcp_fsf_ct_els in zfcp_fsf.h. Signed-off-by: Steffen Maier Reviewed-by: Benjamin

Re: [PATCH 18/23] zfcp: properly format LUN (and WWPN) for LUN sharing violation kmsg

2018-11-16 Thread Hannes Reinecke
On 11/8/18 3:44 PM, Steffen Maier wrote: zfcp: : LUN 0x0 on port 0x5005076. ... zfcp: : LUN 0x1 on port 0x5005076. ... should be zfcp: : LUN 0x on port 0x5005076. ... zfcp: : LUN 0x0001 on port 0x5005076.

Re: [PATCH 17/23] zfcp: use enum zfcp_erp_act_result for argument/return of affected functions

2018-11-16 Thread Hannes Reinecke
On 11/8/18 3:44 PM, Steffen Maier wrote: With that instead of just "int" it becomes clear which functions return this type and which ones also accept it as argument they just pass through in some cases or modify in other cases. v2.6.27 commit 287ac01acf22 ("[SCSI] zfcp: Cleanup code in

Re: [PATCH 16/23] zfcp: use enum zfcp_erp_steps for struct zfcp_erp_action.step

2018-11-16 Thread Hannes Reinecke
On 11/8/18 3:44 PM, Steffen Maier wrote: Use the already defined enum for this purpose to get at least some build checking (even though an enum is type equivalent to an int in C). v2.6.27 commit 287ac01acf22 ("[SCSI] zfcp: Cleanup code in zfcp_erp.c") introduced the enum which was cpp defines

Re: [PATCH 15/23] zfcp: the action field of zfcp_erp_action is actually the type

2018-11-16 Thread Hannes Reinecke
On 11/8/18 3:44 PM, Steffen Maier wrote: _erp_action.action ==> _erp_action.type While at it, make use of the already defined enum for this purpose to get at least some build checking (even though an enum is type equivalent to an int in C). v2.6.27 commit 287ac01acf22 ("[SCSI] zfcp: Cleanup

Re: [PATCH 14/23] zfcp: clarify function argument name for trace tag string

2018-11-16 Thread Hannes Reinecke
On 11/8/18 3:44 PM, Steffen Maier wrote: v2.6.30 commit 5ffd51a5e495 ("[SCSI] zfcp: replace current ERP logging with a more convenient version") changed trace record distinguishing from a numerical ID to a 7 character string called "trace tag". While starting to use function arguments with

Re: [PATCH 13/23] zfcp: ERP thread setup kdoc update

2018-11-16 Thread Hannes Reinecke
On 11/8/18 3:44 PM, Steffen Maier wrote: zfcp_erp_thread_setup() update complements v2.6.32 commit 347c6a965dc1 ("[SCSI] zfcp: Use kthread API for zfcp erp thread"). Signed-off-by: Steffen Maier Reviewed-by: Benjamin Block --- drivers/s390/scsi/zfcp_erp.c | 2 +- 1 file changed, 1

Re: [PATCH 12/23] zfcp: update kernel message for invalid FCP_CMND length, it's not the CDB

2018-11-16 Thread Hannes Reinecke
On 11/8/18 3:44 PM, Steffen Maier wrote: The CDB is just a part inside of FCP_CMND, see zfcp_fc_scsi_to_fcp(). While at it, fix the device driver reaction: adapter not LUN shutdown. Signed-off-by: Steffen Maier Reviewed-by: Benjamin Block --- drivers/s390/scsi/zfcp_fsf.c | 7 ++- 1

Re: [PATCH 11/23] zfcp: drop duplicate seq_no from zfcp_fsf_req which is also in QTCB header

2018-11-16 Thread Hannes Reinecke
On 11/8/18 3:44 PM, Steffen Maier wrote: There is no point for double bookkeeping especially just for tracing. The trace can take it from the QTCB which always exists for non-SRB responses traced with zfcp_dbf_hba_fsf_res(). As a side effect, this removes an alignment hole and reduces the size

Re: [PATCH 10/23] zfcp: drop duplicate fsf_command from zfcp_fsf_req which is also in QTCB header

2018-11-16 Thread Hannes Reinecke
On 11/8/18 3:44 PM, Steffen Maier wrote: Status read buffers (SRBs, unsolicited notifications) never use a QTCB [zfcp_fsf_req_create()]. zfcp_fsf_req_send() already uses this to distinguish SRBs from other FSF request types. We can re-use this method in zfcp_fsf_req_complete(). Introduce a

Re: [PATCH 09/23] zfcp: drop unnecessary forward prototype for struct zfcp_fsf_req

2018-11-16 Thread Hannes Reinecke
On 11/8/18 3:44 PM, Steffen Maier wrote: Signed-off-by: Steffen Maier Reviewed-by: Benjamin Block --- drivers/s390/scsi/zfcp_def.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/s390/scsi/zfcp_def.h b/drivers/s390/scsi/zfcp_def.h index 31b3e2bb3b42..572debf2f528 100644 ---

Re: [PATCH 07/23] zfcp: namespace prefix for internal latency data structures

2018-11-16 Thread Hannes Reinecke
On 11/8/18 3:44 PM, Steffen Maier wrote: In contrast to struct fsf_qual_latency_info, the ones here are not FSF but software defined zfcp-internal. Signed-off-by: Steffen Maier Reviewed-by: Benjamin Block --- drivers/s390/scsi/zfcp_def.h | 14 +++--- drivers/s390/scsi/zfcp_fsf.c |

Re: [PATCH 08/23] zfcp: group sort internal structure definitions for proximity

2018-11-16 Thread Hannes Reinecke
On 11/8/18 3:44 PM, Steffen Maier wrote: Have structures just before the structures that use them (without disrupting sequences of using structures such as zfcp_unit and zfcp_scsi_dev): - zfcp_adapter_mempool embedded in zfcp_adapter, - zfcp_latenc... embedded in zfcp_scsi_dev. Signed-off-by:

Re: [PATCH 06/23] zfcp: update width in comment for ZFCP_COMMON_FLAGS mask

2018-11-16 Thread Hannes Reinecke
On 11/8/18 3:44 PM, Steffen Maier wrote: v2.6.10 history commit 4062e12b2ba2 ("[PATCH] s390: zfcp act enhancements") extended this mask by one nibble with the introduction of ZFCP_STATUS_COMMON_ACCESS_DENIED == 0x0080 for ACT (access control table). Signed-off-by: Steffen Maier

Re: [PATCH 05/23] zfcp: move scsi_eh & non-ERP timeout defines owned by and local to zfcp_fsf.c

2018-11-16 Thread Hannes Reinecke
On 11/8/18 3:44 PM, Steffen Maier wrote: Also clarify namespace prefix for the timeout used for FSF requests on behalf of SCSI error recovery: It is zfcp_fsf_ not zfcp_scsi_. Signed-off-by: Steffen Maier Reviewed-by: Benjamin Block --- drivers/s390/scsi/zfcp_def.h | 6 --

Re: [PATCH 04/23] zfcp: drop unnecessary forward prototype for struct zfcp_reqlist

2018-11-16 Thread Hannes Reinecke
On 11/8/18 3:44 PM, Steffen Maier wrote: While struct zfcp_adapter contains a pointer to zfcp_reqlist, the pointer field does not need to know the structure or even a prototype. The prototype was introduced with v2.6.34 commit b6bd2fb92a7b ("[SCSI] zfcp: Move FSF request tracking code to new

Re: [PATCH 03/23] zfcp: move SG table helper from aux to fc and make them static

2018-11-16 Thread Hannes Reinecke
On 11/8/18 3:44 PM, Steffen Maier wrote: Since commit 663e0890e31c ("[SCSI] zfcp: remove access control tables interface") these helper functions are only used for auto port scan in zfcp_fc.c. Also change them to the corresponding namespace prefix. This is a small cleanup for the miscellaneous

Re: [PATCH 02/22] zfcp: remove unnecessary null pointer check before mempool_destroy

2018-11-16 Thread Hannes Reinecke
On 11/8/18 3:44 PM, Steffen Maier wrote: From: zhong jiang mempool_destroy has taken null pointer check into account. so remove the redundant check. Signed-off-by: zhong jiang Acked-by: Benjamin Block [ma...@linux.ibm.com: depends on v4.3 4e3ca3e033d1 ("mm/mempool: allow NULL `pool'

Re: [PATCH] scsi: lpfc: fix block guard enablement on SLI3 adapters

2018-11-16 Thread Hannes Reinecke
On 11/12/18 9:58 AM, Martin Wilck wrote: Since f44ac12f1dcc, BG enablement is tracked with the LPFC_SLI3_BG_ENABLED bit, which is set in lpfc_get_cfgparam before lpfc_sli_config_sli_port() is called. The bit shouldn't be cleared before checking the feature. Based on problem analysis by David

Re: [PATCH -next] scsi: libfc: Remove set but not used variable 'disc'

2018-11-16 Thread Johannes Thumshirn
Looks good, Reviewed-by: Johannes Thumshirn

Re: [PATCH] qla2xxx: Add SysFS hook for FC-NVMe autoconnect

2018-11-15 Thread Hannes Reinecke
On 11/15/18 5:40 PM, Ewan D. Milne wrote: On Thu, 2018-11-15 at 13:52 +0100, Hannes Reinecke wrote: On 11/14/18 6:13 PM, Ewan D. Milne wrote: On Tue, 2018-11-13 at 09:49 -0800, Bart Van Assche wrote: On Tue, 2018-11-13 at 17:38 +, Madhani, Himanshu wrote: On Nov 13, 2018, at 6:23 AM,

Re: [PATCH] qla2xxx: Add SysFS hook for FC-NVMe autoconnect

2018-11-15 Thread James Smart
On 11/15/2018 8:43 AM, Ewan D. Milne wrote: On Thu, 2018-11-15 at 13:52 +0100, Hannes Reinecke wrote: On 11/14/18 6:13 PM, Ewan D. Milne wrote: On Tue, 2018-11-13 at 09:49 -0800, Bart Van Assche wrote: On Tue, 2018-11-13 at 17:38 +, Madhani, Himanshu wrote: On Nov 13, 2018, at 6:23

Re: [PATCH] qla2xxx: Add SysFS hook for FC-NVMe autoconnect

2018-11-15 Thread James Smart
On 11/15/2018 4:52 AM, Hannes Reinecke wrote: On 11/14/18 6:13 PM, Ewan D. Milne wrote: On Tue, 2018-11-13 at 09:49 -0800, Bart Van Assche wrote: On Tue, 2018-11-13 at 17:38 +, Madhani, Himanshu wrote: On Nov 13, 2018, at 6:23 AM, Bart Van Assche wrote: On Tue, 2018-11-13 at 01:02

Re: dma related cleanups for wd719x v2

2018-11-15 Thread Martin K. Petersen
Christoph, > Various dma relates cleanups Applied to 4.21/scsi-queue, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: use dma_set_mask and dma_set_mask_and_coherent

2018-11-15 Thread Martin K. Petersen
Christoph, > Various SCSI drivers that otherwise use the generic DMA API > still use pci_set_dma_mask, so switch them over to dma_set_mask > and dma_set_mask_and_coherent. Applied to 4.21/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] qla2xxx: Add SysFS hook for FC-NVMe autoconnect

2018-11-15 Thread Ewan D. Milne
On Thu, 2018-11-15 at 13:52 +0100, Hannes Reinecke wrote: > On 11/14/18 6:13 PM, Ewan D. Milne wrote: > > On Tue, 2018-11-13 at 09:49 -0800, Bart Van Assche wrote: > > > On Tue, 2018-11-13 at 17:38 +, Madhani, Himanshu wrote: > > > > On Nov 13, 2018, at 6:23 AM, Bart Van Assche wrote: > > > >

LAENUD

2018-11-15 Thread EPIC LOANS
Lugupeetud härra / proua,   Minu nimi on Steve Miller Ühendkuningriigis asuvast äriühingust EPIC LOANS, kes on pühendunud pakkuma oma klientidele kiiret ja lihtsat isikliku laenu teenust. Teeme kõik endast oleneva, et rahuldada iga kliendi vajadusi. Pakume igasuguseid laene ligikaudu 5000 euro

Re: [PATCH] qla2xxx: Add SysFS hook for FC-NVMe autoconnect

2018-11-15 Thread Hannes Reinecke
On 11/14/18 6:13 PM, Ewan D. Milne wrote: On Tue, 2018-11-13 at 09:49 -0800, Bart Van Assche wrote: On Tue, 2018-11-13 at 17:38 +, Madhani, Himanshu wrote: On Nov 13, 2018, at 6:23 AM, Bart Van Assche wrote: On Tue, 2018-11-13 at 01:02 +, Madhani, Himanshu wrote: I see other drivers

panic in mpt3sas driver in kernel-4.19

2018-11-14 Thread Yang Yingliang
Hi, all When I run some stable tests on D05 board with kernel-4.19.0, I got this kernel panic twice: first time: [26994.792533] Kernel panic - not syncing: 4mpt3sas_cm0: _config_request: Firmware BUG: mpi_reply mismatch: Requested ExtPageType(0x12) Reply ExtPageType(0x10)

[PATCH] iser: set sector for ambiguous mr status errors

2018-11-14 Thread Sagi Grimberg
If for some reason we failed to query the mr status, we need to make sure to provide sufficient information for an ambiguous error (guard error on sector 0). Fixes: 0a7a08ad6f5f ("IB/iser: Implement check_protection") Cc: Reported-by: Dan Carpenter Signed-off-by: Sagi Grimberg ---

Re: [PATCH] qla2xxx: Add SysFS hook for FC-NVMe autoconnect

2018-11-14 Thread Ewan D. Milne
On Tue, 2018-11-13 at 09:49 -0800, Bart Van Assche wrote: > On Tue, 2018-11-13 at 17:38 +, Madhani, Himanshu wrote: > > On Nov 13, 2018, at 6:23 AM, Bart Van Assche wrote: > > > On Tue, 2018-11-13 at 01:02 +, Madhani, Himanshu wrote: > > > > I see other drivers also use similar

Re: [PATCH] qla2xxx: Add SysFS hook for FC-NVMe autoconnect

2018-11-13 Thread Bart Van Assche
On Tue, 2018-11-13 at 17:38 +, Madhani, Himanshu wrote: > On Nov 13, 2018, at 6:23 AM, Bart Van Assche wrote: > > On Tue, 2018-11-13 at 01:02 +, Madhani, Himanshu wrote: > > > I see other drivers also use similar information populated for NVMe > > > Connection at boot time. > > > > Hi

Re: [PATCH] qla2xxx: Add SysFS hook for FC-NVMe autoconnect

2018-11-13 Thread Madhani, Himanshu
> On Nov 13, 2018, at 6:23 AM, Bart Van Assche wrote: > > External Email > > On Tue, 2018-11-13 at 01:02 +, Madhani, Himanshu wrote: >> I see other drivers also use similar information populated for NVMe >> Connection at boot time. > > Hi Himanshu, > > Which other drivers are you

Re: [PATCH] qla2xxx: Add SysFS hook for FC-NVMe autoconnect

2018-11-13 Thread Bart Van Assche
On Tue, 2018-11-13 at 01:02 +, Madhani, Himanshu wrote: > I see other drivers also use similar information populated for NVMe > Connection at boot time. Hi Himanshu, Which other drivers are you referring to? Thanks, Bart.

[PATCH -next] scsi: ufs: Use PTR_ERR_OR_ZERO in ufs_hisi_get_resource()

2018-11-13 Thread YueHaibing
Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR Signed-off-by: YueHaibing --- drivers/scsi/ufs/ufs-hisi.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/scsi/ufs/ufs-hisi.c b/drivers/scsi/ufs/ufs-hisi.c index 452e19f..6fdf059 100644 ---

[PATCH -next] scsi: pmcraid: remove set but not used variables 'res, access'

2018-11-12 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning: drivers/scsi/pmcraid.c: In function 'pmcraid_abort_cmd': drivers/scsi/pmcraid.c:2878:33: warning: variable 'res' set but not used [-Wunused-but-set-variable] drivers/scsi/pmcraid.c: In function 'pmcraid_ioctl_passthrough':

[PATCH -next] scsi: ufs: Fix platform_no_drv_owner.cocci warnings

2018-11-12 Thread YueHaibing
Remove .owner field if calls are used which set it automatically Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci Signed-off-by: YueHaibing --- drivers/scsi/ufs/cdns-pltfrm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/scsi/ufs/cdns-pltfrm.c

Re: [PATCH] qla2xxx: Add SysFS hook for FC-NVMe autoconnect

2018-11-12 Thread Madhani, Himanshu
Hi Bart, > On Nov 12, 2018, at 2:06 PM, Bart Van Assche wrote: > > External Email > > On Mon, 2018-11-12 at 13:40 -0800, Himanshu Madhani wrote: >> diff --git a/drivers/scsi/qla2xxx/qla_attr.c >> b/drivers/scsi/qla2xxx/qla_attr.c >> index 678aff5ca947..323a4aa35f16 100644 >> ---

Re: [PATCH] qla2xxx: Add SysFS hook for FC-NVMe autoconnect

2018-11-12 Thread Bart Van Assche
On Mon, 2018-11-12 at 13:40 -0800, Himanshu Madhani wrote: > diff --git a/drivers/scsi/qla2xxx/qla_attr.c > b/drivers/scsi/qla2xxx/qla_attr.c > index 678aff5ca947..323a4aa35f16 100644 > --- a/drivers/scsi/qla2xxx/qla_attr.c > +++ b/drivers/scsi/qla2xxx/qla_attr.c > @@ -1665,6 +1665,125 @@

[PATCH] qla2xxx: Add SysFS hook for FC-NVMe autoconnect

2018-11-12 Thread Himanshu Madhani
This patch adds a SysFS hook for systemd service to kick off autoconnect command at the boot time. Output of the SysFS hook will provide host-traddr/traddr which will be used by NVMe CLI to kick off discovery at boot time. Signed-off-by: Himanshu Madhani --- Hi Martin, This patch provides

With Due Respect!

2018-11-12 Thread Mr.Ghazi Ahmed
Hi friend I am a banker in ADB BANK. I want to transfer an abandoned $10.2Million to your Bank account. 40/percent will be your share. For more details contanct me urgently. Yours Mr Ghazi Ahmed

Re: [PATCH V2] sg3_utils: sg_write_buffer: convert string to integer while reading from stdio

2018-11-12 Thread Douglas Gilbert
On 2018-11-12 11:32 a.m., Bean Huo (beanhuo) wrote: This patch is to convert inputted string to the integer when read data from stdin. While entering data flow, the data between bytes can be separated by either space, or ',' (or by '.'). V1-V2: 1. Rebased the patch on the latest

[PATCH V2] sg3_utils: sg_write_buffer: convert string to integer while reading from stdio

2018-11-12 Thread Bean Huo (beanhuo)
This patch is to convert inputted string to the integer when read data from stdin. While entering data flow, the data between bytes can be separated by either space, or ',' (or by '.'). V1-V2: 1. Rebased the patch on the latest sg_write_buffer.c 2. Added the wrong input checkup,

Inquiry 12/11/2018

2018-11-12 Thread sinara-group
Hi,friend, This is Daniel Murray and i am from Sinara Group Co.Ltd Group Co.,LTD in Russia. We are glad to know about your company from the web and we are interested in your products. Could you kindly send us your Latest catalog and price list for our trial order. Best Regards, Daniel

[PATCH] scsi: lpfc: fix block guard enablement on SLI3 adapters

2018-11-12 Thread Martin Wilck
Since f44ac12f1dcc, BG enablement is tracked with the LPFC_SLI3_BG_ENABLED bit, which is set in lpfc_get_cfgparam before lpfc_sli_config_sli_port() is called. The bit shouldn't be cleared before checking the feature. Based on problem analysis by David Bond. Fixes: f44ac12f1dcc "scsi: lpfc: Memory

Re: [PATCH -next] scsi: bnx2i: remove set but not used variable 'cid_num'

2018-11-11 Thread Javali, Nilesh
On 11/12/18, 7:24 AM, "YueHaibing" wrote: >External Email > >Fixes gcc '-Wunused-but-set-variable' warning: > >drivers/scsi/bnx2i/bnx2i_hwi.c: In function 'bnx2i_process_ofld_cmpl': >drivers/scsi/bnx2i/bnx2i_hwi.c:2430:6: warning: > variable 'cid_num' set but not used

[PATCH -next] scsi: bnx2i: remove set but not used variable 'cid_num'

2018-11-11 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning: drivers/scsi/bnx2i/bnx2i_hwi.c: In function 'bnx2i_process_ofld_cmpl': drivers/scsi/bnx2i/bnx2i_hwi.c:2430:6: warning: variable 'cid_num' set but not used [-Wunused-but-set-variable] It never used since commit cf4e6363859d ("[SCSI] bnx2i: Add

Price Inquiry

2018-11-11 Thread Daniel Murray
Hi,friend, This is Daniel Murray and i am from Sinara Group Co.Ltd Group Co.,LTD in Russia. We are glad to know about your company from the web and we are interested in your products. Could you kindly send us your Latest catalog and price list for our trial order. Best Regards, Daniel

RE,

2018-11-10 Thread Miss Juliet Muhammad
I have a deal for you, in your region.

Re: [PATCH v1] sg3_utils: sg_write_buffer: convert string to integer while reading from stdio

2018-11-10 Thread Bean Huo (beanhuo)
Hi, Doug Gilbert >>On 2018-11-09 7:18 p.m., Bean Huo (beanhuo) wrote: >> This patch is to convert inputted string to the integer when read data >> from stdin. While entering data, the data between bytes can be >> separated by space, or by ',' or by '.'. > >Could you send me this patch against

[PATCH] scsi: csiostor: remove automatic irq affinity assignment

2018-11-10 Thread Varun Prakash
If number of interrupt vectors are more than num_online_cpus() then pci_alloc_irq_vectors_affinity() assigns cpumask based on num_possible_cpus() to the remaining vectors because of this interrupts are not generating for these vectors. This patch fixes this issue by using pci_alloc_irq_vectors()

SPENDE

2018-11-10 Thread info
Sehr geehrter Herr/Frau, Wir freuen uns, Ihnen mitzuteilen, dass Sie ausgewählt wurden, um die Summe zu erhalten €2,000,000.00 Euro aus Mitteln der Mavis Wanczyk Hilfe. Mein Name ist Mavis Wanczyk der Gewinner des 758,7 Millionen US-Dollar in der Power Ball Lotterie Jackpot als der größte

Re:Hi

2018-11-10 Thread Cynthia Hazem
How are you doing today,hope fine,My name is cynthia and i am a girl. I saw your contact email today and decided to extend my greetings to you. But I do have the mind that you could be a nice person is my believe and there are nice people out there who can appreciate the value of

Re:Hi

2018-11-10 Thread Cynthia Hazem
How are you doing today,hope fine,My name is cynthia and i am a girl. I saw your contact email today and decided to extend my greetings to you. But I do have the mind that you could be a nice person is my believe and there are nice people out there who can appreciate the value of

[PATCH v3] aha1542: convert to DMA mapping API

2018-11-10 Thread Christoph Hellwig
aha1542 is one of the last users of the legacy isa_*_to_bus APIs, which also isn't portable enough. Convert it to the proper DMA mapping API. Thanks to Ondrej Zary for testing and finding and fixing a crucial bug. Signed-off-by: Christoph Hellwig --- Changes since v2: - fix another sizeof of

Re: [PATCH] aha1542: convert to DMA mapping API

2018-11-10 Thread Christoph Hellwig
> > @@ -826,7 +881,8 @@ static int aha1542_dev_reset(struct scsi_cmnd *cmd) > > > > aha1542->aha1542_last_mbo_used = mbo; > > > > - any2scsi(mb[mbo].ccbptr, isa_virt_to_bus([mbo])); /* This gets > > trashed for some reason */ > > + /* This gets trashed for some reason */ > > +

Re: [PATCH v1] sg3_utils: sg_write_buffer: convert string to integer while reading from stdio

2018-11-09 Thread Douglas Gilbert
On 2018-11-09 7:18 p.m., Bean Huo (beanhuo) wrote: This patch is to convert inputted string to the integer when read data from stdin. While entering data, the data between bytes can be separated by space, or by ',' or by '.'. Could you send me this patch against sg_write_buffer.c as found in

Re: [PATCH] aha1542: convert to DMA mapping API

2018-11-09 Thread Ondrej Zary
On Friday 09 November 2018 16:45:54 Christoph Hellwig wrote: > aha1542 is one of the last users of the legacy isa_*_to_bus APIs, which > also isn't portable enough. Convert it to the proper DMA mapping API. > > Thanks to Ondrej Zary for testing and finding and fixing a crucial > bug. > >

[PATCH v1] sg3_utils: sg_write_buffer: convert string to integer while reading from stdio

2018-11-09 Thread Bean Huo (beanhuo)
This patch is to convert inputted string to the integer when read data from stdin. While entering data, the data between bytes can be separated by space, or by ',' or by '.'. Signed-off-by: Bean Huo --- src/sg_write_buffer.c | 31 +++ 1 file changed, 31 insertions(+)

[PATCH v2] megaraid_sas: Add support for MegaRAID Aero controllers

2018-11-09 Thread Shivasharan S
This patch adds support for MegaRAID Aero controller PCI IDs. Throw a message when a Configurable secure type controller is encountered. Signed-off-by: Shivasharan S --- Changes in v2: Change dev_warn to dev_info. drivers/scsi/megaraid/megaraid_sas.h | 4

Re: [PATCH] megaraid_sas: Add support for MegaRAID Aero controllers

2018-11-09 Thread Shivasharan Srikanteshwara
On Fri, Nov 9, 2018 at 7:43 AM Martin K. Petersen wrote: > Shivasharan, > > > This patch adds support for MegaRAID Aero controller PCI IDs. > > Throw a warning message when a Configurable secure type controller is > > encountered. > > > + dev_warn(>dev, "Adapter is in configurable

Re: [PATCH 4/4] gdth: use generic DMA API

2018-11-09 Thread Christoph Hellwig
On Fri, Oct 19, 2018 at 09:42:28AM +1100, Finn Thain wrote: > On Thu, 18 Oct 2018, Christoph Hellwig wrote: > > > Switch from the legacy PCI DMA API to the generic DMA API. Also switch > > to dma_map_single from pci_map_page in one case where this makes the code > > simpler. > > > >

Hello My Beloved One

2018-11-09 Thread Aisha Gaddafi
Assalamu alaikum, I came across your e-mail contact prior a private search while in need of a trusted person. My name is Mrs. Aisha Gaddafi, a single Mother and a Widow with three Children. I am the only biological Daughter of late Libyan President (Late Colonel Muammar Gaddafi)I have a

Re: [PATCH 2/4] gdth: reuse dma coherent allocation in gdth_show_info

2018-11-09 Thread Christoph Hellwig
> > > > -buf = gdth_ioctl_alloc(ha, GDTH_SCRATCH, FALSE, ); > > if (!buf) > > goto stop_output; > > I think this !buf test is redundant. Thanks, fixed.

Re: [PATCH 1/4] gdth: refactor ioc_general

2018-11-09 Thread Christoph Hellwig
> > + switch (gen.command.OpCode) { > > + case GDT_IOCTL: > > + gen.command.u.ioctl.p_param = paddr; > > + break; > > + case CACHESERVICE: > > + gdth_ioc_cacheservice(ha, , paddr); > > + break; > > + case SCSIRAWSERVICE: > > +

[PATCH 2/3] wd719x: use per-command private data

2018-11-09 Thread Christoph Hellwig
Add the SCB onto the scsi command allocation and use dma streaming mappings for it only when in use. This avoid possibly calling dma_alloc_coherent under a lock or even in irq context, while also making the code simpler. Thanks to Ondrej Zary for testing and various bug fixes. Signed-off-by:

[PATCH 3/3] wd719x: always use generic DMA API

2018-11-09 Thread Christoph Hellwig
The wd719x driver currently uses a mix of the legacy PCI DMA and the generic DMA APIs. Switch it over to the generic DMA API entirely. Signed-off-by: Christoph Hellwig --- drivers/scsi/wd719x.c | 32 +--- 1 file changed, 17 insertions(+), 15 deletions(-) diff --git

[PATCH 1/3] wd719x: there should be no active SCBs on removal

2018-11-09 Thread Christoph Hellwig
So warn on that case instead of trying to free them, which would be fatal in case we actuall had active ones. Signed-off-by: Christoph Hellwig --- drivers/scsi/wd719x.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/wd719x.c b/drivers/scsi/wd719x.c index

dma related cleanups for wd719x v2

2018-11-09 Thread Christoph Hellwig
Various dma relates cleanups Changes since v1: - include important fixes from Ondrej

[PATCH] aha1542: convert to DMA mapping API

2018-11-09 Thread Christoph Hellwig
aha1542 is one of the last users of the legacy isa_*_to_bus APIs, which also isn't portable enough. Convert it to the proper DMA mapping API. Thanks to Ondrej Zary for testing and finding and fixing a crucial bug. Signed-off-by: Christoph Hellwig Tested-by: Ondrej Zary ---

Re: [PATCH 01/23] zfcp: make DIX experimental, disabled, and independent of DIF

2018-11-09 Thread Steffen Maier
Hi Martin, On 11/09/2018 03:07 AM, Martin K. Petersen wrote: There are too many unresolved issues with DIX outside of zfcp such as wrong protection data on writesame/discard (over device-mapper) We don't configure protected transfers for anything but read and write commands. There is

[PATCH v2] mpt3sas: Display message on Configurable secure HBA

2018-11-09 Thread Sreekanth Reddy
Display below warning message only up on detection of Configurable secure type controllers. "HBA is in Configurable Secure mode" v2 change set: Replaced dev_warn() with dev_info() function while displaying above message. Signed-off-by: Sreekanth Reddy --- drivers/scsi/mpt3sas/mpt3sas_scsih.c

Re: [PATCH] mpt3sas: Display message on Configurable secure HBA

2018-11-08 Thread Martin K. Petersen
Sreekanth, >> Display below warning message only up on detection of >> Configurable secure type controllers. Actually, same question as for Shivasharan: Why a warning? -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] megaraid_sas: Add support for MegaRAID Aero controllers

2018-11-08 Thread Martin K. Petersen
Shivasharan, > This patch adds support for MegaRAID Aero controller PCI IDs. > Throw a warning message when a Configurable secure type controller is > encountered. > + dev_warn(>dev, "Adapter is in configurable secure > mode\n"); Why warn and not info? -- Martin K. Petersen

Re: [PATCH V2 RESEND] Timeouts occur on surprise removal of QLogic adapter

2018-11-08 Thread Martin K. Petersen
Bill, > When doing a surprise removal of an adapter, some in flight I/Os can get > stuck and take a while to complete (they actually timeout and are > retried). We are not handling an early error exit from > qla2xxx_eh_abort properly. Applied to 4.20/scsi-fixes, thank you. -- Martin K.

Re: [PATCH 01/23] zfcp: make DIX experimental, disabled, and independent of DIF

2018-11-08 Thread Martin K. Petersen
Steffen, > There are too many unresolved issues with DIX outside of zfcp such as > wrong protection data on writesame/discard (over device-mapper) We don't configure protected transfers for anything but read and write commands. There is currently no protection information generated for WRITE

<    1   2   3   4   5   6   7   8   9   10   >