Re: [2.6 patch] drivers/scsi/qla2xxx/: cleanups

2005-02-28 Thread Christoph Hellwig
On Mon, Feb 28, 2005 at 10:00:24PM +0100, Adrian Bunk wrote: This patch contains the following cleanups: - make needlessly global code static - kill the unused global *_version and *_version_str variables in the firmware files The firmware files are generated, so it'd be better to leave

Re: [2.6 patch] drivers/scsi/qla2xxx/: cleanups

2005-02-28 Thread Adrian Bunk
On Mon, Feb 28, 2005 at 09:29:20PM +, Christoph Hellwig wrote: On Mon, Feb 28, 2005 at 10:00:24PM +0100, Adrian Bunk wrote: This patch contains the following cleanups: - make needlessly global code static - kill the unused global *_version and *_version_str variables in the firmware

Re: [2.6 patch] drivers/scsi/qla2xxx/: cleanups

2005-02-28 Thread Andrew Vasquez
On Mon, 28 Feb 2005, Adrian Bunk wrote: This patch contains the following cleanups: - make needlessly global code static As Christoph mentioned, the firmware images are auto-generated, so I'd rather hold off on those deltas. Besides, I'm hoping in the near future to drop the firmware from the