Re: [PATCH] sg: remove bad blk_end_request_all() call

2018-10-16 Thread Martin K. Petersen
Jens, > We just need to free the request here. Additionally, this is > currently wrong for a queue that's using MQ currently, it'll > crash. Applied to 4.20/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] sg: remove bad blk_end_request_all() call

2018-10-16 Thread Douglas Gilbert
On 2018-10-16 10:38 a.m., Jens Axboe wrote: We just need to free the request here. Additionally, this is currently wrong for a queue that's using MQ currently, it'll crash. Surprise removals are difficult code paths to check. That snippet is after the request has been generated and before the c

[PATCH] sg: remove bad blk_end_request_all() call

2018-10-16 Thread Jens Axboe
We just need to free the request here. Additionally, this is currently wrong for a queue that's using MQ currently, it'll crash. Cc: Doug Gilbert Cc: linux-scsi@vger.kernel.org Signed-off-by: Jens Axboe --- drivers/scsi/sg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dr