Re: [PATCH 08/22] scsi: dump sense buffer only for debugging

2014-09-01 Thread Hannes Reinecke
On 09/01/2014 12:09 AM, Christoph Hellwig wrote: > On Thu, Aug 28, 2014 at 07:33:22PM +0200, Hannes Reinecke wrote: >> Dumping the entire sense buffer might overwhelm the logging functions, >> so suppress it per default. > > Call me dumb, but I don't see anything in here that limits the dumps > to

Re: [PATCH 08/22] scsi: dump sense buffer only for debugging

2014-08-31 Thread Christoph Hellwig
On Thu, Aug 28, 2014 at 07:33:22PM +0200, Hannes Reinecke wrote: > Dumping the entire sense buffer might overwhelm the logging functions, > so suppress it per default. Call me dumb, but I don't see anything in here that limits the dumps to debug output. Also if you return boolean-like values plea

[PATCH 08/22] scsi: dump sense buffer only for debugging

2014-08-28 Thread Hannes Reinecke
Dumping the entire sense buffer might overwhelm the logging functions, so suppress it per default. Signed-off-by: Hannes Reinecke cmnd[7], result); scsi_print_sense(SCp); - #endif dma_unmap_single(hostdata->dev, slot->dma_handle,