Re: [PATCH 3/3] scsi: proper state checking and module refcount handling in scsi_device_get

2015-04-29 Thread Christoph Hellwig
On Wed, Apr 29, 2015 at 10:17:59AM +0900, Akinobu Mita wrote: This change broke ufs driver. I'd claim the ufs driver, or rather more specifily the ufs spec had already been broken. That whole concept of keeping references to scsi devices to send commands to for host state changes is just

Re: [PATCH 3/3] scsi: proper state checking and module refcount handling in scsi_device_get

2015-04-28 Thread Akinobu Mita
2015-02-02 22:01 GMT+09:00 Christoph Hellwig h...@lst.de: This effectively reverts commits 85b6c7 ([SCSI] sd: fix cache flushing on module removal (and individual device removal) and dc4515ea (scsi: always increment reference count). We now never call scsi_device_get from the shutdown path,

Re: [PATCH 3/3] scsi: proper state checking and module refcount handling in scsi_device_get

2015-03-05 Thread Paolo Bonzini
On 02/02/2015 14:01, Christoph Hellwig wrote: This effectively reverts commits 85b6c7 ([SCSI] sd: fix cache flushing on module removal (and individual device removal) and dc4515ea (scsi: always increment reference count). We now never call scsi_device_get from the shutdown path, and the

[PATCH 3/3] scsi: proper state checking and module refcount handling in scsi_device_get

2015-02-02 Thread Christoph Hellwig
This effectively reverts commits 85b6c7 ([SCSI] sd: fix cache flushing on module removal (and individual device removal) and dc4515ea (scsi: always increment reference count). We now never call scsi_device_get from the shutdown path, and the fact that we started grabbing reference there in commit

Re: [PATCH 3/3] scsi: proper state checking and module refcount handling in scsi_device_get

2015-01-29 Thread James Bottomley
On Thu, 2015-01-29 at 00:00 +0100, Christoph Hellwig wrote: This effectively reverts commits 85b6c7 ([SCSI] sd: fix cache flushing on module removal (and individual device removal) and dc4515ea (scsi: always increment reference count). We now never call scsi_device_get from the shutdown

[PATCH 3/3] scsi: proper state checking and module refcount handling in scsi_device_get

2015-01-28 Thread Christoph Hellwig
This effectively reverts commits 85b6c7 ([SCSI] sd: fix cache flushing on module removal (and individual device removal) and dc4515ea (scsi: always increment reference count). We now never call scsi_device_get from the shutdown path, and the fact that we started grabbing reference there in commit