Re: [PATCH scsi-misc-2.6 03/04] scsi: make scsi_requeue_request() use blk_requeue_request()

Hello, Christoph Hellwig. On Mon, Apr 11, 2005 at 01:44:19PM +0100, Christoph Hellwig wrote: + cmd-request-flags |= REQ_SOFTBARRIER; + + spin_lock_irqsave(q-queue_lock, flags); + blk_requeue_request(q, cmd-request); + spin_unlock_irqrestore(q-queue_lock, flags);

Re: [PATCH scsi-misc-2.6 03/04] scsi: make scsi_requeue_request() use blk_requeue_request()

+ cmd-request-flags |= REQ_SOFTBARRIER; + + spin_lock_irqsave(q-queue_lock, flags); + blk_requeue_request(q, cmd-request); + spin_unlock_irqrestore(q-queue_lock, flags); scsi_run_queue(q); This exact code sequence is duplicated in the previous patch, maybe time for

Re: [PATCH scsi-misc-2.6 03/04] scsi: make scsi_requeue_request() use blk_requeue_request()

03_scsi_REQ_SPECIAL_semantic_scsi_requeue_command.patch scsi_requeue_request() used to use blk_insert_request() for requeueing requests. This behavior depends on the unobvious behavior of blk_insert_request() setting REQ_SPECIAL and REQ_SOFTBARRIER when