Re: [patch 10/11] drivers/scsi/: Use the DMA_{64,32}BIT_MASK constants

2005-03-07 Thread Matthew Wilcox
On Mon, Mar 07, 2005 at 09:27:17AM -0500, Jes Sorensen wrote: > Matthew> We've had drivers with typos. Missing one f suddenly causes > Matthew> all your memory to come from ZONE_DMA. Having an extra f > Matthew> causes your driver to work ... most of the time on machines > Matthew> with >4GB ram.

Re: [patch 10/11] drivers/scsi/: Use the DMA_{64,32}BIT_MASK constants

2005-03-07 Thread Jes Sorensen
> "Matthew" == Matthew Wilcox <[EMAIL PROTECTED]> writes: Matthew> On Mon, Mar 07, 2005 at 05:14:16AM -0500, Jes Sorensen wrote: >> > "domen" == domen <[EMAIL PROTECTED]> writes: >> domen> Use the DMA_{64,32}BIT_MASK constants from dma-mapping.h when domen> calling pci_set_dma_mask() or p

Re: [patch 10/11] drivers/scsi/: Use the DMA_{64,32}BIT_MASK constants

2005-03-07 Thread Matthew Wilcox
On Mon, Mar 07, 2005 at 05:14:16AM -0500, Jes Sorensen wrote: > > "domen" == domen <[EMAIL PROTECTED]> writes: > > domen> Use the DMA_{64,32}BIT_MASK constants from dma-mapping.h when > domen> calling pci_set_dma_mask() or pci_set_consistent_dma_mask() See > domen> http://marc.theaimsgroup.co

Re: [patch 10/11] drivers/scsi/: Use the DMA_{64,32}BIT_MASK constants

2005-03-07 Thread Jes Sorensen
> "domen" == domen <[EMAIL PROTECTED]> writes: domen> Use the DMA_{64,32}BIT_MASK constants from dma-mapping.h when domen> calling pci_set_dma_mask() or pci_set_consistent_dma_mask() See domen> http://marc.theaimsgroup.com/?t=10800199301&r=1&w=2 for domen> details Why? It's ugly and rea

[patch 10/11] drivers/scsi/: Use the DMA_{64,32}BIT_MASK constants

2005-03-06 Thread domen
Use the DMA_{64,32}BIT_MASK constants from dma-mapping.h when calling pci_set_dma_mask() or pci_set_consistent_dma_mask() See http://marc.theaimsgroup.com/?t=10800199301&r=1&w=2 for details [Merged multiple patches, I can send split ones if desired -domen] Signed-off-by: Tobias Klauser <[EMA