Re: PATCH: usb-storage-psc1350-v4.patch (was Linux scsi / usb-mass-storage and HP printer cardreader bug + fix)

2008-01-20 Thread Hans de Goede
James Bottomley wrote: On Mon, 2008-01-14 at 20:27 +0100, Hans de Goede wrote: James Bottomley wrote: Plus what is the rq->nr_sectors > sdp->sector_size / 512 test supposed to be doing? that being true is supposed to be a guarantee of the block layer (and if something goes wrong there's a chec

Re: PATCH: usb-storage-psc1350-v4.patch (was Linux scsi / usb-mass-storage and HP printer cardreader bug + fix)

2008-01-14 Thread James Bottomley
On Mon, 2008-01-14 at 20:27 +0100, Hans de Goede wrote: > James Bottomley wrote: > >>> Plus what is the rq->nr_sectors > sdp->sector_size / > >>> 512 test supposed to be doing? that being true is supposed to be a > >>> guarantee of the block layer (and if something goes wrong there's a > >>> chec

Re: PATCH: usb-storage-psc1350-v4.patch (was Linux scsi / usb-mass-storage and HP printer cardreader bug + fix)

2008-01-14 Thread Hans de Goede
James Bottomley wrote: Plus what is the rq->nr_sectors > sdp->sector_size / 512 test supposed to be doing? that being true is supposed to be a guarantee of the block layer (and if something goes wrong there's a check for this lower down). It first is was just: rq->nr_sectors > 1 Then I change

Re: PATCH: usb-storage-psc1350-v4.patch (was Linux scsi / usb-mass-storage and HP printer cardreader bug + fix)

2008-01-14 Thread Hans de Goede
Matthew Dharm wrote: On Mon, Jan 14, 2008 at 10:33:08AM -0600, James Bottomley wrote: On Mon, 2008-01-14 at 08:03 -0800, Matthew Dharm wrote: We may be able to convince the SCSI people to enable it for all devices, regardless of HCD. No ... I'm not particularly keen to have enterprise vendors

Re: PATCH: usb-storage-psc1350-v4.patch (was Linux scsi / usb-mass-storage and HP printer cardreader bug + fix)

2008-01-14 Thread James Bottomley
On Mon, 2008-01-14 at 19:37 +0100, Hans de Goede wrote: > James Bottomley wrote: > > On Mon, 2008-01-14 at 08:03 -0800, Matthew Dharm wrote: > >> On Mon, Jan 14, 2008 at 10:46:56AM +0100, Hans de Goede wrote: > >>> Guillaume Bedot wrote: > But it fixes only two models. > Do you think oth

Re: PATCH: usb-storage-psc1350-v4.patch (was Linux scsi / usb-mass-storage and HP printer cardreader bug + fix)

2008-01-14 Thread Matthew Dharm
On Mon, Jan 14, 2008 at 10:33:08AM -0600, James Bottomley wrote: > > On Mon, 2008-01-14 at 08:03 -0800, Matthew Dharm wrote: > > We may be able to convince the SCSI people to enable it for all devices, > > regardless of HCD. > > No ... I'm not particularly keen to have enterprise vendors after my

Re: PATCH: usb-storage-psc1350-v4.patch (was Linux scsi / usb-mass-storage and HP printer cardreader bug + fix)

2008-01-14 Thread Stefan Richter
James Bottomley wrote: > On Mon, 2008-01-14 at 08:03 -0800, Matthew Dharm wrote: >> On Mon, Jan 14, 2008 at 10:46:56AM +0100, Hans de Goede wrote: >> > Guillaume Bedot wrote: >> > >Will this be possible to use "LAST_SECTOR_BUG" quirk for testing without >> > >recompiling a kernel ? >> > >> > This

Re: PATCH: usb-storage-psc1350-v4.patch (was Linux scsi / usb-mass-storage and HP printer cardreader bug + fix)

2008-01-14 Thread Hans de Goede
James Bottomley wrote: On Mon, 2008-01-14 at 08:03 -0800, Matthew Dharm wrote: On Mon, Jan 14, 2008 at 10:46:56AM +0100, Hans de Goede wrote: Guillaume Bedot wrote: But it fixes only two models. Do you think other devices (hp or not) can be impacted ? There are hundreds of models with card rea

Re: PATCH: usb-storage-psc1350-v4.patch (was Linux scsi / usb-mass-storage and HP printer cardreader bug + fix)

2008-01-14 Thread James Bottomley
On Mon, 2008-01-14 at 08:03 -0800, Matthew Dharm wrote: > On Mon, Jan 14, 2008 at 10:46:56AM +0100, Hans de Goede wrote: > > Guillaume Bedot wrote: > > >But it fixes only two models. > > >Do you think other devices (hp or not) can be impacted ? > > >There are hundreds of models with card readers o

Re: PATCH: usb-storage-psc1350-v4.patch (was Linux scsi / usb-mass-storage and HP printer cardreader bug + fix)

2008-01-14 Thread Matthew Dharm
On Mon, Jan 14, 2008 at 10:46:56AM +0100, Hans de Goede wrote: > Guillaume Bedot wrote: > >But it fixes only two models. > >Do you think other devices (hp or not) can be impacted ? > >There are hundreds of models with card readers only for hp : > >http://hplip.sourceforge.net/supported_devices/comb

Re: PATCH: usb-storage-psc1350-v4.patch (was Linux scsi / usb-mass-storage and HP printer cardreader bug + fix)

2008-01-14 Thread Hans de Goede
Guillaume Bedot wrote: I have tested this time with two PSC 1610 printers, and two SD cards, the same bug occured without the patch. And is fixed with your new patch. Good work ! Hi, Thanks for testing! But it fixes only two models. Do you think other devices (hp or not) can be impacted ?

Re: PATCH: usb-storage-psc1350-v4.patch (was Linux scsi / usb-mass-storage and HP printer cardreader bug + fix)

2008-01-14 Thread Guillaume Bedot
Hello, On ven, 2008-01-11 at 21:14 +0100, Hans de Goede wrote: > Boaz Harrosh wrote: > > Yes, you're right. in ULDs it is a much proper way to do this. > > > > So I guess you'll have to do that special host flag or device > > flag, and add a check for it in sd.c. You'll see that sd.c is > > alre

Re: [usb-storage] PATCH: usb-storage-psc1350-v4.patch (was Linux scsi / usb-mass-storage and HP printer cardreader bug + fix)

2008-01-11 Thread Matthew Dharm
On Fri, Jan 11, 2008 at 09:14:00PM +0100, Hans de Goede wrote: > Boaz Harrosh wrote: > >Yes, you're right. in ULDs it is a much proper way to do this. > > > >So I guess you'll have to do that special host flag or device > >flag, and add a check for it in sd.c. You'll see that sd.c is > >already do

PATCH: usb-storage-psc1350-v4.patch (was Linux scsi / usb-mass-storage and HP printer cardreader bug + fix)

2008-01-11 Thread Hans de Goede
Boaz Harrosh wrote: Yes, you're right. in ULDs it is a much proper way to do this. So I guess you'll have to do that special host flag or device flag, and add a check for it in sd.c. You'll see that sd.c is already doing bufflen truncation at sd_prep_fn(), just add one more case. Done, than

Re: Linux scsi / usb-mass-storage and HP printer cardreader bug + fix

2008-01-11 Thread Guillaume Bedot
Hello, Le vendredi 11 janvier 2008 à 13:48 +0100, Hans de Goede a écrit : > That will work nicely, I'll write an updated patch this evening (when I have > access to the printer to test again). > Great news, i am impatient to test this new patch. I may face an other bug with the Transcend 1GB SD

Re: Linux scsi / usb-mass-storage and HP printer cardreader bug + fix

2008-01-11 Thread Hans de Goede
Boaz Harrosh wrote: On Thu, Jan 10 2008 at 12:52 +0200, Hans de Goede <[EMAIL PROTECTED]> wrote: I'm not sure what the proper solution should be? I guess the proper solution would be to add a special case to the scsi layer where the read10 / write10 command is issued, and split the request in

Re: Linux scsi / usb-mass-storage and HP printer cardreader bug + fix

2008-01-10 Thread Boaz Harrosh
D], USB development list >> <[EMAIL PROTECTED]>, David Brown >> <[EMAIL PROTECTED]>, Guillaume Bedot <[EMAIL PROTECTED]>, >> linux-scsi@vger.kernel.org, [EMAIL PROTECTED] >> *Sent:* Wed, Jan 09 2008 at 23:44 +0200 >> *Subject:* Linux scsi / usb-mass-sto

Re: Linux scsi / usb-mass-storage and HP printer cardreader bug + fix

2008-01-10 Thread Hans de Goede
AIL PROTECTED]>, linux-scsi@vger.kernel.org, [EMAIL PROTECTED] *Sent:* Wed, Jan 09 2008 at 23:44 +0200 *Subject:* Linux scsi / usb-mass-storage and HP printer cardreader bug + fix Hi All, First of all sorry for the somewhat massive cross-posting, I've spend a significant amount of time hunting down th

Re: Linux scsi / usb-mass-storage and HP printer cardreader bug + fix

2008-01-10 Thread Boaz Harrosh
r.kernel.org, [EMAIL PROTECTED] *Sent:* Wed, Jan 09 2008 at 23:44 +0200 *Subject:* Linux scsi / usb-mass-storage and HP printer cardreader bug + fix > Hi All, > > First of all sorry for the somewhat massive cross-posting, I've spend a > significant amount of time hunting down thi

Re: [linux-usb-devel] Linux scsi / usb-mass-storage and HP printer cardreader bug + fix

2008-01-09 Thread Matthew Dharm
On Wed, Jan 09, 2008 at 10:44:49PM +0100, Hans de Goede wrote: > First of all sorry for the somewhat massive cross-posting, I've spend a > significant amount of time hunting down this bug, and so far the response > has been less the overwhelming. > The cardreader of the multi function printers

Linux scsi / usb-mass-storage and HP printer cardreader bug + fix

2008-01-09 Thread Hans de Goede
Hi All, First of all sorry for the somewhat massive cross-posting, I've spend a significant amount of time hunting down this bug, and so far the response has been less the overwhelming. The problem is with the HP PSC 1350 (my printer and confirmed by 2 others) and atleast also the HP PSC 161