Re: PATCH: usb-storage-set-last-sector-bug-flag.patch

2008-01-25 Thread Matthew Dharm
ACKed-by: Matthew Dharm <[EMAIL PROTECTED]> Matt On Fri, Jan 25, 2008 at 11:12:21AM -0600, James Bottomley wrote: > On Thu, 2008-01-24 at 09:21 -0800, Greg KH wrote: > > On Thu, Jan 24, 2008 at 06:07:00PM +0100, Stefan Richter wrote: > > > Greg KH wrote: > > > > I just am worried that we are > >

Re: PATCH: usb-storage-set-last-sector-bug-flag.patch

2008-01-25 Thread James Bottomley
On Thu, 2008-01-24 at 09:21 -0800, Greg KH wrote: > On Thu, Jan 24, 2008 at 06:07:00PM +0100, Stefan Richter wrote: > > Greg KH wrote: > > > I just am worried that we are > > > now suddenly keeping access from the last sector for devices that > > > currently did work just fine. > > > > This new wo

Re: PATCH: usb-storage-set-last-sector-bug-flag.patch

2008-01-24 Thread Greg KH
On Thu, Jan 24, 2008 at 06:07:00PM +0100, Stefan Richter wrote: > Greg KH wrote: > > I just am worried that we are > > now suddenly keeping access from the last sector for devices that > > currently did work just fine. > > This new workaround doesn't prevent access to the last sector. It only > b

Re: PATCH: usb-storage-set-last-sector-bug-flag.patch

2008-01-24 Thread Stefan Richter
> The last-sector-(access-)bug workaround _only_ modifies the command > stream which is sent to the device. A dangerous command is replaced by > equivalent safe commands. BTW, one thing about this patch set needs to be criticized: "last_sector_bug" is a really bad name choice for the new flag.

Re: PATCH: usb-storage-set-last-sector-bug-flag.patch

2008-01-24 Thread Stefan Richter
Greg KH wrote: > I just am worried that we are > now suddenly keeping access from the last sector for devices that > currently did work just fine. This new workaround doesn't prevent access to the last sector. It only breaks up a multi-sector access which would also reach the last sector into sev

Re: PATCH: usb-storage-set-last-sector-bug-flag.patch

2008-01-23 Thread Greg KH
On Wed, Jan 23, 2008 at 12:39:39PM -0600, James Bottomley wrote: > > On Wed, 2008-01-23 at 10:12 -0800, Greg KH wrote: > > On Sun, Jan 20, 2008 at 04:45:36PM -0500, Alan Stern wrote: > > > On Sun, 20 Jan 2008, Greg KH wrote: > > > > > > > On Sun, Jan 20, 2008 at 11:27:29AM +0100, Hans de Goede wr

Re: PATCH: usb-storage-set-last-sector-bug-flag.patch

2008-01-23 Thread James Bottomley
On Wed, 2008-01-23 at 10:12 -0800, Greg KH wrote: > On Sun, Jan 20, 2008 at 04:45:36PM -0500, Alan Stern wrote: > > On Sun, 20 Jan 2008, Greg KH wrote: > > > > > On Sun, Jan 20, 2008 at 11:27:29AM +0100, Hans de Goede wrote: > > > > Hi all, > > > > > > > > This patch sets the last_sector_bug flag

Re: PATCH: usb-storage-set-last-sector-bug-flag.patch

2008-01-23 Thread Greg KH
On Sun, Jan 20, 2008 at 04:45:36PM -0500, Alan Stern wrote: > On Sun, 20 Jan 2008, Greg KH wrote: > > > On Sun, Jan 20, 2008 at 11:27:29AM +0100, Hans de Goede wrote: > > > Hi all, > > > > > > This patch sets the last_sector_bug flag to 1 for all USB disks. This is > > > needed to makes the cardre

Re: [usb-storage] PATCH: usb-storage-set-last-sector-bug-flag.patch

2008-01-22 Thread Guillaume Bedot
Hello, Le dimanche 20 janvier 2008 à 11:27 +0100, Hans de Goede a écrit : > Hi all, > > This patch sets the last_sector_bug flag to 1 for all USB disks. This is > needed to makes the cardreader on various HP multifunction printers work. > > Since the performance impact is negible we set this fla

Re: PATCH: usb-storage-set-last-sector-bug-flag.patch

2008-01-20 Thread Alan Stern
On Sun, 20 Jan 2008, Greg KH wrote: > On Sun, Jan 20, 2008 at 11:27:29AM +0100, Hans de Goede wrote: > > Hi all, > > > > This patch sets the last_sector_bug flag to 1 for all USB disks. This is > > needed to makes the cardreader on various HP multifunction printers work. > > > > Since the performa

Re: [usb-storage] PATCH: usb-storage-set-last-sector-bug-flag.patch

2008-01-20 Thread Guillaume Bedot
Le dimanche 20 janvier 2008 à 15:03 -0600, James Bottomley a écrit : > On Sun, 2008-01-20 at 12:56 -0800, Greg KH wrote: > > On Sun, Jan 20, 2008 at 11:27:29AM +0100, Hans de Goede wrote: > > > Hi all, > > > > > > This patch sets the last_sector_bug flag to 1 for all USB disks. This is > > > neede

Re: PATCH: usb-storage-set-last-sector-bug-flag.patch

2008-01-20 Thread Hans de Goede
James Bottomley wrote: On Sun, 2008-01-20 at 12:56 -0800, Greg KH wrote: On Sun, Jan 20, 2008 at 11:27:29AM +0100, Hans de Goede wrote: Hi all, This patch sets the last_sector_bug flag to 1 for all USB disks. This is needed to makes the cardreader on various HP multifunction printers work. Si

Re: PATCH: usb-storage-set-last-sector-bug-flag.patch

2008-01-20 Thread James Bottomley
On Sun, 2008-01-20 at 12:56 -0800, Greg KH wrote: > On Sun, Jan 20, 2008 at 11:27:29AM +0100, Hans de Goede wrote: > > Hi all, > > > > This patch sets the last_sector_bug flag to 1 for all USB disks. This is > > needed to makes the cardreader on various HP multifunction printers work. > > > > Sinc

Re: PATCH: usb-storage-set-last-sector-bug-flag.patch

2008-01-20 Thread Greg KH
On Sun, Jan 20, 2008 at 11:27:29AM +0100, Hans de Goede wrote: > Hi all, > > This patch sets the last_sector_bug flag to 1 for all USB disks. This is > needed to makes the cardreader on various HP multifunction printers work. > > Since the performance impact is negible we set this flag for all USB

PATCH: usb-storage-set-last-sector-bug-flag.patch

2008-01-20 Thread Hans de Goede
Hi all, This patch sets the last_sector_bug flag to 1 for all USB disks. This is needed to makes the cardreader on various HP multifunction printers work. Since the performance impact is negible we set this flag for all USB disks to avoid an unusual_devs.h nightmare. Note that this patch depend