FYI, I've updated the patch a bit in my tree to always set e->tag to
SIMPLE_QUEUE_TAG. The rationale for that is that we actually never set
MSG_ORDERED_TAG for other drivers since 2010, and fixing this up
properly in this driver makes it conflict less with my patch series to
fix up more mess in t
; James Bottomley; linux-scsi@vger.kernel.org
Subject: Re: [PATCH] vmw_pvscsi: fixup tagging
On 10/17/2014 08:34 PM, Arvind Kumar wrote:
> Hi Christoph,
>
> Thanks for the change. Sorry for the delay. The change looks fine to me. I
> just have a question.
>
> The comme
On 10/17/2014 08:34 PM, Arvind Kumar wrote:
Hi Christoph,
Thanks for the change. Sorry for the delay. The change looks fine to me. I just
have a question.
The comment in include/scsi/scsi_cmnd.h says:
struct scsi_cmnd {
...
unsigned char tag; /* SCSI-II queued command tag */
}
On Fri, Oct 17, 2014 at 06:34:48PM +, Arvind Kumar wrote:
> Hi Christoph,
>
> Thanks for the change. Sorry for the delay. The change looks fine to me. I
> just have a question.
>
> The comment in include/scsi/scsi_cmnd.h says:
>
> struct scsi_cmnd {
> ...
> unsigned char tag; /
that too?
Thanks!
Arvind
From: Christoph Hellwig
Sent: Friday, October 17, 2014 6:16 AM
To: Hannes Reinecke
Cc: Arvind Kumar; pv-driv...@vmware.com; James Bottomley;
linux-scsi@vger.kernel.org
Subject: Re: [PATCH] vmw_pvscsi: fixup tagging
Can I get a
Can I get a review from VMWare for this one, please?
On Thu, Oct 02, 2014 at 09:21:41AM +0200, Hannes Reinecke wrote:
> The request (and SCSI command) tag is the tag number assigned
> by the generic block-tagging code, not the SCSI-II tag messages.
> Those are represented by the device flags 'tagg
6 matches
Mail list logo
