Re: [PATCH fix for 3.17] uas: Add a quirk for rejecting ATA_12 and ATA_16 commands

2014-09-15 Thread Alan Stern
On Mon, 15 Sep 2014, Oliver Neukum wrote: > On Mon, 2014-09-15 at 08:42 +, David Laight wrote: > > From: Alan Stern > > > > > You must not add an aditional value for a module parameter without > > > documenting it in Documentation/kernel-parameters.txt. > > > > How can this work as a 'modul

Re: [PATCH fix for 3.17] uas: Add a quirk for rejecting ATA_12 and ATA_16 commands

2014-09-15 Thread Hans de Goede
Hi, On 09/15/2014 10:42 AM, David Laight wrote: > From: Alan Stern > ... >>> p = quirks; >>> while (*p) { >>> @@ -543,6 +544,9 @@ void usb_stor_adjust_quirks(struct usb_device *udev, >>> unsigned long *fflags) >>> case 's': >>> f |= US_FL_SINGLE_LUN; >>>

Re: [PATCH fix for 3.17] uas: Add a quirk for rejecting ATA_12 and ATA_16 commands

2014-09-15 Thread Oliver Neukum
On Mon, 2014-09-15 at 08:42 +, David Laight wrote: > From: Alan Stern > > > You must not add an aditional value for a module parameter without > > documenting it in Documentation/kernel-parameters.txt. > > How can this work as a 'module parameter'? It cannot. This parameter is an aid to deb

RE: [PATCH fix for 3.17] uas: Add a quirk for rejecting ATA_12 and ATA_16 commands

2014-09-15 Thread David Laight
From: Alan Stern ... > > p = quirks; > > while (*p) { > > @@ -543,6 +544,9 @@ void usb_stor_adjust_quirks(struct usb_device *udev, > > unsigned long *fflags) > > case 's': > > f |= US_FL_SINGLE_LUN; > > break; > > + case 't': >

Re: [PATCH fix for 3.17] uas: Add a quirk for rejecting ATA_12 and ATA_16 commands

2014-09-13 Thread Alan Stern
On Sat, 13 Sep 2014, Hans de Goede wrote: > And set this quirk for the Seagate Expansion Desk (0bc2:2312), as that one > seems to hang upon receiving an ATA_12 or ATA_16 command. > > https://bugzilla.kernel.org/show_bug.cgi?id=79511 > > Cc: sta...@vger.kernel.org # 3.16 > Signed-off-by: Hans de