Re: [PATCH] scsi: replace numeric messages with string error messages when blk_execute_rq fails. Also add printing of sense info.

2014-06-04 Thread Hannes Reinecke
On 06/04/2014 09:51 AM, Maurizio Lombardi wrote: On Thu, May 15, 2014 at 08:41:10AM +0200, Christoph Hellwig wrote: We now have a readily available copy of EVPD page 0x83 hanging off the scsi device, so the alua device handler should use it. Hannes, how about you handle that if you're doing ma

Re: [PATCH] scsi: replace numeric messages with string error messages when blk_execute_rq fails. Also add printing of sense info.

2014-06-04 Thread Maurizio Lombardi
On Thu, May 15, 2014 at 08:41:10AM +0200, Christoph Hellwig wrote: > > We now have a readily available copy of EVPD page 0x83 hanging off > the scsi device, so the alua device handler should use it. > > Hannes, how about you handle that if you're doing major surgery in that > area anwyay? Hannes

Re: [PATCH] scsi: replace numeric messages with string error messages when blk_execute_rq fails. Also add printing of sense info.

2014-05-14 Thread Christoph Hellwig
On Tue, May 13, 2014 at 04:24:02PM +0200, Maurizio Lombardi wrote: > On Tue, May 13, 2014 at 04:14:47PM +0200, Hannes Reinecke wrote: > > If you were to go ahead with the patch please strip the first > > scsi_execute() altogether and use the VPD information already > > provided by the scsi device.

Re: [PATCH] scsi: replace numeric messages with string error messages when blk_execute_rq fails. Also add printing of sense info.

2014-05-13 Thread Maurizio Lombardi
On Tue, May 13, 2014 at 04:14:47PM +0200, Hannes Reinecke wrote: > If you were to go ahead with the patch please strip the first > scsi_execute() altogether and use the VPD information already > provided by the scsi device. The patch I'm asking to merge just adds some printks, nothing else, it doe

Re: [PATCH] scsi: replace numeric messages with string error messages when blk_execute_rq fails. Also add printing of sense info.

2014-05-13 Thread Hannes Reinecke
On 05/13/2014 04:07 PM, Christoph Hellwig wrote: On Tue, May 13, 2014 at 03:10:15PM +0200, Maurizio Lombardi wrote: Hannes Reinecke is also working on those functions, I'll have to collaborate with him to minimize the conflicts with the patchset he is preparing. In the meantime, do you think it

Re: [PATCH] scsi: replace numeric messages with string error messages when blk_execute_rq fails. Also add printing of sense info.

2014-05-13 Thread Christoph Hellwig
On Tue, May 13, 2014 at 03:10:15PM +0200, Maurizio Lombardi wrote: > Hannes Reinecke is also working on those functions, I'll have to collaborate > with him to minimize the conflicts with the patchset he is preparing. > > In the meantime, do you think it is possible to merge the first version > of

Re: [PATCH] scsi: replace numeric messages with string error messages when blk_execute_rq fails. Also add printing of sense info.

2014-05-13 Thread Maurizio Lombardi
Hi, On Tue, Apr 29, 2014 at 08:00:41PM +0200, Christoph Hellwig wrote: > > What kind of update do you want? All the sense buffer updates are done > in the low-level code, and then you could update anything additional > you would need in the caller as you get the whole sense buffer when > using s

Re: [PATCH] scsi: replace numeric messages with string error messages when blk_execute_rq fails. Also add printing of sense info.

2014-04-29 Thread Christoph Hellwig
On Tue, Apr 29, 2014 at 11:30:35AM +0200, Maurizio Lombardi wrote: > If I convert submit_rtpg() to make use of scsi_execute() then I'll not be > able to read the updated sense buffer. > > scsi_execute() accepts a pointer to the sense buffer as parameter, but > it does not update its content in cas

Re: [PATCH] scsi: replace numeric messages with string error messages when blk_execute_rq fails. Also add printing of sense info.

2014-04-29 Thread Maurizio Lombardi
Hi Christoph, On Fri, Apr 25, 2014 at 03:12:19PM +0200, Christoph Hellwig wrote: > > Looks useful, but why do we have basically two copies of the same > code for different commands? Looking at them in detail they mostly look > like copies of scsi_execute/scsi_execute_req_flags and should be switc

Re: [PATCH] scsi: replace numeric messages with string error messages when blk_execute_rq fails. Also add printing of sense info.

2014-04-25 Thread Maurizio Lombardi
Hi, On Fri, Apr 25, 2014 at 03:12:19PM +0200, Christoph Hellwig wrote: > > Looks useful, but why do we have basically two copies of the same > code for different commands? Looking at them in detail they mostly look > like copies of scsi_execute/scsi_execute_req_flags and should be switched > to t

Re: [PATCH] scsi: replace numeric messages with string error messages when blk_execute_rq fails. Also add printing of sense info.

2014-04-25 Thread Christoph Hellwig
On Tue, Apr 22, 2014 at 01:44:16PM +0200, Maurizio Lombardi wrote: > Signed-off-by: Maurizio Lombardi > --- > drivers/scsi/device_handler/scsi_dh_alua.c | 18 -- > 1 file changed, 12 insertions(+), 6 deletions(-) Looks useful, but why do we have basically two copies of the same