Re: kernel BUG at block/bio.c:1787! while initializing scsi_debug on ppc64 host

2016-01-05 Thread Eryu Guan
On Tue, Jan 05, 2016 at 06:58:25PM -0500, Martin K. Petersen wrote: > > "Eryu" == Eryu Guan writes: > > Eryu> Any updates on this? It's still reproducible with 4.4-rc8 kernel, > Eryu> and still blocks some of my tests :) > >

Re: kernel BUG at block/bio.c:1787! while initializing scsi_debug on ppc64 host

2016-01-05 Thread Eryu Guan
On Fri, Dec 11, 2015 at 07:53:40PM +0800, Eryu Guan wrote: > Hi, > > I saw this kernel BUG_ON on 4.4-rc4 kernel, and this can be reproduced > easily on ppc64 host by: > > modprobe scsi_debug sector_size=512 physblk_exp=3 dev_size_mb=256 > > And I bisected to this commit > > commit

Re: kernel BUG at block/bio.c:1787! while initializing scsi_debug on ppc64 host

2016-01-05 Thread Martin K. Petersen
> "Eryu" == Eryu Guan writes: Eryu> Any updates on this? It's still reproducible with 4.4-rc8 kernel, Eryu> and still blocks some of my tests :) http://git.kernel.org/cgit/linux/kernel/git/mkp/scsi.git/log/?h=4.4/scsi-fixes It just hasn't made it to Linus yet... --

Re: kernel BUG at block/bio.c:1787! while initializing scsi_debug on ppc64 host

2015-12-15 Thread Eryu Guan
On Tue, Dec 15, 2015 at 09:27:14PM +0800, Ming Lei wrote: > On Tue, Dec 15, 2015 at 9:06 PM, Eryu Guan wrote: > > On Tue, Dec 15, 2015 at 08:06:47PM +0800, Ming Lei wrote: > >> On Tue, Dec 15, 2015 at 7:20 PM, Eryu Guan wrote: > >> > On Fri, Dec 11, 2015

Re: kernel BUG at block/bio.c:1787! while initializing scsi_debug on ppc64 host

2015-12-15 Thread Eryu Guan
On Tue, Dec 15, 2015 at 11:38:41PM +0800, Ming Lei wrote: > On Tue, 15 Dec 2015 21:06:31 +0800 > Eryu Guan wrote: > > > On Tue, Dec 15, 2015 at 08:06:47PM +0800, Ming Lei wrote: > > > On Tue, Dec 15, 2015 at 7:20 PM, Eryu Guan wrote: > > > > On Fri, Dec

Re: kernel BUG at block/bio.c:1787! while initializing scsi_debug on ppc64 host

2015-12-15 Thread Martin K. Petersen
> "Eryu" == Eryu Guan writes: Eryu, Does the patch below fix the issue? -- Martin K. Petersen Oracle Linux Engineering diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c index 3d22fc3e3c1a..d1eb7aa78b8d 100644 --- a/drivers/scsi/sd.c +++ b/drivers/scsi/sd.c @@

Re: kernel BUG at block/bio.c:1787! while initializing scsi_debug on ppc64 host

2015-12-15 Thread Eryu Guan
On Fri, Dec 11, 2015 at 07:53:40PM +0800, Eryu Guan wrote: > Hi, > > I saw this kernel BUG_ON on 4.4-rc4 kernel, and this can be reproduced > easily on ppc64 host by: This is still reproducible with 4.4-rc5 kernel. Thanks, Eryu > > modprobe scsi_debug sector_size=512 physblk_exp=3

Re: kernel BUG at block/bio.c:1787! while initializing scsi_debug on ppc64 host

2015-12-15 Thread Eryu Guan
On Tue, Dec 15, 2015 at 08:06:47PM +0800, Ming Lei wrote: > On Tue, Dec 15, 2015 at 7:20 PM, Eryu Guan wrote: > > On Fri, Dec 11, 2015 at 07:53:40PM +0800, Eryu Guan wrote: > >> Hi, > >> > >> I saw this kernel BUG_ON on 4.4-rc4 kernel, and this can be reproduced > >> easily on

Re: kernel BUG at block/bio.c:1787! while initializing scsi_debug on ppc64 host

2015-12-15 Thread Ming Lei
On Tue, Dec 15, 2015 at 9:06 PM, Eryu Guan wrote: > On Tue, Dec 15, 2015 at 08:06:47PM +0800, Ming Lei wrote: >> On Tue, Dec 15, 2015 at 7:20 PM, Eryu Guan wrote: >> > On Fri, Dec 11, 2015 at 07:53:40PM +0800, Eryu Guan wrote: >> >> Hi, >> >> >> >> I saw

Re: kernel BUG at block/bio.c:1787! while initializing scsi_debug on ppc64 host

2015-12-15 Thread Ming Lei
On Wed, Dec 16, 2015 at 2:29 AM, Martin K. Petersen wrote: >> "Eryu" == Eryu Guan writes: > > Eryu, > > Does the patch below fix the issue? No, it can't. As the debug log shows, it is because you use 'OPTIMAL TRANSFER LENGTH' to set queue's

Re: kernel BUG at block/bio.c:1787! while initializing scsi_debug on ppc64 host

2015-12-15 Thread Ming Lei
On Wed, Dec 16, 2015 at 12:56 AM, Eryu Guan wrote: > On Tue, Dec 15, 2015 at 09:27:14PM +0800, Ming Lei wrote: >> On Tue, Dec 15, 2015 at 9:06 PM, Eryu Guan wrote: >> > On Tue, Dec 15, 2015 at 08:06:47PM +0800, Ming Lei wrote: >> >> On Tue, Dec 15, 2015 at

Re: kernel BUG at block/bio.c:1787! while initializing scsi_debug on ppc64 host

2015-12-15 Thread Martin K. Petersen
> "Ming" == Ming Lei writes: Ming, Ming> No, it can't. Well, it fixes a problem on one of my test systems where max_ws_blocks, by virtue of being 64 bits, clobbers opt_xfer_blocks causing rw_len and thus max_sectors to be set incorrectly. We haven't run into that

Re: kernel BUG at block/bio.c:1787! while initializing scsi_debug on ppc64 host

2015-12-15 Thread Martin K. Petersen
> "Ming" == Ming Lei writes: Ming> I think it is wrong to set max sectors from OPTIMAL TRANSFER Ming> LENGTH. OTL is the preferred size for REQ_TYPE_FS requests as reported by the device. The intent is to honor that. Your patch clamps the rw_size to

Re: kernel BUG at block/bio.c:1787! while initializing scsi_debug on ppc64 host

2015-12-15 Thread Ming Lei
On Tue, 15 Dec 2015 21:06:31 +0800 Eryu Guan wrote: > On Tue, Dec 15, 2015 at 08:06:47PM +0800, Ming Lei wrote: > > On Tue, Dec 15, 2015 at 7:20 PM, Eryu Guan wrote: > > > On Fri, Dec 11, 2015 at 07:53:40PM +0800, Eryu Guan wrote: > > >> Hi, > > >> > > >>

Re: kernel BUG at block/bio.c:1787! while initializing scsi_debug on ppc64 host

2015-12-15 Thread Martin K. Petersen
> "Eryu" == Eryu Guan writes: Eryu, Eryu> This is still reproducible with 4.4-rc5 kernel. Sorry about the delay. I've been busy with a lab move and most of my machines have been disconnected since last week. Almost done getting my equipment back online. However, I

Re: kernel BUG at block/bio.c:1787! while initializing scsi_debug on ppc64 host

2015-12-15 Thread Eryu Guan
On Tue, Dec 15, 2015 at 01:29:59PM -0500, Martin K. Petersen wrote: > > "Eryu" == Eryu Guan writes: > > Eryu, > > Does the patch below fix the issue? Unfortunately no, still BUG_ON. Thanks, Eryu > > -- > Martin K. PetersenOracle Linux Engineering > > diff --git

kernel BUG at block/bio.c:1787! while initializing scsi_debug on ppc64 host

2015-12-11 Thread Eryu Guan
Hi, I saw this kernel BUG_ON on 4.4-rc4 kernel, and this can be reproduced easily on ppc64 host by: modprobe scsi_debug sector_size=512 physblk_exp=3 dev_size_mb=256 And I bisected to this commit commit ca369d51b3e1649be4a72addd6d6a168cfb3f537 Author: Martin K. Petersen