Re: performance improvements for the sglist API (Re: [PATCH] scsi: virtio-scsi: Fix address translation failure of HighMem pages used by sg list)

2012-07-25 Thread Paolo Bonzini
Il 25/07/2012 17:09, Paolo Bonzini ha scritto: > Il 25/07/2012 16:36, Boaz Harrosh ha scritto: I did test the patch with value-assignment. >> >> Still you should use the sg_set_page()!! >> 1. It is not allowed to directly manipulate sg entries. One should always >>use the proper

performance improvements for the sglist API (Re: [PATCH] scsi: virtio-scsi: Fix address translation failure of HighMem pages used by sg list)

2012-07-25 Thread Paolo Bonzini
Il 25/07/2012 16:36, Boaz Harrosh ha scritto: >> > >> > I did test the patch with value-assignment. >> > > > Still you should use the sg_set_page()!! > 1. It is not allowed to directly manipulate sg entries. One should always >use the proper accessor. Even if open coding does work and is not